Re: [HACKERS] 8.2 features status

2006-08-03 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: To me new things are like PITR, Win32, savepoints, two-phase commit, partitioned tables, tablespaces. These are from 8.0 and 8.1. What is there in 8.2 like that? [ shrug... ] Five out of your six items have no basis in the SQL

Re: [HACKERS] 8.2 features status

2006-08-03 Thread Bruce Momjian
Joshua D. Drake wrote: Bruce Momjian wrote: Gavin Sherry wrote: On Fri, 4 Aug 2006, Bruce Momjian wrote: My outlook is that it isn't a lot of _new_ things that you couldn't do before, but rather improvements of existing functionality. It seems as though the majority of things on Tom's

Re: [HACKERS] 8.2 features status

2006-08-03 Thread Joshua D. Drake
It seems as though the majority of things on Tom's list are new things you couldn't do (at all easily) before. To me new things are like PITR, Win32, savepoints, two-phase commit, partitioned tables, tablespaces. These are from 8.0 and 8.1. What is there in 8.2 like that? Well to be honest,

Re: [PATCHES] [HACKERS] 8.2 features?

2006-08-01 Thread Michael Glaesemann
On Aug 1, 2006, at 16:15 , Harald Armin Massa wrote: As accepting 2006-02-31 as a valid date would require brainwashing at least the entire core team, we should find a recommended path of date migration from different universes. Have you checked out the mysql2pgsql[1] or my2postgres

Re: Values list-of-targetlists patch for comments (was Re: [PATCHES] [HACKERS] 8.2 features?)

2006-08-01 Thread Tom Lane
I've found a problem with the VALUES-as-RTE approach: regression=# create table src(f1 int, f2 int); CREATE TABLE regression=# create table log(f1 int, f2 int, tag text); CREATE TABLE regression=# insert into src values(1,2); INSERT 0 1 regression=# create rule r2 as on update to src do

Re: Values list-of-targetlists patch for comments (was Re: [PATCHES] [HACKERS] 8.2 features?)

2006-08-01 Thread Alvaro Herrera
Tom Lane wrote: I've found a problem with the VALUES-as-RTE approach: regression=# create table src(f1 int, f2 int); CREATE TABLE regression=# create table log(f1 int, f2 int, tag text); CREATE TABLE regression=# insert into src values(1,2); INSERT 0 1 regression=# create rule r2 as on

Re: Values list-of-targetlists patch for comments (was Re: [PATCHES] [HACKERS] 8.2 features?)

2006-08-01 Thread Tom Lane
Alvaro Herrera [EMAIL PROTECTED] writes: Does it work if you do regression=# create rule r2 as on update to src do regression-# insert into log values(old.f1, old.f2, 'old'), (new.f1, new.f2, 'new'); No, that's not the problem. * expansion works just fine here, it's the executor that can't

Re: Values list-of-targetlists patch for comments (was Re: [PATCHES] [HACKERS] 8.2 features?)

2006-08-01 Thread Tom Lane
Joe Conway [EMAIL PROTECTED] writes: Tom Lane wrote: What I'm inclined to do for 8.2 is to disallow OLD/NEW references in multi-element VALUES clauses; the feature is still tremendously useful without that. Given the timing, this sounds like a reasonable approach. I agree that the feature

Re: [PATCHES] [HACKERS] 8.2 features?

2006-07-30 Thread Tom Lane
I wrote: I still dislike the way you're doing things in the executor though. I don't see the point of using the execScan.c machinery; most of the time that'll be useless overhead. As I said before, I think the right direction here is to split Result into two single-purpose node types and

Re: [PATCHES] [HACKERS] 8.2 features?

2006-07-30 Thread Joe Conway
Tom Lane wrote: So what I'm currently thinking is 1. Implement ValuesScan. 2. Convert all existing uses of Result without a child node into ValuesScan. 3. Rename Result to Filter and rip out whatever code is only used for the no-child-node case. Steps 2 and 3 are just in the nature of

Re: Values list-of-targetlists patch for comments (was Re: [PATCHES] [HACKERS] 8.2 features?)

2006-07-29 Thread Tom Lane
Joe Conway [EMAIL PROTECTED] writes: One of the things I'm struggling with is lack of column aliases. Would it be reasonable to require something like this? SELECT ... FROM (VALUES ...) AS foo(col1, col2, ...) Requiring column aliases is counter to spec ... The other issue is how to

Re: Values list-of-targetlists patch for comments (was Re: [PATCHES] [HACKERS] 8.2 features?)

2006-07-29 Thread Tom Lane
Joe Conway [EMAIL PROTECTED] writes: Tom Lane wrote: As for the types, I believe that the spec pretty much dictates that we apply the same type resolution algorithm as for a UNION. Where do I find that algorithm -- somewhere in nodeAppend.c? select_common_type(), in the parser.

Re: [PATCHES] [HACKERS] 8.2 features?

2006-07-21 Thread Jim C. Nasby
On Thu, Jul 20, 2006 at 08:46:13PM -0400, Tom Lane wrote: Joe Conway [EMAIL PROTECTED] writes: I'm liking this too. But when you say jointree node, are you saying to model the new node type after NestLoop/MergeJoin/HashJoin nodes? These are referred to as join nodes in ExecInitNode. Or as

Re: [PATCHES] [HACKERS] 8.2 features?

2006-07-20 Thread Joe Conway
Tom Lane wrote: Joe Conway [EMAIL PROTECTED] writes: I was actually just looking at that and ended up thinking that it might be better to deal with it one level down in ExecProject (because it is already passing targetlists directly to ExecTargetList). I'd vote against that, because (a)

Re: [PATCHES] [HACKERS] 8.2 features?

2006-07-20 Thread Tom Lane
Joe Conway [EMAIL PROTECTED] writes: I'm liking this too. But when you say jointree node, are you saying to model the new node type after NestLoop/MergeJoin/HashJoin nodes? These are referred to as join nodes in ExecInitNode. Or as you mentioned a couple of times, should this look more like

Re: [PATCHES] [HACKERS] 8.2 features?

2006-07-20 Thread Joe Conway
Tom Lane wrote: No, I guess I confused you by talking about the executor representation at the same time. This is really unrelated to the executor. The join tree I'm thinking of here is the data structure that dangles off Query.jointree --- it's a representation of the query's FROM clause, and

Re: [PATCHES] [HACKERS] 8.2 features?

2006-07-19 Thread Joe Conway
Joe Conway wrote: Tom Lane wrote: Christopher Kings-Lynne [EMAIL PROTECTED] writes: Strange. Last time I checked I thought MySQL dump used 'multivalue lists in inserts' for dumps, for the same reason that we use COPY I think Andrew identified the critical point upthread: they don't try to

Re: [PATCHES] [HACKERS] 8.2 features?

2006-07-19 Thread Tom Lane
Joe Conway [EMAIL PROTECTED] writes: I did some testing today against mysql and found that it will easily absorb insert statements with 1 million targetlists provided you set max_allowed_packet high enough for the server. It peaked out at about 600MB, compared to my test similar last night

Re: [PATCHES] [HACKERS] 8.2 features?

2006-07-19 Thread Joe Conway
Tom Lane wrote: Joe Conway [EMAIL PROTECTED] writes: I did some testing today against mysql and found that it will easily absorb insert statements with 1 million targetlists provided you set max_allowed_packet high enough for the server. It peaked out at about 600MB, compared to my test

Re: [PATCHES] [HACKERS] 8.2 features?

2006-07-19 Thread Tom Lane
Joe Conway [EMAIL PROTECTED] writes: The difficulty is finding a way to avoid all that extra work without a very ugly special case kludge just for inserts. [ thinks a bit ... ] It seems to me that the reason it's painful is exactly that INSERT ... VALUES is a kluge already. We've

Re: [PATCHES] [HACKERS] 8.2 features?

2006-07-19 Thread Joe Conway
Tom Lane wrote: Joe Conway [EMAIL PROTECTED] writes: The difficulty is finding a way to avoid all that extra work without a very ugly special case kludge just for inserts. [ thinks a bit ... ] It seems to me that the reason it's painful is exactly that INSERT ... VALUES is a kluge already.

Re: [PATCHES] [HACKERS] 8.2 features?

2006-07-19 Thread Tom Lane
Joe Conway [EMAIL PROTECTED] writes: Tom Lane wrote: I think the place we'd ultimately like to get to involves changing the executor's Result node type to have a list of targetlists and sequence through those lists to produce its results I was actually just looking at that and ended up

Re: [PATCHES] [HACKERS] 8.2 features?

2006-07-18 Thread Tom Lane
If the use case is people running MySQL dumps, then there will be millions of values-targetlists in MySQL dumps. I did some experimentation just now, and could not get mysql to accept a command longer than about 1 million bytes. It complains about Got a packet bigger than

Re: [PATCHES] [HACKERS] 8.2 features?

2006-07-18 Thread Thomas Bley
from http://dev.mysql.com/doc/refman/4.1/en/blob.html You can change the message buffer size by changing the value of the max_allowed_packet variable, but you must do so for both the server and your client program. For example, both mysql and mysqldump allow you to change the client-side

Re: [PATCHES] [HACKERS] 8.2 features?

2006-07-18 Thread Matthew D. Fuller
On Tue, Jul 18, 2006 at 02:19:01PM -0400 I heard the voice of Tom Lane, and lo! it spake thus: I did some experimentation just now, and could not get mysql to accept a command longer than about 1 million bytes. It complains about Got a packet bigger than 'max_allowed_packet' bytes

Re: [PATCHES] [HACKERS] 8.2 features?

2006-07-18 Thread Christopher Kings-Lynne
I did some experimentation just now, and could not get mysql to accept a command longer than about 1 million bytes. It complains about Got a packet bigger than 'max_allowed_packet' bytes which seems a bit odd because max_allowed_packet is allegedly set to 16 million, but anyway I don't think

Re: [PATCHES] [HACKERS] 8.2 features?

2006-07-18 Thread Christopher Kings-Lynne
I did some experimentation just now, and could not get mysql to accept a command longer than about 1 million bytes. It complains about Got a packet bigger than 'max_allowed_packet' bytes which seems a bit odd because max_allowed_packet is allegedly set to 16 million, but anyway I don't think

Re: [PATCHES] [HACKERS] 8.2 features?

2006-07-18 Thread Tom Lane
Christopher Kings-Lynne [EMAIL PROTECTED] writes: Strange. Last time I checked I thought MySQL dump used 'multivalue lists in inserts' for dumps, for the same reason that we use COPY I think Andrew identified the critical point upthread: they don't try to put an unlimited number of rows into

Re: [HACKERS] 8.2 features?

2006-07-17 Thread Susanne Ebrecht
Am Freitag, den 14.07.2006, 16:26 +0200 schrieb Bernd Helmle: --On Freitag, Juli 14, 2006 01:23:11 +0200 Peter Eisentraut [EMAIL PROTECTED] wrote: . multiple values clauses for INSERT Susanne Ebrecht [EMAIL PROTECTED] was last heard to work on it. Updates, Susanne? I've talked

Re: [HACKERS] 8.2 features?

2006-07-17 Thread Joe Conway
Andrew Dunstan wrote: Bernd Helmle wrote: --On Freitag, Juli 14, 2006 01:23:11 +0200 Peter Eisentraut [EMAIL PROTECTED] wrote: . multiple values clauses for INSERT Susanne Ebrecht [EMAIL PROTECTED] was last heard to work on it. Updates, Susanne? I've talked to Susanne today and she's

Re: [HACKERS] 8.2 features?

2006-07-17 Thread Pavel Stehule
Hello, I did some work on mutliple value insert. First: SELECT .. UNION ALL SELECT is wrong idea. VALUES can contain DEFAULT keyword. Second: It's neccessery general implementation of table values constructor like SQL:2003. Main problem what I see is biger request on sources if we implement

Re: [HACKERS] 8.2 features?

2006-07-14 Thread Bernd Helmle
--On Freitag, Juli 14, 2006 01:23:11 +0200 Peter Eisentraut [EMAIL PROTECTED] wrote: . multiple values clauses for INSERT Susanne Ebrecht [EMAIL PROTECTED] was last heard to work on it. Updates, Susanne? I've talked to Susanne today and she's just back from hospital and not available

Re: [HACKERS] 8.2 features?

2006-07-14 Thread Andrew Dunstan
Bernd Helmle wrote: --On Freitag, Juli 14, 2006 01:23:11 +0200 Peter Eisentraut [EMAIL PROTECTED] wrote: . multiple values clauses for INSERT Susanne Ebrecht [EMAIL PROTECTED] was last heard to work on it. Updates, Susanne? I've talked to Susanne today and she's just back from

[HACKERS] 8.2 features?

2006-07-13 Thread Andrew Dunstan
What is the state of the following items that have been previously discussed? . MERGE (at least in PK case) . multiple values clauses for INSERT . recursive WITH queries Thanks andrew ---(end of broadcast)--- TIP 1: if posting/reading

Re: [HACKERS] 8.2 features?

2006-07-13 Thread Tom Lane
Andrew Dunstan [EMAIL PROTECTED] writes: What is the state of the following items that have been previously discussed? . MERGE (at least in PK case) No submitted patch; no one working on it AFAIK; doesn't look like something that could get done in the next three weeks. . multiple values

Re: [HACKERS] 8.2 features?

2006-07-13 Thread Jonah H. Harris
On 7/13/06, Tom Lane [EMAIL PROTECTED] wrote: . recursive WITH queries I believe Jonah has given up on fixing the originally-submitted patch, but he mentioned at the code sprint that non-recursive WITH is potentially doable in time for 8.2. Not sure if that's a sufficiently important case to

Re: [HACKERS] 8.2 features?

2006-07-13 Thread Andrew Dunstan
Tom Lane wrote: . multiple values clauses for INSERT Also not done, but if we are willing to accept a limited patch (ie, not necessarily everything that SQL92 says you can do with VALUES, but at least the INSERT case) I think it could get done. I might even volunteer to do it ... but

Re: [HACKERS] 8.2 features?

2006-07-13 Thread Jonah H. Harris
On 7/13/06, Andrew Dunstan [EMAIL PROTECTED] wrote: . multiple values clauses for INSERT I would be very happy to see it accepted. Same here. -- Jonah H. Harris, Software Architect | phone: 732.331.1300 EnterpriseDB Corporation| fax: 732.331.1301 33 Wood Ave S, 2nd Floor

Re: [HACKERS] 8.2 features?

2006-07-13 Thread David Fetter
On Thu, Jul 13, 2006 at 05:09:32PM -0400, Jonah H. Harris wrote: On 7/13/06, Andrew Dunstan [EMAIL PROTECTED] wrote: . multiple values clauses for INSERT I would be very happy to see it accepted. Same here. aolMe, too!/aol Cheers, D -- David Fetter [EMAIL PROTECTED] http://fetter.org/

Re: [HACKERS] 8.2 features?

2006-07-13 Thread Joe Conway
Tom Lane wrote: Andrew Dunstan [EMAIL PROTECTED] writes: What is the state of the following items that have been previously discussed? . multiple values clauses for INSERT Also not done, but if we are willing to accept a limited patch (ie, not necessarily everything that SQL92 says you can

Re: [HACKERS] 8.2 features?

2006-07-13 Thread Peter Eisentraut
Andrew Dunstan wrote: . MERGE (at least in PK case) I think that died after we figured out that it didn't do the sort of UPDATE-else-INSERT thing that people wanted out of it. . multiple values clauses for INSERT Susanne Ebrecht [EMAIL PROTECTED] was last heard to work on it. Updates,

Re: [HACKERS] 8.2 features?

2006-07-13 Thread Stephen Frost
* Peter Eisentraut ([EMAIL PROTECTED]) wrote: Andrew Dunstan wrote: . MERGE (at least in PK case) I think that died after we figured out that it didn't do the sort of UPDATE-else-INSERT thing that people wanted out of it. I agree that it's probably not going to happen for 8.2 but I

Re: [HACKERS] 8.2 features?

2006-07-13 Thread Jonah H. Harris
On 7/13/06, Stephen Frost [EMAIL PROTECTED] wrote: I agree that it's probably not going to happen for 8.2 but I certainly have uses for the SQL spec's definition of MERGE (table-level instead of the individual-tuple case). I'd like to see the individual-tuple UPSERT/REPLACE issue handled as

<    1   2   3   4