Re: [HACKERS] [COMMITTERS] pgsql: make_restrictinfo() failed to attach the specified

2005-11-21 Thread Jim C. Nasby
On Wed, Nov 16, 2005 at 11:05:11PM -0300, Alvaro Herrera wrote: Christopher Kings-Lynne wrote: I've never been a fan of regression tests in the narrow sense of let's test for this specific mistake we made once. If you can devise a test that catches a class of errors including the one you

Re: [HACKERS] [COMMITTERS] pgsql: make_restrictinfo() failed to attach the specified

2005-11-16 Thread Alvaro Herrera
Tom Lane wrote: Log Message: --- make_restrictinfo() failed to attach the specified required_relids to its result when the clause was an OR clause. Brain fade exposed by example from Sebastian B?ck. I wonder if there should be regression tests for all the bugs exposed after 8.1 ...

Re: [HACKERS] [COMMITTERS] pgsql: make_restrictinfo() failed to attach the specified

2005-11-16 Thread Tom Lane
Alvaro Herrera [EMAIL PROTECTED] writes: I wonder if there should be regression tests for all the bugs exposed after 8.1 ... I mean, what stops anyone from introducing the same bugs again? I've never been a fan of regression tests in the narrow sense of let's test for this specific mistake we

Re: [HACKERS] [COMMITTERS] pgsql: make_restrictinfo() failed to attach the specified

2005-11-16 Thread Alvaro Herrera
Christopher Kings-Lynne wrote: I've never been a fan of regression tests in the narrow sense of let's test for this specific mistake we made once. If you can devise a test that catches a class of errors including the one you actually made, that's a different story, because it's much more

Re: [HACKERS] [COMMITTERS] pgsql: make_restrictinfo() failed to attach the specified

2005-11-16 Thread Robert Treat
On Wednesday 16 November 2005 21:05, Alvaro Herrera wrote: Christopher Kings-Lynne wrote: I've never been a fan of regression tests in the narrow sense of let's test for this specific mistake we made once. If you can devise a test that catches a class of errors including the one you