On Sat, Jul 6, 2013 at 9:27 AM, Andrew Dunstan wrote:
> Or maybe just invent a magic result file name such as "none" or
> "do_not_run".
>
> I'm not keen to have us build up a large patchwork of regression tests that
> run on some platforms and not on others, though.
Me, neither. But I don't real
On 07/06/2013 09:12 AM, Robert Haas wrote:
On Fri, Jul 5, 2013 at 6:56 PM, Andres Freund wrote:
On 2013-07-03 14:17:20 -0400, Robert Haas wrote:
I agree. I think it'd be a good idea to get the buildfarm to run the
existing collate.utf8.linux test regularly on platforms where it
passes, but t
On Fri, Jul 5, 2013 at 6:56 PM, Andres Freund wrote:
> On 2013-07-03 14:17:20 -0400, Robert Haas wrote:
>> I agree. I think it'd be a good idea to get the buildfarm to run the
>> existing collate.utf8.linux test regularly on platforms where it
>> passes, but this particular approach is valuable m
On 2013-07-03 14:17:20 -0400, Robert Haas wrote:
> I agree. I think it'd be a good idea to get the buildfarm to run the
> existing collate.utf8.linux test regularly on platforms where it
> passes, but this particular approach is valuable mostly because
> (supposedly) it was going to work everywher
On 07/05/2013 07:44 PM, Andrew Dunstan wrote:
On 07/03/2013 03:16 PM, Andrew Dunstan wrote:
On 07/03/2013 03:00 PM, Alvaro Herrera wrote:
Robert Haas escribió:
I agree. I think it'd be a good idea to get the buildfarm to run the
existing collate.utf8.linux test regularly on platforms wher
On 07/03/2013 03:16 PM, Andrew Dunstan wrote:
On 07/03/2013 03:00 PM, Alvaro Herrera wrote:
Robert Haas escribió:
I agree. I think it'd be a good idea to get the buildfarm to run the
existing collate.utf8.linux test regularly on platforms where it
passes,
+1
I can probably whip up a mod
On 07/03/2013 03:00 PM, Alvaro Herrera wrote:
Robert Haas escribió:
I agree. I think it'd be a good idea to get the buildfarm to run the
existing collate.utf8.linux test regularly on platforms where it
passes,
+1
I can probably whip up a module for it. (I created the buildfarm module
sys
Robert Haas escribió:
> I agree. I think it'd be a good idea to get the buildfarm to run the
> existing collate.utf8.linux test regularly on platforms where it
> passes,
+1
--
Álvaro Herrerahttp://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
On Wed, Jul 3, 2013 at 1:38 PM, Tom Lane wrote:
> Andres Freund writes:
>> On 2013-07-03 13:29:18 -0400, Robert Haas wrote:
>>> I think that's a killer blow for this particular patch. I'm going to
>>> set this to rejected in the CF app.
>
>> Can't we use a alternative expected file for those?
>
Andres Freund writes:
> On 2013-07-03 13:29:18 -0400, Robert Haas wrote:
>> I think that's a killer blow for this particular patch. I'm going to
>> set this to rejected in the CF app.
> Can't we use a alternative expected file for those?
Alternative expected files are a PITA to maintain, at lea
On 2013-07-03 13:29:18 -0400, Robert Haas wrote:
> On Wed, Jul 3, 2013 at 1:26 PM, Robert Haas wrote:
> >> Please revert.
> >
> > OK, sure, but just for my education and general enlightenment ... what
> > platform is that?
>
> Ah, never mind. I see that the buildfarm is quickly turning red -
> N
On Wed, Jul 3, 2013 at 1:26 PM, Robert Haas wrote:
>> Please revert.
>
> OK, sure, but just for my education and general enlightenment ... what
> platform is that?
Ah, never mind. I see that the buildfarm is quickly turning red -
NetBSD, OmniOS, and HP/UX are all unhappy.
I think that's a kille
On Wed, Jul 3, 2013 at 1:11 PM, Tom Lane wrote:
> Robert Haas writes:
>> I did remove those, plus made some other cleanups, and committed this.
>> I think that there's now some duplication between this and the
>> collate.linux.utf8 test that should be cleaned up by removing the
>> duplicative st
Robert Haas writes:
> I did remove those, plus made some other cleanups, and committed this.
> I think that there's now some duplication between this and the
> collate.linux.utf8 test that should be cleaned up by removing the
> duplicative stuff from that test, assuming this holds up OK when the
On Thu, May 9, 2013 at 9:27 PM, Robins Tharakan wrote:
> One workaround is to use DROP COLLATION IF EXISTS, that conveys the message
> without UTF8 in the message string.
>
> But three other tests use ALTER COLLATION and I see no way but to comment /
> disable them. Currently have them disabled (w
One workaround is to use DROP COLLATION IF EXISTS, that conveys the message
without UTF8 in the message string.
But three other tests use ALTER COLLATION and I see no way but to comment /
disable them. Currently have them disabled (with comments as to what they
do, and why they're disabled).
This
On Thu, May 9, 2013 at 4:19 PM, Fabien COELHO wrote:
> However, it is not clear whether these tests run automatically or only if
> they are explicitely called. The README seems to suggest that it is the
> later. If so, maybe having them invoked automatically if possible would
> ensure that they
Maybe some tests could be applied under some condition, say a given locale is
indeed available, but ISTM that it would require to change the test
infrastructure in a portable way to add such feature.
I just noticed that there is a "src/test/locale" directory with some stuff
about german, gre
Fabien pointed out that currently does not check for non-trivial locales.
Indeed, but although it was not very from my point (my wish), and as
pointed out by Tom, it is not quite possible to test non trivial locales
because you cannot assume that a given locale is available on any test
mach
Robins Tharakan writes:
> Fabien pointed out that currently does not check for non-trivial locales. I
> am still on the learning curve about LOCALEs and so, let me know if this is
> a show-stopper. I guess I could look at it and get back in some time with
> more tests as Fabien points out.
You re
Hi,
Please find attached the updated patch.
Fabien pointed out that currently does not check for non-trivial locales. I
am still on the learning curve about LOCALEs and so, let me know if this is
a show-stopper. I guess I could look at it and get back in some time with
more tests as Fabien points
On Thu, Apr 11, 2013 at 4:14 PM, Robins Tharakan wrote:
> Hi,
>
> Please find attached a patch to take 'make check' code-coverage of COLLATE
> (/src/backend/commands/collationcmds) from 0% to 96%.
>
> Any feedback is more than welcome. Also posting this to Commitfest-next.
>
Just by having a quic
22 matches
Mail list logo
