(catching up here)
On Sun, May 7, 2017 at 9:01 AM, Andres Freund wrote:
> Turns out this isn't the better fix, because the checkpoint code
> compares with the actual record LSN (rather than the end+1 that
> XLogInsert() returns). We'd start having to do more bookkeeping or more
> complicated com
Hi,
On 2017-05-04 18:24:47 -0700, Andres Freund wrote:
> Hi,
>
> On 2016-12-22 19:33:30 +, Andres Freund wrote:
> > Skip checkpoints, archiving on idle systems.
>
> As part of an independent bugfix I noticed that Michael & I appear to
> have introduced an off-by-one here. A few locations do
On Fri, May 5, 2017 at 11:57 AM, Andres Freund wrote:
> Hi,
>
> On 2017-05-05 11:50:12 +0530, Amit Kapila wrote:
>> I see that EndPos can be updated in one of the cases after releasing
>> the lock (refer below code). Won't that matter?
>
> I can't see how it'd in the cases that'd matter for
> GetL
Hi,
On 2017-05-05 11:50:12 +0530, Amit Kapila wrote:
> I see that EndPos can be updated in one of the cases after releasing
> the lock (refer below code). Won't that matter?
I can't see how it'd in the cases that'd matter for
GetLastImportantRecPtr() - but it'd probably good to note it in the
com
On Fri, May 5, 2017 at 11:43 AM, Andres Freund wrote:
> On 2017-05-05 11:04:14 +0530, Amit Kapila wrote:
>> On Fri, May 5, 2017 at 6:54 AM, Andres Freund wrote:
>> > Hi,
>> >
>> > On 2016-12-22 19:33:30 +, Andres Freund wrote:
>> >> Skip checkpoints, archiving on idle systems.
>> >
>> > As pa
On 2017-05-05 11:04:14 +0530, Amit Kapila wrote:
> On Fri, May 5, 2017 at 6:54 AM, Andres Freund wrote:
> > Hi,
> >
> > On 2016-12-22 19:33:30 +, Andres Freund wrote:
> >> Skip checkpoints, archiving on idle systems.
> >
> > As part of an independent bugfix I noticed that Michael & I appear to
On Fri, May 5, 2017 at 6:54 AM, Andres Freund wrote:
> Hi,
>
> On 2016-12-22 19:33:30 +, Andres Freund wrote:
>> Skip checkpoints, archiving on idle systems.
>
> As part of an independent bugfix I noticed that Michael & I appear to
> have introduced an off-by-one here. A few locations do compa