Re: [HACKERS] SSI 2PC coverage

2011-08-25 Thread Alvaro Herrera
Excerpts from Tom Lane's message of mié ago 24 22:11:58 -0300 2011: > Alvaro Herrera writes: > > After having to play with this, I didn't like it very much, because > > regression.diffs gets spammed with the (rather massive and completely > > useless) diff in that test. For the xml tests, rather

Re: [HACKERS] SSI 2PC coverage

2011-08-24 Thread Robert Haas
On Wed, Aug 24, 2011 at 9:11 PM, Tom Lane wrote: > Alvaro Herrera writes: >> After having to play with this, I didn't like it very much, because >> regression.diffs gets spammed with the (rather massive and completely >> useless) diff in that test.  For the xml tests, rather than ignoring it >> f

Re: [HACKERS] SSI 2PC coverage

2011-08-24 Thread Tom Lane
Alvaro Herrera writes: > After having to play with this, I didn't like it very much, because > regression.diffs gets spammed with the (rather massive and completely > useless) diff in that test. For the xml tests, rather than ignoring it > fail on an installation without libxml, we use an alterna

Re: [HACKERS] SSI 2PC coverage

2011-08-24 Thread Alvaro Herrera
Excerpts from Heikki Linnakangas's message of jue ago 18 09:57:34 -0400 2011: > Committed. I removed the second expected output file, and marked the > prepared-transactions tests in the schedule as "ignore" instead. That > way if max_prepared_transactions=0, you get a notice that the test case

Re: [HACKERS] SSI 2PC coverage

2011-08-24 Thread Alvaro Herrera
Excerpts from Kevin Grittner's message of mar ago 23 15:07:33 -0300 2011: > Heikki Linnakangas wrote: > > I did change the lexer slightly, to trim whitespace from the > > beginning and end of SQL blocks. This cuts the size of expected > > output a bit, and makes it look nicer anyway. > > OK. Y

Re: [HACKERS] SSI 2PC coverage

2011-08-23 Thread Kevin Grittner
Heikki Linnakangas wrote: > Committed. I removed the second expected output file, and marked > the prepared-transactions tests in the schedule as "ignore" > instead. That way if max_prepared_transactions=0, you get a notice > that the test case failed, but pg_regress still returns 0 as exit > st

Re: [HACKERS] SSI 2PC coverage

2011-08-18 Thread Heikki Linnakangas
On 18.08.2011 17:07, Tom Lane wrote: Heikki Linnakangas writes: On 07.07.2011 18:43, Kevin Grittner wrote: OK. I'll work on this tonight unless Dan jumps in to claim it. Committed. I removed the second expected output file, and marked the prepared-transactions tests in the schedule as "ign

Re: [HACKERS] SSI 2PC coverage

2011-08-18 Thread Tom Lane
Heikki Linnakangas writes: > On 07.07.2011 18:43, Kevin Grittner wrote: >> OK. I'll work on this tonight unless Dan jumps in to claim it. > Committed. I removed the second expected output file, and marked the > prepared-transactions tests in the schedule as "ignore" instead. That > way if max_

Re: [HACKERS] SSI 2PC coverage

2011-08-18 Thread Heikki Linnakangas
On 07.07.2011 18:43, Kevin Grittner wrote: Heikki Linnakangas wrote: On 05.07.2011 20:06, Kevin Grittner wrote: There's two expected output files for this, one for max_prepared_xacts=0 and another for the "normal" case. The max_prepared_xacts=0 case isn't very interesting, since all the PREP

Re: [HACKERS] SSI 2PC coverage

2011-07-07 Thread Kevin Grittner
Heikki Linnakangas wrote: > On 05.07.2011 20:06, Kevin Grittner wrote: >> In reviewing the recent fix to 2PC coverage in SSI, I found some >> cases which didn't seem to be covered. Dan bit the bullet and >> came up with an additional isolation test to rigorously cover all >> the permutations, t

Re: [HACKERS] SSI 2PC coverage

2011-07-07 Thread Heikki Linnakangas
On 05.07.2011 20:06, Kevin Grittner wrote: [resending after gzip of test patch] In reviewing the recent fix to 2PC coverage in SSI, I found some cases which didn't seem to be covered. Dan bit the bullet and came up with an additional isolation test to rigorously cover all the permutations, to f

Re: [HACKERS] SSI 2PC coverage

2011-07-05 Thread Dan Ports
On Tue, Jul 05, 2011 at 09:14:30PM +0300, Heikki Linnakangas wrote: > I think that needs some explanation, why only those SxactIsCommitted() > tests need to be replaced with SxactIsPrepared()? Here is the specific problem this patch addresses: If there's a dangerous structure T0 ---> T1 ---> T2,

Re: [HACKERS] SSI 2PC coverage

2011-07-05 Thread Kevin Grittner
Heikki Linnakangas wrote: >> Attached is also a patch to fix those, so that all permutations >> work. > > I think that needs some explanation, why only those > SxactIsCommitted() tests need to be replaced with > SxactIsPrepared()? What about the first SxactIsCommitted() test in > OnConflict_Che

Re: [HACKERS] SSI 2PC coverage

2011-07-05 Thread Heikki Linnakangas
On 05.07.2011 20:06, Kevin Grittner wrote: [resending after gzip of test patch] In reviewing the recent fix to 2PC coverage in SSI, I found some cases which didn't seem to be covered. Dan bit the bullet and came up with an additional isolation test to rigorously cover all the permutations, to f