Re: pgindent (was Re: [HACKERS] Header comments in the recently added files)

2011-03-18 Thread Robert Haas
On Thu, Mar 10, 2011 at 11:25 AM, Robert Haas robertmh...@gmail.com wrote: On Thu, Mar 10, 2011 at 10:59 AM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: Speaking of running scripts, I think we should run pgindent now. Yeah, +1 for doing it as soon as Tom is at

pgindent (was Re: [HACKERS] Header comments in the recently added files)

2011-03-10 Thread Robert Haas
On Thu, Mar 10, 2011 at 10:21 AM, Bruce Momjian br...@momjian.us wrote: Tom Lane wrote: Itagaki Takahiro itagaki.takah...@gmail.com writes: I found trivial mistakes in the recently added files. Will they fixed by some automated batches, or by manual? - Copyright (c) xxx-*2010*, PostgreSQL

Re: pgindent (was Re: [HACKERS] Header comments in the recently added files)

2011-03-10 Thread Bruce Momjian
Robert Haas wrote: On Thu, Mar 10, 2011 at 10:21 AM, Bruce Momjian br...@momjian.us wrote: Tom Lane wrote: Itagaki Takahiro itagaki.takah...@gmail.com writes: I found trivial mistakes in the recently added files. Will they fixed by some automated batches, or by manual? - Copyright

Re: pgindent (was Re: [HACKERS] Header comments in the recently added files)

2011-03-10 Thread Tom Lane
Bruce Momjian br...@momjian.us writes: Robert Haas wrote: Speaking of running scripts, I think we should run pgindent now. We usually do it during a late beta. Last time we did it early and then again late, and that seemed to work well. I wouldn't object to a pgindent run now, but please

Re: pgindent (was Re: [HACKERS] Header comments in the recently added files)

2011-03-10 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian br...@momjian.us writes: Robert Haas wrote: Speaking of running scripts, I think we should run pgindent now. We usually do it during a late beta. Last time we did it early and then again late, and that seemed to work well. I wouldn't object to a pgindent

Re: pgindent (was Re: [HACKERS] Header comments in the recently added files)

2011-03-10 Thread Robert Haas
On Thu, Mar 10, 2011 at 10:47 AM, Tom Lane t...@sss.pgh.pa.us wrote: Bruce Momjian br...@momjian.us writes: Robert Haas wrote: Speaking of running scripts, I think we should run pgindent now. We usually do it during a late beta. Last time we did it early and then again late, and that seemed

Re: pgindent (was Re: [HACKERS] Header comments in the recently added files)

2011-03-10 Thread Magnus Hagander
On Thu, Mar 10, 2011 at 16:50, Robert Haas robertmh...@gmail.com wrote: On Thu, Mar 10, 2011 at 10:47 AM, Tom Lane t...@sss.pgh.pa.us wrote: Bruce Momjian br...@momjian.us writes: Robert Haas wrote: Speaking of running scripts, I think we should run pgindent now. We usually do it during a

Re: pgindent (was Re: [HACKERS] Header comments in the recently added files)

2011-03-10 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: Speaking of running scripts, I think we should run pgindent now. Yeah, +1 for doing it as soon as Tom is at a good stopping point. It makes things a lot simpler later on. IIRC the argument for an early pgindent run was to standardize the new code for

Re: pgindent (was Re: [HACKERS] Header comments in the recently added files)

2011-03-10 Thread Andrew Dunstan
On 03/10/2011 10:33 AM, Robert Haas wrote: On Thu, Mar 10, 2011 at 10:21 AM, Bruce Momjianbr...@momjian.us wrote: Tom Lane wrote: Itagaki Takahiroitagaki.takah...@gmail.com writes: I found trivial mistakes in the recently added files. Will they fixed by some automated batches, or by

Re: pgindent (was Re: [HACKERS] Header comments in the recently added files)

2011-03-10 Thread Robert Haas
On Thu, Mar 10, 2011 at 10:59 AM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: Speaking of running scripts, I think we should run pgindent now. Yeah, +1 for doing it as soon as Tom is at a good stopping point.  It makes things a lot simpler later on. IIRC the

Re: pgindent (was Re: [HACKERS] Header comments in the recently added files)

2011-03-10 Thread Kevin Grittner
Tom Lane t...@sss.pgh.pa.us wrote: I expect to be spending a whole lot of time reading collate and SSI code over the next few weeks, so I'm in favor of pgindent'ing that stuff first. I've been running that throughout development, but it hasn't been run after the last few changes. If you