Re: [JDBC] flames!

2001-10-07 Thread Anders Bengtsson
On Sun, 7 Oct 2001, Elias Karakoulakis wrote: > Hello all, Hello Elias! > I'd like to make an inflamatory note: > > ==> let a non-Latin programmer do the Unicode stuff <== Excellent, a non-Latin volonteer! :) Seriously, if you use a non-latin charset you would be the perfect person to add som

Re: [JDBC] driver source code indentation

2001-09-05 Thread Anders Bengtsson
On Tue, 4 Sep 2001, Bruce Momjian wrote: > Can people tak a look at that and see if they like it? I will work on > astyle to find a format that matches the main code indenting. > > If you like it, I will indent just after we go beta. Looks great! I only noticed two things that I sort of dislik

Re: [JDBC] JAVA vs PERL : PERL wins to postgreSQL

2001-09-03 Thread Anders Bengtsson
On Mon, 3 Sep 2001, andy wrote: > Hi, > > I ran a few bench marks on JAVA writing to a postgreSQL table using and > found that for the same number of records added to the table as a > similar PERL routine the following results : > PERL 39 seconds : JAVA 45 Seconds. How did you start the te

Re: [JDBC] Status of JDBC test suite?

2001-08-29 Thread Anders Bengtsson
On Wed, 29 Aug 2001, Liam Stewart wrote: > > > Would a brief How-to help? > > > > Yes! :) > > I assume that you're wondering about the JDBC 2 test suite from Sun. > I've attached a note that has some detailed instructions on getting the > suite to work with PostgreSQL. Rene, do you want to post t

Re: [JDBC] Status of JDBC test suite?

2001-08-26 Thread Anders Bengtsson
On Sun, 26 Aug 2001, Rene Pijlman wrote: > This is probably true, but once you have your environment setup > (including a test database, password etc.) its just a matter of > typing "make check". > > Would a brief How-to help? Yes! :) > >Ideally we should be able to extract parts of the test su

Re: [JDBC] Status of JDBC test suite?

2001-08-26 Thread Anders Bengtsson
On Sun, 26 Aug 2001, Rene Pijlman wrote: > While working on the executeBatch() patch I noticed that the > JDBC 2 test suite with current CVS code generates 9 > errors/failures. Some of these errors appear to be caused by > tests that do not create their own tables. With the tables added it's sti

[JDBC] Attempt to clean up ExecSql() in JDBC

2001-08-26 Thread Anders Bengtsson
Hi, Attached is my attempt to clean up the horrors of the ExecSQL() method in the JDBC driver. I've done this by extracting it into a new method object called QueryExecutor (should go into org/postgresql/core/) and then taking it apart into different methods in that class. A short summary: *

[JDBC] JDBC Statement cleanup patch

2001-08-08 Thread Anders Bengtsson
Hello, Attached is a patch to remove some redundant code in the JDBC driver. * Merges identical code from org.postgresql.jdbc[1|2].Statement into org.postgresql.Statement. * Moves escapeSQL() method from Connection to Statement (the only place it's used) * Minor cleanup of the new isolation

Re: [JDBC] Re: What needs to be done?

2001-08-02 Thread Anders Bengtsson
On Wed, 1 Aug 2001, Barry Lind wrote: > Anders, > > What aspects of BLOB support do you consider broken? Are these aspects > that are broken in the JDBC layer or are 'broken' at the server layer? Now I've looked at the code and located the problem: The method setBinaryStream(...) in PreparedSt

Re: [JDBC] Re: What needs to be done?

2001-08-02 Thread Anders Bengtsson
On Thu, 2 Aug 2001, Barry Lind wrote: > There are actually a couple of reasons why the jdbc driver can't do this: > > 1) The client doesn't know that the column being deleted is a blob. All > it can know is that the data type of the column is oid. Oids can be > used for many reasons, one of whi

Re: [JDBC] What needs to be done?

2001-08-01 Thread Anders Bengtsson
On Wed, 1 Aug 2001, Rene Pijlman wrote: > Hello, > > I read in comp.lang.java.databases that help is needed with > development of the JDBC driver. Can someone please provide some > pointers to what needs to be done? > > What are the open issues? Is it JDBC 2.0 compliance? PostgreSQL > 7.1 support

[JDBC] Merging JDBC1 and JDBC2 similarities

2001-07-22 Thread Anders Bengtsson
This patch merges the identical methods from the JDBC1 and JDBC2 connection implementations (org.postgresql.jdbc[1|2].Connection) into their superclass (org.postgresql.Connection). It also changes the close() methods of Connection and PG_Stream, so that PG_Stream no longer is responsible for sen

Re: [PATCHES] Re: [JDBC] [PATCH] Cleanup of JDBC character encoding

2001-07-21 Thread Anders Bengtsson
On Sat, 21 Jul 2001, Bruce Momjian wrote: > OK, patch applied. I put the new java files in /core and /test as > indicated in the java package header in the source code. Patch applied > too. Almost right. :-) EncodingTest.java should go in "org/postgresql/test/jdbc2/", not in "org/postgresql/te

Re: [PATCHES] Re: [JDBC] [PATCH] Cleanup of JDBC character encoding

2001-07-19 Thread Anders Bengtsson
On Sun, 15 Jul 2001, Bruce Momjian wrote: > I am having trouble applying this patch to the current CVS tree. The > majority of changes fail to apply. Can you give me a patch against > current CVS or can someone manually merge the changes into CVS and send > me a patch? Thanks. Here's a patch

Re: [JDBC] [PATCH] Cleanup of JDBC character encoding

2001-07-13 Thread Anders Bengtsson
On Thu, 12 Jul 2001, Bruce Momjian wrote: > Your patch has been added to the PostgreSQL unapplied patches list at: Here is a new version of that patch, with improvements from some feedback I got from Barry Lind. More of the encoding-related logic is moved into the Encoding class and I've added s

[JDBC] Re: [PATCHES] Re: [PATCH] Cleanup of JDBC character encoding

2001-07-10 Thread Anders Bengtsson
> > I have some issues with this patch. > > > > 1) Please don't require the driver to perform yet another round trip to > > the server to get the database encoding. You changed the following code > > which accessed the server once at connection creation: > [snip] > > 2) I don't like having test

[JDBC] Re: [PATCH] Cleanup of JDBC character encoding

2001-07-10 Thread Anders Bengtsson
On Mon, 9 Jul 2001, Barry Lind wrote: > Anders, > > I have some issues with this patch. > > 1) Please don't require the driver to perform yet another round trip to > the server to get the database encoding. You changed the following code > which accessed the server once at connection creation: [

[JDBC] [PATCH] Cleanup of JDBC character encoding

2001-07-08 Thread Anders Bengtsson
Hello, With this patch I've done an attempt to make the handling of character encoding in the JDBC driver a little clearer. * Cleans up the logic to select a JVM encoding for a backend encoding. * Makes the connection setup code easier to read. * Gathers character encoding and decoding in a sing