Dear Bruce,
> Is ALSO part of the SQL standard? I can't imagine it is because there
> is no rule mention.
As RULE is not in the SQL standard, ALSO is sure no part of it.
> I guess if we were coding from scratch, we could make the syntax INSTEAD
> or ALSO, but at this point, I don't see adding
Fabien COELHO <[EMAIL PROTECTED]> writes:
> Most of the patch deals with the documentation, which is rather ugly
> because it keeps telling about "INSTEAD" vs "non-INSTEAD" rules, as there
> is no name for the default behavior. I think "ALSO" fixes this issue as it
> clarifies the explanations.
Hm
Tom Lane wrote:
> Fabien COELHO <[EMAIL PROTECTED]> writes:
> > Most of the patch deals with the documentation, which is rather ugly
> > because it keeps telling about "INSTEAD" vs "non-INSTEAD" rules, as there
> > is no name for the default behavior. I think "ALSO" fixes this issue as it
> > clari
> I thought the syntax came from Berkeley. We can add ALSO if folks like
> it. I can't think of cases where we have keywords for both on and off
> behavior, and allow a default if the keyword is missing.
ALTER TABLE ... DROP CONSTRAINT ... [ RESTRICT | CASCADE ] ;
CREATE TABLE ... [ WITH OIDS
Fabien COELHO wrote:
>
> > I thought the syntax came from Berkeley. We can add ALSO if folks like
> > it. I can't think of cases where we have keywords for both on and off
> > behavior, and allow a default if the keyword is missing.
>
> ALTER TABLE ... DROP CONSTRAINT ... [ RESTRICT | CASCADE ]
> Shoot me the patch again and I will put in the the queue. Thanks.
Please find attached (again) the patch I sent. It is against 7.4.1.
If necessary, I can redo the job against current head.
Have a nice day,
--
Fabien Coelho - [EMAIL PROTECTED]*** ./doc/src/sgml/rules.sgml.orig Sun Feb 2
The doc for the trim functions does not say that the second argument can
be omitted. This patch fixes it. It also fixes that the type text was not
wrapped as text.
I can not build the docs myself, but i'm pretty sure it's correct.
Is it okay to commit this? Should I do it on the 7.4 branch also
Dennis Bjorklund wrote:
> The doc for the trim functions does not say that the second argument can
> be omitted. This patch fixes it. It also fixes that the type text was not
> wrapped as text.
Good.
> I can not build the docs myself, but i'm pretty sure it's correct.
No problem. See the deve
The log_executor_stats config variable doesn't work 100%. It shows
stats for only certain SQL queries. Looking at utils/portal.h:
* We have several execution strategies for Portals, depending on what
* query or queries are to be executed. (Note: in all cases, a Portal
* executes just a singl
Bruce Momjian wrote:
No problem. See the developers page for 5-minute build so you can check
your commit.
I think it's best if people always check that they don't break the
docs before committing changes. "make check" should be sufficient, and
that is much faster than building the docs completel
Dennis Bjorklund <[EMAIL PROTECTED]> writes:
> The doc for the trim functions does not say that the second argument can
> be omitted. This patch fixes it. It also fixes that the type text was not
> wrapped as text.
It would perhaps be clearer to show the single-argument forms as
separate entries
Bruce Momjian <[EMAIL PROTECTED]> writes:
> it only logs executor stats for PORTAL_MULTI_QUERY queries. I assume
> this was done so that individual queries are logged rather than the
> entire multi-query.
I think it was just an oversight. IIRC, the PORTAL_MULTI_QUERY path of
control is the only
Tom Lane wrote:
Fabien COELHO <[EMAIL PROTECTED]> writes:
Most of the patch deals with the documentation, which is rather ugly
because it keeps telling about "INSTEAD" vs "non-INSTEAD" rules, as there
is no name for the default behavior. I think "ALSO" fixes this issue as it
clarifies the explanat
Jan Wieck wrote:
> Tom Lane wrote:
>
> > Fabien COELHO <[EMAIL PROTECTED]> writes:
> >> Most of the patch deals with the documentation, which is rather ugly
> >> because it keeps telling about "INSTEAD" vs "non-INSTEAD" rules, as there
> >> is no name for the default behavior. I think "ALSO" fixes
Tom Lane wrote:
> Bruce Momjian <[EMAIL PROTECTED]> writes:
> > it only logs executor stats for PORTAL_MULTI_QUERY queries. I assume
> > this was done so that individual queries are logged rather than the
> > entire multi-query.
>
> I think it was just an oversight. IIRC, the PORTAL_MULTI_QUERY
Bruce Momjian wrote:
Jan Wieck wrote:
Tom Lane wrote:
> Fabien COELHO <[EMAIL PROTECTED]> writes:
>> Most of the patch deals with the documentation, which is rather ugly
>> because it keeps telling about "INSTEAD" vs "non-INSTEAD" rules, as there
>> is no name for the default behavior. I think "A
Jan Wieck wrote:
> Bruce Momjian wrote:
>
> > Jan Wieck wrote:
> >> Tom Lane wrote:
> >>
> >> > Fabien COELHO <[EMAIL PROTECTED]> writes:
> >> >> Most of the patch deals with the documentation, which is rather ugly
> >> >> because it keeps telling about "INSTEAD" vs "non-INSTEAD" rules, as there
Patch applied. Thanks.
---
Thomas Hallgren wrote:
> > Who did you think would do it?
> >
> > regards, tom lane
> >
> you :-)
>
> Seriously, I didn't give it much though. This is undoubtedly the best way
> although some pr
Neil Conway wrote:
> Bruce Momjian wrote:
> > No problem. See the developers page for 5-minute build so you can check
> > your commit.
>
> I think it's best if people always check that they don't break the
> docs before committing changes. "make check" should be sufficient, and
> that is much f
Patch applied. Thanks.
I realize the function names have changed, but we want to encourage
improvement of our xml capabilities. If folks want the old function
names, we can put the old code up on gborg.
I updated the README to mention that libxml is now required.
-
I moved your new version into /contrib/xml2, and kept /contrib/xml
unchanged.
---
Bruce Momjian wrote:
>
> Patch applied. Thanks.
>
> I realize the function names have changed, but we want to encourage
> improvement of ou
Bruce Momjian wrote:
I moved your new version into /contrib/xml2, and kept /contrib/xml
unchanged.
There's just one last thing - are both xml and xml2 totally disjoint?
eg. is it possible to install both for switchover purposes?
Chris
---(end of broadcast)-
Christopher Kings-Lynne wrote:
>
>
> Bruce Momjian wrote:
>
> > I moved your new version into /contrib/xml2, and kept /contrib/xml
> > unchanged.
>
> There's just one last thing - are both xml and xml2 totally disjoint?
> eg. is it possible to install both for switchover purposes?
No idea. J
Fabien COELHO wrote:
>
> Dear patchers,
>
> Here is my second and last try of the day.
>
> This patch adds a "notice" at constraint creation time if the referential
> integrity check is to be "costly", that is it cannot use the index due to
> some incompatibility.
>
> The patch was generated wi
Joe Conway wrote:
Tom Lane wrote:
Joe Conway <[EMAIL PROTECTED]> writes:
I like the idea in general, but maybe instead there should be a new
overloaded version of the existing function names that accepts an
additional bool argument. Without the argument, behavior would be as
it is now; with it,
25 matches
Mail list logo
