Fabien COELHO wrote:
(1) boolean-and and boolean-or aggregates named bool_and and bool_or.
they (SHOULD;-) correspond to standard sql every and some/any aggregates.
they do not have the right name as there is a problem with
the standard and the parser for some/any. Tom also think that
Dear Tom,
Please find attached my first submission for installing all necessary
build files (makefile, scripts...) by default.
Why? They won't do anyone any good outside the original build tree.
Is your question rhetorical?
So as to allow postgresql extensions (types, functions) to be
Dear Bruce,
Agreed, these seem to be of general interest and have been requested in
the past. I will clean up the docs a little.
Please find attached a new version to address Neil's comments.
- add every anyway, next to bool_and.
- cleaner source and comments.
I also added more regression
Bruce Momjian [EMAIL PROTECTED] writes:
I will try to apply it within the next 48 hours.
This patch seems to still be under active discussion. Would you refrain
from giving the impression that it's going to be applied as-is?
regards, tom lane
Tom Lane wrote:
Bruce Momjian [EMAIL PROTECTED] writes:
I will try to apply it within the next 48 hours.
This patch seems to still be under active discussion. Would you refrain
from giving the impression that it's going to be applied as-is?
He submitted a new version based on Neil's
Tom Lane wrote:
Bruce Momjian [EMAIL PROTECTED] writes:
Tom Lane wrote:
[EMAIL PROTECTED] (Bruce Momjian) writes:
Remove elog() calls from find_my_exec; do fprintf(stderr) instead.
Isn't that a seriously bad idea?
Yes, it probably is bad, but I am not sure how frequently this will
Bruce Momjian [EMAIL PROTECTED] writes:
so it has to be earlier. I can put it much earlier in both postgres and
postmaster, but by having it in main.c, I have it in only one place. It
doesn't do any palloc or anything fancy, because of course it is also
used by client apps.
Patch attached
Tom Lane wrote:
Bruce Momjian [EMAIL PROTECTED] writes:
so it has to be earlier. I can put it much earlier in both postgres and
postmaster, but by having it in main.c, I have it in only one place. It
doesn't do any palloc or anything fancy, because of course it is also
used by client
so it has to be earlier. I can put it much earlier in
both postgres
and postmaster, but by having it in main.c, I have it in only one
place. It doesn't do any palloc or anything fancy, because of
course it is also used by client apps.
Patch attached and applied.
And
Bruce Momjian [EMAIL PROTECTED] writes:
Tom Lane wrote:
And tested? I didn't say that I thought elog would work in main.c.
In fact I'm pretty certain it won't.
Compiles/regression tests pass.
You need to test the cases that will produce elog output.
This is why I removed elog in the
Tom Lane wrote:
Bruce Momjian [EMAIL PROTECTED] writes:
Tom Lane wrote:
And tested? I didn't say that I thought elog would work in main.c.
In fact I'm pretty certain it won't.
Compiles/regression tests pass.
You need to test the cases that will produce elog output.
This is why
Tom Lane wrote:
Bruce Momjian [EMAIL PROTECTED] writes:
OK, I moved the find_my_exec calls to the locations you mentioned in
both postgres.c and postmaster.c and remove it from main.c. I tested
the elog and it worked.
You omitted get_pkglib_path() from the postmaster case; was that
Tom Lane wrote:
Christopher Kings-Lynne [EMAIL PROTECTED] writes:
This might seem a bit silly, but is there any chance we could add a
comment at the end of pg_dump text output that says '-- End of dump'?
Sure --- while you're at it, put a beginning of dump at the start.
Is it worth
I have made your configure-related changes for Irix, and renamed the
port from irix5 to irix. Patch attached.
For your other comments, would you please send a new version or diff
against FAQ_IRIX. I am unsure how much of the current content to
change.
Thanks.
Bruce Momjian [EMAIL PROTECTED] writes:
I have made your configure-related changes for Irix,
Please revert the configure.in changes (the programs.m4 one may be ok).
Adding port-specific code to configure.in in order to suppress warnings
in config.log is the mark of someone who hasn't a clue what
Bruce Momjian [EMAIL PROTECTED] writes:
Tom Lane wrote:
Also, in the non-exec case it seems unnecessary and possibly unsafe to
repeat this computation in a backend.
Thanks. It originally was as below and I forgot about that. It now is:
if (my_exec_path[0] == '\0' find_my_exec(argv[0],
Claudio Natoli wrote:
Tom Lane wrote:
Bruce Momjian [EMAIL PROTECTED] writes:
Tom Lane wrote:
Also, in the non-exec case it seems unnecessary and possibly unsafe
to
repeat this computation in a backend.
Thanks. It originally was as below and I forgot about that. It
Bruce Momjian [EMAIL PROTECTED] writes:
Claudio Natoli wrote:
There's also the possibility of adding it to read/write_backend_variables,
just as we add other variables for fork/exec that we want the backends to
inherit.
In the exec case, the executable name is actually different from the
Tom Lane wrote:
Bruce Momjian [EMAIL PROTECTED] writes:
Claudio Natoli wrote:
There's also the possibility of adding it to read/write_backend_variables,
just as we add other variables for fork/exec that we want the backends to
inherit.
In the exec case, the executable name is actually
Same patch as before but I added a small change to the gram.y enabling
SET command to use qualified names.
- thomas
Index: doc/src/sgml/runtime.sgml
===
RCS file: /projects/cvsroot/pgsql-server/doc/src/sgml/runtime.sgml,v
retrieving
Would you show an example of the invalid value this is trying to avoid?
---
Stephen Frost wrote:
Greetings,
The attached patch adds some error-checking to the timestamp_recv
function so that it's not possible to
I was hoping to avoid platform-specific binaries. Once pg_ctl is done
in C, it can start/stop the postmaster, but not individual backends.
Can we add a flag to pg_ctl so it can send arbitrary signals to
processed on Win32? That would be best, I think.
This looks very close to the method we had agreed to. I think it need a
little adjustment, like removing tablespace now that the tablespaces
patch is coming, but it is a great start.
I could probably clean it up and apply it. Is that OK?
We documented using rotatelogs in the pg_ctl manual page, and have the
main docs correct on how to use it. Hopefully that will be enough.
---
Andrew Hammond wrote:
[ PGP not available, raw data follows ]
-BEGIN PGP
24 matches
Mail list logo
