Otherwise, we need to extend the ADD CONSTRAINT syntax.
Yeah, I was wondering if there was some minimal-impact way to do that.
Shall I hold off on doing any pg_dump changes then?
Chris
---(end of broadcast)---
TIP 1: subscribe and unsubscribe commands
Otherwise, we need to extend the ADD CONSTRAINT syntax.
Yeah, I was wondering if there was some minimal-impact way to do that.
Oh, or we create ALTER CONSTRAINT :)
Chris
---(end of broadcast)---
TIP 7: don't forget to increase your free space map set
In fact, now that I think of it, the patch-as-committed already
introduces some serious headaches for pg_dump: it can't know for sure
what name will be assigned to constraint indexes (pkey and unique
indexes) so it has no good way to emit ALTER TABLE SET TABLESPACE
commands for those indexes.
I gue
Christopher Kings-Lynne <[EMAIL PROTECTED]> writes:
> Otherwise, we need to extend the ADD CONSTRAINT syntax.
Yeah, I was wondering if there was some minimal-impact way to do that.
regards, tom lane
---(end of broadcast)---
Gavin Sherry <[EMAIL PROTECTED]> writes:
> On Mon, 12 Jul 2004, Christopher Kings-Lynne wrote:
>> I vote for taking it out.
> Pull it. I added it intentionally but now I'm questioning my reasoning
> (which was, sequences might be accessed lots, people might want to put
> them somewhere intentiona
Bruce Momjian <[EMAIL PROTECTED]> writes:
> Will toast go in the same tablespace as the base table?
That is the current design, and I'd prefer to keep it that way because
anything else adds great complexity for unclear gain.
Two examples of pain points:
1. That pending patch to report a table's
On Mon, 12 Jul 2004, Christopher Kings-Lynne wrote:
> > I had forgotten that the original patch allowed that. Personally I'd
> > vote for taking it out, for the above-stated reasons --- any objections?
>
> I vote for taking it out.
Pull it. I added it intentionally but now I'm questioning my re
I had forgotten that the original patch allowed that. Personally I'd
vote for taking it out, for the above-stated reasons --- any objections?
I vote for taking it out.
Chris
---(end of broadcast)---
TIP 7: don't forget to increase your free space map
Christopher Kings-Lynne <[EMAIL PROTECTED]> writes:
>> Sequences are too small to be worth moving around, and may someday be
>> reimplemented in a fashion that doesn't use up a separate disk file for
>> each one. If we allow SET TABLESPACE on them we will be limiting our
>> future flexibility for
However, based on our feature freeze, maybe what we have now is fine and
I can just add the TODO item again.
---
Tom Lane wrote:
> Christopher Kings-Lynne <[EMAIL PROTECTED]> writes:
> >> Sequences are too small to be worth
Will toast go in the same tablespace as the base table? I can see some
advantages to splitting that to another drive for extreme cases (think
heap/toast lookups over and over again).
---
Tom Lane wrote:
> Christopher Kings-
Patch applied. Thanks.
I had to manually apply your patch, and I adjusted how you set
effective_user.
---
Magnus Hagander wrote:
> Here you go.
>
> > -Original Message-
> > From: Dave Page [mailto:[EMAIL
Christopher Kings-Lynne wrote:
> > Please remove that; if I thought either one was a good idea, I would
> > have allowed it in the committed patch.
> >
> > Sequences are too small to be worth moving around, and may someday be
> > reimplemented in a fashion that doesn't use up a separate disk file
Does this patch allow setting the tablespace of sequences as well? If
so, then you will need to modify pg_dump of SERIAL sequences. Perhaps
output a ALTER TABLE/SET TABLESPACE command after the CREATE TABLE
definition to move the SERIAL sequence.
The same argument applies if it allows moving i
Please remove that; if I thought either one was a good idea, I would
have allowed it in the committed patch.
Sequences are too small to be worth moving around, and may someday be
reimplemented in a fashion that doesn't use up a separate disk file for
each one. If we allow SET TABLESPACE on them we
Patch applied. Thanks.
---
Gavin Sherry wrote:
> Tablespace examples for CREATE TABLE/INDEX/SCHEMA/DATABASE as well as some
> other examples for CREATE DATABASE.
>
> Gavin
>
> !DSPAM:40e6501e286851292611956!
Content-Des
I have added this patch plus your later comments to the patch queue.
Your patch has been added to the PostgreSQL unapplied patches list at:
http://momjian.postgresql.org/cgi-bin/pgpatches
I will try to apply it within the next 48 hours.
-
Patch applied. Thanks.
---
Alvaro Herrera wrote:
> The outer #define was forgotten. Attached patch adds it; please apply.
>
> --
> Alvaro Herrera ()
> "Sallah, I said NO camels! That's FIVE camels; can't you count?"
> (
Patch withdrawn by author.
---
Andrew Dunstan wrote:
>
> The following patch applies a change I inadvertantly left out of the
> previous patch, and makes spi_exec_query work correctly in the case of a
> select query.
> Te
Previous patch removed from the queue.
Your patch has been added to the PostgreSQL unapplied patches list at:
http://momjian.postgresql.org/cgi-bin/pgpatches
I will try to apply it within the next 48 hours.
---
A
Thanks. New FAQ version added.
---
Pavel Stehule wrote:
> Hello
>
> I reformated FAQ into html. I am sending diff and html file.
>
> regards
> Pavel Stehule
Content-Description:
[ Attachment, skipping... ]
Content-Des
OK, removed.
---
Tom Lane wrote:
> Bruce Momjian <[EMAIL PROTECTED]> writes:
> > Added to TODO;
> > * Allow moving sequences and toast tables to other tablespaces
> > in case no one does it.
>
> Please remove that; if I
Tom Lane wrote:
> Christopher Kings-Lynne <[EMAIL PROTECTED]> writes:
> >> Attached is an updated ALTER TABLE ... SET TABLESPACE patch.
>
> > Does this patch allow setting the tablespace of sequences as well? If
> > so, then you will need to modify pg_dump of SERIAL sequences. Perhaps
> > outp
Bruce Momjian <[EMAIL PROTECTED]> writes:
> Added to TODO;
> * Allow moving sequences and toast tables to other tablespaces
> in case no one does it.
Please remove that; if I thought either one was a good idea, I would
have allowed it in the committed patch.
Sequences are too small to be wo
Patch applied. Thanks. Your documentation changes can be viewed in
five minutes using links at the bottom of the developer's page,
http://developer.postgresql.org/index.php.
---
Michael Glaesemann wrote:
> Hello all
>
>
Patch applied. Thanks. Your documentation changes can be viewed in
five minutes using links at the bottom of the developer's page,
http://developer.postgresql.org/index.php.
---
Gavin Sherry wrote:
> Small addition.
Con
Applied by Tom.
---
Gavin Sherry wrote:
> Hi all,
>
> Attached is an updated ALTER TABLE ... SET TABLESPACE patch.
>
> It uses the block by block copy mechanism proposed by Tom and handles i)
> ALTER TABLE and ii) Co
Christopher Kings-Lynne <[EMAIL PROTECTED]> writes:
>> Attached is an updated ALTER TABLE ... SET TABLESPACE patch.
> Does this patch allow setting the tablespace of sequences as well? If
> so, then you will need to modify pg_dump of SERIAL sequences. Perhaps
> output a ALTER TABLE/SET TABLESP
Oops, path patch attached.
---
Bruce Momjian wrote:
>
> I think this still is not fixed. I think we need to add a call to
> trim_trailing_separator() in checkDataDir(). Magnus, can you confirm
> this will fix it?
>
> ---
subscribe
end
I think this still is not fixed. I think we need to add a call to
trim_trailing_separator() in checkDataDir(). Magnus, can you confirm
this will fix it?
---
Bruce Momjian wrote:
>
> I am now confused about the original re
I am now confused about the original report. I don't see how my fix
would correct the reported problem. trim_trailing_separator() would
have handled d:\pgdata\ and d:\pgdata just fine. The fix only corrects
d:\.
Magnus, does current CVS fix the problem?
---
OK, thanks, adjusted, and I added a comment about control-z handling.
---
Peter Eisentraut wrote:
> Bruce Momjian wrote:
> > + #ifndef WIN32
> > + #define R_TEXTFILE"r"
> > + #else
> > + #define R_TEXTFILE"rb"
> > +
Already applied by Tom.
---
Christopher Kings-Lynne wrote:
> Hi,
>
> This is the final patch that adds OWNER TO commands to every object.
> This includes tablespaces. I have also added RENAME TO on tablespaces.
>
> Full
Bruce Momjian wrote:
> + #ifndef WIN32
> + #define R_TEXTFILE"r"
> + #else
> + #define R_TEXTFILE"rb"
> + #endif
This appears to be redundant with
#if defined(__CYGWIN__) || defined(WIN32)
#define PG_BINARY O_BINARY
#define PG_BINARY_R "rb"
#define PG_BINARY_W "wb"
#else
#define PG_
35 matches
Mail list logo
