Re: [PATCHES] more fixes for making contrib null safe

2005-01-28 Thread Tom Lane
Kris Jurka <[EMAIL PROTECTED]> writes: > This adds the strict function attribute to the places in contrib that > crash on null inputs. Sounds good. Barring objections, I'll apply this to current and back branches before we make the upcoming releases. regards, tom lane -

Re: [PATCHES] Continue transactions after errors in psql

2005-01-28 Thread Greg Sabino Mullane
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Michael Paesold wrote: > 2) Implement a server-side function to get the savepoints from the server > and query that before every release. I could not find a way to do this. Is there any interface to the list? I looked over the patch from Micha

Re: [PATCHES] more fixes for making contrib null safe

2005-01-28 Thread Jon Jensen
On Fri, 28 Jan 2005, Kris Jurka wrote: Doesn't C need to be quoted? A few of those looked like this: LANGUAGE C STRICT This is perfectly legal: http://developer.postgresql.org/docs/postgres/sql-createfunction.html langname The name of the language that the function is implemented in. May be SQL,

Re: [PATCHES] more fixes for making contrib null safe

2005-01-28 Thread Kris Jurka
On Sat, 29 Jan 2005, Jon Jensen wrote: > On Fri, 28 Jan 2005, Kris Jurka wrote: > > > This adds the strict function attribute to the places in contrib that > > crash on null inputs. > > Doesn't C need to be quoted? A few of those looked like this: > > LANGUAGE C STRICT > This is perfectly l

Re: [PATCHES] more fixes for making contrib null safe

2005-01-28 Thread Jon Jensen
On Fri, 28 Jan 2005, Kris Jurka wrote: This adds the strict function attribute to the places in contrib that crash on null inputs. Doesn't C need to be quoted? A few of those looked like this: LANGUAGE C STRICT but I thought it should be: LANGUAGE 'C' STRICT Is that right? Jon -- Jon Jensen End Poi

[PATCHES] more fixes for making contrib null safe

2005-01-28 Thread Kris Jurka
This adds the strict function attribute to the places in contrib that crash on null inputs. Kris JurkaIndex: contrib/chkpass/chkpass.sql.in === RCS file: /projects/cvsroot/pgsql/contrib/chkpass/chkpass.sql.in,v retrieving revision 1

Re: [PATCHES] Continue transactions after errors in psql

2005-01-28 Thread Robert Treat
On Fri, 2005-01-28 at 04:46, Christopher Kings-Lynne wrote: > > I've attached a revised patch which fixes the problem, however I'm sure > > there > > is a better way. Thanks to Neil for putting up with me on irc :-) > > How about calling the savepoint pg_psql_savepoint instead, that way it > f

Re: [PATCHES] dbsize patch

2005-01-28 Thread Andreas Pflug
Tom Lane wrote: Andreas Pflug <[EMAIL PROTECTED]> writes: Hm, these are all implementable as SQL functions, do we need these hard coded too? e.g. create function aggregate_relation_size(oid) returns int8 as $CODE$ select sum(pg_relation_size(indexrelid)) from pg_index where indrelid=$1; $CODE$ la

Re: [PATCHES] Continue transactions after errors in psql

2005-01-28 Thread Michael Paesold
Robert Treat wrote: I've attached a revised patch which fixes the problem, however I'm sure there is a better way. Thanks to Neil for putting up with me on irc :-) In September 2004 I had already sent a patch to implement this behaviour, the patch, still in the archives, is here: http://archives

Re: [PATCHES] Continue transactions after errors in psql

2005-01-28 Thread Christopher Kings-Lynne
I've attached a revised patch which fixes the problem, however I'm sure there is a better way. Thanks to Neil for putting up with me on irc :-) How about calling the savepoint pg_psql_savepoint instead, that way it follows our 'don't begin things with pg_' philosophy. Chris