Re: [PATCHES] final light versions of Oracle compatibility (SQLSTATE, GREATEST,

2005-06-08 Thread Neil Conway
Pavel Stehule wrote: 1. SQLSTATE and SQLERRM exists only on exception's block, and allways carry info about some exception. Attached is a revised version of this patch. I'll apply it tonight or tomorrow, barring any objections. -Neil Index: doc/src/sgml/plpgsql.sgml =

Re: [PATCHES] [HACKERS] Should *.backup files ever be removed from pg_xlog?

2005-06-08 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian writes: > > I have fixed the code to properly remove *.backup files from the > > /pg_xlog directory once they are archived. > > I do not actually think that this is a good idea. The .backup files are > not large and they are pretty critical info --- so having mult

Re: [PATCHES] [HACKERS] Should *.backup files ever be removed from pg_xlog?

2005-06-08 Thread Tom Lane
Bruce Momjian writes: > I have fixed the code to properly remove *.backup files from the > /pg_xlog directory once they are archived. I do not actually think that this is a good idea. The .backup files are not large and they are pretty critical info --- so having multiple copies of them seems li

Re: [PATCHES] ALTER SCHEMA ... SET TABLESPACE

2005-06-08 Thread Bruce Momjian
Thanks, removed. --- Tom Lane wrote: > Gavin Sherry <[EMAIL PROTECTED]> writes: > > I must have missed something (likely, as I've been away from a computer > > for 6 weeks) but didn't we scrap the idea of schemas having a de

Re: [PATCHES] ALTER SCHEMA ... SET TABLESPACE

2005-06-08 Thread Bruce Momjian
Patch withdrawn by author --- not needed. --- Gavin Sherry wrote: > This patch implements ALTER SCHEMA ... SET TABLESPACE. > > This changes the default schema tablespace but does not attempted to move > objects within the s

Re: [PATCHES] [HACKERS] Should *.backup files ever be removed from pg_xlog?

2005-06-08 Thread Bruce Momjian
Bruce Momjian wrote: > Tom Lane wrote: > > Bruce Momjian writes: > > > When you do a pg_start_backup()/pg_stop_backup(), the *.backup files > > > created in pg_xlog are never deleted. Is that intended? > > > > Yes. See the documentation. DBAs can delete 'em if they feel like, > > but I don't s

Re: [PATCHES] ALTER SCHEMA ... SET TABLESPACE

2005-06-08 Thread Tom Lane
Gavin Sherry <[EMAIL PROTECTED]> writes: > I must have missed something (likely, as I've been away from a computer > for 6 weeks) but didn't we scrap the idea of schemas having a default > tablespace? Yeah, we did, but Bruce has still got that old patch of yours in his to-do queue. It's irrelevan

Re: [PATCHES] ALTER SCHEMA ... SET TABLESPACE

2005-06-08 Thread Gavin Sherry
On Sat, 4 Jun 2005, Bruce Momjian wrote: > > I am thinking some day we will need: > > ALTER SCHEMA ... SET NEW TABLESPACE > > and > > ALTER SCHEMA ... SET CURRENT TABLESPACE > > to specify if existing objects are moved, but at this point we aren't > going to get the later in 8.1, so I

Re: [PATCHES] Are you actively hacking on 2PC?

2005-06-08 Thread Alvaro Herrera
On Tue, Jun 07, 2005 at 07:00:48PM -0400, Tom Lane wrote: > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > Tom, please let me know if you want to hack on it, if that's the case > > I'll stop my cleanup and start to work on supporting the things that > > need further coding, which are AFAICS MultiXa

Re: [PATCHES] AT TIME ZONE with full timezones

2005-06-08 Thread Tom Lane
"Magnus Hagander" <[EMAIL PROTECTED]> writes: > This patch makes it possible to use the full set of timezones when doing > "AT TIME ZONE", and not just the shorlist previously available. > Docs updates forthcoming assuming this approach is considered good ;-) Looks reasonable to me, please supply

Re: [HACKERS] [PATCHES] regexp_replace

2005-06-08 Thread Bruce Momjian
Robert Treat wrote: > On Tuesday 07 June 2005 10:57, David Fetter wrote: > > On Tue, Jun 07, 2005 at 10:27:28PM +0900, Atsushi Ogawa wrote: > > > My idea is opposite. I think that the regexp_replace() should make > > > "replace all" a default. Because the replace() of pgsql replaces all > > > strin

Re: [HACKERS] [PATCHES] regexp_replace

2005-06-08 Thread Robert Treat
On Tuesday 07 June 2005 10:57, David Fetter wrote: > On Tue, Jun 07, 2005 at 10:27:28PM +0900, Atsushi Ogawa wrote: > > My idea is opposite. I think that the regexp_replace() should make > > "replace all" a default. Because the replace() of pgsql replaces all > > string, and regexp_replace() of ora