Re: [PATCHES] CREATE TABLE LIKE INCLUDING INDEXES support

2007-07-10 Thread NikhilS
Hi, This version updates the patch to CVS HEAD and has various fixes and refactoring, including proper docs. I refactored get_opclass_name() into lsyscache.c, but then realized that this means that lsyscache.c will depend on commands/indexcmds.c (for GetDefaultOpClass()), which is arguably

Re: [PATCHES] Maintaining cluster order on insert

2007-07-10 Thread Heikki Linnakangas
Tom Lane wrote: What you would hope to see as the benefit of the patch is that the time for the range SELECT degrades more slowly as more of the table is replaced. Ignoring the first SELECT as being a startup transient, it looks like HEAD degrades from about 3 msec to 6 msec over 10 iterations

Re: [PATCHES] Maintaining cluster order on insert

2007-07-10 Thread Gregory Stark
Tom Lane [EMAIL PROTECTED] writes: * delete a random 2% of the table * vacuum to recover space * insert a random 2% of the table * select (about) 1000 consecutively-numbered rows * select all the rows (this is just a cross check that the number of rows

Re: [PATCHES] Maintaining cluster order on insert

2007-07-10 Thread Heikki Linnakangas
Gregory Stark wrote: It's pretty serious what you're suggesting since it means that we'll basically never have a real cluster feature. I would sure hope we're missing something and there's a way to make this work usefully. Another approach would be an online CLUSTER command. That means

Re: [PATCHES] Maintaining cluster order on insert

2007-07-10 Thread Greg Smith
On Mon, 9 Jul 2007, Tom Lane wrote: The hardware is just a Dell x86_64 workstation with crappy IDE disk, so maybe things would look better elsewhere, but it's all I have to work with. Do you have write-caching turned off on the drive so INSERTs are being rate-limited by WAL syncs? Trying

Re: [PATCHES] Maintaining cluster order on insert

2007-07-10 Thread Tom Lane
Gregory Stark [EMAIL PROTECTED] writes: It's pretty serious what you're suggesting since it means that we'll basically never have a real cluster feature. It seems entirely likely that this is not the way to go about real clustering. regards, tom lane

Re: [PATCHES] Maintaining cluster order on insert

2007-07-10 Thread Tom Lane
Greg Smith [EMAIL PROTECTED] writes: On Mon, 9 Jul 2007, Tom Lane wrote: The hardware is just a Dell x86_64 workstation with crappy IDE disk, so maybe things would look better elsewhere, but it's all I have to work with. Do you have write-caching turned off on the drive so INSERTs are

Re: [PATCHES] CREATE TABLE LIKE INCLUDING INDEXES support

2007-07-10 Thread Bruce Momjian
Neil Conway wrote: On Tue, 2007-05-06 at 14:50 +0530, NikhilS wrote: PFA, a patch which provides the CREATE .. INCLUDING INDEXES functionality. This patch uses the same functionality introduced by the earlier patches in this thread albeit for the INCLUDING INDEXES case. Attached is a

Re: [PATCHES] CREATE TABLE LIKE INCLUDING INDEXES support

2007-07-10 Thread Jaime Casanova
On 7/10/07, Bruce Momjian [EMAIL PROTECTED] wrote: Neil Conway wrote: Attached is a revised version of this patch. Sorry for taking so long to make progress on this: my new job been keeping my busy, and I've recently been ill. Illness only counts as an excuse if you _don't_ recover. If you