Re: [PATCHES] variadic function support

2008-07-13 Thread Jeff Davis
On Sun, 2008-07-13 at 07:52 +0200, Pavel Stehule wrote: you checked second or third variant? There are two variants still. Sorry for being unclear. Those comments regarded patch v2.2.1. The bug is in pg_function_is_visible(). Additionally, I'd like to see support for calling variadic functions

Re: [PATCHES] variadic function support

2008-07-13 Thread Jeff Davis
On Sat, 2008-07-12 at 23:06 -0700, Jeff Davis wrote: I don't have a strong opinion about whether the variadic argument is declared as an array or scalar, so I am posting my comments about this version of the patch as well. This version also has a problem when declaring two functions foo(int)

Re: [PATCHES] variadic function support

2008-07-13 Thread Pavel Stehule
2008/7/13 Jeff Davis [EMAIL PROTECTED]: On Tue, 2008-06-24 at 17:10 +0200, Pavel Stehule wrote: Hello this version implements syntax based on argmodes. CREATE FUNCTION mleast(variadic numeric[]) RETURNS numeric AS $$ SELECT min($1[i]) FROM generate_subscripts($1,1) g(i); $$

Re: [PATCHES] page macros cleanup (ver 04)

2008-07-13 Thread Tom Lane
Zdenek Kotala [EMAIL PROTECTED] writes: Good catch. if we have to bump catalog version then I have there small patch which introduce following macro and remove PageHeaderData stucture from HashMetaPageData: Seems like a bad idea --- PageGetContents is not guaranteed to deliver a maxaligned

Re: [PATCHES] page macros cleanup (ver 04)

2008-07-13 Thread Tom Lane
Heikki Linnakangas [EMAIL PROTECTED] writes: ... That macro is actually doing the same thing as PageGetContents, so I switched to using that. As that moves the data sligthly on those bitmap pages, I guess we'll need a catversion bump. I'm amazed that Zdenek didn't scream bloody murder

Re: [HACKERS] [PATCHES] GIN improvements

2008-07-13 Thread Teodor Sigaev
Updated: http://www.sigaev.ru/misc/fast_insert_gin-0.9.gz need more review of fast_insert yet? It looked like a number of people commented on it already. I still havn't clearness of acceptability for suggested aminsertcleanup calling. -- Teodor Sigaev