Re: [PATCHES] Nested transactions

2004-06-18 Thread Barry Lind
The other thing that I have been meaning to say in this thread is that I don't like using COMMIT to mean subtransaction commit (vs. introducing a new command for it) because of the following situation. Lets say that I have a java method that takes a jdbc connection and this code starts a trans

Re: [PATCHES] Nested transactions

2004-06-17 Thread Barry Lind
Alvaro Herrera wrote: With this in place, implementing SAVEPOINTs the way SQL expects them to work appears to be a very trivial exercise. You may not see it, but a savepoint is just the start of a nested transaction in disguise. Consider: begin; insert into foo values (1); savepoi

Re: [PATCHES] Nested transactions

2004-06-16 Thread Barry Lind
I agree with Simon's comments. And to them I would add: I had assumed that the requirements for 'nested transactions' was following some standard definition or specification (i.e. the ANSI SQL spec). But from what I can tell, we are rolling our own definition here, not following a specificat

Re: [PATCHES] Ant version detection

2003-10-23 Thread Barry Lind
Johann, I would suggest putting together a rough proposal of what functionality you want to add (and if appropriate how you want to add it) and send it to the pgsql-jdbc mail list. Then incorporate the feedback you get from the community. thanks, --Barry Johann Uhrmann wrote: Tom Lane wrote:

Re: [PATCHES] [JDBC] JDBC stored procs doc patch

2003-08-14 Thread Barry Lind
Patch applied. thanks, --Barry Nic wrote: The changes to JDBC stored proc calls (made a while ago) highlighted some bits missing in the manual. This fills them in. Index: doc/src/sgml/jdbc.sgml ===

Re: [PATCHES] [JDBC] more bad markup -- jdbc.sgml

2003-08-08 Thread Barry Lind
Fixed. --Barry Joe Conway wrote: Second case of bad markup today. Someone from the jdbc camp might want to look at this, but I took a shot at fixing it so I could keep working on my own doc updates. Joe p.s. Just a friendly reminder ;-) cd doc/src/sgml make check

pgsql-patches@postgresql.org

2003-06-30 Thread Barry Lind
Kim, Are you going to be submitting a patch for this? thanks, --Barry Kim Ho wrote: On Wed, 2003-06-18 at 13:09, Kim Ho wrote: Problem: - setObject(x,y,Types.BIT) throws an exception if y is a Number - getObject() on a bit column will return null instead of True or False Boolean objects Added Pr

Re: [JDBC] [PATCHES] IPv6 patch doesn't work fine

2003-06-30 Thread Barry Lind
Patch applied. thanks, --Barry Kris Jurka wrote: On Sat, 28 Jun 2003, Kurt Roeckx wrote: On Thu, Jun 26, 2003 at 08:02:01AM -0400, Kris Jurka wrote: On Thu, 26 Jun 2003, Manuel Gil [iso-8859-1] P?rez wrote: Hi all. I have a Java application that it connects to the PostgreSQL database with IP

Re: [PATCHES] Add checking in setMaxRows, setQueryTimeout, and setFetchSize

2003-06-30 Thread Barry Lind
Patch applied. --Barry Kim Ho wrote: Problem: - If you try to setMaxRows(), setQueryTimeout() or setFetchSize() to negative values, it should throw an exception, but doesn't. JDBC CTS test failures. Fix: - Added new error messages to errors.properties file. - PSQLExceptions thrown when user a