been installed in $libdir.
Thanks,
-rocco
> -Original Message-
> From: Tom Lane [mailto:[EMAIL PROTECTED]
> Sent: Thursday, January 19, 2006 6:28 PM
> To: Rocco Altier
> Cc: Bruce Momjian; Andrew Dunstan; Magnus Hagander; PostgreSQL-patches
> Subject: Re: [PATCHES]
"Rocco Altier" <[EMAIL PROTECTED]> writes:
> If we take the DESTDIR out of here, where should we get the POSTGRES_IMP
> file from?
In the PGXS case, $(bindir) has been gotten from pg_config, and it's
correct as-is by definition. Adding $(DESTDIR) to it cannot be right.
re
On Thu, 2006-01-19 at 15:33 -0500, Tom Lane wrote:
> Bruce Momjian writes:
> > The difference between Magnus's and Andrew's is
> > that Magnus used MODULE_big (which means create a shared library), while
> > Andrew used MODULES. So, Magnus's only worked because he was creating a
> > DLL and that
y 19, 2006 3:54 PM
> To: Bruce Momjian
> Cc: Andrew Dunstan; Magnus Hagander; PostgreSQL-patches
> Subject: Re: [PATCHES] [HACKERS] pgxs/windows
>
>
> Bruce Momjian writes:
> > Tom Lane wrote:
> >> What about the question of whether $(DESTDIR) belongs there or
Tom Lane wrote:
> Bruce Momjian writes:
> > Tom Lane wrote:
> >> What about the question of whether $(DESTDIR) belongs there or not?
> >> I think we had concluded that PGXS shouldn't ever use $(DESTDIR),
> >> because that's only for install-time stuff.
>
> > I considered that a separate issue and
Bruce Momjian writes:
> Tom Lane wrote:
>> What about the question of whether $(DESTDIR) belongs there or not?
>> I think we had concluded that PGXS shouldn't ever use $(DESTDIR),
>> because that's only for install-time stuff.
> I considered that a separate issue and didn't explore it, but I thin
Tom Lane wrote:
> Bruce Momjian writes:
> > The difference between Magnus's and Andrew's is
> > that Magnus used MODULE_big (which means create a shared library), while
> > Andrew used MODULES. So, Magnus's only worked because he was creating a
> > DLL and that brought in the -L from MODULE_big.
Bruce Momjian writes:
> The difference between Magnus's and Andrew's is
> that Magnus used MODULE_big (which means create a shared library), while
> Andrew used MODULES. So, Magnus's only worked because he was creating a
> DLL and that brought in the -L from MODULE_big.
Ah, good catch.
> I have
OK, I found the cause. Using tests from Magnus and Andrew, I could
reproduce Magnus's success and Andrew's failure in an 8.1.2 pginstaller
install using MinGW. The difference between Magnus's and Andrew's is
that Magnus used MODULE_big (which means create a shared library), while
Andrew used MOD
