[PATCHES] COPY Fillfactor patch

2005-04-12 Thread Simon Riggs
During recent tuning of the TPC-C workload, I produced the following patch to force COPY to leave some space in each data block when it loads data into heap relations. Rationale for this was to improve performance of random UPDATE statements against a table too large to fit in memory. That activit

Re: [PATCHES] COPY Fillfactor patch

2005-04-12 Thread Tom Lane
Simon Riggs <[EMAIL PROTECTED]> writes: > During recent tuning of the TPC-C workload, I produced the following > patch to force COPY to leave some space in each data block when it loads > data into heap relations. This is an amazingly ugly way to do it. Put the info into the Relation structure in

Re: [PATCHES] COPY Fillfactor patch

2005-04-12 Thread Neil Conway
Simon Riggs wrote: During recent tuning of the TPC-C workload, I produced the following patch to force COPY to leave some space in each data block when it loads data into heap relations. I can't get too excited about incorporating changes designed solely to improve performance for the workload of

Re: [PATCHES] COPY Fillfactor patch

2005-04-12 Thread Simon Riggs
On Wed, 2005-04-13 at 00:00 +1000, Neil Conway wrote: > Simon Riggs wrote: > > During recent tuning of the TPC-C workload, I produced the following > > patch to force COPY to leave some space in each data block when it loads > > data into heap relations. > > I can't get too excited about incorpora

Re: [PATCHES] COPY Fillfactor patch

2005-04-12 Thread Simon Riggs
On Tue, 2005-04-12 at 09:56 -0400, Tom Lane wrote: > Simon Riggs <[EMAIL PROTECTED]> writes: > > During recent tuning of the TPC-C workload, I produced the following > > patch to force COPY to leave some space in each data block when it loads > > data into heap relations. > > Put the info into th

Re: [PATCHES] COPY Fillfactor patch

2005-04-20 Thread Hannu Krosing
On T, 2005-04-12 at 18:38 +0100, Simon Riggs wrote: > On Tue, 2005-04-12 at 09:56 -0400, Tom Lane wrote: (Neil, I added you to CC: to show you at least two more places where sparse heaps can be generally useful and not tweaks for single benchmark) > > Simon Riggs <[EMAIL PROTECTED]> writes: > > >

Re: [PATCHES] COPY Fillfactor patch

2005-04-20 Thread Bruce Momjian
My guess is that the FILLFACTOR will actually be a GUC variable rather than a clause to CREATE INDEX or REINDEX or CLUSTER. --- Hannu Krosing wrote: > On T, 2005-04-12 at 18:38 +0100, Simon Riggs wrote: > > On Tue, 2005-04-1

Re: [PATCHES] COPY Fillfactor patch

2005-04-20 Thread Simon Riggs
On Wed, 2005-04-20 at 02:08 +0300, Hannu Krosing wrote: > > Anyway, when I get time, I'll finish off the patch. Unless other readers > > would like to follow on. > > I hope you will you will get that time before 8.1 ships :) It's very unlikely, sorry. I'm working towards improving Business Intel

Re: [PATCHES] COPY Fillfactor patch

2005-04-20 Thread Simon Riggs
On Wed, 2005-04-20 at 09:03 -0400, Bruce Momjian wrote: > My guess is that the FILLFACTOR will actually be a GUC variable rather > than a clause to CREATE INDEX or REINDEX or CLUSTER. I hope not, but it would be easier to set like that and a lot easier to code up that way. Trouble is, if you need

Re: [PATCHES] COPY Fillfactor patch

2005-04-20 Thread Tom Lane
Simon Riggs <[EMAIL PROTECTED]> writes: > On Wed, 2005-04-20 at 09:03 -0400, Bruce Momjian wrote: >> My guess is that the FILLFACTOR will actually be a GUC variable rather >> than a clause to CREATE INDEX or REINDEX or CLUSTER. > I hope not, but it would be easier to set like that and a lot easier

Re: [PATCHES] COPY Fillfactor patch

2005-04-20 Thread Bruce Momjian
Tom Lane wrote: > Simon Riggs <[EMAIL PROTECTED]> writes: > > On Wed, 2005-04-20 at 09:03 -0400, Bruce Momjian wrote: > >> My guess is that the FILLFACTOR will actually be a GUC variable rather > >> than a clause to CREATE INDEX or REINDEX or CLUSTER. > > > I hope not, but it would be easier to se

Re: [PATCHES] COPY Fillfactor patch

2005-04-20 Thread Simon Riggs
On Wed, 2005-04-20 at 09:42 -0400, Tom Lane wrote: > Simon Riggs <[EMAIL PROTECTED]> writes: > > On Wed, 2005-04-20 at 09:03 -0400, Bruce Momjian wrote: > >> My guess is that the FILLFACTOR will actually be a GUC variable rather > >> than a clause to CREATE INDEX or REINDEX or CLUSTER. > > > I hop