[Pharo-dev] Issue 12970 - 16 steps to get through #halt - PROPOSED FIX

2015-01-24 Thread Ben Coman
I've found a fix for something that has annoyed me for a long time - but I can't determine what it might break. 1. In Workspace I evaluate the following Halt enableHaltOnce. a := 1. self halt. b := 2. self haltOnce. c := 3. Transcript show: a + b + c. 2. In the debugg

Re: [Pharo-dev] Issue 12970 - 16 steps to get through #halt - PROPOSED FIX

2015-01-24 Thread Sean P. DeNigris
Ben Coman wrote > Anyone see a problem with removing > that last condition? Off the top of my head... Yes that doesn't seem like a good idea. You don't want to find yourself inside Halt. You want to be in your code. Although the change makes this weird exceptional-sounding case better, it looks li

Re: [Pharo-dev] Issue 12970 - 16 steps to get through #halt - PROPOSED FIX

2015-01-26 Thread Nicolai Hess
2015-01-25 0:22 GMT+01:00 Sean P. DeNigris : > Ben Coman wrote > > Anyone see a problem with removing > > that last condition? > > Off the top of my head... Yes that doesn't seem like a good idea. You don't > want to find yourself inside Halt. You want to be in your code. But isn't it already li

Re: [Pharo-dev] Issue 12970 - 16 steps to get through #halt - PROPOSED FIX

2015-01-26 Thread Eliot Miranda
Hi Ben, On Sat, Jan 24, 2015 at 7:57 AM, Ben Coman wrote: > I've found a fix for something that has annoyed me for a long time - but I > can't determine what it might break. > > 1. In Workspace I evaluate the following > > Halt enableHaltOnce. > a := 1. > self halt. > b := 2. >

Re: [Pharo-dev] Issue 12970 - 16 steps to get through #halt - PROPOSED FIX

2015-01-27 Thread Ben Coman
@Sean, In what way will it make halts more annoying? As far as I can tell, it eliminates FIVE mouse-clicks from #halt, and #haltOnce behaviour is unchanged. Now ideally the debugger should not step into the halt at all when you - but this change eliminates FIVE mouse-clicks from #halt, making #

Re: [Pharo-dev] Issue 12970 - 16 steps to get through #halt - PROPOSED FIX

2015-01-27 Thread Ben Coman
Just notice, I have another solution under development. On Tue, Jan 27, 2015 at 9:55 PM, Ben Coman wrote: > @Sean, In what way will it make halts more annoying? As far as I can > tell, it eliminates FIVE mouse-clicks from #halt, and #haltOnce behaviour > is unchanged. > > Now ideally the debug

Re: [Pharo-dev] Issue 12970 - 16 steps to get through #halt - PROPOSED FIX

2015-01-27 Thread Ben Coman
I poked around and found another possible solution uploaded as SLICE-Issue-12970-16-steps-to-get-through-halt-BenComan.2. However this based on my microscope view of tracing in from a #halt in the button. This is the first time I've looked at this and I don't grasp the the high level architectur

Re: [Pharo-dev] Issue 12970 - 16 steps to get through #halt - PROPOSED FIX

2015-01-30 Thread Sean P. DeNigris
Ben Coman wrote > @Sean, In what way will it make halts more annoying? Clearly seems to make things better in your use case, but IIRC the purpose of that test is that you don't want to open the debugger within the halting system. And indeed, when you remove it, you end up in #halt. But where you

Re: [Pharo-dev] Issue 12970 - 16 steps to get through #halt - PROPOSED FIX

2015-01-30 Thread Eliot Miranda
On Fri, Jan 30, 2015 at 2:54 PM, Sean P. DeNigris wrote: > Ben Coman wrote > > @Sean, In what way will it make halts more annoying? > > Clearly seems to make things better in your use case, but IIRC the purpose > of that test is that you don't want to open the debugger within the halting > syste

Re: [Pharo-dev] Issue 12970 - 16 steps to get through #halt - PROPOSED FIX

2015-01-31 Thread Ben Coman
On Sat, Jan 31, 2015 at 8:44 AM, Eliot Miranda wrote: > > > On Fri, Jan 30, 2015 at 2:54 PM, Sean P. DeNigris > wrote: > >> Ben Coman wrote >> > @Sean, In what way will it make halts more annoying? >> >> Clearly seems to make things better in your use case, but IIRC the purpose >> of that test

Re: [Pharo-dev] Issue 12970 - 16 steps to get through #halt - PROPOSED FIX

2015-01-31 Thread Sean P. DeNigris
Ben Coman wrote > This is all in SLICE-Issue-12970-16-steps-to-get-through-halt-BenComan.4. Great, I'll take another look. Did you consider Elliot's suggestion? - Cheers, Sean -- View this message in context: http://forum.world.st/Issue-12970-16-steps-to-get-through-halt-PROPOSED-FIX-tp480

Re: [Pharo-dev] Issue 12970 - 16 steps to get through #halt - PROPOSED FIX

2015-01-31 Thread Ben Coman
On Sat, Jan 31, 2015 at 11:50 PM, Sean P. DeNigris wrote: > Ben Coman wrote > > This is all in SLICE-Issue-12970-16-steps-to-get-through-halt-BenComan.4. > > Great, I'll take another look. Did you consider Elliot's suggestion? > > > Sorry I didn't. At first glance I didn't fathom the "inlining"

Re: [Pharo-dev] Issue 12970 - 16 steps to get through #halt - PROPOSED FIX

2015-02-24 Thread Ben Coman
All, Please take a moment to comment on how you like the current behaviour of executing the following snippet then three times to get to the line c := 3. a := 1. self halt. b := 2. self halt. c := 3. cheers -ben

Re: [Pharo-dev] Issue 12970 - 16 steps to get through #halt - PROPOSED FIX

2015-02-24 Thread Marcus Denker
> On 24 Feb 2015, at 15:21, Ben Coman wrote: > > All, > > Please take a moment to comment on how you like the current behaviour of > executing the following snippet then three times to get to the > line c := 3. > > a := 1. > self halt. > b := 2. > self halt. > c := 3. I like the new be