Re: [Pharo-dev] Random refactoring on UITheme or what?

2014-03-26 Thread Hilaire Fernandes
Ben, My personal opinion on that: - Pharo3Theme subclassing UIWatery was not necessary as these two themes have mostly nothing in common - Indeed if you want to only change a base color of watery theme, you have to subclass from it. - For DrGeo on tablet I needed a dedicated theme to remove the w

Re: [Pharo-dev] Random refactoring on UITheme or what?

2014-03-26 Thread Ben Coman
Hilaire Fernandes wrote: I will propose a simple hierarchy for the theme: UITheme +-UIPharoTheme +-UIVistaryTheme +-UIWateryTheme I will propose to delete all the other themes as they should belong to other package. Hilaire Just curious to learn... I saw mentioned somewhere that it was

Re: [Pharo-dev] Random refactoring on UITheme or what?

2014-03-22 Thread Hilaire Fernandes
Slice in the Inbox. https://pharo.fogbugz.com/f/cases/13118/Clean-up-the-mess-in-UITheme-hierarchy Thanks Hilaire Le 22/03/2014 18:11, Ben Coman a écrit : > Hilaire Fernandes wrote: >> Sure. >> Oh, by the way I realize the Polymoprh examples where scalped in Pharo3 >> because of the protocol ch

Re: [Pharo-dev] Random refactoring on UITheme or what?

2014-03-22 Thread Ben Coman
Hilaire Fernandes wrote: Sure. Oh, by the way I realize the Polymoprh examples where scalped in Pharo3 because of the protocol change of ListModel. This is really *not* nice. Fixing that as well. Hilaire Thanks Hilaire. Le 22/03/2014 17:10, p...@highoctane.be a écrit : Pharo3Theme is a

Re: [Pharo-dev] Random refactoring on UITheme or what?

2014-03-22 Thread p...@highoctane.be
Pharo3Theme is a renamed glamourTheme under Watery with some leftovers. Maybe a PharoTheme just under UITheme would be cleaner. Phil Le 22 mars 2014 16:49, "Hilaire Fernandes" a écrit : > I don't think so. These are orthogonal. > > I will propose a simple hierarchy for the theme: > > UITheme

Re: [Pharo-dev] Random refactoring on UITheme or what?

2014-03-22 Thread Hilaire Fernandes
Sure. Oh, by the way I realize the Polymoprh examples where scalped in Pharo3 because of the protocol change of ListModel. This is really *not* nice. Fixing that as well. Hilaire Le 22/03/2014 17:10, p...@highoctane.be a écrit : > Pharo3Theme is a renamed glamourTheme under Watery with some lef

Re: [Pharo-dev] Random refactoring on UITheme or what?

2014-03-22 Thread Hilaire Fernandes
I don't think so. These are orthogonal. I will propose a simple hierarchy for the theme: UITheme +-UIPharoTheme +-UIVistaryTheme +-UIWateryTheme I will propose to delete all the other themes as they should belong to other package. Hilaire Le 22/03/2014 15:27, Nicolas Cellier a écrit : > Per

Re: [Pharo-dev] Random refactoring on UITheme or what?

2014-03-22 Thread Nicolas Cellier
Personnally, I find a huge progress in usability of 3.0 tools versus 2.0 which was really awfull. If it must be at the price of broken themes (we can hope temporarily), I buy it. 2014-03-22 15:14 GMT+01:00 Pharo4Stef : > > > > Speaking of that, one will notice that the class comment of UITheme h

Re: [Pharo-dev] Random refactoring on UITheme or what?

2014-03-22 Thread Pharo4Stef
> Speaking of that, one will notice that the class comment of UITheme has the > examples list: > > Common superclass for User Interface themes. Provides methods for creating > new morphs in a standard way, various "services" like a file dialog, message > dialogs etc. and also methods for cust

Re: [Pharo-dev] Random refactoring on UITheme or what?

2014-03-22 Thread p...@highoctane.be
Speaking of that, one will notice that the class comment of UITheme has the examples list: Common superclass for User Interface themes. Provides methods for creating new morphs in a standard way, various "services" like a file dialog, message dialogs etc. and also methods for customising aspects o

Re: [Pharo-dev] Random refactoring on UITheme or what?

2014-03-22 Thread Sergi Reyner
2014-03-22 10:55 GMT+00:00 Esteban Lorenzano : > > So... I suppose we need to do both: clean removing the old ones and fix the > ones we decide to keep :) > While talking about themes... I´d like to have at least one theme that supports changing the window color, without looking childish like th

Re: [Pharo-dev] Random refactoring on UITheme or what?

2014-03-22 Thread Hilaire Fernandes
Phil, What is the darktheme? Years ago I produced a Sugar theme for DrGeo on XO OLPC[1]. It is a black and white theme[2]. Thanks Hilaire [1] http://blog.ofset.org/hilaire/index.php?post/2010/07/20/Pharo-Smalltalk-on-XO [2] http://blog.ofset.org/hilaire/index.php?post/2010/07/17/Sugar-theme-f

Re: [Pharo-dev] Random refactoring on UITheme or what?

2014-03-22 Thread Esteban Lorenzano
Hi Hilaire, There are many themes that needs to be removed (Pharo -is the old one-, Orange, Blue). Then others we need to decide what we do with them. For example, I have the feeling that vistary theme is so bad that no one uses it, but I can be wrong (and maybe is not so bad and is just me wh

Re: [Pharo-dev] Random refactoring on UITheme or what?

2014-03-22 Thread Hilaire Fernandes
Hello, Well, if you can't do it, don't. I mean there is no obligation to refactor working stuff if you don't have the resource to go from A to Z. It is ok. Then I *don't* understand something else: why so many new themes? It is ridiculous to see PharoTheme, BlueTheme, OrangeTheme, Pharo3Theme. So

Re: [Pharo-dev] Random refactoring on UITheme or what?

2014-03-22 Thread Sven Van Caekenberghe
The theme stuff is really hard and complex. It is impossible to maintain multiple ones, especially if those are seldom used. Maybe it would have been better to remove all those that are not properly maintained. But that would not have made you happy either I guess. It is really simple: with the

Re: [Pharo-dev] Random refactoring on UITheme or what?

2014-03-22 Thread p...@highoctane.be
Themes are hard to change in 2.0 And the darktheme can only come out of serious refactorings I think. So, I've got hope that we move forward on that and there will indeed be serious breakage along the way. Phil On Sat, Mar 22, 2014 at 9:48 AM, Pharo4Stef wrote: > > > > > In Pharo3, the UIThe

Re: [Pharo-dev] Random refactoring on UITheme or what?

2014-03-22 Thread Pharo4Stef
> > In Pharo3, the UITheme hierarchy seems to have been hit by random > refactoring (it really looks like that) because it is broken in so many > place[1][2][3] and in such obvious way (very visible). > > It will be nice the random refactorers take(s) full responsibility to do > the job from A t

[Pharo-dev] Random refactoring on UITheme or what?

2014-03-22 Thread Hilaire Fernandes
Hello, In Pharo3, the UITheme hierarchy seems to have been hit by random refactoring (it really looks like that) because it is broken in so many place[1][2][3] and in such obvious way (very visible). It will be nice the random refactorers take(s) full responsibility to do the job from A to Z, an