Re: [Pharo-dev] SUnit improvements need review and feedback

2016-09-09 18:09 GMT+02:00 stepharo : > Tx denis. > > I wonder what is the reason of the crashes I experienced. > I don't know. Here is details on covered issue: TestExecutionEnvironment introduces problem when image is saved inside test process (which is case for Guille code which fork image in

Re: [Pharo-dev] SUnit improvements need review and feedback

Tx denis. I wonder what is the reason of the crashes I experienced. Le 9/9/16 à 18:01, Denis Kudriashov a écrit : And fix for Guille case is inbox 19073 . (details are inside)

Re: [Pharo-dev] SUnit improvements need review and feedback

And fix for Guille case is inbox 19073 . (details are inside) 2016-09-05 23:30 GMT+02:00 Denis Kudriashov : > > 2016-09-05 18:23 GMT+02:00 Guillermo Polito : > >> ARgh, since this go

Re: [Pharo-dev] SUnit improvements need review and feedback

2016-09-05 18:23 GMT+02:00 Guillermo Polito : > ARgh, since this got integrated I keep crashing images... > > I'm just executing some OSSubprocess like this: > > process := OSSUnixSubprocess new > command: 'ls'; > redirectStdout; > runAndWaitOnExitDo: [ :command :outString | ^ outString ]. > > and

Re: [Pharo-dev] SUnit improvements need review and feedback

On Mon, Sep 5, 2016 at 3:18 PM, Guille Polito wrote: > Hola, > > for the record, I'm using OSSubprocess in several projects and it's pretty > robust. > Good to hear that. > The problems I had were because either: > > - I was using it wrongly. e.g., I was deadlocking my process due to a > pro

Re: [Pharo-dev] SUnit improvements need review and feedback

Hola, for the record, I'm using OSSubprocess in several projects and it's pretty robust. The problems I had were because either: - I was using it wrongly. e.g., I was deadlocking my process due to a process that was writing a lot to stdout. I fixed this after I read the entire documentation.

Re: [Pharo-dev] SUnit improvements need review and feedback

Guille, Just for the record, there has been some crashes in Pharo using OSSubprocess, but I (we) were never able to reproduce nor found the cause, and even less a fix :( Soany help in this direction is really appreciated as I want OSSubprocess to be robust. Cheers, On Mon, Sep 5, 2016 at 2:5

Re: [Pharo-dev] SUnit improvements need review and feedback

I mean crash. Somehow my image's processes were killed and I only had the UI process: no delay process, no finalization, no idle process. Then, when the VM tries to suspend the current process and change to a second one, it finds none and it just quits. So it's not a VM problem I think but mostly

Re: [Pharo-dev] SUnit improvements need review and feedback

ARgh, since this got integrated I keep crashing images... do you mean real crash or DNU. Because indeed I got some crashes too.

Re: [Pharo-dev] SUnit improvements need review and feedback

argh!! May be we should revert the change. And make the changes optional. ARgh, since this got integrated I keep crashing images... I'm just executing some OSSubprocess like this: process := OSSUnixSubprocess new command: 'ls'; redirectStdout; runAndWaitOnExitDo: [ :command :outString |

Re: [Pharo-dev] SUnit improvements need review and feedback

ARgh, since this got integrated I keep crashing images... I'm just executing some OSSubprocess like this: process := OSSUnixSubprocess new command: 'ls'; redirectStdout; runAndWaitOnExitDo: [ :command :outString | ^ outString ]. and my image crashes with a: (scheduler could not find a runnable

Re: [Pharo-dev] SUnit improvements need review and feedback

And it is worth breaking all the book chapters and videos. I think that assert: closeTo: kind of solution is - simple - regular with the other assert: - incremental So maximum quality. Stef

Re: [Pharo-dev] SUnit improvements need review and feedback

2016-09-03 9:22 GMT+02:00 stepharo >: Denis can we also have assert: aNumber withPrecision: precision equals: otherNumber self assert: (aNumber round: precision) equals: otherNumber assert: aNumber closeTo: otherNumber

Re: [Pharo-dev] SUnit improvements need review and feedback

Nicolas I like your ideas can you propose (code) something? Stef Le 3/9/16 à 09:48, Nicolas Cellier a écrit : For floating points it would be good to also have something related to unit of least precision like I think it exists in google tests: assert: aFloat isWithin: anInteger ulpFrom: an

Re: [Pharo-dev] SUnit improvements need review and feedback

2016-09-03 19:11 GMT+02:00 Paul DeBruicker : > Oh wait I see in the first message in this thread you have > > self timeLimit: 10 seconds > yes

Re: [Pharo-dev] SUnit improvements need review and feedback

Oh wait I see in the first message in this thread you have self timeLimit: 10 seconds Paul DeBruicker wrote > How do you propose raising the limit for a specific test would go? > > Pragma? > Denis Kudriashov wrote >> Super!!! It's integrated (In 60201). Thank's integrators. >> >> Now w

Re: [Pharo-dev] SUnit improvements need review and feedback

How do you propose raising the limit for a specific test would go? Pragma? Denis Kudriashov wrote > Super!!! It's integrated (In 60201). Thank's integrators. > > Now we need correct default time limit and mark long tests as long. I > opened new issue 19035 >

Re: [Pharo-dev] SUnit improvements need review and feedback

Super!!! It's integrated (In 60201). Thank's integrators. Now we need correct default time limit and mark long tests as long. I opened new issue 19035 . What you think about default value? I would use 200 millis

Re: [Pharo-dev] SUnit improvements need review and feedback

2016-09-03 11:17 GMT+02:00 Denis Kudriashov : > > 2016-09-03 9:48 GMT+02:00 Nicolas Cellier gmail.com>: > >> For floating points it would be good to also have something related to >> unit of least precision like I think it exists in google tests: >> >> assert: aFloat isWithin: anInteger ulpFrom:

Re: [Pharo-dev] SUnit improvements need review and feedback

2016-09-03 9:48 GMT+02:00 Nicolas Cellier < nicolas.cellier.aka.n...@gmail.com>: > For floating points it would be good to also have something related to > unit of least precision like I think it exists in google tests: > > assert: aFloat isWithin: anInteger ulpFrom: anotherFloat > ^(aFloat -

Re: [Pharo-dev] SUnit improvements need review and feedback

2016-09-03 9:22 GMT+02:00 stepharo : > Denis > > can we also have > > assert: aNumber withPrecision: precision equals: otherNumber > > self > assert: (aNumber round: precision) > equals: otherNumber > > assert: aNumber closeTo: otherNumber > > assert: aNumber withPrecision:

Re: [Pharo-dev] SUnit improvements need review and feedback

Hi 2016-09-03 9:22 GMT+02:00 stepharo : > *3) Any failures inside forked processes should not spawn debugger while > running tests.* > Only when we debug tests we need debugger on forked failed processes. > During normal run SUnit should prevent such "background debuggers" and > mark such tests a

Re: [Pharo-dev] SUnit improvements need review and feedback

For floating points it would be good to also have something related to unit of least precision like I think it exists in google tests: assert: aFloat isWithin: anInteger ulpFrom: anotherFloat ^(aFloat - anotherFloat) abs <= (anotherFloat ulp max: aFloat ulp) It's testing if the result are the

Re: [Pharo-dev] SUnit improvements need review and feedback

Denis can we also have assert: aNumber withPrecision: precision equals: otherNumber self assert: (aNumber round: precision) equals: otherNumber assert: aNumber closeTo: otherNumber assert: aNumber withPrecision: self defaultPrecision equals: otherNumber defaul

[Pharo-dev] SUnit improvements need review and feedback

Hi. I am working on SUnit improvements. I open issue 19015 . Slice is inbox which waits your review and feedback. I was trying to address three problems: *1) Tests should never hang. They should be al