Re: [Pharo-project] Need code review

2008-06-16 Thread Stéphane Ducasse
Ok I will try to harvest it today. Stef On Jun 16, 2008, at 2:23 PM, Alexandre Bergel wrote: Ah ok.. I see now... As I said, your removal makes fully sense to me... Alexandre On 16 Jun 2008, at 14:13, Alain Plantec wrote: Hi Alexandre, thanks for this review. On Monday 16 June 2008 09:3

Re: [Pharo-project] Need code review

2008-06-16 Thread Alexandre Bergel
Ah ok.. I see now... As I said, your removal makes fully sense to me... Alexandre On 16 Jun 2008, at 14:13, Alain Plantec wrote: Hi Alexandre, thanks for this review. On Monday 16 June 2008 09:34:26 Alexandre Bergel wrote: http://lists.gforge.inria.fr/pipermail/pharo-project/2008-June/0003

Re: [Pharo-project] Need code review

2008-06-16 Thread Alain Plantec
Hi Alexandre, thanks for this review. On Monday 16 June 2008 09:34:26 Alexandre Bergel wrote: > > http://lists.gforge.inria.fr/pipermail/pharo-project/2008-June/000323.html > >>> [Pharo-project] MVC removal step2 investigations ... > Few questions: > - Inspector>>openOn: anObject wit

Re: [Pharo-project] Need code review

2008-06-16 Thread Alexandre Bergel
http://lists.gforge.inria.fr/pipermail/pharo-project/2008-June/000323.html [Pharo-project] MVC removal step2 investigations This is a big removal. I reviewed the code. Here are my comments: - Few methods in Browser are redefined using the hypothesis that a browser cannot be open in a

Re: [Pharo-project] Need code review

2008-06-14 Thread Stéphane Ducasse
yes if you could cut it into smaller ones it would be better. Stef On Jun 14, 2008, at 12:31 PM, Alexandre Bergel wrote: I am now working on the second change. It is a big one... Alexandre On 14 Jun 2008, at 12:27, Stéphane Ducasse wrote: ok I will harvest it. Stef On Jun 14, 2008, at 1

Re: [Pharo-project] Need code review

2008-06-14 Thread Alexandre Bergel
I am now working on the second change. It is a big one... Alexandre On 14 Jun 2008, at 12:27, Stéphane Ducasse wrote: ok I will harvest it. Stef On Jun 14, 2008, at 12:18 PM, Alexandre Bergel wrote: http://lists.gforge.inria.fr/pipermail/pharo-project/2008-June/000238.html [Pharo

Re: [Pharo-project] Need code review

2008-06-14 Thread Stéphane Ducasse
ok I will harvest it. Stef On Jun 14, 2008, at 12:18 PM, Alexandre Bergel wrote: http://lists.gforge.inria.fr/pipermail/pharo-project/2008-June/000238.html [Pharo-project] Hunting down nebraska This change makes sense to me. Essentially reorganization. Alexandre -- _,.;:~^~:;._,.;:

Re: [Pharo-project] Need code review

2008-06-14 Thread Alexandre Bergel
http://lists.gforge.inria.fr/pipermail/pharo-project/2008-June/000238.html [Pharo-project] Hunting down nebraska This change makes sense to me. Essentially reorganization. Alexandre -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^

Re: [Pharo-project] Need code review

2008-06-13 Thread Norbert Hartl
Stef wrote down subject lines from postings to this list http://lists.gforge.inria.fr/pipermail/pharo-project/2008-June/000238.html http://lists.gforge.inria.fr/pipermail/pharo-project/2008-June/000323.html Norbert On Fri, 2008-06-13 at 11:37 +0200, Alexandre Bergel wrote: > Sorry to weak up so

Re: [Pharo-project] Need code review

2008-06-13 Thread Alexandre Bergel
Sorry to weak up so lately, but where the source code is accessible ? I spent few minutes on looking at: - PharoInBox - list of taks on gforge - list of issues on google and I haven't found where the code to review could be... Any hint? Alexandre On 13 Jun 2008, at 11:1

[Pharo-project] Need code review

2008-06-13 Thread Stéphane Ducasse
Hi guys I would like some other people to have a look at [Pharo-project] Hunting down nebraska [Pharo-project] MVC removal step2 investigations Can somebody have a look? Stef ___ Pharo-project mailing list Pharo-project@lists.gforge.