[PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/oci8/oci8_statement.c trunk/ext/oci8/oci8_statement.c

2010-04-23 Thread Christopher Jones
sixd Sat, 24 Apr 2010 00:44:56 + Revision: http://svn.php.net/viewvc?view=revision&revision=298404 Log: Initialize vars to prevent valgrind warnings in some cases Changed paths: U php/php-src/branches/PHP_5_3/ext/oci8/oci8_statement.c U php/php

[PHP-CVS] svn: /php/php-src/trunk/ Makefile.global

2010-04-23 Thread Felipe Pena
felipe Fri, 23 Apr 2010 19:20:55 + Revision: http://svn.php.net/viewvc?view=revision&revision=298390 Log: - Fix regexp Changed paths: U php/php-src/trunk/Makefile.global Modified: php/php-src/trunk/Makefile.global =

Re: [PHP-CVS] svn: /php/php-src/trunk/ Makefile.global

2010-04-23 Thread Christopher Jones
Kalle Sommer Nielsen wrote: kalleThu, 22 Apr 2010 23:23:10 + Revision: http://svn.php.net/viewvc?view=revision&revision=298352 Log: Update the deprecated directives in the MakeFile Changed paths: U php/php-src/trunk/Makefile.global Modified: php

[PHP-CVS] svn: /php/php-src/trunk/sapi/fpm/fpm/ fpm_main.c

2010-04-23 Thread Jérôme Loyet
fat Fri, 23 Apr 2010 16:05:52 + Revision: http://svn.php.net/viewvc?view=revision&revision=298383 Log: Add PHP_VALUE and PHP_ADMIN_VALUE interpretation from fastcgi headers. It works as php_value and php_admin_value from the main conf file or apache sapi.

[PHP-CVS] svn: /php/php-src/trunk/sapi/fpm/fpm/ fastcgi.c fastcgi.h fpm_main.c fpm_status.c fpm_status.h fpm_stdio.c

2010-04-23 Thread Jérôme Loyet
fat Fri, 23 Apr 2010 15:09:28 + Revision: http://svn.php.net/viewvc?view=revision&revision=298380 Log: Remove unused functions / variables / #if 0 blocks Changed paths: U php/php-src/trunk/sapi/fpm/fpm/fastcgi.c U php/php-src/trunk/sapi/fpm/fp

[PHP-CVS] svn: /php/php-src/trunk/sapi/fpm/ php-fpm.conf.in

2010-04-23 Thread Jérôme Loyet
fat Fri, 23 Apr 2010 13:56:14 + Revision: http://svn.php.net/viewvc?view=revision&revision=298375 Log: typo Changed paths: U php/php-src/trunk/sapi/fpm/php-fpm.conf.in Modified: php/php-src/trunk/sapi/fpm/php-fpm.conf.in ===

[PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/mysqli/tests/bug51647.phpt branches/PHP_5_3/ext/mysqli/tests/cacert.pem branches/PHP_5_3/ext/mysqli/tests/client-cert.pem branch

2010-04-23 Thread Andrey Hristov
andrey Fri, 23 Apr 2010 13:54:40 + Revision: http://svn.php.net/viewvc?view=revision&revision=298374 Log: Fix for bug #51647 Certificate file without private key (pk in another file) doesn't work Bug: http://bugs.php.net/51647 (Verified) Certificate file wi

[PHP-CVS] svn: /php/php-src/ branches/PHP_5_2/ext/openssl/xp_ssl.c branches/PHP_5_3/ext/openssl/xp_ssl.c trunk/ext/openssl/xp_ssl.c

2010-04-23 Thread Felipe Pena
felipe Fri, 23 Apr 2010 13:32:03 + Revision: http://svn.php.net/viewvc?view=revision&revision=298373 Log: - Fixed compiler warnings Changed paths: U php/php-src/branches/PHP_5_2/ext/openssl/xp_ssl.c U php/php-src/branches/PHP_5_3/ext/openssl/xp_s

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/openssl/openssl.c trunk/ext/openssl/openssl.c

2010-04-23 Thread Pierre Joye
Please open a new bug with the details + reproduce script. Thanks. On Fri, Apr 23, 2010 at 2:42 PM, Andrey Hristov wrote: > Tony, > > Antony Dovgal wrote: >> >> On 23.04.2010 15:05, Andrey Hristov wrote: >>> >>> "The SSL_CTX_use_PrivateKey_file function loads the private key for use >>> with Secu

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/openssl/openssl.c trunk/ext/openssl/openssl.c

2010-04-23 Thread Andrey Hristov
Tony, Antony Dovgal wrote: On 23.04.2010 15:05, Andrey Hristov wrote: "The SSL_CTX_use_PrivateKey_file function loads the private key for use with Secure Sockets Layer (SSL) sessions using a specific context (CTX) structure." However, what gets passed is path to a certificate, not to a priva

Re: [PHP-CVS] Re: utf-8?q?svn:_/php/php-src/trunk/sapi/fpm/_config.m4_fpm/fastcgi.c_ fpm/fpm=5Fchildren.c_fpm/fpm=5Fconf.c_fpm/fpm=5Fconf.h_fpm/fpm=5Fenv.c_fpm /fpm=5Fphp.c_fpm/fpm=5Fprocess=5Fctl.c

2010-04-23 Thread Derick Rethans
On Fri, 23 Apr 2010, Pierre Joye wrote: > We agreed to introduce this syntax to trunk while evaluating FPM > altogether. It then makes sense to discuss this evaluation on the list > instead of arguing about a commit. We didn't *agree* on anything. If you still think that, point me to that email

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/openssl/openssl.c trunk/ext/openssl/openssl.c

2010-04-23 Thread Andrey Hristov
Antony Dovgal wrote: On 23.04.2010 15:05, Andrey Hristov wrote: "The SSL_CTX_use_PrivateKey_file function loads the private key for use with Secure Sockets Layer (SSL) sessions using a specific context (CTX) structure." However, what gets passed is path to a certificate, not to a private key

Re: [PHP-CVS] Re: utf-8?q?svn:_/php/php-src/trunk/sapi/fpm/_config.m4_fpm/fastcgi.c_ fpm/fpm=5Fchildren.c_fpm/fpm=5Fconf.c_fpm/fpm=5Fconf.h_fpm/fpm=5Fenv.c_fpm /fpm=5Fphp.c_fpm/fpm=5Fprocess=5Fctl.c

2010-04-23 Thread Jérôme Loyet
Le 23 avril 2010 13:09, Derick Rethans a écrit : > On Fri, 23 Apr 2010, Jérôme Loyet wrote: > >> Le 23 avril 2010 11:31, Derick Rethans a écrit : >> > On Wed, 21 Apr 2010, Jérôme Loyet wrote: >> >> >> >> Log: >> >> switch the configuration syntax from xml to ini >> >> It's been describe in the RF

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/openssl/openssl.c trunk/ext/openssl/openssl.c

2010-04-23 Thread Antony Dovgal
On 23.04.2010 15:05, Andrey Hristov wrote: > "The SSL_CTX_use_PrivateKey_file function loads the private key for use > with Secure Sockets Layer (SSL) sessions using a specific context (CTX) > structure." > > However, what gets passed is path to a certificate, not to a private > key. So you rei

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/openssl/openssl.c trunk/ext/openssl/openssl.c

2010-04-23 Thread Johannes Schlüter
On Fri, 2010-04-23 at 13:05 +0200, Andrey Hristov wrote: > Pierre, Pierre, > + if (SSL_CTX_use_PrivateKey_file(ctx, resolved_path_buff, > SSL_FILETYPE_PEM) != 1) { > > this is what the revert gives back, if you go and check what this > function does: > > "The SSL_CTX_use_PrivateKey_file fun

Re: [PHP-CVS] Re: utf-8?q?svn:_/php/php-src/trunk/sapi/fpm/_config.m4_fpm/fastcgi.c_ fpm/fpm=5Fchildren.c_fpm/fpm=5Fconf.c_fpm/fpm=5Fconf.h_fpm/fpm=5Fenv.c_fpm /fpm=5Fphp.c_fpm/fpm=5Fprocess=5Fctl.c

2010-04-23 Thread Pierre Joye
hi Derick, Please discuss that on the internals mailing (new thread). We agreed to introduce this syntax to trunk while evaluating FPM altogether. It then makes sense to discuss this evaluation on the list instead of arguing about a commit. Thanks, Cheers, 2010/4/23 Derick Rethans : > On Fri,

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/openssl/openssl.c trunk/ext/openssl/openssl.c

2010-04-23 Thread Pierre Joye
On Fri, Apr 23, 2010 at 1:05 PM, Andrey Hristov wrote: > > So, I am going to revert the revert and reintroduce the code that fixes a > bug. No. Don't do that. If you have found a bug in SSL please report a bug with a SSL specific test case and a patch if you have one. Thanks, -- Pierre @pier

[PHP-CVS] Re: utf-8?q?svn:_/php/php-src/trunk/sapi/fpm/_config.m4_fpm/fastcgi.c_ fpm/fpm=5Fchildren.c_fpm/fpm=5Fconf.c_fpm/fpm=5Fconf.h_fpm/fpm=5Fenv.c_fpm /fpm=5Fphp.c_fpm/fpm=5Fprocess=5Fctl.c_fpm

2010-04-23 Thread Derick Rethans
On Fri, 23 Apr 2010, Jérôme Loyet wrote: > Le 23 avril 2010 11:31, Derick Rethans a écrit : > > On Wed, 21 Apr 2010, Jérôme Loyet wrote: > >> > >> Log: > >> switch the configuration syntax from xml to ini > >> It's been describe in the RFC: http://wiki.php.net/rfc/fpm/ini_syntax > > > I feel ext

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/openssl/openssl.c trunk/ext/openssl/openssl.c

2010-04-23 Thread Andrey Hristov
Pierre, Pierre, + if (SSL_CTX_use_PrivateKey_file(ctx, resolved_path_buff, SSL_FILETYPE_PEM) != 1) { this is what the revert gives back, if you go and check what this function does: "The SSL_CTX_use_PrivateKey_file function loads the private key for use with Secure Sockets Layer (SSL) sess

[PHP-CVS] Re: utf-8?q?svn:_/php/php-src/trunk/sapi/fpm/_config.m4_fpm/fastcgi.c_ fpm/fpm=5Fchildren.c_fpm/fpm=5Fconf.c_fpm/fpm=5Fconf.h_fpm/fpm=5Fenv.c_fpm /fpm=5Fphp.c_fpm/fpm=5Fprocess=5Fctl.c_fpm

2010-04-23 Thread Jérôme Loyet
Le 23 avril 2010 11:31, Derick Rethans a écrit : > On Wed, 21 Apr 2010, Jérôme Loyet wrote: > >> fat                                      Wed, 21 Apr 2010 22:56:33 + >> >> Revision: http://svn.php.net/viewvc?view=revision&revision=298281 >> >> Log: >> switch the configuration syntax from xml t

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/openssl/openssl.c trunk/ext/openssl/openssl.c

2010-04-23 Thread Pierre Joye
hi, On Fri, Apr 23, 2010 at 12:14 PM, Andrey Hristov wrote: >  More info about the segfaults? Tests that show the segfaults and thus keep > us from regressions? The tests we have in ext/openssl/tests crash. However we were wondering why you did these changes and I did not see any relation betwe

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/openssl/openssl.c trunk/ext/openssl/openssl.c

2010-04-23 Thread Andrey Hristov
More info about the segfaults? Tests that show the segfaults and thus keep us from regressions? Andrey Antony Dovgal wrote: tony2001 Thu, 22 Apr 2010 15:59:44 + Revision: http://svn.php.net/viewvc?view=revision&revision=298331 Log: revert most of the And

Re: [PHP-CVS] utf-8?q?svn:_/php/php-src/trunk/sapi/fpm/_config.m4_fpm/fastcgi.c_ fpm/fpm=5Fchildren.c_fpm/fpm=5Fconf.c_fpm/fpm=5Fconf.h_fpm/fpm=5Fenv.c_fpm /fpm=5Fphp.c_fpm/fpm=5Fprocess=5Fctl.c_fpm

2010-04-23 Thread Pierre Joye
2010/4/23 Derick Rethans : > I feel extremely unhappy about this patch. From what I've seen there is > only a very small group of people that want to switch from the XML > format to the INI format. Another group, was opposed to this move. I for > one, find this new INI stuff extremely complicated

[PHP-CVS] utf-8?q?svn:_/php/php-src/trunk/sapi/fpm/_config.m4_fpm/fastcgi.c_ fpm/fpm=5Fchildren.c_fpm/fpm=5Fconf.c_fpm/fpm=5Fconf.h_fpm/fpm=5Fenv.c_fpm /fpm=5Fphp.c_fpm/fpm=5Fprocess=5Fctl.c_fpm/fpm=5

2010-04-23 Thread Derick Rethans
On Wed, 21 Apr 2010, Jérôme Loyet wrote: > fat Wed, 21 Apr 2010 22:56:33 + > > Revision: http://svn.php.net/viewvc?view=revision&revision=298281 > > Log: > switch the configuration syntax from xml to ini > It's been describe in the RFC: http://wiki.php.ne

[PHP-CVS] svn: /php/php-src/trunk/Zend/ zend_execute_API.c

2010-04-23 Thread Antony Dovgal
tony2001 Fri, 23 Apr 2010 09:11:44 + Revision: http://svn.php.net/viewvc?view=revision&revision=298370 Log: fix WS Changed paths: U php/php-src/trunk/Zend/zend_execute_API.c Modified: php/php-src/trunk/Zend/zend_execute_API.c ===

[PHP-CVS] svn: /php/php-src/trunk/Zend/ zend_compile.c zend_execute_API.c zend_vm_def.h zend_vm_execute.h

2010-04-23 Thread Dmitry Stogov
dmitry Fri, 23 Apr 2010 08:56:03 + Revision: http://svn.php.net/viewvc?view=revision&revision=298369 Log: Use fast class fetch function Changed paths: U php/php-src/trunk/Zend/zend_compile.c U php/php-src/trunk/Zend/zend_execute_API.c U php

[PHP-CVS] svn: /php/php-src/trunk/sapi/fpm/ php-fpm.conf.in

2010-04-23 Thread Jérôme Loyet
fat Fri, 23 Apr 2010 08:06:49 + Revision: http://svn.php.net/viewvc?view=revision&revision=298368 Log: typo and errors in php-fpm.conf Changed paths: U php/php-src/trunk/sapi/fpm/php-fpm.conf.in Modified: php/php-src/trunk/sapi/fpm/php-fpm.conf.in