janiWed Mar 26 13:35:54 2008 UTC
Modified files: (Branch: PHP_5_3)
/php-srcgenfiles
Log:
- Use the right tool here too
http://cvs.php.net/viewvc.cgi/php-src/genfiles?r1=1.22.2.2r2=1.22.2.2.4.1diff_format=u
Index: php-src/genfiles
diff -u
Hello Jani,
shouldn't the -i go into RE2CFLAGS but then how about the -g that
might have been detected for your system. And another thing is, how do we
deal with cases where re2c is not present. Should we a) error out, b)
revert, c) ignore?
marcus
Wednesday, March 26, 2008, 2:35:54 PM, you
Hello Jani,
the build system figures out whether one is compiling on a system that
uses a GCC version that supports computed gotos. If so it will set
RE2C_FLAGS to -g to enable that. So the genfiles should overwrite this
setting so that the packed tarball does not end up with code generated
janiWed Mar 26 15:04:57 2008 UTC
Modified files: (Branch: PHP_5_3)
/php-srcgenfiles
Log:
- Give Marcus good old warm and fuzzy feeling.. :)
http://cvs.php.net/viewvc.cgi/php-src/genfiles?r1=1.22.2.2.4.1r2=1.22.2.2.4.2diff_format=u
Index: php-src/genfiles
Well, that'd be quite a magical build system to sneak that RE2C_FLAGS
there since no such thing is run when a tarball is created. :)
But to make you have warm fuzzy feeling, I added it like that.
--Jani
On Wed, 2008-03-26 at 15:52 +0100, Marcus Boerger wrote:
Hello Jani,
the build system
