Re: [PHP-CVS] cvs: php-src /ext/mbstring mbstring.c mbstring.h /main rfc1867.c

2003-10-26 Thread Ilia Alshanetsky
On October 26, 2003 02:20 am, Rui Hirokawa wrote: > But, I shoudn't revert an another license related patch > as shown below because the license compatibility has priority. There is no argument about the license fix patch, it is a necessary evil. I will make RC3 on Monday with this patch and if n

Re: [PHP-CVS] cvs: php-src /ext/mbstring mbstring.c mbstring.h/main rfc1867.c

2003-10-26 Thread Rui Hirokawa
Moriyoshi, Yes, there was a temporary agreement that allows us to release the current version in the 4.3 branch until new implementation has stability. But, I think replacing libmbfl with mbfilter.* in PHP 4.3.4 is preferable because, 1. license problem should be solved as quickly as possible

Re: [PHP-CVS] cvs: php-src /ext/mbstring mbstring.c mbstring.h/main rfc1867.c

2003-10-26 Thread Moriyoshi Koizumi
Rui, wasn't there any agreement with the author of libmbfl that still allows us to keep the modified version in the 4.3 branch? Unless there's something obvious, we'd be better off replacing them by the safer stuff however. Moriyoshi Rui Hirokawa <[EMAIL PROTECTED]> wrote: > > Ilia, > > I ap

Re: [PHP-CVS] cvs: php-src /ext/mbstring mbstring.c mbstring.h /main rfc1867.c

2003-10-26 Thread Rui Hirokawa
Ilia, I appreciate your continious effort about QC process. GPC bug in rfc1867.c is not critical one, and I agree with you it is not preferable in the final RC process. I will revert my GPC related patch in a couple of hours. But, I shoudn't revert an another license related patch as shown bel

Re: [PHP-CVS] cvs: php-src /ext/mbstring mbstring.c mbstring.h/main rfc1867.c

2003-10-25 Thread Moriyoshi Koizumi
Ilia Alshanetsky <[EMAIL PROTECTED]> wrote: > On October 25, 2003 07:14 pm, Rasmus Lerdorf wrote: > > Ah, thought it was the other patch. However, I wouldn't call the above a > > new feature. That one is a bug fix as it was an oversight to not also > > convert form fields in multipart posts. >

Re: [PHP-CVS] cvs: php-src /ext/mbstring mbstring.c mbstring.h /main rfc1867.c

2003-10-25 Thread Ilia Alshanetsky
On October 25, 2003 07:14 pm, Rasmus Lerdorf wrote: > Ah, thought it was the other patch. However, I wouldn't call the above a > new feature. That one is a bug fix as it was an oversight to not also > convert form fields in multipart posts. Well, it is a mix of a feature & a bug fix. The bug if

Re: [PHP-CVS] cvs: php-src /ext/mbstring mbstring.c mbstring.h /main rfc1867.c

2003-10-25 Thread Rui Hirokawa
I think it is a kind of bug fix because, 1. name field of multipart/form was not converted into internal encoding. This behavior is different from the usual GPC conversion performed by mbstr_treat_data() and it might makes confusion for the users. 2. auto-detection might be fail because auto-de

Re: [PHP-CVS] cvs: php-src /ext/mbstring mbstring.c mbstring.h /main rfc1867.c

2003-10-25 Thread Rasmus Lerdorf
On Sat, 25 Oct 2003, Ilia Alshanetsky wrote: > On October 25, 2003 06:22 pm, Rasmus Lerdorf wrote: > > And continue breaking licenses knowingly? > > That patch does not fix licensing issues, it merely adds a feature, the > license fix is not there... > > Patch log: > name/value in multipart/fo

Re: [PHP-CVS] cvs: php-src /ext/mbstring mbstring.c mbstring.h /main rfc1867.c

2003-10-25 Thread Ilia Alshanetsky
On October 25, 2003 06:22 pm, Rasmus Lerdorf wrote: > And continue breaking licenses knowingly? That patch does not fix licensing issues, it merely adds a feature, the license fix is not there... Patch log: name/value in multipart/form-date will be converted into internal encoding when mbstrin

Re: [PHP-CVS] cvs: php-src /ext/mbstring mbstring.c mbstring.h /main rfc1867.c

2003-10-25 Thread Rasmus Lerdorf
And continue breaking licenses knowingly? On Sat, 25 Oct 2003, Ilia Alshanetsky wrote: > My appologies for the delayed response (I see that the patch was commited). > After reviewing the patch I would very much prefer if you would revert it and > wait till PHP 4.3.5 (ot whatever the next releas

Re: [PHP-CVS] cvs: php-src /ext/mbstring mbstring.c mbstring.h /main rfc1867.c

2003-10-25 Thread Ilia Alshanetsky
My appologies for the delayed response (I see that the patch was commited). After reviewing the patch I would very much prefer if you would revert it and wait till PHP 4.3.5 (ot whatever the next release will be) with it. Ilia On October 24, 2003 11:08 pm, Rui Hirokawa wrote: > Yes, I have plan

Re: [PHP-CVS] cvs: php-src /ext/mbstring mbstring.c mbstring.h /main rfc1867.c

2003-10-24 Thread Rui Hirokawa
Yes, I have plan to commit to 4.3 branch. Ilia, is it possible to commit ? Rui On Thu, 23 Oct 2003 10:43:16 +0900 (JST) Rasmus Lerdorf <[EMAIL PROTECTED]> wrote: > Are you committing this to 4.3 as well? > > On Wed, 22 Oct 2003, Rui Hirokawa wrote: > > > hirokawaWed Oct 22 10:14:0

Re: [PHP-CVS] cvs: php-src /ext/mbstring mbstring.c mbstring.h /main rfc1867.c

2003-10-22 Thread Rasmus Lerdorf
Are you committing this to 4.3 as well? On Wed, 22 Oct 2003, Rui Hirokawa wrote: > hirokawa Wed Oct 22 10:14:06 2003 EDT > > Modified files: > /php-src/main rfc1867.c > /php-src/ext/mbstring mbstring.c mbstring.h > Log: > name/value in multipart

[PHP-CVS] cvs: php-src /ext/mbstring mbstring.c mbstring.h /main rfc1867.c

2003-10-22 Thread Rui Hirokawa
hirokawaWed Oct 22 10:14:06 2003 EDT Modified files: /php-src/main rfc1867.c /php-src/ext/mbstring mbstring.c mbstring.h Log: name/value in multipart/form-date will be converted into internal encoding when mbstring.encoding_translation is