Re: [PHP-CVS] cvs: php4 / CODING_STANDARDS

2003-04-05 Thread Jani Taskinen
On Sat, 5 Apr 2003, Marcus Börger wrote: >At 19:01 04.04.2003, Sterling Hughes wrote: >>sterlingFri Apr 4 12:01:10 2003 EDT >> >> Modified files: >> /php4 CODING_STANDARDS >> Log: >> both these entries are bad, and were never agreed upon. >> assert() usage is a c

Re: [PHP-CVS] cvs: php4 / CODING_STANDARDS

2003-04-05 Thread Marcus Börger
At 19:01 04.04.2003, Sterling Hughes wrote: sterlingFri Apr 4 12:01:10 2003 EDT Modified files: /php4 CODING_STANDARDS Log: both these entries are bad, and were never agreed upon. assert() usage is a controversial concept at best. docref() is something quite a

[PHP-CVS] cvs: php4 / CODING_STANDARDS

2003-04-04 Thread Sterling Hughes
sterlingFri Apr 4 12:01:10 2003 EDT Modified files: /php4 CODING_STANDARDS Log: both these entries are bad, and were never agreed upon. assert() usage is a controversial concept at best. docref() is something quite a few of us strong disagree w

[PHP-CVS] cvs: php4 / CODING_STANDARDS

2002-10-29 Thread Marcus Börger
helly Tue Oct 29 15:25:09 2002 EDT Modified files: /php4 CODING_STANDARDS Log: rewrite paragraph 9 No instances yet. And it does not work with #if 0_FOO but with #if FOO_0 Index: php4/CODING_STANDARDS diff -u php4/CODING_STANDARDS:1.23 php4/CODING_S

[PHP-CVS] cvs: php4 / CODING_STANDARDS

2002-10-10 Thread Jon Parise
jon Thu Oct 10 13:03:49 2002 EDT Modified files: /php4 CODING_STANDARDS Log: Adding a new item (number 11) that explains why it's important to use emalloc() and friends in place of the standard C library functions. Index: php4/CODING_STANDARDS di

Re: [PHP-CVS] cvs: php4 / CODING_STANDARDS

2002-09-09 Thread Sterling Hughes
Quoting [EMAIL PROTECTED]: > On Mon, 9 Sep 2002, Sterling Hughes wrote: > > > I'd rather see people use what they like -- so long as they stay > consistent > > to the coding of the style that they are currently editing. By > specializing > > to the PHP macro's you limit an extensions usage to

Re: [PHP-CVS] cvs: php4 / CODING_STANDARDS

2002-09-09 Thread derick
On Mon, 9 Sep 2002, Sterling Hughes wrote: > I'd rather see people use what they like -- so long as they stay consistent > to the coding of the style that they are currently editing. By specializing > to the PHP macro's you limit an extensions usage to only PHP in many ways. > > Sure, there is

Re: [PHP-CVS] cvs: php4 / CODING_STANDARDS

2002-09-09 Thread Sterling Hughes
Quoting "Thies C. Arntzen" <[EMAIL PROTECTED]>: > On Mon, Sep 09, 2002 at 12:49:04AM +0200, [EMAIL PROTECTED] wrote: > > On Sun, 8 Sep 2002, Yasuo Ohgaki wrote: > > > > > yohgaki Sun Sep 8 18:38:57 2002 EDT > > > > > > Modified files: > > > /php4 CODING_STANDARDS

[PHP-CVS] cvs: php4 / CODING_STANDARDS

2002-09-09 Thread Derick Rethans
derick Mon Sep 9 03:54:12 2002 EDT Modified files: /php4 CODING_STANDARDS Log: - spaces instead of tabs Index: php4/CODING_STANDARDS diff -u php4/CODING_STANDARDS:1.21 php4/CODING_STANDARDS:1.22 --- php4/CODING_STANDARDS:1.21 Mon Sep 9 03:52:39 200

[PHP-CVS] cvs: php4 / CODING_STANDARDS

2002-09-09 Thread Derick Rethans
derick Mon Sep 9 03:52:40 2002 EDT Modified files: /php4 CODING_STANDARDS Log: - Use PHP_ instead of ZEND_ Index: php4/CODING_STANDARDS diff -u php4/CODING_STANDARDS:1.20 php4/CODING_STANDARDS:1.21 --- php4/CODING_STANDARDS:1.20 Sun Sep 8 19:00:31

Re: [PHP-CVS] cvs: php4 / CODING_STANDARDS

2002-09-09 Thread derick
On Mon, 9 Sep 2002, Yasuo Ohgaki wrote: > PHP_* macros are mostly used, but ZEND_* macros are preffered, IMHO. IMO it is not. > I asked about PHP_* & ZEND_* macro issue long time ago when Zend > became BSD style license. As a result of discussion, I added following > entry. I can not remember

Re: [PHP-CVS] cvs: php4 / CODING_STANDARDS

2002-09-08 Thread Thies C. Arntzen
On Mon, Sep 09, 2002 at 12:49:04AM +0200, [EMAIL PROTECTED] wrote: > On Sun, 8 Sep 2002, Yasuo Ohgaki wrote: > > > yohgaki Sun Sep 8 18:38:57 2002 EDT > > > > Modified files: > > /php4 CODING_STANDARDS > > Log: > > It seems we're better to mention about mi

Re: [PHP-CVS] cvs: php4 / CODING_STANDARDS

2002-09-08 Thread Yasuo Ohgaki
[EMAIL PROTECTED] wrote: > On Sun, 8 Sep 2002, Yasuo Ohgaki wrote: > > >>yohgaki Sun Sep 8 18:38:57 2002 EDT >> >> Modified files: >>/php4 CODING_STANDARDS >> Log: >> It seems we're better to mention about missing functions. >> PHP_FUNCTION -> ZEND_FUNCT

Re: [PHP-CVS] cvs: php4 / CODING_STANDARDS

2002-09-08 Thread Yasuo Ohgaki
Jon Parise wrote: > On Sun, Sep 08, 2002 at 11:56:39PM +0100, James Cox wrote: > > >>yasuo, i really don't mean to sound nasty, or anything like this... but if >>you want to check in text like this, please send it via php-dev for >>review... this just doesn't make any sense. >> >>What you wanted

RE: [PHP-CVS] cvs: php4 / CODING_STANDARDS

2002-09-08 Thread James Cox
> I just committed a reworded version. I'm sorry I didn't catch your > response first, though, or I would have opened it up to further > critique. > Jon, i wouldn't worry about it too much... (yours made more sense than mine :)) but it was just something that had niggled me over the last few m

Re: [PHP-CVS] cvs: php4 / CODING_STANDARDS

2002-09-08 Thread Jon Parise
On Sun, Sep 08, 2002 at 11:56:39PM +0100, James Cox wrote: > yasuo, i really don't mean to sound nasty, or anything like this... but if > you want to check in text like this, please send it via php-dev for > review... this just doesn't make any sense. > > What you wanted to say is: > > [10] Do

[PHP-CVS] cvs: php4 / CODING_STANDARDS

2002-09-08 Thread Jon Parise
jon Sun Sep 8 19:00:34 2002 EDT Modified files: /php4 CODING_STANDARDS Log: Reword item 10 for greater clarity. Index: php4/CODING_STANDARDS diff -u php4/CODING_STANDARDS:1.19 php4/CODING_STANDARDS:1.20 --- php4/CODING_STANDARDS:1.19 Sun Sep 8 1

RE: [PHP-CVS] cvs: php4 / CODING_STANDARDS

2002-09-08 Thread James Cox
> +[10] Do no define that is not available. For instance, if > library available is > + missing function(s), do not define function nor raise error > for missing > + function(s). > + yasuo, i really don't mean to sound nasty, or anything like this... but if you want to check in text lik

Re: [PHP-CVS] cvs: php4 / CODING_STANDARDS

2002-09-08 Thread Edin Kadribasic
On Sun, 08 Sep 2002 22:38:57 - "Yasuo Ohgaki" <[EMAIL PROTECTED]> wrote: > yohgaki Sun Sep 8 18:38:57 2002 EDT > > Modified files: > /php4 CODING_STANDARDS > Log: > It seems we're better to mention about missing functions. > PHP_FUNCTION -> ZEND_F

Re: [PHP-CVS] cvs: php4 / CODING_STANDARDS

2002-09-08 Thread derick
On Sun, 8 Sep 2002, Yasuo Ohgaki wrote: > yohgaki Sun Sep 8 18:38:57 2002 EDT > > Modified files: > /php4 CODING_STANDARDS > Log: > It seems we're better to mention about missing functions. > PHP_FUNCTION -> ZEND_FUNCTION erm, where was this decided

[PHP-CVS] cvs: php4 / CODING_STANDARDS

2002-09-08 Thread Yasuo Ohgaki
yohgaki Sun Sep 8 18:38:57 2002 EDT Modified files: /php4 CODING_STANDARDS Log: It seems we're better to mention about missing functions. PHP_FUNCTION -> ZEND_FUNCTION Index: php4/CODING_STANDARDS diff -u php4/CODING_STANDARDS:1.18 php4/CODING_STAND