Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_4/ NEWS ext/zlib/tests/bug61139.phpt ext/zlib/zlib_fopen_wrapper.c

2012-05-01 Thread Hannes Magnusson
Why is this test creating the file in the root directory? And should it be created at all since the function fails? -Hannes On Fri, Mar 2, 2012 at 15:16, Nikita Popov wrote: > nikic                                    Fri, 02 Mar 2012 14:16:47 + > > Revision: http://svn.php.net/viewvc?view=re

Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_4/ NEWS

2012-03-02 Thread Laruence
Hi Nikic: just FYI, I was told that, the entries in NEWS should be in desc order(in a category) by bug id :) thanks On Fri, Mar 2, 2012 at 4:25 PM, Nikita Popov wrote: > nikic                                    Fri, 02 Mar 2012 08:25:28 + > > Revision: http://svn.php.net/viewvc?view=revi

Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_4/ NEWS ext/standard/string.c

2012-03-01 Thread Pierrick Charron
Test for bug #55871 is already covering this issue. P. On 1 March 2012 11:35, Antony Dovgal wrote: > On 03/01/2012 07:10 PM, Pierrick Charron wrote: >> >> pierrick                                 Thu, 01 Mar 2012 15:10:29 + >> >> Revision: http://svn.php.net/viewvc?view=revision&revision=323

Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_4/ NEWS ext/standard/string.c

2012-03-01 Thread Antony Dovgal
On 03/01/2012 07:10 PM, Pierrick Charron wrote: pierrick Thu, 01 Mar 2012 15:10:29 + Revision: http://svn.php.net/viewvc?view=revision&revision=323710 Log: Fixed memory leak in substr_replace +test ? -- Wbr, Antony Dovgal --- http://pinba.org - realtime pr

Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_4/ NEWS

2012-02-28 Thread Christopher Jones
Stas, Some of those bug fixes listed under 5.4.0 are already fixed in 5.3.10. Random examples include the OCI8 fixes, OpenSSL fix 60279, Tidy fix 54682, and CURL fix 60439. Do you need a hand sorting out the dups? Chris On 02/28/2012 04:50 PM, Stanislav Malyshev wrote: stas

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/Zend/Zend.m4 branches/PHP_5_4/Zend/zend.h branches/PHP_5_4/main/main.c trunk/Zend/Zend.m4 trunk/Zend/zend.h trunk/main/main.c

2012-02-15 Thread Stas Malyshev
Hi! Did you run the tests? Just from a quick skim I think this would break both the pcntl and the posix extension. Yes, I did - no (new) fails both on Mac and Linux. If you see any please tell me. -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext.

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/Zend/Zend.m4 branches/PHP_5_4/Zend/zend.h branches/PHP_5_4/main/main.c trunk/Zend/Zend.m4 trunk/Zend/zend.h trunk/main/main.c

2012-02-15 Thread Rasmus Lerdorf
On 02/15/2012 08:52 PM, Rasmus Lerdorf wrote: > On 02/15/2012 05:51 PM, Stanislav Malyshev wrote: >> stas Thu, 16 Feb 2012 01:51:45 + >> >> Revision: http://svn.php.net/viewvc?view=revision&revision=323245 >> >> Log: >> make ZEND_SIGNALS configurable, off by

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/Zend/Zend.m4 branches/PHP_5_4/Zend/zend.h branches/PHP_5_4/main/main.c trunk/Zend/Zend.m4 trunk/Zend/zend.h trunk/main/main.c

2012-02-15 Thread Rasmus Lerdorf
On 02/15/2012 05:51 PM, Stanislav Malyshev wrote: > stas Thu, 16 Feb 2012 01:51:45 + > > Revision: http://svn.php.net/viewvc?view=revision&revision=323245 > > Log: > make ZEND_SIGNALS configurable, off by default > also make ZEND_SIGNALS enabled and disable

Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_4/ NEWS ext/standard/html.c ext/standard/tests/strings/bug60965.phpt

2012-02-05 Thread Nuno Lopes
On Sun, 05 Feb 2012 15:00:11 +0100, Gustavo Lopes wrote: On Sun, 5 Feb 2012 14:37:27 +0100, Pierre Joye wrote: 2012/2/5 Gustavo Lopes : All the length and position variables are of type size_t, so I'd say we'd be out of memory long before that could be a problem (unless there's some architectu

Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_4/ NEWS ext/standard/html.c ext/standard/tests/strings/bug60965.phpt

2012-02-05 Thread Gustavo Lopes
On Sun, 05 Feb 2012 15:00:11 +0100, Gustavo Lopes wrote: On Sun, 5 Feb 2012 14:37:27 +0100, Pierre Joye wrote: 2012/2/5 Gustavo Lopes : All the length and position variables are of type size_t, so I'd say we'd be out of memory long before that could be a problem (unless there's some architect

Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_4/ NEWS ext/standard/html.c ext/standard/tests/strings/bug60965.phpt

2012-02-05 Thread Gustavo Lopes
On Sun, 5 Feb 2012 14:37:27 +0100, Pierre Joye wrote: 2012/2/5 Gustavo Lopes : All the length and position variables are of type size_t, so I'd say we'd be out of memory long before that could be a problem (unless there's some architecture of which I'm not aware where SIZE_T is low enough fo

Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_4/ NEWS ext/standard/html.c ext/standard/tests/strings/bug60965.phpt

2012-02-05 Thread Pierre Joye
2012/2/5 Gustavo Lopes : >> All the length and position variables are of type size_t, so I'd say >> we'd be out of memory long before that could be a problem (unless >> there's some architecture of which I'm not aware where SIZE_T is low >> enough for this to be a problem). > > > read: SIZE_MAX, n

Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_4/ NEWS ext/standard/html.c ext/standard/tests/strings/bug60965.phpt

2012-02-05 Thread Gustavo Lopes
On Sun, 05 Feb 2012 14:00:11 +0100, Gustavo Lopes wrote: On Sun, 5 Feb 2012 10:55:39 -, Nuno Lopes wrote: I didn't carefully review this patch, but doesn't this code suffer from potential math overflow? i.e. with strlen($input_str) > INT_MAX/2 (or UINT_MAX/2) All the length and position

Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_4/ NEWS ext/standard/html.c ext/standard/tests/strings/bug60965.phpt

2012-02-05 Thread Gustavo Lopes
On Sun, 5 Feb 2012 10:55:39 -, Nuno Lopes wrote: I didn't carefully review this patch, but doesn't this code suffer from potential math overflow? i.e. with strlen($input_str) > INT_MAX/2 (or UINT_MAX/2) All the length and position variables are of type size_t, so I'd say we'd be out of m

Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_4/ NEWS ext/standard/html.c ext/standard/tests/strings/bug60965.phpt

2012-02-05 Thread Nuno Lopes
I didn't carefully review this patch, but doesn't this code suffer from potential math overflow? i.e. with strlen($input_str) > INT_MAX/2 (or UINT_MAX/2) Nuno - Original Message - From: "Gustavo André dos Santos Lopes" To: Sent: Sunday, February 05, 2012 9:59 AM Subject: [PHP-CVS]

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/acinclude.m4 trunk/acinclude.m4

2011-12-27 Thread Nuno Lopes
On Tue, Dec 27, 2011 at 18:02, Nuno Lopes wrote: Uhm, I don't think this change makes much sense (nor does the previous behaviour on Mac).. Extensions that use C++ should pull in the required libraries themselves. We shouldn't be linking PHP everytime with libstdc++ if that is not needed. Th

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/acinclude.m4 trunk/acinclude.m4

2011-12-27 Thread Hannes Magnusson
On Tue, Dec 27, 2011 at 18:02, Nuno Lopes wrote: > Uhm, I don't think this change makes much sense (nor does the previous > behaviour on Mac).. > Extensions that use C++ should pull in the required libraries themselves. We > shouldn't be linking PHP everytime with libstdc++ if that is not needed.

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/acinclude.m4 trunk/acinclude.m4

2011-12-27 Thread Nuno Lopes
Uhm, I don't think this change makes much sense (nor does the previous behaviour on Mac).. Extensions that use C++ should pull in the required libraries themselves. We shouldn't be linking PHP everytime with libstdc++ if that is not needed. Nuno - Original Message - bjori

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/Zend/zend_compile.c branches/PHP_5_4/Zend/zend_object_handlers.c trunk/Zend/zend_compile.c trunk/Zend/zend_object_handlers.c

2011-12-19 Thread Xinchen Hui
s/class/object/ Sent from my iPhone 在 2011-12-20,9:29,Xinchen Hui 写道: > Hi: > For public and protected properties, you will have only one copy > in the child class, so there is no such conflict. > > Thanks > > Sent from my iPhone > > 在 2011-12-20,1:12,Stefan Marr 写道: > >> Hi: >> >> Thanks

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/Zend/zend_compile.c branches/PHP_5_4/Zend/zend_object_handlers.c trunk/Zend/zend_compile.c trunk/Zend/zend_object_handlers.c

2011-12-19 Thread Xinchen Hui
Hi: For public and protected properties, you will have only one copy in the child class, so there is no such conflict. Thanks Sent from my iPhone 在 2011-12-20,1:12,Stefan Marr 写道: > Hi: > > Thanks guys! > > I have only briefly rechecked the code, and dont remember at the moment how > the

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/Zend/zend_compile.c branches/PHP_5_4/Zend/zend_object_handlers.c trunk/Zend/zend_compile.c trunk/Zend/zend_object_handlers.c

2011-12-19 Thread Stefan Marr
Hi: Thanks guys! I have only briefly rechecked the code, and dont remember at the moment how the default property table works, but for me it feels like these offsets are also incorrect for public or protected stuff that gets newly added to the class? Best regards Stefan On 19 Dec 2011, at 17:

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/main/main.c branches/PHP_5_4/main/php_globals.h branches/PHP_5_4/main/php_variables.c trunk/main/main.c trunk/main/php_globals.h

2011-12-14 Thread Christopher Jones
Dmitry, Please update php.ini-*. Thanks, Chris On 12/14/2011 12:56 AM, Dmitry Stogov wrote: dmitry Wed, 14 Dec 2011 08:56:35 + Revision: http://svn.php.net/viewvc?view=revision&revision=321003 Log: Added max_input_vars directive to prevent attacks base

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/main/main.c branches/PHP_5_4/main/php_globals.h branches/PHP_5_4/main/php_variables.c trunk/main/main.c trunk/main/php_globals.h

2011-12-14 Thread Pierre Joye
hi Dmitry, Please add a note to the UPGRADING guide as well. Thanks, On Wed, Dec 14, 2011 at 9:56 AM, Dmitry Stogov wrote: > dmitry                                   Wed, 14 Dec 2011 08:56:35 + > > Revision: http://svn.php.net/viewvc?view=revision&revision=321003 > > Log: > Added max_input_

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/sapi/cli/php_cli_server.c branches/PHP_5_4/sapi/cli/tests/php_cli_server_014.phpt trunk/sapi/cli/php_cli_server.c trunk/sapi/cli

2011-12-08 Thread Laruence
Hi: this fix should be a suboptimal fix, the problem is for static file, builtin server bypass the sapi_activate (in the send_error_page), call sapi_activate_header_only instead. then when it call the sapi_deactivate, crashed. I have tried to make a optimize fix , but failed. I w

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/main/main.c branches/PHP_5_4/main/php_globals.h branches/PHP_5_4/main/php_ini.c branches/PHP_5_4/tests/basic/bug54514.phpt trunk

2011-12-07 Thread Pierre Joye
seems to be due to partially generated global table, clean build and I cannot reproduce the crash anymore. Sorry for the noise :) On Wed, Dec 7, 2011 at 12:20 PM, Pierre Joye wrote: > this patch is not correct, php crashes on startup when a request is > initialized. -- Pierre @pierrejoye | h

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/main/main.c branches/PHP_5_4/main/php_globals.h branches/PHP_5_4/main/php_ini.c branches/PHP_5_4/tests/basic/bug54514.phpt trunk

2011-12-07 Thread Pierre Joye
this patch is not correct, php crashes on startup when a request is initialized. ==7872==at 0x816204B: php_auto_globals_create_request (php_variables.c:804) ==7872==by 0x818E564: zend_auto_global_init (zend_compile.c:6694) ==7872==by 0x81BB0CE: zend_hash_apply (zend_hash.c:716) ==7872=

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/ext/mbstring/libmbfl/filters/mbfilter_cp936.c branches/PHP_5_4/ext/mbstring/tests/bug60306.phpt trunk/ext/mbstring/libmbfl/filte

2011-11-18 Thread Laruence
Hi Moriyoshi: plz sync this fix into libmbfl :) thanks On Fri, Nov 18, 2011 at 4:50 PM, Xinchen Hui wrote: > laruence                                 Fri, 18 Nov 2011 08:50:29 + > > Revision: http://svn.php.net/viewvc?view=revision&revision=319452 > > Log: > Fixed bug #60306 (Character

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/Zend/zend_builtin_functions.c branches/PHP_5_4/ext/com_dotnet/com_typeinfo.c branches/PHP_5_4/ext/oci8/oci8.c branches/PHP_5_4/e

2011-11-18 Thread Kalle Sommer Nielsen
Hi Stas 2011/11/18 Stanislav Malyshev : > Modified: php/php-src/branches/PHP_5_4/Zend/zend_builtin_functions.c > === > --- php/php-src/branches/PHP_5_4/Zend/zend_builtin_functions.c  2011-11-18 > 07:07:42 UTC (rev 319441) > +++ php/p

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/main/output.c branches/PHP_5_4/tests/output/bug60282.phpt trunk/main/output.c trunk/tests/output/bug60282.phpt

2011-11-13 Thread Ferenc Kovacs
Hi Laruence, ob_gzhandler is only available if php is built --with-zlib This means that your test can fail with "Warning: ob_start(): function 'ob_gzhandler' not found or invalid function name" on depending on the configure options. Could you please add a SKIPIF and skip the test if ob_gzhandler i

Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_4/ NEWS ext/standard/basic_functions.c ext/standard/exec.c ext/standard/exec.h ext/standard/tests/general_functions/bug60116.phpt

2011-11-11 Thread Ferenc Kovacs
On Fri, Nov 11, 2011 at 3:52 PM, Rui Hirokawa wrote: > hirokawa Fri, 11 Nov 2011 14:52:56 + > > Revision: http://svn.php.net/viewvc?view=revision&revision=319057 > > Log: > revert changes to fix bug #60116. > > Bug: https://bugs.php.net/60116 (Assigned) escapes

Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_4/ NEWS ext/standard/exec.c ext/standard/tests/general_functions/bug60116.phpt

2011-11-10 Thread Hannes Magnusson
On Thu, Nov 10, 2011 at 15:19, Rui Hirokawa wrote: > hirokawa                                 Thu, 10 Nov 2011 14:19:06 + > > Revision: http://svn.php.net/viewvc?view=revision&revision=318996 > > Log: > MFH: fixed bug #60116 (escapeshellcmd() cannot escape the characters which > cause shell c

Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_4/ NEWS ext/standard/exec.c ext/standard/tests/general_functions/bug60116.phpt

2011-11-10 Thread Ferenc Kovacs
On Thu, Nov 10, 2011 at 3:19 PM, Rui Hirokawa wrote: > hirokawa Thu, 10 Nov 2011 14:19:06 + > > Revision: http://svn.php.net/viewvc?view=revision&revision=318996 > > Log: > MFH: fixed bug #60116 (escapeshellcmd() cannot escape the characters which > cause shell

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/sapi/cli/php_cli_server.c trunk/sapi/cli/php_cli_server.c

2011-10-22 Thread Laruence
Hi: miss update info: Fixed bug #60115 (memory memory definitely lost in cli server) 2011/10/23 Xinchen Hui : > laruence                                 Sun, 23 Oct 2011 03:02:24 + > > Revision: http://svn.php.net/viewvc?view=revision&revision=318333 > > Log: > fix memory leak > > Changed pa

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/sapi/cli/php_cli_server.c branches/PHP_5_4/sapi/cli/tests/php_cli_server_004.phpt trunk/sapi/cli/php_cli_server.c trunk/sapi/cli

2011-09-21 Thread Alexey Shein
Hello, laruence, could you also take a look here: http://tools.ietf.org/html/draft-robinson-www-interface-00 (see chapter 5. Environment variables) and add them too? Thank you. 2011/9/21 Xinchen Hui : > laruence                                 Wed, 21 Sep 2011 03:09:42 + > > Revision: http://

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/ext/session/config.m4 branches/PHP_5_4/ext/session/config.w32 branches/PHP_5_4/ext/session/mod_user.c branches/PHP_5_4/ext/sessi

2011-09-13 Thread Laruence
Hi: after I re-run buildconf, error has gone sorry for mis-report. thanks 2011/9/14 Laruence : > Hi: >    trunk build broken: >    ext/session/session.o(.rodata+0x24a8): undefined reference to > `zim_SessionHandler_open' > ext/session/session.o(.rodata+0x24c8): undefined reference to > `zim_

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/ext/session/config.m4 branches/PHP_5_4/ext/session/config.w32 branches/PHP_5_4/ext/session/mod_user.c branches/PHP_5_4/ext/sessi

2011-09-13 Thread Laruence
Hi: trunk build broken: ext/session/session.o(.rodata+0x24a8): undefined reference to `zim_SessionHandler_open' ext/session/session.o(.rodata+0x24c8): undefined reference to `zim_SessionHandler_close' ext/session/session.o(.rodata+0x24e8): undefined reference to `zim_SessionHandler_read' ex

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/ext/session/config.m4 branches/PHP_5_4/ext/session/config.w32 branches/PHP_5_4/ext/session/mod_user.c branches/PHP_5_4/ext/sessi

2011-09-13 Thread Christopher Jones
On 09/13/2011 06:21 PM, Arpad Ray wrote: On Wed, Sep 14, 2011 at 1:12 AM, Kalle Sommer Nielsen wrote: Hi Arpad 2011/9/14 Arpad Ray: arpadTue, 13 Sep 2011 22:28:15 + Revision: http://svn.php.net/viewvc?view=revision&revision=316688 Log: Implement ob

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/ext/session/config.m4 branches/PHP_5_4/ext/session/config.w32 branches/PHP_5_4/ext/session/mod_user.c branches/PHP_5_4/ext/sessi

2011-09-13 Thread Arpad Ray
On Wed, Sep 14, 2011 at 1:12 AM, Kalle Sommer Nielsen wrote: > Hi Arpad > > 2011/9/14 Arpad Ray : >> arpad                                    Tue, 13 Sep 2011 22:28:15 + >> >> Revision: http://svn.php.net/viewvc?view=revision&revision=316688 >> >> Log: >> Implement object-oriented session hand

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/ext/session/config.m4 branches/PHP_5_4/ext/session/config.w32 branches/PHP_5_4/ext/session/mod_user.c branches/PHP_5_4/ext/sessi

2011-09-13 Thread Kalle Sommer Nielsen
Hi Arpad 2011/9/14 Arpad Ray : > arpad                                    Tue, 13 Sep 2011 22:28:15 + > > Revision: http://svn.php.net/viewvc?view=revision&revision=316688 > > Log: > Implement object-oriented session handlers > (https://wiki.php.net/rfc/session-oo) Just by skimming over the

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/Zend/tests/closure_036.phpt branches/PHP_5_4/Zend/tests/closure_038.phpt branches/PHP_5_4/Zend/tests/closure_039.phpt branches/P

2011-09-07 Thread Hannes Magnusson
On Wed, Sep 7, 2011 at 16:00, Gustavo A. S. Lopes wrote: > On Wed, 07 Sep 2011 10:38:54 +0100, Hannes Magnusson > wrote: > >> On Wed, Sep 7, 2011 at 08:46, Stanislav Malyshev wrote: >>> >>> stas                                     Wed, 07 Sep 2011 06:46:27 + >>> >>> Revision: http://svn.php.

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/Zend/tests/closure_036.phpt branches/PHP_5_4/Zend/tests/closure_038.phpt branches/PHP_5_4/Zend/tests/closure_039.phpt branches/P

2011-09-07 Thread Gustavo A. S. Lopes
On Wed, 07 Sep 2011 10:38:54 +0100, Hannes Magnusson wrote: On Wed, Sep 7, 2011 at 08:46, Stanislav Malyshev wrote: stas Wed, 07 Sep 2011 06:46:27 + Revision: http://svn.php.net/viewvc?view=revision&revision=316300 [...] @@ -20,7 +20,7 @@ $ca = $a

Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_4/ NEWS

2011-09-07 Thread Ferenc Kovacs
>  - Removed features: > -  . Removed magic_quotes_gpc, magic_quotes_runtime and magic_quotes_sybase > ini options. > -    get_magic_quotes_gpc, get_magic_quotes_runtime are kept but always return > -    false, set_magic_quotes_runtime raises an E_CORE_ERROR. (Pierrick, > Pierre) > +  . Removed m

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/Zend/tests/closure_036.phpt branches/PHP_5_4/Zend/tests/closure_038.phpt branches/PHP_5_4/Zend/tests/closure_039.phpt branches/P

2011-09-07 Thread Hannes Magnusson
On Wed, Sep 7, 2011 at 08:46, Stanislav Malyshev wrote: > stas                                     Wed, 07 Sep 2011 06:46:27 + > > Revision: http://svn.php.net/viewvc?view=revision&revision=316300 > > Log: > Commit Gustavo's closure rebinding patch as desided by vote > > Changed paths: >    U

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/ext/standard/string.c branches/PHP_5_4/ext/standard/tests/strings/substr_replace_array.phpt trunk/ext/standard/string.c trunk/ex

2011-08-29 Thread Hannes Magnusson
On Mon, Aug 29, 2011 at 22:38, Arpad Ray wrote: > arpad                                    Mon, 29 Aug 2011 20:38:52 + > > Revision: http://svn.php.net/viewvc?view=revision&revision=315740 > > Log: > Fixed bug #55366: keys lost when using substr_replace an array > > Bug: https://bugs.php.net/5

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/sapi/cli/php_cli_server.c trunk/NEWS trunk/sapi/cli/php_cli_server.c

2011-08-22 Thread Laruence
Hi: Added SERVER[SERVER_SOFTWARE], http://svn.php.net/viewvc?view=revision&revision=315300 but server_addr is a litte diffcult since there is no a ready value for that, needs a litte more works, I think we'd better not do that much changes for this, at least need the author to review, :) thank

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/sapi/cli/php_cli_server.c trunk/NEWS trunk/sapi/cli/php_cli_server.c

2011-08-22 Thread Pierre Joye
open a new FR please. Easier than following php-cvs for new FR. On Mon, Aug 22, 2011 at 2:17 PM, Kalle Sommer Nielsen wrote: > Hi > > 2011/8/22 Xinchen Hui : >> laruence                                 Mon, 22 Aug 2011 11:55:41 + >> >> Revision: http://svn.php.net/viewvc?view=revision&revisio

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/sapi/cli/php_cli_server.c trunk/NEWS trunk/sapi/cli/php_cli_server.c

2011-08-22 Thread Kalle Sommer Nielsen
Hi 2011/8/22 Xinchen Hui : > laruence                                 Mon, 22 Aug 2011 11:55:41 + > > Revision: http://svn.php.net/viewvc?view=revision&revision=315278 > > Log: > Fixed #55463 (cli-server missing _SERVER[REMOTE_ADDR]) We might as well add SERVER_ADDR (+ SERVER_SOFTWARE) if not

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/Zend/zend_builtin_functions.c branches/PHP_5_4/Zend/zend_errors.h branches/PHP_5_4/php.ini-development branches/PHP_5_4/php.ini-

2011-07-31 Thread Felipe Pena
2011/7/31 Stefan Marr : > Hi: > > On Sun, Jul 24, 2011 at 12:07 AM, Stanislav Malyshev wrote: >> stas                                     Sat, 23 Jul 2011 22:07:22 + >> >> Revision: http://svn.php.net/viewvc?view=revision&revision=313645 >> >> Log: >> Change E_ALL to include E_STRICT > > Could

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/Zend/zend_builtin_functions.c branches/PHP_5_4/Zend/zend_errors.h branches/PHP_5_4/php.ini-development branches/PHP_5_4/php.ini-

2011-07-31 Thread Stefan Marr
Hi: On Sun, Jul 24, 2011 at 12:07 AM, Stanislav Malyshev wrote: > stas                                     Sat, 23 Jul 2011 22:07:22 + > > Revision: http://svn.php.net/viewvc?view=revision&revision=313645 > > Log: > Change E_ALL to include E_STRICT Could please someone take the time to fix t

Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_4/ NEWS

2011-07-13 Thread Pierre Joye
how so? On Wed, Jul 13, 2011 at 10:12 PM, Stanislav Malyshev wrote: > stas                                     Wed, 13 Jul 2011 20:12:14 + > > Revision: http://svn.php.net/viewvc?view=revision&revision=313214 > > Log: > integrate 5.3 NEWS > > Changed paths: >    U   php/php-src/branches/PHP_5

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/ext/standard/basic_functions.c branches/PHP_5_4/ext/standard/head.c trunk/ext/standard/basic_functions.c trunk/ext/standard/head

2011-07-11 Thread Stas Malyshev
Hi! On 7/11/11 8:56 PM, Kalle Sommer Nielsen wrote: kalleTue, 12 Jul 2011 03:56:32 + Revision: http://svn.php.net/viewvc?view=revision&revision=313156 Log: Changed http_response_code() to be able to set a response code Are you sure this patch is right

Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_4/ NEWS configure.in main/php_version.h

2011-07-06 Thread Pierre Joye
On Wed, Jul 6, 2011 at 9:20 PM, Rasmus Lerdorf wrote: > Given the pretty big changes that are likely to occur between alpha > releases, I think it would be a good idea to have separated NEWS > sections. And yes, when we put out the first beta we merge them all. Exactly, every change happening be

Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_4/ NEWS configure.in main/php_version.h

2011-07-06 Thread Stas Malyshev
Hi! On 7/6/11 12:20 PM, Rasmus Lerdorf wrote: Given the pretty big changes that are likely to occur between alpha releases, I think it would be a good idea to have separated NEWS sections. And yes, when we put out the first beta we merge them all. OK, I'll split them. -- Stanislav Malyshev, S

Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_4/ NEWS configure.in main/php_version.h

2011-07-06 Thread Rasmus Lerdorf
On 07/06/2011 12:18 PM, Stas Malyshev wrote: > Hi! > > On 7/6/11 12:12 PM, Hannes Magnusson wrote: >> Hmmmh.. >> So the news for alpha2 will not be separated from alpha1? >> Thats going to make it hard to see the difference for users :] > > Well, alphas aren't really for "users" - i.e., it should

Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_4/ NEWS configure.in main/php_version.h

2011-07-06 Thread Stas Malyshev
Hi! On 7/6/11 12:12 PM, Hannes Magnusson wrote: Hmmmh.. So the news for alpha2 will not be separated from alpha1? Thats going to make it hard to see the difference for users :] Well, alphas aren't really for "users" - i.e., it should not be used in any setting where the difference (as opposed

Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_4/ NEWS configure.in main/php_version.h

2011-07-06 Thread Hannes Magnusson
On Sun, Jun 19, 2011 at 22:15, Stanislav Malyshev wrote: > stas                                     Sun, 19 Jun 2011 20:15:33 + > > Revision: http://svn.php.net/viewvc?view=revision&revision=312302 > > Log: > Back to -dev > > Changed paths: >    U   php/php-src/branches/PHP_5_4/NEWS >    U   p

Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_4/ NEWS TSRM/TSRM.c TSRM/TSRM.h TSRM/tsrm.m4 Zend/Makefile.am Zend/Zend.m4 Zend/zend.c Zend/zend.h Zend/zend_alloc.c Zend/zend_execute_API.c Zend/zend_ha

2011-06-23 Thread Jérôme Loyet
Le 23 juin 2011 02:41, Felipe Pena a écrit : > Try again, please. :) > yeah it works ! thanks you very much for your time ++ jerome -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_4/ NEWS TSRM/TSRM.c TSRM/TSRM.h TSRM/tsrm.m4 Zend/Makefile.am Zend/Zend.m4 Zend/zend.c Zend/zend.h Zend/zend_alloc.c Zend/zend_execute_API.c Zend/zend_ha

2011-06-22 Thread Felipe Pena
Try again, please. :) 2011/6/22 Jérôme Loyet : > Le 23 juin 2011 02:26, Felipe Pena a écrit : >> Hi, >> >> I've committed a fix, can you check if it's ok? > > nope: > > fat@dev:~/dev/php-src/branches/PHP_5_4$ gdb ./sapi/fpm/php-fpm > GNU gdb (Ubuntu/Linaro 7.2-1ubuntu11) 7.2 > Copyright (C) 2010

Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_4/ NEWS TSRM/TSRM.c TSRM/TSRM.h TSRM/tsrm.m4 Zend/Makefile.am Zend/Zend.m4 Zend/zend.c Zend/zend.h Zend/zend_alloc.c Zend/zend_execute_API.c Zend/zend_ha

2011-06-22 Thread Jérôme Loyet
Le 23 juin 2011 02:26, Felipe Pena a écrit : > Hi, > > I've committed a fix, can you check if it's ok? nope: fat@dev:~/dev/php-src/branches/PHP_5_4$ gdb ./sapi/fpm/php-fpm GNU gdb (Ubuntu/Linaro 7.2-1ubuntu11) 7.2 Copyright (C) 2010 Free Software Foundation, Inc. License GPLv3+: GNU GPL version

Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_4/ NEWS TSRM/TSRM.c TSRM/TSRM.h TSRM/tsrm.m4 Zend/Makefile.am Zend/Zend.m4 Zend/zend.c Zend/zend.h Zend/zend_alloc.c Zend/zend_execute_API.c Zend/zend_ha

2011-06-22 Thread Felipe Pena
Hi, I've committed a fix, can you check if it's ok? 2011/6/22 Jérôme Loyet : > Hi > > it breaks FPM in 5.4 branch on my server: > > fat@dev:~/dev/php-src/branches/PHP_5_4$ gdb ./sapi/fpm/php-fpm > GNU gdb (Ubuntu/Linaro 7.2-1ubuntu11) 7.2 > Copyright (C) 2010 Free Software Foundation, Inc. > Lice

Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_4/ NEWS TSRM/TSRM.c TSRM/TSRM.h TSRM/tsrm.m4 Zend/Makefile.am Zend/Zend.m4 Zend/zend.c Zend/zend.h Zend/zend_alloc.c Zend/zend_execute_API.c Zend/zend_ha

2011-06-22 Thread Jérôme Loyet
Hi it breaks FPM in 5.4 branch on my server: fat@dev:~/dev/php-src/branches/PHP_5_4$ gdb ./sapi/fpm/php-fpm GNU gdb (Ubuntu/Linaro 7.2-1ubuntu11) 7.2 Copyright (C) 2010 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later This is free softwa

Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_4/ NEWS Zend/zend_multiply.h Zend/zend_operators.c Zend/zend_operators.h Zend/zend_vm_def.h Zend/zend_vm_execute.h

2011-06-18 Thread Jérôme Loyet
Le 18 juin 2011 20:12, Felipe Pena a écrit : > Hi, > I've added the #ifndef. thanks you -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_4/ NEWS Zend/zend_multiply.h Zend/zend_operators.c Zend/zend_operators.h Zend/zend_vm_def.h Zend/zend_vm_execute.h

2011-06-18 Thread Felipe Pena
Hi, I've added the #ifndef. 2011/6/18 Jérôme Loyet > Hi dmitry, > > in Zend/zend_operators.h you have added the offsetof macro. > > In some case, this macro is already defined and gcc throws a > compilation warning: > > In file included from > /home/fat/dev/php-src/branches/PHP_5_4/Zend/zend.h:8

Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_4/ NEWS Zend/zend_multiply.h Zend/zend_operators.c Zend/zend_operators.h Zend/zend_vm_def.h Zend/zend_vm_execute.h

2011-06-18 Thread Jérôme Loyet
Hi dmitry, in Zend/zend_operators.h you have added the offsetof macro. In some case, this macro is already defined and gcc throws a compilation warning: In file included from /home/fat/dev/php-src/branches/PHP_5_4/Zend/zend.h:818:0, from /home/fat/dev/php-src/branches/PHP_5_4/ma

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/ext/standard/filestat.c branches/PHP_5_4/ext/standard/tests/file/userstreams_007.phpt branches/PHP_5_4/main/php_streams.h branch

2011-05-25 Thread Hannes Magnusson
On Wed, May 25, 2011 at 23:24, Stas Malyshev wrote: > Hi! > >> There seem to be a lot of unrelated code cleanup here, and I am in >> general a bit confused in this code. >> Could you review http://php.net/streamwrapper and write up the changes to >> it? >> > > There shouldn't be any changes except

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/ext/standard/filestat.c branches/PHP_5_4/ext/standard/tests/file/userstreams_007.phpt branches/PHP_5_4/main/php_streams.h branch

2011-05-25 Thread Stas Malyshev
Hi! No time to actually proper design and propose alternatives yet. That does mean we have to accept something "just because it is ready". Sorry No, I think if we have working solution for a real problem, even if it's not perfect - it is the reason to use it and "I can vaguely imagine someth

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/ext/standard/filestat.c branches/PHP_5_4/ext/standard/tests/file/userstreams_007.phpt branches/PHP_5_4/main/php_streams.h branch

2011-05-25 Thread Pierre Joye
On Thu, May 26, 2011 at 12:04 AM, Stas Malyshev wrote: > Hi! > >> Besides that, did we even approve that change? Gustavo and I were two >> that did not like the current implemenation/design. > > There were no objections and/or proposals for improving it since I posted > the patch, which as about 2

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/ext/standard/filestat.c branches/PHP_5_4/ext/standard/tests/file/userstreams_007.phpt branches/PHP_5_4/main/php_streams.h branch

2011-05-25 Thread Stas Malyshev
Hi! Besides that, did we even approve that change? Gustavo and I were two that did not like the current implemenation/design. There were no objections and/or proposals for improving it since I posted the patch, which as about 2 months ago, so I assumed it's ok. If you have any specific ideas

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/ext/standard/filestat.c branches/PHP_5_4/ext/standard/tests/file/userstreams_007.phpt branches/PHP_5_4/main/php_streams.h branch

2011-05-25 Thread Pierre Joye
hi, Besides that, did we even approve that change? Gustavo and I were two that did not like the current implemenation/design. Cheers, On Wed, May 25, 2011 at 11:24 PM, Stas Malyshev wrote: > Hi! > > There seem to be a lot of unrelated code cleanup here, and I am in >> general a bit confused in

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/ext/standard/filestat.c branches/PHP_5_4/ext/standard/tests/file/userstreams_007.phpt branches/PHP_5_4/main/php_streams.h branch

2011-05-25 Thread Stas Malyshev
Hi! There seem to be a lot of unrelated code cleanup here, and I am in > general a bit confused in this code. > Could you review http://php.net/streamwrapper and write up the changes to > it? > > There shouldn't be any changes except for adding one stream handler (see rfc: https://wiki.php.net/rfc

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/ext/standard/filestat.c branches/PHP_5_4/ext/standard/tests/file/userstreams_007.phpt branches/PHP_5_4/main/php_streams.h branch

2011-05-25 Thread Hannes Magnusson
There seem to be a lot of unrelated code cleanup here, and I am in general a bit confused in this code. Could you review http://php.net/streamwrapper and write up the changes to it? -Hannes On Wed, May 25, 2011 at 23:03, Stanislav Malyshev wrote: > stas                                     Wed, 2