[PHP-CVS] svn: /php/php-src/trunk/ NEWS

2010-11-23 Thread Andi Gutmans
andi Wed, 24 Nov 2010 04:31:45 + Revision: http://svn.php.net/viewvc?view=revision&revision=305709 Log: - Fix typo Changed paths: U php/php-src/trunk/NEWS Modified: php/php-src/trunk/NEWS =

Re: [PHP-CVS] cvs: php4 /ext/standard basic_functions.c php_var.h var.c

2003-01-18 Thread Andi Gutmans
This should follow our naming conventions and be called memory_get_usage(). Andi At 06:26 PM 1/14/2003 +, Andrey Hristov wrote: andrey Tue Jan 14 13:26:47 2003 EDT Modified files: /php4/ext/standard basic_functions.c php_var.h var.c Log: added function get_memory_usage()

Re: [PHP-CVS] cvs: php4(PHP_4_3) /main SAPI.h

2003-01-18 Thread Andi Gutmans
At 06:42 PM 1/15/2003 +0100, Derick Rethans wrote: On Wed, 15 Jan 2003, Shane Caraveo wrote: > Edin Kadribasic wrote: > > I think that we should relax this contraint a bit on PHP_4_3 due to the > > fact that head is not likely going to see realeased version for some time > > to come due to the m

Re: [PHP-CVS] cvs: php4 /sapi/cgi cgi_main.c

2003-01-25 Thread Andi Gutmans
Please try not to mix whitespace and functionality patches. I'm having a hard time looking at two of your patches because too much has changed and most of it is whitespace. Thanks, Andi At 10:01 PM 1/25/2003 +, Shane Caraveo wrote: shane Sat Jan 25 17:01:54 2003 EDT Modified fi

Re: [PHP-CVS] cvs: php4 /ext/ftp ftp.c ftp.h php_ftp.c php_ftp.h

2003-01-26 Thread Andi Gutmans
This is a wonderful opportunity for a buffer overflow attack. There's a reason zend_parse_parameters() in PHP_FUNCTION(ftp_chmod) forces you to retrieve filename_len. Please fix it. Thanks, Andi At 02:54 AM 1/27/2003 +, Sara Golemon wrote: +ftp_chmod(ftpbuf_t *ftp, const int mode, const char

[PHP-CVS] cvs: php4 /ext/bcmath bcmath.c

2003-02-04 Thread Andi Gutmans
andiTue Feb 4 16:07:40 2003 EDT Modified files: /php4/ext/bcmathbcmath.c Log: - Please follow coding standards (this isn't java :) Index: php4/ext/bcmath/bcmath.c diff -u php4/ext/bcmath/bcmath.c:1.49 php4/ext/bcmath/bcmath.c:1.50 --- php4/ext/bcmath

Re: [PHP-CVS] cvs: php4 /ext/bcmath bcmath.c

2003-02-04 Thread Andi Gutmans
At 10:13 PM 2/4/2003 +0100, Marcus Börger wrote: At 22:07 04.02.2003, Andi Gutmans wrote: andiTue Feb 4 16:07:40 2003 EDT Modified files: /php4/ext/bcmathbcmath.c Log: - Please follow coding standards (this isn't java :) I only corrected this... I know. It w

Re: [PHP-CVS] cvs: php4 /ext/yp yp.c

2003-02-26 Thread Andi Gutmans
Please use strlcpy() instead of strncpy(). At 01:35 PM 2/24/2003 +, Hartmut Holzgraefe wrote: hholzgraMon Feb 24 08:35:06 2003 EDT Modified files: /php4/ext/ypyp.c Log: "key" has to be zero-delimited Index: php4/ext/yp/yp.c diff -u php4/ext/yp/yp.c:1.34 php4/

Re: [PHP-CVS] cvs: php4 /main fopen_wrappers.c

2003-03-26 Thread Andi Gutmans
Are you sure this is the right place to fix it? I would fix the place which calls this function because you might end up crashing on the returned null in the places which call this. At 11:01 PM 3/26/2003 +, Sterling Hughes wrote: sterlingWed Mar 26 18:01:39 2003 EDT Modifi

Re: [PHP-CVS] cvs: php4 /main fopen_wrappers.c

2003-03-26 Thread Andi Gutmans
OK... :) I hope no one tries to efree() this though. At 11:03 PM 3/26/2003 +, Sterling Hughes wrote: sterlingWed Mar 26 18:03:48 2003 EDT Modified files: /php4/main fopen_wrappers.c Log: really fix Index: php4/main/fopen_wrappers.c diff -u php4/main/fopen_wrappers.c

Re: [PHP-CVS] cvs: php4 /ext/curl multi.c ZendEngine2 zend_list.c zend_list.h

2003-04-02 Thread Andi Gutmans
I didn't quite understand what you did here. Can you please explain? Is it absolutely necessary to add this hack just for curl? Andi At 04:58 PM 4/2/2003 +, Sterling Hughes wrote: sterlingWed Apr 2 11:58:52 2003 EDT Modified files: /ZendEngine2zend_list.c zend

Re: [PHP-CVS] cvs: php4 /ext/curl multi.c ZendEngine2 zend_list.c zend_list.h

2003-04-02 Thread Andi Gutmans
At 01:21 PM 4/2/2003 -0500, Sterling Hughes wrote: > I didn't quite understand what you did here. Can you please explain? Is it > absolutely necessary to add this hack just for curl? > I added the ability to find a resource identifier from a resource. Something I think is generally pretty useful.

Re: [PHP-CVS] cvs: php4 /ext/exif exif.c

2003-04-02 Thread Andi Gutmans
I don't have time to look through this in a thorough way but I think it could leak now. Maybe it's best if you move this function to getParameters() and convert_to_string() w/o _ex. Andi At 10:07 PM 4/2/2003 +, Rasmus Lerdorf wrote: rasmus Wed Apr 2 17:07:22 2003 EDT Modified f

Re: [PHP-CVS] cvs: php4 /ext/bcmath bcmath.c

2003-04-02 Thread Andi Gutmans
I agree with him. We have standards and people have worked hard to indent the source code in a consistent manner (especially people like Jani). It doesn't take more time to indent nicely. Andi At 06:54 PM 4/2/2003 -0800, Rasmus Lerdorf wrote: Oh, give me a break Jani. A space here or there mak

Re: [PHP-CVS] cvs: php4 /main output.c

2003-04-04 Thread Andi Gutmans
I don't think we should back-out these kind of whitespace fixes. I tend to agree with Jani and I think he's doing a good job whitespacing code. I also think that Rasmus reasoning for not commiting correctly whitespaced code because we have lots of broken code in PHP, is not very strong. Let's tr

Re: [PHP-CVS] cvs: php4 /main php.h ZendEngine2 zend_API.h

2003-04-04 Thread Andi Gutmans
What's the difference between ZEND_ME() and ZEND_METHOD()? (i.e. what does ME stand for?) At 03:38 PM 4/4/2003 +, Andrei Zmievski wrote: andrei Fri Apr 4 10:38:20 2003 EDT Modified files: /ZendEngine2zend_API.h /php4/main php.h Log: Introduce ZEND_ME() and ZE

Re: [PHP-CVS] cvs: php4 /ext/gd gd.c

2003-04-05 Thread Andi Gutmans
At 08:52 PM 4/4/2003 +0300, Jani Taskinen wrote: On Fri, 4 Apr 2003, Rasmus Lerdorf wrote: >Jani, it is not just me. I think there is pretty much universal agreement >that this error_docref stuff is crap. We already decided to disable it by >default in 4.3.2. We haven't discussed it yet, but co

[PHP-CVS] cvs: CVSROOT / avail

2003-06-10 Thread Andi Gutmans
andiTue Jun 10 15:26:03 2003 EDT Modified files: /CVSROOTavail Log: - Add imajes to Zend. License commit coming up Index: CVSROOT/avail diff -u CVSROOT/avail:1.685 CVSROOT/avail:1.686 --- CVSROOT/avail:1.685 Thu Jun 5 12:42:06 2003 +++ CVSROOT/avail

Re: [PHP-CVS] cvs: php-src /ext/dom config.m4

2003-06-25 Thread Andi Gutmans
So is DOM enabled by default? So what is new DOM support which is "no" during configure? Andi At 06:06 PM 6/25/2003 +, Sterling Hughes wrote: sterlingWed Jun 25 14:06:06 2003 EDT Modified files: /php-src/ext/domconfig.m4 Log: autodetect zlib if dom is enabled I

Re: [PHP-CVS] cvs: php-src /ext/sqlite php_sqlite.h sqlite.c /ext/sqlite/tests sqlite_oo_016.phpt

2003-06-27 Thread Andi Gutmans
IMO, it doesn't make sense to introduce aliases in a new extension. Andi At 07:26 PM 26/6/2003 +, Marcus Boerger wrote: helly Thu Jun 26 15:26:26 2003 EDT Modified files: /php-src/ext/sqlite php_sqlite.h sqlite.c /php-src/ext/sqlite/tests sqlite_oo_016.phpt Log: Ren

Re: [PHP-CVS] cvs: php-src / README.EXT_SKEL /ext ext_skel ext_skel_win32.php /ext/skeleton .cvsignore CREDITS EXPERIMENTAL create_stubs php_skeleton.h skeleton.c skeleton.dsp skeleton.php /ext/skeleton/tests .cvsignore 001.phpt /scripts/ext_skel_ng BUGS README TODO config_m4.php dummy.gif ext_skel_ng.php extension.dtd extension.xml extension_parser.php license.php license_bsd.php license_lgpl.php license_php.php php_constant.php php_element.php php_function.php php_global.php php_ini.php php_logo.php php_resource.php xml_stream_callback_parser.php xml_stream_parser.php

2003-06-29 Thread Andi Gutmans
Why? I liked ext_skel and it was great a great light weight solution. Why do you remove stuff without consulting the development mailing list? I'd like to see this reverted! Andi At 12:21 PM 29/6/2003 +, Hartmut Holzgraefe wrote: hholzgraSun Jun 29 08:21:58 2003 EDT Remove

Re: [PHP-CVS] cvs: php-src / README.EXT_SKEL /ext ext_skel ext_skel_win32.php /ext/skeleton CREDITS EXPERIMENTAL create_stubs php_skeleton.h skeleton.c skeleton.dsp skeleton.php /ext/skeleton/tests .cvsignore 001.phpt

2003-06-29 Thread Andi Gutmans
Didn't see this when I wrote my previous email :) At 04:07 PM 29/6/2003 +, Hartmut Holzgraefe wrote: hholzgraSun Jun 29 12:07:18 2003 EDT Modified files: /php-srcREADME.EXT_SKEL /php-src/extext_skel ext_skel_win32.php /php-src/ext/skeleton CREDI

[PHP-CVS] cvs: CVSROOT / avail

2003-06-30 Thread Andi Gutmans
andiMon Jun 30 15:58:02 2003 EDT Modified files: /CVSROOTavail Log: - ZE2 Karma for George Schlossnagle Index: CVSROOT/avail diff -u CVSROOT/avail:1.700 CVSROOT/avail:1.701 --- CVSROOT/avail:1.700 Wed Jun 25 20:16:54 2003 +++ CVSROOT/avail Mon

Re: [PHP-CVS] cvs: php-src /ext/simplexml simplexml.c

2003-07-05 Thread Andi Gutmans
Sterling, Extensions shouldn't really be using stuff like PZVAL_UNLOCK(). Can you explain what you are trying to accomplish? Andi At 12:33 AM 5/7/2003 +, Sterling Hughes wrote: sterlingFri Jul 4 20:33:13 2003 EDT Modified files: /php-src/ext/simplexml simplexml.

Re: [PHP-CVS] cvs: php-src /ext/sqlite sqlite.c

2003-07-19 Thread Andi Gutmans
Why not use zend_list_find() (without the _)? Andi At 05:52 AM 14/7/2003 +, Sebastian Bergmann wrote: sebastian Mon Jul 14 01:52:57 2003 EDT Modified files: /php-src/ext/sqlite sqlite.c Log: ZTS fix. Index: php-src/ext/sqlite/sqlite.c diff -u php-src/ext/sqlite/sqlite

[PHP-CVS] cvs: CVSROOT / avail

2003-07-19 Thread Andi Gutmans
andiSat Jul 19 14:47:40 2003 EDT Modified files: /CVSROOTavail Log: - ZE karma for moriyoshi Index: CVSROOT/avail diff -u CVSROOT/avail:1.713 CVSROOT/avail:1.714 --- CVSROOT/avail:1.713 Thu Jul 17 13:03:56 2003 +++ CVSROOT/avail Sat Jul 19 14:47

RE: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/standard basic_functions.c /ext/standard/tests/network ip.phpt

2007-08-20 Thread Andi Gutmans
There are some convenience functions in zend_operators.h which would save having to repeat this logic (I think they are called zend_binary_strcmp() and zend_binary_zval_strcmp()). Andi > -Original Message- > From: Antony Dovgal [mailto:[EMAIL PROTECTED] > Sent: Thursday, August 16, 2007

[PHP-CVS] cvs: CVSROOT / avail

2007-09-12 Thread Andi Gutmans
andiWed Sep 12 21:57:30 2007 UTC Modified files: /CVSROOTavail Log: - Enable Stas to help with CVS accounts http://cvs.php.net/viewvc.cgi/CVSROOT/avail?r1=1.1302&r2=1.1303&diff_format=u Index: CVSROOT/avail diff -u CVSROOT/avail:1.1302 CVSROOT/avail:1

RE: [PHP-CVS] cvs: php-src(PHP_5_2_WITH_DRCP) /ext/oci8 READMEoci8.c oci8_interface.c php_oci8_int.h /ext/oci8/tests debug.phptpassword.phpt password_2.phpt password_new.phpt password_old.phpt

2007-10-05 Thread Andi Gutmans
Weird, I'm pretty sure I created the branch for Chris in PECL. This is intentionally in a branch so that people can play around with it but without risking the stable branch. Chris, did you checkout pecl/oci8 or php-src/ext/oci8 before you commited? Andi > -Original Message- > From: Jani

RE: [PHP-CVS] cvs: php-src(PHP_5_2_WITH_DRCP) /ext/oci8 READMEoci8.c oci8_interface.c php_oci8_int.h /ext/oci8/tests debug.phptpassword.phpt password_2.phpt password_new.phpt password_old.phpt

2007-10-05 Thread Andi Gutmans
Yeah I also got confused for a sec :) > -Original Message- > From: Jani Taskinen [mailto:[EMAIL PROTECTED] > Sent: Friday, October 05, 2007 4:38 PM > To: Andi Gutmans > Cc: Christopher Jones; [email protected] > Subject: Re: [PHP-CVS] cvs: php-src(PHP_5_2_WI

RE: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/mysqli mysqli.c /ext/mysqlnd mysqlnd_priv.h

2007-10-27 Thread Andi Gutmans
Hi Andrey, Are you sure it's a good idea to replicate these macros? It kind of breaks the ability to tweak them in a central place. What's the reasoning for it? Andi > -Original Message- > From: Andrey Hristov [mailto:[EMAIL PROTECTED] > Sent: Tuesday, October 16, 2007 1:56 PM > To: php-

Re: [PHP-CVS] cvs: php-src /ext/reflection php_reflection.c /ext/reflection/tests 007.phpt

2006-01-27 Thread Andi Gutmans
OK in that case it's probably best not to add inconsistency and leave it this way. At 12:44 AM 1/25/2006, Marcus Boerger wrote: Hello Andi, it was Sebastians idea and he took the name from invokeArgs(). I don't care, so if you can sleep better with your proposal change both names and live wi

Re: [PHP-CVS] cvs: php-src /ext/msession README config.m4 msession-test.php msession.c msessionapi.h php_msession.h reqclient.h

2006-01-30 Thread Andi Gutmans
Seems like your commit screwed up the copyright notice. Did you commit ancient code? :) - | Copyright (c) 1997-2006 The PHP Group| + | Copyright (c) 1997-2003 The PHP Group| +-

Re: [PHP-CVS] cvs: php-src /ext/xmldbx CREDITS config.m4 php_xmldbx.h sessionxml.php xmldbx.c xmldbx.h xmldbx.php

2006-01-30 Thread Andi Gutmans
Derick, I suggest to just rm -rf it from the repository and have him recommit it to PECL. Andi At 03:26 PM 1/30/2006, Derick Rethans wrote: On Mon, 30 Jan 2006, Derick Rethans wrote: > The process is more: > - add extension to PECL > - develop it there, make it stable > - contact internals@

Re: [PHP-CVS] cvs: php-src(PHP_5_1) / NEWS php.ini-dist php.ini-recommended

2006-02-08 Thread Andi Gutmans
Thanks. Sucks that this was missing :) At 03:43 PM 2/8/2006, Ilia Alshanetsky wrote: iliaa Wed Feb 8 23:43:48 2006 UTC Modified files: (Branch: PHP_5_1) /php-srcphp.ini-dist php.ini-recommended NEWS Log: Fixed bug #36334 (Added missing documentation about r

Re: [PHP-CVS] cvs: php-src(PHP_5_1) / configure.in /ext/standard basic_functions.c basic_functions.h

2006-02-16 Thread Andi Gutmans
Hey Wez, We should stick to coding standards for new functions. How about sys_getloadavg()? Andi At 02:49 PM 2/16/2006, Wez Furlong wrote: wez Thu Feb 16 22:49:13 2006 UTC Modified files: (Branch: PHP_5_1) /php-srcconfigure.in /php-src/ext/standard

Re: [PHP-CVS] cvs: php-src(PHP_5_1) / configure.in /ext/standard basic_functions.c basic_functions.h

2006-02-17 Thread Andi Gutmans
name here needs to be matched in phpweb. --Wez. Andi Gutmans wrote: > Hey Wez, > > We should stick to coding standards for new functions. > How about sys_getloadavg()? > > Andi > > At 02:49 PM 2/16/2006, Wez Furlong wrote: >> wez Thu Feb 16

[PHP-CVS] cvs: php-src /ext/com_dotnet com_persist.c /ext/curl interface.c /ext/dbase dbase.c /ext/fdf fdf.c /ext/filepro filepro.c /ext/gd php_gd.h /ext/ming ming.c /ext/oci8 oci8_interface.c

2006-02-18 Thread Andi Gutmans
andiSun Feb 19 00:55:21 2006 UTC Modified files: /php-src/ext/com_dotnet com_persist.c /php-src/ext/curl interface.c /php-src/ext/dbase dbase.c /php-src/ext/fdffdf.c /php-src/ext/fileprofilepro.c /php-src/ext/gd php_gd

[PHP-CVS] cvs: php-src /main fopen_wrappers.c main.c /main/streams plain_wrapper.c

2006-02-18 Thread Andi Gutmans
andiSun Feb 19 01:10:13 2006 UTC Modified files: /php-src/main fopen_wrappers.c main.c /php-src/main/streams plain_wrapper.c Log: - Some more safe_mode nuking http://cvs.php.net/viewcvs.cgi/php-src/main/fopen_wrappers.c?r1=1.177&r2=1.178&

[PHP-CVS] cvs: php-src /main fopen_wrappers.c fopen_wrappers.h /main/streams plain_wrapper.c

2006-02-18 Thread Andi Gutmans
andiSun Feb 19 01:19:37 2006 UTC Modified files: /php-src/main fopen_wrappers.c fopen_wrappers.h /php-src/main/streams plain_wrapper.c Log: Nuke php_check_safe_mode_include_dir http://cvs.php.net/viewcvs.cgi/php-src/main/fopen_wrappers.c?

[PHP-CVS] cvs: php-src /ext/curl interface.c /ext/openssl openssl.c /ext/standard file.c ftok.c iptc.c

2006-02-18 Thread Andi Gutmans
andiSun Feb 19 03:07:39 2006 UTC Modified files: /php-src/ext/curl interface.c /php-src/ext/opensslopenssl.c /php-src/ext/standard file.c ftok.c iptc.c Log: - More safe_mode nuking http://cvs.php.net/viewcvs.cgi/php-src/ext/curl/

[PHP-CVS] cvs: php-src /main/streams plain_wrapper.c

2006-02-18 Thread Andi Gutmans
andiSun Feb 19 03:41:25 2006 UTC Modified files: /php-src/main/streams plain_wrapper.c Log: - Fix according to Sara's reply http://cvs.php.net/viewcvs.cgi/php-src/main/streams/plain_wrapper.c?r1=1.61&r2=1.62&diff_format=u Index: php-src/main/streams

[PHP-CVS] cvs: php-src /ext/bz2 bz2.c /ext/dba dba.c /ext/exif exif.c /ext/ftp php_ftp.c /ext/gd gd.c /ext/hash hash.c hash_md.c hash_sha.c /ext/imap php_imap.c /ext/libxml libxml.c /ext/mime_

2006-02-18 Thread Andi Gutmans
andiSun Feb 19 04:29:42 2006 UTC Modified files: /php-src/ext/bz2bz2.c /php-src/ext/dbadba.c /php-src/ext/exif exif.c /php-src/ext/ftpphp_ftp.c /php-src/ext/gd gd.c /php-src/ext/hash hash.c hash_md.c hash_sha.c /php-

[PHP-CVS] cvs: php-src /ext/curl interface.c /ext/gd php_gd.h

2006-02-18 Thread Andi Gutmans
andiSun Feb 19 05:05:42 2006 UTC Modified files: /php-src/ext/curl interface.c /php-src/ext/gd php_gd.h Log: - Couple of compile fixes. http://cvs.php.net/viewcvs.cgi/php-src/ext/curl/interface.c?r1=1.76&r2=1.77&diff_format=u Index: php-src/ext

Re: [PHP-CVS] cvs: php-src /ext/unicode unicode.c /main main.c /main/streams filter.c streams.c ZendEngine2 zend.c zend_constants.c zend_globals.h zend_unicode.c zend_unicode.h

2006-03-26 Thread Andi Gutmans
We should namespaces these and all other unicode constants... + REGISTER_MAIN_LONG_CONSTANT("FROM_UNICODE", ZEND_FROM_UNICODE, CONST_PERSISTENT | CONST_CS); + REGISTER_MAIN_LONG_CONSTANT("TO_UNICODE", ZEND_TO_UNICODE, CONST_PERSISTENT | CONST_CS); At 05:48 PM 3/25/2006, Andrei Zm

Re: [PHP-CVS] cvs: php-src /ext/unicode unicode.c /main main.c /main/streams filter.c streams.c ZendEngine2 zend.c zend_constants.c zend_globals.h zend_unicode.c zend_unicode.h

2006-03-28 Thread Andi Gutmans
3/27/2006, Andrei Zmievski wrote: Namespace them to what? It's a short and understandable name that will be used a lot.. -Andrei On Mar 26, 2006, at 9:51 PM, Andi Gutmans wrote: We should namespaces these and all other unicode constants... + REGISTER_MAIN_LONG_CONSTANT

Re: [PHP-CVS] cvs: php-src(PHP_5_1) /sapi/apache php_apache.c

2006-04-27 Thread Andi Gutmans
Shouldn't you use ZEND_DLIMPORT? It'd be much nicer and save us those #ifdef's Andi At 02:31 AM 4/26/2006, Edin Kadribasic wrote: edink Wed Apr 26 09:31:23 2006 UTC Modified files: (Branch: PHP_5_1) /php-src/sapi/apachephp_apache.c Log: Correctly import

Re: [PHP-CVS] cvs: php-src(PHP_5_1) /ext/standard php_smart_str.h

2006-05-02 Thread Andi Gutmans
Does smart_str realloc at the end? If not, then this patch can lead to much higher memory use. From our tests we found 5.1 to use more memory and this was part of the reason for some slowdown. Even if a micro benchmark can show this to be faster, for real world apps and the various CPUs we are

Re: [PHP-CVS] cvs: php-src / NEWS /ext/standard basic_functions.c file.c file.h

2006-05-06 Thread Andi Gutmans
Hartmut, This is a very odd name to be using and doesn't follow our naming conventions. Maybe something like sys_get_tmpdir()? Andi At 02:59 AM 5/6/2006, Hartmut Holzgraefe wrote: hholzgraSat May 6 09:59:02 2006 UTC Modified files: /php-srcNEWS /php-src/ext/sta

Re: [PHP-CVS] cvs: php-src / NEWS /ext/standard basic_functions.c file.c file.h

2006-05-07 Thread Andi Gutmans
Either of these works for me. At 11:02 AM 5/7/2006, Pierre wrote: On 5/7/06, Antony Dovgal <[EMAIL PROTECTED]> wrote: On 07.05.2006 21:26, Wez Furlong wrote: > sys_tmpdir()? > I vote for sys_ as the prefix, as we've started down that path with > sys_getloadavg(). Yeah, sys_tmpdir() sounds good

[PHP-CVS] cvs: php-src(PHP_5_2) / NEWS

2006-05-30 Thread Andi Gutmans
andiWed May 31 03:43:17 2006 UTC Modified files: (Branch: PHP_5_2) /php-srcNEWS Log: - Fix typo http://cvs.php.net/viewcvs.cgi/php-src/NEWS?r1=1.2027.2.547.2.66&r2=1.2027.2.547.2.67&diff_format=u Index: php-src/NEWS diff -u php-src/NEWS:1.2027.2.547.2.

Re: [PHP-CVS] cvs: php-src / README.NEW-OUTPUT-API /ext/pgsql pgsql.c /ext/session session.c /ext/soap soap.c /ext/standard basic_functions.c head.c info.c url_scanner_ex.c url_scanner_ex.re var.c

2006-06-02 Thread Andi Gutmans
Can you give a short summary of what the essence of the change is and how the APIs have changed (Both the ones available to the PHP developer and to the extension writer?) Thanks! Andi At 12:51 PM 6/2/2006, Michael Wallner wrote: mikeFri Jun 2 19:51:43 2006 UTC Added files:

Re: [PHP-CVS] cvs: php-src / README.NEW-OUTPUT-API /ext/pgsql pgsql.c /ext/session session.c /ext/soap soap.c /ext/standard basic_functions.c head.c info.c url_scanner_ex.c url_scanner_ex.re var.c

2006-06-02 Thread Andi Gutmans
Btw, any reason why we need all those redefinition of functions? If it's just to save having to write TSRMLS_C then I'd prefer to remove those macros. They just make debugging harder, there's no real benefit and we've tried to be explicit in other places. The patch looks nice though although I

Re: [PHP-CVS] cvs: php-src /ext/session session.c /ext/soap soap.c /ext/standard basic_functions.c head.c info.c url_scanner_ex.c url_scanner_ex.re var.c /ext/tidy tidy.c /ext/zlib zlib.c /main S

2006-06-03 Thread Andi Gutmans
Thanks! I missed the original email you sent with the patch which is why I didn't catch it earlier. At 04:19 AM 6/3/2006, Michael Wallner wrote: mikeSat Jun 3 11:19:44 2006 UTC Modified files: /php-src/ext/sessionsession.c /php-src/ext/soap soap.c /php-src

Re: [PHP-CVS] cvs: php-src(PHP_5_2) /sapi/cgi cgi_main.c /sapi/cli php_cli.c

2006-06-03 Thread Andi Gutmans
Hey, I must have missed the discussion around this one. Why is it useless? How long has this feature existed? Thx. Andi At 03:02 PM 6/3/2006, Johannes Schlüter wrote: johannesSat Jun 3 22:02:02 2006 UTC Modified files: (Branch: PHP_5_2) /php-src/sapi/cli

Re: [PHP-CVS] cvs: php-src /ext/unicode config.m4 config.w32 php_transform.h transform.c unicode.c

2006-06-13 Thread Andi Gutmans
Please fix the naming conventions... At 04:46 PM 6/13/2006, Andrei Zmievski wrote: andrei Tue Jun 13 23:46:04 2006 UTC Added files: /php-src/ext/unicodephp_transform.h transform.c Modified files: /php-src/ext/unicodeconfig.m4 config.w32 unicode.c Log: t

Re: [PHP-CVS] cvs: php-src /ext/unicode config.m4 config.w32 php_transform.h transform.c unicode.c

2006-06-13 Thread Andi Gutmans
ODING_STANDARDS. Thx. At 07:49 PM 6/13/2006, Andrei Zmievski wrote: What do you mean? -Andrei On Jun 13, 2006, at 5:45 PM, Andi Gutmans wrote: Please fix the naming conventions... -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php -- PHP C

Re: [PHP-CVS] cvs: php-src /ext/unicode config.m4 config.w32 php_transform.h transform.c unicode.c

2006-06-14 Thread Andi Gutmans
sense. text_transliterate()? str_transliterate()? We've abandoned the idea of i18n_ prefix and unicode_ doesn't fit here either.. -Andrei On Jun 13, 2006, at 8:41 PM, Andi Gutmans wrote: As you know our naming conventions are module_function, e.g. unicode_transliterate, i18

Re: [PHP-CVS] cvs: php-src /ext/unicode php_transform.h transform.c unicode.c

2006-06-15 Thread Andi Gutmans
Thanks! At 10:37 AM 6/15/2006, Andrei Zmievski wrote: andrei Thu Jun 15 17:37:48 2006 UTC Modified files: /php-src/ext/unicodephp_transform.h transform.c unicode.c Log: Rename to str_transliterate(). http://cvs.php.net/viewcvs.cgi/php-src/ext/unicode/php_transform.h

[PHP-CVS] RE: [PHP-DEV] Re: [PHP-CVS] New Memory Manager (Was: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/standard var.c /main main.c /sapi/apache mod_php5.c /sapi/apache2filter sapi_apache2.c /

2006-07-18 Thread Andi Gutmans
Didn't see this but I did :) Andi > -Original Message- > From: Andrei Zmievski [mailto:[EMAIL PROTECTED] > Sent: Tuesday, July 18, 2006 10:13 AM > To: Dmitry Stogov > Cc: [email protected]; [email protected] > Subject: [PHP-DEV] Re: [PHP-CVS] New Memory Manager (Was: > [PHP-C

RE: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/zip php_zip.c

2006-08-26 Thread Andi Gutmans
I missed the discussion about this. Is there a bug in VCWD_REALPATH()? Can you explain? Thanks. > -Original Message- > From: Pierre-Alain Joye [mailto:[EMAIL PROTECTED] > Sent: Saturday, August 26, 2006 5:24 AM > To: [email protected] > Subject: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/

RE: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/bz2 bz2.c php_bz2.h /ext/ctype ctype.c php_ctype.h /ext/json json.c php_json.h /ext/pspell php_pspell.h pspell.c /ext/tidy php_tidy.h tidy.c /ext/zlib php

2006-08-26 Thread Andi Gutmans
Why is this important? We never defined these as static. As long as you move them to the .c file (for whatever reason you have that might be justified) you really don't have to define them as static IMO. > -Original Message- > From: Nuno Lopes [mailto:[EMAIL PROTECTED] > Sent: Monday, Au

RE: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/bz2 bz2.c php_bz2.h /ext/ctype ctype.c php_ctype.h /ext/json json.c php_json.h /ext/pspell php_pspell.h pspell.c /ext/tidy php_tidy.h tidy.c /ext/zlib php

2006-08-26 Thread Andi Gutmans
ls also. It could come in handly with dlls. Andi > -Original Message- > From: Ilia Alshanetsky [mailto:[EMAIL PROTECTED] On Behalf Of > Ilia Alshanetsky > Sent: Saturday, August 26, 2006 9:59 AM > To: Andi Gutmans > Cc: 'Nuno Lopes'; [email protected] > S

[PHP-CVS] cvs: CVSROOT / avail

2009-03-22 Thread Andi Gutmans
andiMon Mar 23 02:32:49 2009 UTC Modified files: /CVSROOTavail Log: - Give ericstewart commit access to php-src for INI and test work http://cvs.php.net/viewvc.cgi/CVSROOT/avail?r1=1.1503&r2=1.1504&diff_format=u Index: CVSROOT/avail diff -u CVSROOT/av

[PHP-CVS] svn: /php/php-src/trunk/ README.UNICODE

2009-08-08 Thread Andi Gutmans
andi Sun, 09 Aug 2009 03:39:15 + Revision: http://svn.php.net/viewvc?view=revision&revision=286937 Log: - Fix small typo Changed paths: U php/php-src/trunk/README.UNICODE Modified: php/php-src/trunk/README.UNICODE ===

[PHP-CVS] svn: /php/php-src/trunk/Zend/ zend_alloc.c

2009-08-08 Thread Andi Gutmans
andi Sun, 09 Aug 2009 04:46:02 + Revision: http://svn.php.net/viewvc?view=revision&revision=286940 Log: - Optimize slightly for common case - n!=4 Changed paths: U php/php-src/trunk/Zend/zend_alloc.c Modified: php/php-src/trunk/Zend/zend_alloc.c ===

[PHP-CVS] svn: /php/php-src/branches/PHP_5_3/Zend/ zend_alloc.c

2009-08-08 Thread Andi Gutmans
andi Sun, 09 Aug 2009 04:46:30 + Revision: http://svn.php.net/viewvc?view=revision&revision=286941 Log: - MFH Changed paths: U php/php-src/branches/PHP_5_3/Zend/zend_alloc.c Modified: php/php-src/branches/PHP_5_3/Zend/zend_alloc.c ==

RE: [PHP-CVS] svn: /php/php-src/branches/PHP_5_3/Zend/ zend_alloc.c

2009-08-11 Thread Andi Gutmans
Sure. > -Original Message- > From: Derick Rethans [mailto:[email protected]] > Sent: Tuesday, August 11, 2009 2:11 AM > To: Andi Gutmans > Cc: [email protected]; [email protected] > Subject: Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_3/Zend/ zend_alloc.c > >

[PHP-CVS] cvs: CVSROOT / avail

2008-08-11 Thread Andi Gutmans
andiMon Aug 11 19:41:57 2008 UTC Modified files: /CVSROOTavail Log: - Karma to commit tests for CURL. http://cvs.php.net/viewvc.cgi/CVSROOT/avail?r1=1.1433&r2=1.1434&diff_format=u Index: CVSROOT/avail diff -u CVSROOT/avail:1.1433 CVSROOT/avail:1.1434

[PHP-CVS] cvs: php-src / NEWS

2005-06-10 Thread Andi Gutmans
andiFri Jun 10 12:55:29 2005 EDT Modified files: /php-srcNEWS Log: - Go with Beta 1 - Merged 5.0.x news and nuked anything prior to 5.0.0 release http://cvs.php.net/diff.php/php-src/NEWS?r1=1.1910&r2=1.1911&ty=u Index: php-src/NEWS diff -u php-src/NE

[PHP-CVS] cvs: php-src / configure.in /main php_version.h ZendEngine2 zend.h

2005-06-10 Thread Andi Gutmans
andiFri Jun 10 14:06:43 2005 EDT Modified files: /php-srcconfigure.in /ZendEngine2zend.h /php-src/main php_version.h Log: - Go with 5.1.0b1 http://cvs.php.net/diff.php/php-src/configure.in?r1=1.559&r2=1.560&ty=u Index: php-src/

[PHP-CVS] cvs: php-src / configure.in /main php_version.h ZendEngine2 zend.h

2005-06-10 Thread Andi Gutmans
andiFri Jun 10 14:29:12 2005 EDT Modified files: /php-srcconfigure.in /ZendEngine2zend.h /php-src/main php_version.h Log: - Back to -dev http://cvs.php.net/diff.php/php-src/configure.in?r1=1.560&r2=1.561&ty=u Index: php-src/con

[PHP-CVS] cvs: php-src / NEWS configure.in /main php_version.h ZendEngine2 zend.h

2005-06-11 Thread Andi Gutmans
andiSat Jun 11 12:59:25 2005 EDT Modified files: /php-srcNEWS configure.in /ZendEngine2zend.h /php-src/main php_version.h Log: - b2 (will post it to internals@) http://cvs.php.net/diff.php/php-src/NEWS?r1=1.1911&r2=1.1912&ty=u

[PHP-CVS] cvs: php-src / configure.in /main php_version.h ZendEngine2 zend.h

2005-06-11 Thread Andi Gutmans
andiSat Jun 11 13:03:43 2005 EDT Modified files: /php-srcconfigure.in /ZendEngine2zend.h /php-src/main php_version.h Log: - Back to -dev http://cvs.php.net/diff.php/php-src/configure.in?r1=1.562&r2=1.563&ty=u Index: php-src/con

Re: [PHP-CVS] cvs: php-src / NEWS configure.in /main php_version.h ZendEngine2 zend.h

2005-06-11 Thread Andi Gutmans
I can but I'd prefer to know what we're holding for. I am in no hurry to post it today, especially as it's the weekend and I have family to be with :) At 07:39 PM 6/11/2005 +0200, Derick Rethans wrote: On Sat, 11 Jun 2005, Andi Gutmans wrote: > andi Sat Jun 11

Re: [PHP-CVS] cvs: php-src /main network.c

2005-06-14 Thread Andi Gutmans
Thanks. At 01:09 PM 6/14/2005 +, Ilia Alshanetsky wrote: iliaa Tue Jun 14 09:09:07 2005 EDT Modified files: /php-src/main network.c Log: bzero > memset http://cvs.php.net/diff.php/php-src/main/network.c?r1=1.115&r2=1.116&ty=u Index: php-src/main/network.c diff -u

Re: [PHP-CVS] cvs: php-src(PHP_5_0) /scripts phpize.in

2005-06-15 Thread Andi Gutmans
We should still keep this as an option until 5.1.0 is out, although I'm hoping we won't release anything else. Andi At 07:59 PM 6/15/2005 +0200, Derick Rethans wrote: On Wed, 15 Jun 2005, Antony Dovgal wrote: > tony2001 Wed Jun 15 13:19:42 2005 EDT > > Modified files:

[PHP-CVS] cvs: php-src / php.ini-recommended

2005-06-18 Thread Andi Gutmans
andiSat Jun 18 12:52:25 2005 EDT Modified files: /php-srcphp.ini-recommended Log: - E_STRICT shouldn't be on by default on production servers. http://cvs.php.net/diff.php/php-src/php.ini-recommended?r1=1.176&r2=1.177&ty=u Index: php-src/php.ini-recomm

[PHP-CVS] cvs: php-src / NEWS

2005-06-19 Thread Andi Gutmans
andiSun Jun 19 23:54:47 2005 EDT Modified files: /php-srcNEWS Log: - Fix typo http://cvs.php.net/diff.php/php-src/NEWS?r1=1.1936&r2=1.1937&ty=u Index: php-src/NEWS diff -u php-src/NEWS:1.1936 php-src/NEWS:1.1937 --- php-src/NEWS:1.1936 Sun Jun 19 23:0

[PHP-CVS] cvs: php-src / NEWS configure.in /main php_version.h ZendEngine2 zend.h

2005-06-20 Thread Andi Gutmans
andiMon Jun 20 16:49:56 2005 EDT Modified files: /php-srcNEWS configure.in /ZendEngine2zend.h /php-src/main php_version.h Log: - Beta 2 http://cvs.php.net/diff.php/php-src/NEWS?r1=1.1941&r2=1.1942&ty=u Index: php-src/NEWS diff

Re: [PHP-CVS] cvs: php-src / NEWS configure.in /main php_version.h ZendEngine2 zend.h

2005-06-20 Thread Andi Gutmans
Yeah, give me a few minutes! At 11:47 PM 6/20/2005 +0200, Derick Rethans wrote: On Mon, 20 Jun 2005, Andi Gutmans wrote: > andi Mon Jun 20 16:49:56 2005 EDT > > Modified files: > /php-src NEWS configure.in > /ZendEngine2 zend.h > /php-src/main

[PHP-CVS] cvs: php-src / NEWS configure.in /main php_version.h ZendEngine2 zend.h

2005-06-20 Thread Andi Gutmans
andiMon Jun 20 18:34:57 2005 EDT Modified files: /php-srcNEWS configure.in /ZendEngine2zend.h /php-src/main php_version.h Log: - Back to -dev http://cvs.php.net/diff.php/php-src/NEWS?r1=1.1942&r2=1.1943&ty=u Index: php-src/NEWS

[PHP-CVS] cvs: php-src / NEWS configure.in /main php_version.h ZendEngine2 zend.h

2005-06-21 Thread Andi Gutmans
andiTue Jun 21 11:44:51 2005 EDT Modified files: /php-srcNEWS configure.in /ZendEngine2zend.h /php-src/main php_version.h Log: - Take #3 :) http://cvs.php.net/diff.php/php-src/NEWS?r1=1.1944&r2=1.1945&ty=u Index: php-src/NEWS d

[PHP-CVS] cvs: php-src / configure.in /main php_version.h ZendEngine2 zend.h

2005-06-21 Thread Andi Gutmans
andiTue Jun 21 12:31:19 2005 EDT Modified files: /php-srcconfigure.in /ZendEngine2zend.h /php-src/main php_version.h Log: - Back to -dev. Guys (n' Girls), give at least 1 hour before you start - complaining about not going back to

[PHP-CVS] cvs: php-src / NEWS

2005-06-22 Thread Andi Gutmans
andiWed Jun 22 23:55:43 2005 EDT Modified files: /php-srcNEWS Log: - Beta 2 http://cvs.php.net/diff.php/php-src/NEWS?r1=1.1951&r2=1.1952&ty=u Index: php-src/NEWS diff -u php-src/NEWS:1.1951 php-src/NEWS:1.1952 --- php-src/NEWS:1.1951 Wed Jun 22 15:59:

[PHP-CVS] cvs: php-src / configure.in /main php_version.h ZendEngine2 zend.h

2005-06-22 Thread Andi Gutmans
andiWed Jun 22 23:56:38 2005 EDT Modified files: /php-srcconfigure.in /ZendEngine2zend.h /php-src/main php_version.h Log: - Beta 2 http://cvs.php.net/diff.php/php-src/configure.in?r1=1.568&r2=1.569&ty=u Index: php-src/configure

[PHP-CVS] cvs: php-src / NEWS configure.in /main php_version.h ZendEngine2 zend.h

2005-06-22 Thread Andi Gutmans
andiThu Jun 23 00:20:50 2005 EDT Modified files: /php-srcNEWS configure.in /ZendEngine2zend.h /php-src/main php_version.h Log: - Back to -dev http://cvs.php.net/diff.php/php-src/NEWS?r1=1.1952&r2=1.1953&ty=u Index: php-src/NEWS

Re: [PHP-CVS] cvs: php-src /ext/date php_date.c

2005-07-01 Thread Andi Gutmans
And if you don't want to be bothered by memcpy() then don't forget strlcpy() is your friend :) At 07:27 PM 6/30/2005 -0400, Ilia Alshanetsky wrote: It looks like in most cases where %s is used it can be replaced with mempcy(). I'll look into it tomorrow unless Derick get's to it first :-) I

Re: [PHP-CVS] cvs: php-src /ext/odbc php_odbc.c

2005-07-02 Thread Andi Gutmans
What bug # is this? You're sure it's correct? At 10:48 PM 7/2/2005 +, Edin Kadribasic wrote: edink Sat Jul 2 18:48:09 2005 EDT Modified files: /php-src/ext/odbc php_odbc.c Log: Don't crash on exit by destroying the same hash twice http://cvs.php.net/diff.php/php-src/

Re: [PHP-CVS] cvs: php-src / NEWS

2005-07-02 Thread Andi Gutmans
Never mind. I see the bug # here. At 11:04 PM 7/2/2005 +, Edin Kadribasic wrote: edink Sat Jul 2 19:04:34 2005 EDT Modified files: /php-srcNEWS Log: BFN http://cvs.php.net/diff.php/php-src/NEWS?r1=1.1971&r2=1.1972&ty=u Index: php-src/NEWS diff -u php-src/NEWS:1.197

Re: [PHP-CVS] cvs: php-src /ext/pdo_pgsql pgsql_driver.c

2005-07-06 Thread Andi Gutmans
Yeah, definitely seems like PQexecParams is the safest and easiest way of doing so. In general, I'm always in favor of using bound parameters exactly for this reason. Andi At 10:44 AM 7/7/2005 +0800, Christopher Kings-Lynne wrote: By the way, using PQexecParams is by far the easiest fastest an

Re: [PHP-CVS] cvs: php-src /ext/pdo_pgsql pgsql_driver.c

2005-07-07 Thread Andi Gutmans
Oh, that's a different story then... At 01:54 PM 7/7/2005 +0800, Christopher Kings-Lynne wrote: It does impose a v7.4 and above libpq requirement, however. Chris Andi Gutmans wrote: Yeah, definitely seems like PQexecParams is the safest and easiest way of doing so. In general, I'm

Re: [PHP-CVS] cvs: php-src / NEWS /ext/ldap ldap.c

2005-07-08 Thread Andi Gutmans
Why do you need to convert_to_string_ex() if entry is a string? Should that be !=? At 12:46 AM 7/9/2005 +, Jani Taskinen wrote: + /* If anything else than string is passed, ldap_base_dn = NULL */ + if (Z_TYPE_PP(entry) == IS_STRING

[PHP-CVS] cvs: php-src / configure.in /main php_version.h ZendEngine2 zend.h

2005-07-12 Thread Andi Gutmans
andiTue Jul 12 15:59:53 2005 EDT Modified files: /php-srcconfigure.in /ZendEngine2zend.h /php-src/main php_version.h Log: - Beta 3 http://cvs.php.net/diff.php/php-src/configure.in?r1=1.570&r2=1.571&ty=u Index: php-src/configure

[PHP-CVS] cvs: php-src / configure.in /main php_version.h ZendEngine2 zend.h

2005-07-12 Thread Andi Gutmans
andiTue Jul 12 16:25:28 2005 EDT Modified files: /php-srcconfigure.in /ZendEngine2zend.h /php-src/main php_version.h Log: - Back to -dev http://cvs.php.net/diff.php/php-src/configure.in?r1=1.571&r2=1.572&ty=u Index: php-src/con

[PHP-CVS] cvs: php-src / NEWS

2005-07-12 Thread Andi Gutmans
andiTue Jul 12 16:25:48 2005 EDT Modified files: /php-srcNEWS Log: - Update News http://cvs.php.net/diff.php/php-src/NEWS?r1=1.1993&r2=1.1994&ty=u Index: php-src/NEWS diff -u php-src/NEWS:1.1993 php-src/NEWS:1.1994 --- php-src/NEWS:1.1993 Tue Jul 12 1

Re: [PHP-CVS] cvs: php-src / NEWS

2005-07-12 Thread Andi Gutmans
Hmm, I wonder where I got that from :) Good catch. At 10:33 PM 7/12/2005 +0200, Derick Rethans wrote: On Tue, 12 Jul 2005, Andi Gutmans wrote: > http://cvs.php.net/diff.php/php-src/NEWS?r1=1.1993&r2=1.1994&ty=u > Index: php-src/NEWS > diff -u php-src/NEWS:1.1993 php-src/NEWS

[PHP-CVS] cvs: php-src / NEWS

2005-07-12 Thread Andi Gutmans
andiTue Jul 12 16:40:11 2005 EDT Modified files: /php-srcNEWS Log: - Update Beta 3 date http://cvs.php.net/diff.php/php-src/NEWS?r1=1.1994&r2=1.1995&ty=u Index: php-src/NEWS diff -u php-src/NEWS:1.1994 php-src/NEWS:1.1995 --- php-src/NEWS:1.1994 Tue J

Re: [PHP-CVS] cvs: php-src /ext/mysqli mysqli_fe.c php_mysqli.h

2005-07-12 Thread Andi Gutmans
Is this a critical patch to include in Beta 3? Andi At 08:38 PM 7/12/2005 +, Antony Dovgal wrote: tony2001Tue Jul 12 16:38:35 2005 EDT Modified files: /php-src/ext/mysqli mysqli_fe.c php_mysqli.h Log: add forgotten ifdefs, fix #33667 (mysqli doesn't compile) htt

Re: [PHP-CVS] cvs: php-src /ext/mysqli mysqli_fe.c php_mysqli.h

2005-07-12 Thread Andi Gutmans
OK good. I'll reroll. Thanks. Andi At 12:50 AM 7/13/2005 +0400, Antony Dovgal wrote: On Tue, 12 Jul 2005 13:43:39 -0700 Andi Gutmans <[EMAIL PROTECTED]> wrote: > Is this a critical patch to include in Beta 3? Yes, as ext/mysqli just doesn't compile without these ifdefs

  1   2   3   4   5   >