Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /ext/session session.c

2002-10-06 Thread Andi Gutmans
Please use sizeof(sid) and not 4 in such code. Also, why use hash_find() if just calling hash_del() would work? Andi At 12:05 AM 9/27/2002 +0200, Markus Fischer wrote: Guys, _Please_ include bug fixes in NEWS entries (or separately commit them) so we've complete log.

[PHP-DEV] Re: [PHP-CVS] cvs: php4 /ext/session session.c

2002-09-26 Thread Markus Fischer
Guys, _Please_ include bug fixes in NEWS entries (or separately commit them) so we've complete log. Browsing back the ChangeLog and finding missing treasures ain't that funny. ;) thanks, - Markus On Thu, Sep 26, 2002 at 06:12:27PM -, Ilia Alshanetsky

[PHP-DEV] Re: [PHP-CVS] cvs: php4 /ext/session session.c

2002-05-03 Thread Sebastian Bergmann
Sebastian Bergmann wrote: sebastian Fri May 3 04:10:49 2002 EDT Modified files: /php4/ext/session session.c Log: Fix ZTS build. This fixes the ZTS build not completely, I get some errors in the .re file(s) as well, but I don't dare touching there, so ... :-)

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /ext/session session.c

2002-05-03 Thread Thies C. Arntzen
On Fri, May 03, 2002 at 10:21:44AM +0200, Sebastian Bergmann wrote: Sebastian Bergmann wrote: sebastian Fri May 3 04:10:49 2002 EDT Modified files: /php4/ext/session session.c Log: Fix ZTS build. This fixes the ZTS build not completely, I get some

[PHP-DEV] Re: [PHP-CVS] cvs: php4 /ext/session session.c

2002-01-06 Thread Yasuo Ohgaki
[EMAIL PROTECTED] wrote: On Thu, 3 Jan 2002, Yasuo Ohgaki wrote: Which is perfectly fine as it is IMO. What is the change here that you suggest exactly? - Do not use php_session_register_module() - Add #ifdef to ps_modules struct for external save handler modules You want to add

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /ext/session session.c

2002-01-06 Thread Yasuo Ohgaki
Mlwmohawk wrote: On Wednesday 02 January 2002 04:37 pm, Yasuo Ohgaki wrote: Yasuo Ohgaki wrote: BTW, if I fix the issue with 3), I have to change msession a line so that it does not register it as session save handler. (handler is registered by #ifdef) I have to move pgsql session save

[PHP-DEV] Re: [PHP-CVS] cvs: php4 /ext/session session.c

2002-01-02 Thread Yasuo Ohgaki
Yasuo Ohgaki wrote: [EMAIL PROTECTED] wrote: On Sun, 30 Dec 2001, Yasuo Ohgaki wrote: yohgakiSat Dec 29 20:37:24 2001 EDT Modified files: /php4/ext/sessionsession.c Log: Get rid of error message # These lines should be enabled when save handlers can be initialized

[PHP-DEV] Re: [PHP-CVS] cvs: php4 /ext/session session.c

2002-01-02 Thread Yasuo Ohgaki
Derick Rethans wrote: On Thu, 3 Jan 2002, Yasuo Ohgaki wrote: BTW, if I fix the issue with 3), I have to change msession a line so that it does not register it as session save handler. (handler is registered by #ifdef) Which is perfectly fine as it is IMO. What is the change here that

[PHP-DEV] Re: [PHP-CVS] cvs: php4 /ext/session session.c

2002-01-02 Thread Yasuo Ohgaki
BTW, the reason why 4.0.6 or older do not have problems are session module was normal module. From 4.1.0, session module is internal module and initialized before save handlers. Yasuo Ohgaki wrote: Derick Rethans wrote: On Thu, 3 Jan 2002, Yasuo Ohgaki wrote: BTW, if I fix the issue with

[PHP-DEV] Re: [PHP-CVS] cvs: php4 /ext/session session.c

2002-01-02 Thread derick
On Thu, 3 Jan 2002, Yasuo Ohgaki wrote: Which is perfectly fine as it is IMO. What is the change here that you suggest exactly? - Do not use php_session_register_module() - Add #ifdef to ps_modules struct for external save handler modules You want to add the pgsql module here too

[PHP-DEV] Re: [PHP-CVS] cvs: php4 /ext/session session.c

2001-12-30 Thread derick
On Sun, 30 Dec 2001, Yasuo Ohgaki wrote: yohgaki Sat Dec 29 20:37:24 2001 EDT Modified files: /php4/ext/session session.c Log: Get rid of error message # These lines should be enabled when save handlers can be initialized # before session module

[PHP-DEV] Re: [PHP-CVS] cvs: php4 /ext/session session.c

2001-12-30 Thread Yasuo Ohgaki
[EMAIL PROTECTED] wrote: On Sun, 30 Dec 2001, Yasuo Ohgaki wrote: yohgaki Sat Dec 29 20:37:24 2001 EDT Modified files: /php4/ext/session session.c Log: Get rid of error message # These lines should be enabled when save handlers can be initialized # before