Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /main output.c

2002-10-03 Thread Yasuo Ohgaki
Zeev Suraski wrote: > At 13:26 03/10/2002, Yasuo Ohgaki wrote: > >> It may not flush as user expected. It is depends on how each buffers >> treat data. For instance, a handler may need 1024 bytes before output >> anything. > > > I'm not sure what you're talking about really. implicit_flush sho

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /main output.c

2002-10-03 Thread Jon Parise
On Thu, Oct 03, 2002 at 08:05:51PM +0900, Yasuo Ohgaki wrote: > >Can you please re-test things regarding to this? I reverted Yasuo's > >commits and I might have overlooked something. > > What kind of diff you are using? > I guess you are willing to revert my patches, but you don't. > > BTW, st

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /main output.c

2002-10-03 Thread Zeev Suraski
At 13:26 03/10/2002, Yasuo Ohgaki wrote: >It may not flush as user expected. It is depends on how each buffers >treat data. For instance, a handler may need 1024 bytes before output >anything. I'm not sure what you're talking about really. implicit_flush should effect ONLY what happens in the u

[PHP-DEV] Re: [PHP-CVS] cvs: php4 /main output.c

2002-10-03 Thread Yasuo Ohgaki
Derick Rethans wrote: > On Wed, 2 Oct 2002, Marcus Börger wrote: > > >>helly Wed Oct 2 11:10:11 2002 EDT >> >> Modified files: >>/php4/mainoutput.c >> Log: >> Modified get_status(): Display chunk_size allways and size which is in >> most cases initial_size

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /main output.c

2002-10-03 Thread Yasuo Ohgaki
Sebastian Bergmann wrote: > Yasuo Ohgaki wrote: > >>Anyway, I'm not big fun of implicit flush and removing the feature >>is ok to me, too. > > > Do you actually read what other people post about this on php-dev? > Do you actually know how it is working? Try some with current code. Let me k

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /main output.c

2002-10-03 Thread Sebastian Bergmann
Yasuo Ohgaki wrote: > Anyway, I'm not big fun of implicit flush and removing the feature > is ok to me, too. Do you actually read what other people post about this on php-dev? -- Sebastian Bergmann http://sebastian-bergmann.de/ http://phpOpenTracker.de/ Did I help you?

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /main output.c

2002-10-03 Thread Yasuo Ohgaki
Zeev Suraski wrote: >> implicit_flush in php.ini only for debugging. >> It may do something unwanted thing in your script, but >> this is original design. > > > As the one who introduced implicit_flush, no, it is not the original > design at all. It's not something for debugging only, but also

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /main output.c

2002-10-03 Thread Zeev Suraski
At 12:48 03/10/2002, Yasuo Ohgaki wrote: >Zeev Suraski wrote: >>But it does not seem as if you fixed it properly. I don't see how >>implicit flush can be at all related to output buffering. If it was, it >>should have been trivial to fix it, at a centralized place. You appear >>to be adding

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /main output.c

2002-10-03 Thread Yasuo Ohgaki
Zeev Suraski wrote: > But it does not seem as if you fixed it properly. I don't see how > implicit flush can be at all related to output buffering. If it was, it > should have been trivial to fix it, at a centralized place. You appear > to be adding code all over the codebase, and as far as

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /main output.c

2002-10-03 Thread Zeev Suraski
At 12:13 03/10/2002, Yasuo Ohgaki wrote: >Sebastian Bergmann wrote: >>Zeev Suraski wrote: >> >>>That's the desired behavior, please make sure you did not deviate from >>>it. >> >> He deviated from it. >> Functions like highlight_string() or var_export() currently don't work >> with implicit_

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /main output.c

2002-10-03 Thread Yasuo Ohgaki
Sebastian Bergmann wrote: > Zeev Suraski wrote: > >>That's the desired behavior, please make sure you did not deviate from >>it. > > > He deviated from it. > > Functions like highlight_string() or var_export() currently don't work > with implicit_flush enabled. Guys, implicit flush fea

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /main output.c

2002-10-03 Thread Yasuo Ohgaki
Derick Rethans wrote: > On Thu, 3 Oct 2002, Yasuo Ohgaki wrote: > > >>You are the one used unexported php_ob_* function in var.c :) >>I'll fix var.c, then. > > > No, don't. These functions were meant to be exported, see this chat log > with Zeev from around the time I implemented the function

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /main output.c

2002-10-03 Thread Sebastian Bergmann
Zeev Suraski wrote: > That's the desired behavior, please make sure you did not deviate from > it. He deviated from it. Functions like highlight_string() or var_export() currently don't work with implicit_flush enabled. -- Sebastian Bergmann http://sebastian-bergmann.de/

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /main output.c

2002-10-03 Thread Zeev Suraski
Yasuo, Implicit flush has nothing to do with the PHP-level output buffering layers. Implicit flush only means that the server-specific flush function should be called whenever output is being written using the server-specific output function. As long as you're not calling the server-specific

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /main output.c

2002-10-03 Thread Derick Rethans
On Thu, 3 Oct 2002, Yasuo Ohgaki wrote: > You are the one used unexported php_ob_* function in var.c :) > I'll fix var.c, then. No, don't. These functions were meant to be exported, see this chat log with Zeev from around the time I implemented the function: php.bugs-2001-12-15: 15:03 <@Deric

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /main output.c

2002-10-03 Thread Yasuo Ohgaki
You are the one used unexported php_ob_* function in var.c :) I'll fix var.c, then. -- Yasuo Ohgaki Derick Rethans wrote: > On Thu, 3 Oct 2002, Yasuo Ohgaki wrote: > > >>A little history. When 4.1.0 (or 4.2.0?) is released, I've fixed >>crush with deleting wrong buffer with implicit flush. Th

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /main output.c

2002-10-03 Thread Edin Kadribasic
On Thursday 03 October 2002 09:14, Derick Rethans wrote: [snip] > (While it should not have dumped the contents at all). Please revert > this, as this breaks backward compability BIG time, and IMO this is not > a shortcoming of CLI. BTW, where did you get that implicit_flush should > disable all o

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /main output.c

2002-10-02 Thread Derick Rethans
On Thu, 3 Oct 2002, Yasuo Ohgaki wrote: > A little history. When 4.1.0 (or 4.2.0?) is released, I've fixed > crush with deleting wrong buffer with implicit flush. The fix > disabled implicit flush. > > I finally fixed implicit flush. Users should worry about > implicit flush directive in php.ini

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /main output.c

2002-10-02 Thread Yasuo Ohgaki
Alan Knowles wrote: > Yasuo Ohgaki wrote: >> A little history. When 4.1.0 (or 4.2.0?) is released, I've fixed >> crush with deleting wrong buffer with implicit flush. The fix >> disabled implicit flush. >> >> I finally fixed implicit flush. Users should worry about >> implicit flush directive in p

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /main output.c

2002-10-02 Thread Alan Knowles
Yasuo Ohgaki wrote: > Sebastian Bergmann wrote: > >> Yasuo Ohgaki wrote: >> >>> yohgaki Mon Sep 30 22:43:33 2002 EDT >>> >>> Modified files: >>>/php4/main output.c >>> Log: >>> Fixed implicit flush. >> >> >> >> This commit broke my script, that I mentioned before, again. It now

[PHP-DEV] Re: [PHP-CVS] cvs: php4 /main output.c

2002-10-02 Thread Yasuo Ohgaki
Yasuo Ohgaki wrote: > A little history. When 4.1.0 (or 4.2.0?) is released, I've fixed > crush with deleting wrong buffer with implicit flush. The fix > disabled implicit flush. > > I finally fixed implicit flush. Users should worry about > implicit flush directive in php.ini now. e.g. implicit_f

[PHP-DEV] Re: [PHP-CVS] cvs: php4 /main output.c

2002-10-02 Thread Yasuo Ohgaki
Sebastian Bergmann wrote: > Yasuo Ohgaki wrote: > >>yohgaki Mon Sep 30 22:43:33 2002 EDT >> >> Modified files: >>/php4/main output.c >> Log: >> Fixed implicit flush. > > > This commit broke my script, that I mentioned before, again. It now > dumps the contents of a variable

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /main output.c

2002-10-02 Thread Marcus Börger
At 15:45 02.10.2002, Sebastian Bergmann wrote: >Yasuo Ohgaki wrote: > > yohgaki Mon Sep 30 22:43:33 2002 EDT > > > > Modified files: > > /php4/main output.c > > Log: > > Fixed implicit flush. > > This commit broke my script, that I mentioned before, again. It now > dumps the

[PHP-DEV] Re: [PHP-CVS] cvs: php4 /main output.c

2002-10-02 Thread Sebastian Bergmann
Yasuo Ohgaki wrote: > yohgaki Mon Sep 30 22:43:33 2002 EDT > > Modified files: > /php4/main output.c > Log: > Fixed implicit flush. This commit broke my script, that I mentioned before, again. It now dumps the contents of a variable to stdout instead of writing it to a fi

[PHP-DEV] Re: [PHP-CVS] cvs: php4 /main output.c

2002-09-23 Thread Sebastian Bergmann
Zeev Suraski wrote: > zeevMon Sep 23 10:18:43 2002 EDT > > Modified files: > /php4/main output.c > Log: > Fix bug #19525 echo 'test'; now prints in HEAD Cannot use output buffering in output buffering display handlers as it already does in the 4.2.3 rele