Re: [PHP-WEBMASTER] Coding Standard for https://github.com/php/web-php

2022-06-27 Thread Paul Dragoonis
On Mon, 27 Jun 2022, 17:22 Andreas Möller, wrote: > > > What do others think about introducing PHP_CodeSniffer[1] or > > PHP-CS-Fixer[2] with a suitable coding standard, which could be the PER > > Coding Style[3]. > > > > [1] > > [2]

[PHP-WEBMASTER] [web-php] PR #567: Redesign Docs.php

2022-06-27 Thread kamil-tekiela
Pull Request: https://github.com/php/web-php/pull/567 Author: kamil-tekiela The information about PHP 4 & 5 docs while still useful can be moved to "more documentation" section where it belongs more. The information about URL wasn't grammatically correct IMHO and also kind of out of place wher

Re: [PHP-WEBMASTER] Re: Production environment, PHP 7.2 vs PHP 8.1

2022-06-27 Thread Paul Dragoonis
On Mon, 27 Jun 2022, 18:24 Christoph M. Becker, wrote: > On 27.06.2022 at 18:26, Andreas Möller wrote: > > > README.md (see https://github.com/php/web-php#code-requirements < > https://github.com/php/web-php#code-requirements>) suggests that the > production environment is currently running PHP 7

[PHP-WEBMASTER] [web-php] PR #560: Drop useless documentation table

2022-06-27 Thread cmb69
Pull Request: https://github.com/php/web-php/pull/560 Closed by cmb69. -- PHP Webmaster List Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-WEBMASTER] [web-php] master: Drop useless documentation table

2022-06-27 Thread Christoph M. Becker via GitHub
Author: Christoph M. Becker (cmb69) Committer: GitHub (web-flow) Pusher: cmb69 Date: 2022-06-27T23:55:23+02:00 Commit: https://github.com/php/web-php/commit/cc81e8e340f1ad6380e192db47a094c1457d7cd8 Raw diff: https://github.com/php/web-php/commit/cc81e8e340f1ad6380e192db47a094c1457d7cd8.diff Dro

[PHP-WEBMASTER] [web-php] PR #550: No useless return

2022-06-27 Thread kamil-tekiela
Pull Request: https://github.com/php/web-php/pull/550 Closed by kamil-tekiela. -- PHP Webmaster List Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-WEBMASTER] [web-php] master: Remove fetch_contents and fetch_header (#566)

2022-06-27 Thread Kamil Tekiela via GitHub
Author: Kamil Tekiela (kamil-tekiela) Committer: GitHub (web-flow) Pusher: kamil-tekiela Date: 2022-06-27T22:49:22+01:00 Commit: https://github.com/php/web-php/commit/a6c79eca2e43faedb65cbe1ccb7a376ccb179fe4 Raw diff: https://github.com/php/web-php/commit/a6c79eca2e43faedb65cbe1ccb7a376ccb179fe4

[PHP-WEBMASTER] [web-php] PR #566: Remove fetch_contents and fetch_header

2022-06-27 Thread kamil-tekiela
Pull Request: https://github.com/php/web-php/pull/566 Closed by kamil-tekiela. -- PHP Webmaster List Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-WEBMASTER] [web-php] master: Fix: Remove useless function

2022-06-27 Thread Andreas Möller via GitHub
Author: Andreas Möller (localheinz) Committer: GitHub (web-flow) Pusher: cmb69 Date: 2022-06-27T23:41:53+02:00 Commit: https://github.com/php/web-php/commit/139d12d908d05007ba80d434b339bca47e528158 Raw diff: https://github.com/php/web-php/commit/139d12d908d05007ba80d434b339bca47e528158.diff Fix

[PHP-WEBMASTER] [web-php] PR #562: Fix: Remove useless function

2022-06-27 Thread cmb69
Pull Request: https://github.com/php/web-php/pull/562 Closed by cmb69. -- PHP Webmaster List Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-WEBMASTER] [web-php] PR #566: Remove fetch_contents and fetch_header

2022-06-27 Thread kamil-tekiela
Pull Request: https://github.com/php/web-php/pull/566 Author: kamil-tekiela Removed unused functions that were full of errors. -- PHP Webmaster List Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-WEBMASTER] [web-php] PR #565: Fix: Remove duplicate key-value pairs

2022-06-27 Thread kamil-tekiela
Pull Request: https://github.com/php/web-php/pull/565 Closed by kamil-tekiela. -- PHP Webmaster List Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-WEBMASTER] [web-php] master: Fix: Remove duplicate key-value pairs (#565)

2022-06-27 Thread Andreas Möller via GitHub
Author: Andreas Möller (localheinz) Committer: GitHub (web-flow) Pusher: kamil-tekiela Date: 2022-06-27T21:06:30+01:00 Commit: https://github.com/php/web-php/commit/e5ad28094f7aca291074f49858d8a5b9942251c3 Raw diff: https://github.com/php/web-php/commit/e5ad28094f7aca291074f49858d8a5b9942251c3.d

[PHP-WEBMASTER] [web-php] PR #565: Fix: Remove duplicate key-value pairs

2022-06-27 Thread localheinz
Pull Request: https://github.com/php/web-php/pull/565 Author: localheinz This pull request - [x] removes duplicate key-value pairs from an array -- PHP Webmaster List Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-WEBMASTER] [web-php] PR #564: Fix: Heredoc syntax

2022-06-27 Thread localheinz
Pull Request: https://github.com/php/web-php/pull/564 Author: localheinz This pull request - [x] fixes heredoc syntax issues -- PHP Webmaster List Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-WEBMASTER] [web-php] master: Fix: Remove unused private property (#561)

2022-06-27 Thread Andreas Möller via GitHub
Author: Andreas Möller (localheinz) Committer: GitHub (web-flow) Pusher: kamil-tekiela Date: 2022-06-27T19:24:21+01:00 Commit: https://github.com/php/web-php/commit/8fbbe3bb896b3e93a745f4938dee97fc337a4ecd Raw diff: https://github.com/php/web-php/commit/8fbbe3bb896b3e93a745f4938dee97fc337a4ecd.d

[PHP-WEBMASTER] [web-php] PR #561: Fix: Remove unused `private` property

2022-06-27 Thread kamil-tekiela
Pull Request: https://github.com/php/web-php/pull/561 Closed by kamil-tekiela. -- PHP Webmaster List Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-WEBMASTER] [web-php] PR #563: Fix: Remove unused references to a global variable

2022-06-27 Thread localheinz
Pull Request: https://github.com/php/web-php/pull/563 Author: localheinz This pull request - [x] removes unused references to the global variable `$MYSITE` -- PHP Webmaster List Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-WEBMASTER] [web-php] PR #562: Fix: Remove useless function

2022-06-27 Thread localheinz
Pull Request: https://github.com/php/web-php/pull/562 Author: localheinz This pull request - [x] removes the useless function `language_redirect()` -- PHP Webmaster List Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-WEBMASTER] [web-php] PR #561: Fix: Remove unused private property

2022-06-27 Thread localheinz
Pull Request: https://github.com/php/web-php/pull/561 Author: localheinz This pull request - [x] removes an unused `private` property 💁‍♂️ Running ```shell git grep -i ratingFactor ``` on current `master` yields ``` include/shared-manual.inc:34:private $ratingFactor; ``` -- PHP Webmaste

[PHP-WEBMASTER] [web-php] PR #560: Drop useless documentation table

2022-06-27 Thread cmb69
Pull Request: https://github.com/php/web-php/pull/560 Author: cmb69 -- PHP Webmaster List Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-WEBMASTER] [web-php] master: Enhancement: Add .editorconfig

2022-06-27 Thread Andreas Möller via GitHub
Author: Andreas Möller (localheinz) Committer: GitHub (web-flow) Pusher: cmb69 Date: 2022-06-27T19:15:41+02:00 Commit: https://github.com/php/web-php/commit/51b196dff8c3f56ac14592d4d7945ee87d9dcf3d Raw diff: https://github.com/php/web-php/commit/51b196dff8c3f56ac14592d4d7945ee87d9dcf3d.diff Enh

[PHP-WEBMASTER] Re: Production environment, PHP 7.2 vs PHP 8.1

2022-06-27 Thread Christoph M. Becker
On 27.06.2022 at 18:26, Andreas Möller wrote: > README.md (see https://github.com/php/web-php#code-requirements > ) suggests that the > production environment is currently running PHP 7.2. > > I have three questions: > > - What are the reasons fo

[PHP-WEBMASTER] [web-php] PR #554: Enhancement: Add `.editorconfig`

2022-06-27 Thread cmb69
Pull Request: https://github.com/php/web-php/pull/554 Closed by cmb69. -- PHP Webmaster List Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-WEBMASTER] Production environment, PHP 7.2 vs PHP 8.1

2022-06-27 Thread Andreas Möller
README.md (see https://github.com/php/web-php#code-requirements ) suggests that the production environment is currently running PHP 7.2. I have three questions: - What are the reasons for running PHP 7.2 in production when PHP 7.2 has been unsu

Re: [PHP-WEBMASTER] Coding Standard for https://github.com/php/web-php

2022-06-27 Thread Andreas Möller
> What do others think about introducing PHP_CodeSniffer[1] or > PHP-CS-Fixer[2] with a suitable coding standard, which could be the PER > Coding Style[3]. > > [1] > [2] To get the ball rolling, I have

[PHP-WEBMASTER] [web-php] PR #559: Enhancement: Run friendsofphp/php-cs-fixer on GitHub Actions

2022-06-27 Thread localheinz
Pull Request: https://github.com/php/web-php/pull/559 Author: localheinz This pull request - [x] runs `friendsofphp/php-cs-fixer` on GitHub Actions 💁‍♂️ To get the ball rolling, here is a proposal for running `friendsofphp/php-cs-fixer` to enforce a coding standard on GitHub Actions. To see th

[PHP-WEBMASTER] [web-php] PR #558: Fix: Remove superfluous note

2022-06-27 Thread cmb69
Pull Request: https://github.com/php/web-php/pull/558 Closed by cmb69. -- PHP Webmaster List Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-WEBMASTER] [web-php] master: Remove superfluous note

2022-06-27 Thread Andreas Möller via GitHub
Author: Andreas Möller (localheinz) Committer: GitHub (web-flow) Pusher: cmb69 Date: 2022-06-27T16:13:23+02:00 Commit: https://github.com/php/web-php/commit/c40cac09f2b7d50e191ab6d474cf015032068e0a Raw diff: https://github.com/php/web-php/commit/c40cac09f2b7d50e191ab6d474cf015032068e0a.diff Rem

[PHP-WEBMASTER] [web-pres2] PR: #6 redesing of the whole page

2022-06-27 Thread Aaron Junker
Hi all As PRs in the Web-Pres2 repo don't get announced in this mail list I will do it manually: PR #6 opened by: aaron-junker: https://github.com/php/web-pres2/pull/6 Best regards Aaron Junker -- PHP Webmaster List Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/u

[PHP-WEBMASTER] [web-php] PR #557: Fix: Do not use `vertical-align: middle` for table cells

2022-06-27 Thread localheinz
Pull Request: https://github.com/php/web-php/pull/557 Author: localheinz This pull - [x] stops overriding the default `vertical-align: top` with `vertical-align :middle` for table cells -- PHP Webmaster List Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-WEBMASTER] Re: Coding Standard for https://github.com/php/web-php

2022-06-27 Thread Christoph M. Becker
On 17.06.2022 at 16:45, Andreas Möller wrote: > As pull requests suggesting coding standard changes have been opened in the > past (see https://github.com/php/web-php/pull/196 > ) and more recently (see > https://github.com/php/web-php/pulls/MathiasReker

[PHP-WEBMASTER] [web-php] PR #558: Fix: Remove superfluous note

2022-06-27 Thread localheinz
Pull Request: https://github.com/php/web-php/pull/558 Author: localheinz This pull request - [x] removes a superfluous note Slightly related to #499. 💁‍♂️ If we were consistent, we would have two options: - add a similar note to all other major versions that are end of life - remove this note