Re: [PHP-DOC] Patch to Add AMQP Examples

2011-08-26 Thread Bradley Holt
On Thu, Aug 25, 2011 at 8:35 PM, Philip Olson wrote: > > On Aug 25, 2011, at 11:14 AM, Bradley Holt wrote: > >> Hi, >> >> Attached is a patch to add examples to the documentation for >> AMQPQueue::get and AMQPQueue::ack. > > > Hello Bradley, > > Looks good. A few minor issues: > >  - Use for all

Re: [PHP-DOC] Patch to Add AMQP Examples

2011-08-26 Thread Peter Cowburn
On 26 August 2011 17:05, Bradley Holt wrote: > Philip, > > On Thu, Aug 25, 2011 at 8:35 PM, Philip Olson wrote: >> >> On Aug 25, 2011, at 11:14 AM, Bradley Holt wrote: >> >>> Hi, >>> >>> Attached is a patch to add examples to the documentation for >>> AMQPQueue::get and AMQPQueue::ack. >> >> >> H

Re: [PHP-DOC] Patch to Add AMQP Examples

2011-08-26 Thread Bradley Holt
Philip, On Thu, Aug 25, 2011 at 8:35 PM, Philip Olson wrote: > > On Aug 25, 2011, at 11:14 AM, Bradley Holt wrote: > >> Hi, >> >> Attached is a patch to add examples to the documentation for >> AMQPQueue::get and AMQPQueue::ack. > > > Hello Bradley, > > Looks good. A few minor issues: > >  - Use

Re: [PHP-DOC] Patch to Add AMQP Examples

2011-08-25 Thread Philip Olson
On Aug 25, 2011, at 11:14 AM, Bradley Holt wrote: > Hi, > > Attached is a patch to add examples to the documentation for > AMQPQueue::get and AMQPQueue::ack. Hello Bradley, Looks good. A few minor issues: - Use for all methods. Sometimes you used . Both work but, well, I did say "minor

Re: [PHP-DOC] Patch to Add AMQP Examples

2011-08-25 Thread Bradley Holt
On Thu, Aug 25, 2011 at 4:31 PM, Peter Cowburn wrote: > Hi Bradley, > > On 25 August 2011 19:14, Bradley Holt wrote: >> Hi, >> >> Attached is a patch to add examples to the documentation for >> AMQPQueue::get and AMQPQueue::ack. > > Would you mind attaching future patches as .txt files? Gmail let

Re: [PHP-DOC] Patch to Add AMQP Examples

2011-08-25 Thread Peter Cowburn
Hi Bradley, On 25 August 2011 19:14, Bradley Holt wrote: > Hi, > > Attached is a patch to add examples to the documentation for > AMQPQueue::get and AMQPQueue::ack. Would you mind attaching future patches as .txt files? Gmail lets me view those in the browser, but requires me to download .patch

[PHP-DOC] Patch to Add AMQP Examples

2011-08-25 Thread Bradley Holt
Hi, Attached is a patch to add examples to the documentation for AMQPQueue::get and AMQPQueue::ack. Thanks, Bradley amqp-examples.patch Description: Binary data