[Piglit] [PATCH] glean/texunits: Initialize TexUnitsTest member variables.

2012-12-17 Thread Vinson Lee
Fixes uninitialized scalar field defect reported by Coverity. Signed-off-by: Vinson Lee --- tests/glean/ttexunits.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tests/glean/ttexunits.h b/tests/glean/ttexunits.h index 436f857..6997960 100644 --- a/tests/glean/ttexunits

[Piglit] [PATCH] glean/vertprog1: Initialize VertexProgramTest member variables.

2012-12-17 Thread Vinson Lee
Fixes uninitialized scalar field defect reported by Coverity. Signed-off-by: Vinson Lee --- tests/glean/tvertprog1.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/glean/tvertprog1.h b/tests/glean/tvertprog1.h index 429692f..1c80406 100644 --- a/tests/glean/tvertpro

[Piglit] [PATCH] Only specify -cl-std when test hasn't explicitly overridden -cl-std (v2)

2012-12-17 Thread Aaron Watry
The previous code would always add -cl-std if the version was > 1.0. This ignored whatever the test itself wanted (e.g. the invalid-version-declaration test). We should probably only add " -cl-std=x.y" when the test hasn't requested a specific version. Note: This doesn't address the rewrite of the

[Piglit] [PATCH 1/1] gles3: use _${piglit_target_api} for testcase names

2012-12-17 Thread Tom Gall
Use _${piglit_target_api} as the suffix of testcase binaries to to be consistant across piglit as suggested by Chad Versace. Signed-off-by: Tom Gall --- tests/all.tests |2 +- tests/spec/gles-3.0/CMakeLists.gles3.txt |2 +- 2 files changed, 2 insertions(+), 2 d

[Piglit] [PATCH 5/5] gles2: add gles2-invalid-es3-queries to all.tests

2012-12-17 Thread Tom Gall
Signed-off-by: Tom Gall --- tests/all.tests |1 + 1 file changed, 1 insertion(+) diff --git a/tests/all.tests b/tests/all.tests index fad2b09..99bcc97 100644 --- a/tests/all.tests +++ b/tests/all.tests @@ -2675,6 +2675,7 @@ gles20['sanity-test_gles2'] = PlainExecTest(['sanity-test_gles2',

[Piglit] [PATCH 4/5] gles2: add minmax test

2012-12-17 Thread Tom Gall
Add minmax test based on values that can be queried as specified in chapter 6.2 of the OpenGL ES 2.0.25 spec. Small modification to tests/util/minmax-test.* so that functions which use GLint64 and GLuint64 types aren't compiled when building for OpenGL ES2. Signed-off-by: Tom Gall --- tes

[Piglit] [PATCH 3/5] gles2: port clear-varray-2.0

2012-12-17 Thread Tom Gall
Port testcase clear-varray-2.0 from tests/general into tests/spec/gles-2.0 and update substantially for OpenGL ES 2.0. Test checks that glClear and vertex attributes via glVertexAttribPointer work correctly together. Signed-off-by: Tom Gall --- tests/all.tests |

[Piglit] [PATCH 2/5] gles2: new glReadPixels unit test

2012-12-17 Thread Tom Gall
Unit test for glReadPixels specifically for OpenGL ES 2.0. Covers a variety of formats and types, both valid and invalid. A few variations are commented out due to results that are incorrect and need to be followed up with Mesa, such as modifying the buffer even tho the format is invalid. There ar

[Piglit] [PATCH 1/5] gles2: add sanity test

2012-12-17 Thread Tom Gall
new tests/spec/gles-2.0 directory and infrastructure to build initial testcase and add gles-2.0 as part of all.tests new gles2 sanity test which very simply renders a triangle fan and validates it was rendered correctly via piglit_probe_rect_rgba Signed-off-by: Tom Gall --- tests/all.test

[Piglit] [PATCH 0/5] gles2: add gles2 tests

2012-12-17 Thread Tom Gall
In this version: Small change so testcases are named _${piglit_target_api} in CMakeLists.gles2.txt and _gles2 in all.tests Overview of patches: 0001-gles2-add-sanity-test.patch - add sanity test, matching gl sanity test 0002-gles2-new-glReadPixels-unit-test.patch - add unit test to stress glReadP

Re: [Piglit] [PATCH 1/6] glsl: gles2: add version 100

2012-12-17 Thread Tom Gall
On Mon, Dec 17, 2012 at 12:35 PM, Chad Versace wrote: > On 12/14/2012 12:01 PM, Tom Gall wrote: >> This is a small change in two parts to repair support for >> gles2 by glslparsertest. >> >> To glslparsertest.c, add 100 into the list of versions the switch >> handles when passed from the command l

[Piglit] [PATCH 3/3 v2] arb_internalformat_query: Verify minimum maximums

2012-12-17 Thread Ian Romanick
From: Ian Romanick This test passes on NVIDIA's closed-source driver (version 304.64 on GTX260). This driver supports GL_ARB_texture_multisample. This test fails on AMD's closed-source driver (Catalyst 12.6 on HD 3650). Querying GL_SRGB8_ALPHA8 (for all targets) returns {1, 0, 2}. This is inva

[Piglit] [PATCH 2/3 v2] arb_internalformat_query: Verify glGetInternalformativ doesn't over-run the buffer

2012-12-17 Thread Ian Romanick
From: Ian Romanick This test passes on NVIDIA's closed-source driver (version 304.64 on GTX 260). This test fails on AMD's closed-source driver (Catalyst 12.6 on HD 3650). Queries of GL_NUM_SAMPLE_COUNTS merrily write data even when bufSize is zero. v2: Add some comments describing the non-obv

[Piglit] [PATCH 1/3 v2] arb_internalformat_query: Add initial API error test for this extension

2012-12-17 Thread Ian Romanick
From: Ian Romanick This test passes on NVIDIA's closed-source driver (version 304.64 on GTX 260). This driver supports GL_ARB_texture_multisample, but it does not support GL_ARB_internalformat_query2. This test fails on AMD's closed-source driver (Catalyst 12.6 on HD 3650). It appears that non

Re: [Piglit] [PATCH 2/6] gles2, glsl: add gles2 support to glslparser test

2012-12-17 Thread Tom Gall
On Mon, Dec 17, 2012 at 12:54 PM, Chad Versace wrote: > On 12/14/2012 12:01 PM, Tom Gall wrote: >> Add GLSLESParserTest class which runs the gles2/gles3 >>version of glslparsertest. Why is this needed? >>The current GLSLParserTest class doesn't know about the >>gles2/gles3 varient of g

Re: [Piglit] [PATCH] piglit-dispatch: Update enumext.spec from the registry

2012-12-17 Thread Paul Berry
On 7 December 2012 08:31, Ian Romanick wrote: > From: Ian Romanick > > The most notable changes are the removal of GL_TEXTURE_BUFFER_FORMAT > (this was not prototed to core from the ARB extension), and the > addition of a giant pile of new extesions. > > Support is added to piglit_get_gl_enum_na

Re: [Piglit] [PATCH 3/6] glsl, gles2: add shader/frag tests for gles2

2012-12-17 Thread Tom Gall
On Mon, Dec 17, 2012 at 12:33 PM, Chad Versace wrote: > On 12/14/2012 12:01 PM, Tom Gall wrote: >> This is a set of trivial changes. In the appropriate set of >> tests/glslparsertests/shaders/*.frag which are targeted for >> glsl_version 1.10 or 1.20, add glsles_version: 1.00 which >> identi

Re: [Piglit] [PATCH 2/6] gles2, glsl: add gles2 support to glslparser test

2012-12-17 Thread Chad Versace
On 12/14/2012 12:01 PM, Tom Gall wrote: > Add GLSLESParserTest class which runs the gles2/gles3 >version of glslparsertest. Why is this needed? >The current GLSLParserTest class doesn't know about the >gles2/gles3 varient of glslparsertest. The versioning >of glsl_version in the con

Re: [Piglit] [PATCH 1/6] glsl: gles2: add version 100

2012-12-17 Thread Chad Versace
On 12/14/2012 12:01 PM, Tom Gall wrote: > This is a small change in two parts to repair support for > gles2 by glslparsertest. > > To glslparsertest.c, add 100 into the list of versions the switch > handles when passed from the command line instead of the default > path. Next in piglit_init when v

Re: [Piglit] [PATCH 3/6] glsl, gles2: add shader/frag tests for gles2

2012-12-17 Thread Chad Versace
On 12/14/2012 12:01 PM, Tom Gall wrote: > This is a set of trivial changes. In the appropriate set of > tests/glslparsertests/shaders/*.frag which are targeted for > glsl_version 1.10 or 1.20, add glsles_version: 1.00 which > identifies the test as appropriate for glsl es 1.0 which lines up >

[Piglit] [PATCH] Transform feedback: test buffer size change after binding.

2012-12-17 Thread Paul Berry
--- tests/all.tests| 6 + .../spec/ext_transform_feedback/CMakeLists.gl.txt | 1 + tests/spec/ext_transform_feedback/change-size.c| 320 + 3 files changed, 327 insertions(+) create mode 100644 tests/spec/ext_transform_feedback/chang

[Piglit] Fwd: [PATCH 0/6] glsl: gles2:

2012-12-17 Thread Tom Gall
Any comments on this? I'd like to think this was in keeping with what Paul Berry had in mind with his post back in May. If this set of patches it's on track, certainly would like to get it going in the right direction. Thanks -- Forwarded message -- From: Tom Gall Date: Sat, De

Re: [Piglit] [PATCH] Remove #version from variable indexing shader tests.

2012-12-17 Thread Chad Versace
On 12/17/2012 08:40 AM, Stuart Abercrombie wrote: > shader_runner will insert #version based on GLSL >=. > > Testing: same number of passes on Sandy Bridge. > > Signed-off-by: Stuart Abercrombie > Reviewed-by: Chad Versace > Reviewed-by: Tom Gall I think we've had enough discussion on this pa

[Piglit] [PATCH 5/5] gles2: add gles2-invalid-es3-queries to all.tests

2012-12-17 Thread Tom Gall
Signed-off-by: Tom Gall --- tests/all.tests |1 + 1 file changed, 1 insertion(+) diff --git a/tests/all.tests b/tests/all.tests index da67407..f0998c9 100644 --- a/tests/all.tests +++ b/tests/all.tests @@ -2675,6 +2675,7 @@ gles20['gles2-sanity-test'] = PlainExecTest(['gles2-sanity-test',

[Piglit] [PATCH 4/5] gles2: add minmax test

2012-12-17 Thread Tom Gall
Add minmax test based on values that can be queried as specified in chapter 6.2 of the OpenGL ES 2.0.25 spec. Small modification to tests/util/minmax-test.* so that functions which use GLint64 and GLuint64 types aren't compiled when building for OpenGL ES2. Signed-off-by: Tom Gall --- tes

[Piglit] [PATCH 3/5] gles2: port clear-varray-2.0

2012-12-17 Thread Tom Gall
Port testcase clear-varray-2.0 from tests/general into tests/spec/gles-2.0 and update substantially for OpenGL ES 2.0. Test checks that glClear and vertex attributes via glVertexAttribPointer work correctly together. Signed-off-by: Tom Gall --- tests/all.tests |

[Piglit] [PATCH 2/5] gles2: new glReadPixels unit test

2012-12-17 Thread Tom Gall
Unit test for glReadPixels specifically for OpenGL ES 2.0. Covers a variety of formats and types, both valid and invalid. A few variations are commented out due to results that are incorrect and need to be followed up with Mesa, such as modifying the buffer even tho the format is invalid. There ar

[Piglit] [PATCH 1/5] gles2: add sanity test

2012-12-17 Thread Tom Gall
new tests/spec/gles-2.0 directory and infrastructure to build initial testcase and add gles-2.0 as part of all.tests new gles2 sanity test which very simply renders a triangle fan and validates it was rendered correctly via piglit_probe_rect_rgba Signed-off-by: Tom Gall --- tests/all.test

[Piglit] [PATCH 0/5] gles2: add gles2 tests to tests/spec/gles-2.0

2012-12-17 Thread Tom Gall
Patches rebased to latest. Small change to remove addition of OPENGL_gles2_LIBRARY and OPENGL_egl_LIBRARY from the tests/spec/gles-2.0/CMakeLists.gles2.txt as they aren't needed. Overview of patches: 0001-gles2-add-sanity-test.patch - add sanity test, matching gl sanity test 0002-gles2-new-glReadP

Re: [Piglit] [PATCH] ext_framebuffer_multisample: Initialize Test member variables.

2012-12-17 Thread Brian Paul
On 12/16/2012 05:15 PM, Vinson Lee wrote: Fixes uninitialized scalar field defect reported by Coverity. Signed-off-by: Vinson Lee --- tests/spec/ext_framebuffer_multisample/common.cpp | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tests/spec/ext_framebuffer_multisam

Re: [Piglit] [PATCH] varying-packing-simple: Fix memory leak.

2012-12-17 Thread Brian Paul
On 12/16/2012 08:39 PM, Vinson Lee wrote: Fixes resource leak defect reported by Coverity. Signed-off-by: Vinson Lee --- tests/spec/glsl-1.10/execution/varying-packing/simple.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/spec/glsl-1.10/execution/varying-packing/simple.c b/tests

[Piglit] [RFC PATCH] KHR image from texture test

2012-12-17 Thread Abdiel Janulgue
Initial piglit test for image from texture extension. This patch-set currently tests KHR_gl_texture_2D_image functionality. I plan to incrementally add tests for cubemaps and 3D textures at some point. The test basically makes sure that we create correct multiple EGL targets from a source texture.

Re: [Piglit] [PATCH] arb_texture_buffer_object_rgb32: add support for RGB32 formats to formats test

2012-12-17 Thread Dave Airlie
>> bool test_vs; >> bool test_arb; >> - >> +bool test_rgb32; Its global - so implicitly false like test vs and test arb. Dave. ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit