[Piglit] [PATCH 4/4] glean/pointsprite: Initialize PointSpriteTest member variables.

2012-12-19 Thread Vinson Lee
Fixes uninitialized scalar field defect reported by Coverity. Signed-off-by: Vinson Lee --- tests/glean/tpointsprite.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/glean/tpointsprite.h b/tests/glean/tpointsprite.h index 089afa0..9901543 100644 --- a/tests/glean/t

[Piglit] [PATCH 2/4] glean/texenv: Initialize TexEnvTest member variable.

2012-12-19 Thread Vinson Lee
Fixes uninitialized scalar field defect reported by Coverity. Signed-off-by: Vinson Lee --- tests/glean/ttexenv.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/glean/ttexenv.h b/tests/glean/ttexenv.h index 6cf1f1e..2e50d22 100644 --- a/tests/glean/ttexenv.h +++ b/te

[Piglit] [PATCH 1/4] glean/texrect: Initialize TexRectTest member variable.

2012-12-19 Thread Vinson Lee
Fixes uninitialized scalar field defect reported by Coverity. Signed-off-by: Vinson Lee --- tests/glean/ttexrect.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/glean/ttexrect.h b/tests/glean/ttexrect.h index 5e8675b..f305585 100644 --- a/tests/glean/ttexrect.h +++

[Piglit] [PATCH 3/4] glean/texcube: Initialize TexCubeTest member variable.

2012-12-19 Thread Vinson Lee
Fixes uninitialized scalar field defect reported by Coverity. Signed-off-by: Vinson Lee --- tests/glean/ttexcube.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/glean/ttexcube.h b/tests/glean/ttexcube.h index 8ca15e3..7494022 100644 --- a/tests/glean/ttexcube.h +++

Re: [Piglit] [PATCH 1/2] Test that varyings can't be bools or structs

2012-12-19 Thread Paul Berry
On 19 December 2012 11:49, Ian Romanick wrote: > On 12/19/2012 08:30 AM, Paul Berry wrote: > > Reviewed-by: Ian Romanick > > Now for the bad news... > > In GLSL ES 3.00 and GLSL 1.50 this language changes to: > > "They can only be float, floating-point vectors, matrices, > signed or unsi

Re: [Piglit] [PATCH 2/2] Test that varying packing can pack floats, ints, and uints together.

2012-12-19 Thread Ian Romanick
On 12/19/2012 08:30 AM, Paul Berry wrote: Reviewed-by: Ian Romanick --- .../varying-packing-mixed-types.shader_test| 60 ++ 1 file changed, 60 insertions(+) create mode 100644 tests/spec/glsl-1.30/execution/varying-packing-mixed-types.shader_test diff --git

Re: [Piglit] [PATCH 1/2] Test that varyings can't be bools or structs

2012-12-19 Thread Ian Romanick
On 12/19/2012 08:30 AM, Paul Berry wrote: Reviewed-by: Ian Romanick Now for the bad news... In GLSL ES 3.00 and GLSL 1.50 this language changes to: "They can only be float, floating-point vectors, matrices, signed or unsigned integers or integer vectors, or arrays or structures of

Re: [Piglit] [PATCH 1/6] glsl: gles2: add version 100

2012-12-19 Thread Chad Versace
On 12/19/2012 11:11 AM, Eric Anholt wrote: > Chad Versace writes: > >> On 12/14/2012 12:01 PM, Tom Gall wrote: >>> This is a small change in two parts to repair support for >>> gles2 by glslparsertest. >>> >>> To glslparsertest.c, add 100 into the list of versions the switch >>> handles when pass

Re: [Piglit] [PATCH] arb_uniform_buffer_object: Add new tests for GL_MAX_UNIFORM_BLOCK_SIZE.

2012-12-19 Thread Eric Anholt
Ian Romanick writes: > On 12/18/2012 10:50 AM, Eric Anholt wrote: >> + >> +switch (target) { >> +case GL_VERTEX_SHADER: >> +asprintf(&vs_source, vs_ubo_template, vec4s); >> +asprintf(&fs_source, fs_template); > > Is asprintf universally available? I thought we ran

Re: [Piglit] [PATCH 2/3 v2] arb_internalformat_query: Verify glGetInternalformativ doesn't over-run the buffer

2012-12-19 Thread Eric Anholt
Ian Romanick writes: > From: Ian Romanick > > This test passes on NVIDIA's closed-source driver (version 304.64 on > GTX 260). > > This test fails on AMD's closed-source driver (Catalyst 12.6 on HD > 3650). Queries of GL_NUM_SAMPLE_COUNTS merrily write data even when > bufSize is zero. > > v2:

Re: [Piglit] [PATCH 1/3 v2] arb_internalformat_query: Add initial API error test for this extension

2012-12-19 Thread Eric Anholt
Ian Romanick writes: > There is some debate about whether the {RED,RG,RGB,RGBA}_SNORM formats > should be allowed or not. The spec seems to indicate that they are > valid, but implementation other than Mesa actually allows them. There ^ missing "no"? Assuming this code is the same

Re: [Piglit] [PATCH 1/6] glsl: gles2: add version 100

2012-12-19 Thread Eric Anholt
Chad Versace writes: > On 12/14/2012 12:01 PM, Tom Gall wrote: >> This is a small change in two parts to repair support for >> gles2 by glslparsertest. >> >> To glslparsertest.c, add 100 into the list of versions the switch >> handles when passed from the command line instead of the default >> p

Re: [Piglit] [PATCH 4/5] gles2: add minmax test

2012-12-19 Thread Eric Anholt
Tom Gall writes: > Add minmax test based on values that can be queried as specified > in chapter 6.2 of the OpenGL ES 2.0.25 spec. This is a test I do want to see in piglit for sure. > Small modification to tests/util/minmax-test.* so that functions > which use GLint64 and GLuint64 types ar

Re: [Piglit] [PATCH 1/5] gles2: add sanity test

2012-12-19 Thread Eric Anholt
Tom Gall writes: > new tests/spec/gles-2.0 directory and infrastructure to build > initial testcase and add gles-2.0 as part of all.tests > > new gles2 sanity test which very simply renders a triangle fan and > validates it was rendered correctly via > piglit_probe_rect_rgba Given that the

[Piglit] [PATCH 2/2] Test that varying packing can pack floats, ints, and uints together.

2012-12-19 Thread Paul Berry
--- .../varying-packing-mixed-types.shader_test| 60 ++ 1 file changed, 60 insertions(+) create mode 100644 tests/spec/glsl-1.30/execution/varying-packing-mixed-types.shader_test diff --git a/tests/spec/glsl-1.30/execution/varying-packing-mixed-types.shader_test b/

[Piglit] [PATCH 1/2] Test that varyings can't be bools or structs

2012-12-19 Thread Paul Berry
--- .../qualifiers/varying-bool-prohibited.frag| 20 +++ .../qualifiers/varying-bool-prohibited.vert| 21 .../qualifiers/varying-bvec2-prohibited.frag | 20 +++ .../qualifiers/varying-bvec2-prohibited.vert | 21 ++

[Piglit] [PATCH 6/6] glsl, gles2: add glsl2/frag tests for gles2

2012-12-19 Thread Tom Gall
This is a set of trivial changes. In the appropriate set of tests/glslparsertests/glsl2/*.frag which are targeted for glsl_version 1.10 or 1.20, add glsles_version: 1.00 which identifies the test as appropriate for glsl es 1.0 which lines up with gles2. Signed-off-by: Tom Gall --- tests/glslpars

[Piglit] [PATCH 4/6] glsl, gles2: add shader/vert tests for gles2

2012-12-19 Thread Tom Gall
This is a set of trivial changes. In the appropriate set of tests/glslparsertests/shaders/*.vert which are targeted for glsl_version 1.10 or 1.20, add glsles_version: 1.00 which identifies the test as also appropriate for glsl es 1.0. Signed-off-by: Tom Gall --- tests/glslparsertest/shaders/Corr

[Piglit] [PATCH 2/6] gles2, glsl: add gles2 support to glslparser test

2012-12-19 Thread Tom Gall
Add GLSLESParserTest class which runs the gles2/gles3 version of glslparsertest. Why is this needed? The current GLSLParserTest class doesn't know about the gles2/gles3 varient of glslparsertest. The versioning of glsl_version in the config section of frags and vert shaders is conceptually incompat

[Piglit] [PATCH 1/6] glsl: gles2: add version 100

2012-12-19 Thread Tom Gall
This is a small change in two parts to repair support for gles2 by glslparsertest. To glslparsertest.c, add 100 into the list of versions the switch handles when passed from the command line instead of the default path. Next in piglit_init when version 100 is used, check for gles and if in use don

[Piglit] [Patch 0/6] glsl: gles2

2012-12-19 Thread Tom Gall
This patch series adds gles2 support to glslparser test. Picking up ~406 tests all total for gles2. New in this version of the patch series, the GLSLESParserTest class has been reworked to subclass GLSLParserTest and as a result is substantially smaller and much more simple. The change is no longe