[Piglit] [PATCH] Test unsized arrays in interface blocks

2013-09-27 Thread Paul Berry
These tests verify that unsized arrays appearing inside interface blocks obey the same rules as unsized arrays appearing outside interface blocks. Namely, their size is inferred from the largest constant integer index used to access them across all compilation units for the same shader stage, and

[Piglit] [PATCH] fbo-alphatest-formats: silence piglit_report_subtest_result() format warnings

2013-09-27 Thread Brian Paul
silences tests/fbo/fbo-alphatest-formats.c:184:3: warning: format not a string literal and no format arguments [-Wformat-security] --- A number of tests are generating this warning. If there's no objection, I'll clean up the other tests too. --- tests/fbo/fbo-alphatest-formats.c |6 +++---

[Piglit] [PATCH] Test that GS has access to noise functions

2013-09-27 Thread Nicholas Mack
--- .../glsl-1.50/compiler/gs-noise-functions.geom | 24 ++ 1 file changed, 24 insertions(+) create mode 100644 tests/spec/glsl-1.50/compiler/gs-noise-functions.geom diff --git a/tests/spec/glsl-1.50/compiler/gs-noise-functions.geom

Re: [Piglit] [PATCH] fbo-alphatest-formats: silence piglit_report_subtest_result() format warnings

2013-09-27 Thread Eric Anholt
Brian Paul bri...@vmware.com writes: silences tests/fbo/fbo-alphatest-formats.c:184:3: warning: format not a string literal and no format arguments [-Wformat-security] --- A number of tests are generating this warning. If there's no objection, I'll clean up the other tests too. Seems

[Piglit] [PATCH 1/4] GLSL 1.50 Interface blocks: Test that block array sizes must match between shaders

2013-09-27 Thread Nicholas Mack
--- ...ce-blocks-vs-fs-array-size-mismatch.shader_test | 37 +++ ...ce-blocks-vs-gs-array-size-mismatch.shader_test | 41 ++ 2 files changed, 78 insertions(+) create mode 100644

[Piglit] [PATCH 3/4] GLSL 1.50 Interface blocks: Test that interface blocks cannot have initializers or sampler types within the block.

2013-09-27 Thread Nicholas Mack
--- ...terface-blocks-no-initializer-within-block.vert | 25 ++ ...erface-blocks-no-sampler-type-within-block.vert | 24 + 2 files changed, 49 insertions(+) create mode 100644 tests/spec/glsl-1.50/compiler/interface-blocks-no-initializer-within-block.vert

[Piglit] [PATCH 1/2] GLSL 1.50: Test that version 140 and version 150 shaders can be linked together

2013-09-27 Thread Nicholas Mack
--- .../glsl-1.50/linker/versions-mingled.shader_test | 29 ++ 1 file changed, 29 insertions(+) create mode 100644 tests/spec/glsl-1.50/linker/versions-mingled.shader_test diff --git a/tests/spec/glsl-1.50/linker/versions-mingled.shader_test

[Piglit] [PATCH 2/2] GLSL 1.50: Test that multiple shaders of version 140 and 150 can be linked together

2013-09-27 Thread Nicholas Mack
--- ...ons-mingled-multiple-shader-objects.shader_test | 52 ++ 1 file changed, 52 insertions(+) create mode 100644 tests/spec/glsl-1.50/linker/versions-mingled-multiple-shader-objects.shader_test diff --git

[Piglit] [PATCH] Test that all vertex shader inputs are enumerated by GetActiveAttrib(). This includes built-ins such as gl_InstanceID and gl_VertexID.

2013-09-27 Thread Nicholas Mack
--- tests/all.tests| 2 + tests/spec/gl-3.2/CMakeLists.gl.txt| 1 + .../gl-3.2/get-active-attrib-returns-all-inputs.c | 117 + 3 files changed, 120 insertions(+) create mode 100644

Re: [Piglit] [PATCH] glsl-1.50: Test compilation of interface blocks containing unsized arrays.

2013-09-27 Thread Paul Berry
On 24 September 2013 15:51, Ian Romanick i...@freedesktop.org wrote: This looks like a reasonable set of tests, but... could you toss one in that tries to use one of these implicitly sized arrays in an invalid way. Perhaps with .length? We already test that for some other types of

[Piglit] [PATCH] glsl-1.50: Test illegal uses of unsized arrays in interface blocks.

2013-09-27 Thread Paul Berry
These tests verify that unsized arrays appearing inside interface blocks are subject to the same restrictions as unsized arrays appearing outside interface blocks (e.g. they can't be used in bulk assignment, they don't support .length(), and they can't be accessed using a non-constant index).

Re: [Piglit] [PATCH] glsl-1.50: Test illegal uses of unsized arrays in interface blocks.

2013-09-27 Thread Ian Romanick
On 09/27/2013 01:37 PM, Paul Berry wrote: These tests verify that unsized arrays appearing inside interface blocks are subject to the same restrictions as unsized arrays appearing outside interface blocks (e.g. they can't be used in bulk assignment, they don't support .length(), and they can't

Re: [Piglit] [PATCH RESEND] gs: Test corner case for triangle strip ordering with primitive restart.

2013-09-27 Thread Ian Romanick
On 09/12/2013 11:39 AM, Paul Berry wrote: Verified using the NVIDIA proprietary driver for linux. When mentioning a closed-source driver, I like to mention the version and the hardware. That's more important, I think, when the test fails on the closed-driver, but it still seems useful. Either

Re: [Piglit] [PATCH] gs: Test core GS inputs on GLSL 1.50

2013-09-27 Thread Ian Romanick
Reviewed-by: Ian Romanick ian.d.roman...@intel.com On 09/14/2013 10:44 AM, Paul Berry wrote: --- .../execution/geometry/core-inputs.shader_test | 98 ++ 1 file changed, 98 insertions(+) create mode 100644

Re: [Piglit] [PATCH] Test accuracy of dFdx and dFdy functions.

2013-09-27 Thread Ian Romanick
On 09/20/2013 10:15 AM, Paul Berry wrote: Mesa/i965 currently (as of commit 1cc3b90) has an inaccurate implementation of dFdy() which produces the same results for every pixel in an aligned 2x2 block. This piglit test exposes the inaccuracy. Two questions: - How did you come up with the

[Piglit] Status Object V2

2013-09-27 Thread Dylan Baker
This series is split into 4 seperate parts Patches 1-2: These implement some conformance tests for the way summary detects regressions, fixes, changes, and problems. Patch 3: Fixes the current implementation of piglit to conform to these tests. Patches 4-5: These are the patches that were

[Piglit] [PATCH 5/7] status: Make use of the status objects

2013-09-27 Thread Dylan Baker
This adds code in framework/summary.py and framework/core.py to make use of the status classes in status.py. This makes comparisons between statuses much simpler and cleaner v2: - Instead of importing all of the classes into the local namespace use the ``import ... as'' syntax. This means

[Piglit] [PATCH 3/7] framework/summary.py: Fix problems with status handling

2013-09-27 Thread Dylan Baker
Fixes status hanlding (fixes, regressions, changes) to be compliant with the status handling in framework_tests/summary.py. Mainly this addresses notrun - * and * - notrun, as well as a few corner cases. Signed-off-by: Dylan Baker baker.dyla...@gmail.com --- framework/summary.py | 47

[Piglit] [PATCH 1/7] framework_tests/summary.py: Tests Summary.py's assignment of statues

2013-09-27 Thread Dylan Baker
This code tests the way Summary.py assigns statuses to tests. Specifically it tests regressions, fixes, changes, and problems, assuring that only the correct permutations of these tests are added to the list. It uses python's builtin unittest framework, and a magical decorator to limit code

[Piglit] [PATCH 2/7] piglit-framework-tests.py: Adds a utility for running piglit unit tests

2013-09-27 Thread Dylan Baker
This program gives the option to run the tests. These tests are meant to test internal features of the piglit framework. Currently there are only tests for the summary module's handling of regressions, fixes, changes, and problems. Signed-off-by: Dylan Baker baker.dyla...@gmail.com ---

[Piglit] [PATCH 4/7] status.py: Adds a new status class and subclasses

2013-09-27 Thread Dylan Baker
These status classes are intended to replace the string statuses currently used by piglit summary. They give a couple of very nice advantages, first, they can be directly compared to each other to determine whether a status is worse than another status. These statuses can also be compared to any

[Piglit] [PATCH 6/7] summary: Remove optimization with no impact

2013-09-27 Thread Dylan Baker
Generating these lists is rather trivial, so just generate them all the time. Signed-off-by: Dylan Baker baker.dyla...@gmail.com --- framework/summary.py | 61 +--- 1 file changed, 25 insertions(+), 36 deletions(-) diff --git

[Piglit] [PATCH 7/7] summary: Fold __generate_lists into __init__

2013-09-27 Thread Dylan Baker
Since there is nothign special about __generate_lists anymore (it just does the same thing all the time), just fold it back into the constructor and save on having to call it. Signed-off-by: Dylan Baker baker.dyla...@gmail.com --- framework/summary.py | 26 -- 1 file

Re: [Piglit] [PATCH 3/4] GLSL 1.50 Interface blocks: Test that interface blocks cannot have initializers or sampler types within the block.

2013-09-27 Thread Jordan Justen
On Fri, 2013-09-27 at 11:28 -0700, Nicholas Mack wrote: diff --git a/tests/spec/glsl-1.50/compiler/interface-blocks-no-sampler-type-within-block.vert b/tests/spec/glsl-1.50/compiler/interface-blocks-no-sampler-type-within-block.vert new file mode 100644 index 000..8055c72 ---

Re: [Piglit] [PATCH 3/4] GLSL 1.50 Interface blocks: Test that interface blocks cannot have initializers or sampler types within the block.

2013-09-27 Thread Jordan Justen
On Fri, 2013-09-27 at 14:46 -0700, Jordan Justen wrote: On Fri, 2013-09-27 at 11:28 -0700, Nicholas Mack wrote: diff --git a/tests/spec/glsl-1.50/compiler/interface-blocks-no-sampler-type-within-block.vert

[Piglit] [PATCH] GL 3.2: Test that GetTexLevelParameterfv() generates an error when passed TEXTURE_BORDER

2013-09-27 Thread Nicholas Mack
--- tests/spec/gl-3.2/CMakeLists.gl.txt | 1 + tests/spec/gl-3.2/texture-border-deprecated.c | 63 +++ 2 files changed, 64 insertions(+) create mode 100644 tests/spec/gl-3.2/texture-border-deprecated.c diff --git a/tests/spec/gl-3.2/CMakeLists.gl.txt

Re: [Piglit] [PATCH 7/7] summary: Fold __generate_lists into __init__

2013-09-27 Thread Dylan Baker
On Friday, September 27, 2013 05:29:57 PM Ken Phillis Jr wrote: This patch looks good. The only suggest I have is to double check spelling on the commit logs and comments... For example, The word nothign should be nothing. On Fri, Sep 27, 2013 at 4:39 PM, Dylan Baker

Re: [Piglit] [PATCH] Test that GS has access to noise functions

2013-09-27 Thread Ian Romanick
With the whitespace issues fixed, this patch is Reviewed-by: Ian Romanick ian.d.roman...@intel.com On 09/27/2013 10:33 AM, Nicholas Mack wrote: --- .../glsl-1.50/compiler/gs-noise-functions.geom | 24 ++ 1 file changed, 24 insertions(+) create mode 100644

Re: [Piglit] [WIP 1/4] util: buffer object probe

2013-09-27 Thread Ian Romanick
On 09/16/2013 07:54 AM, Topi Pohjolainen wrote: Make feedback buffer probe accessible also for other tests. Original behavior is altered not to print matching values anymore. Signed-off-by: Topi Pohjolainen topi.pohjolai...@intel.com --- tests/spec/ext_transform_feedback/separate.c | 30

Re: [Piglit] [PATCH v2 01/10] GL3.2 GL_ARB_sync: Test to check the correct error messages are returned for invalid inputs for ClientWaitSync

2013-09-27 Thread Chad Versace
On 08/20/2013 11:26 AM, Nicholas Mack wrote: v2: Fix comments, initialize variables, rewrite loop through all bit masks --- tests/spec/arb_sync/CMakeLists.gl.txt | 1 + tests/spec/arb_sync/ClientWaitSync-errors.c | 103 2 files changed, 104 insertions(+)

Re: [Piglit] [PATCH v2 01/10] GL3.2 GL_ARB_sync: Test to check the correct error messages are returned for invalid inputs for ClientWaitSync

2013-09-27 Thread Chad Versace
On 09/27/2013 04:22 PM, Chad Versace wrote: On 08/20/2013 11:26 AM, Nicholas Mack wrote: v2: Fix comments, initialize variables, rewrite loop through all bit masks --- tests/spec/arb_sync/CMakeLists.gl.txt | 1 + tests/spec/arb_sync/ClientWaitSync-errors.c | 103

Re: [Piglit] [PATCH v2 05/10] GL3.2 GL_ARB_sync: Test for the correct error messages caused by invalid input to FenceSync

2013-09-27 Thread Chad Versace
On 08/20/2013 11:26 AM, Nicholas Mack wrote: v2: Fix comments, remove unnecessary tests. --- tests/spec/arb_sync/CMakeLists.gl.txt | 1 + tests/spec/arb_sync/FenceSync-errors.c | 71 ++ 2 files changed, 72 insertions(+) create mode 100644

Re: [Piglit] [WIP] Some ARB_transform_feedback3 tests

2013-09-27 Thread Ian Romanick
On 09/16/2013 07:54 AM, Topi Pohjolainen wrote: I started drafting tests for the new transform feedback mechanisms. So far I have exercised the use of interleaved and separate modes together (previously only one of the modes could be used at a time). I first wrote a test using fixed set of

[Piglit] [PATCH 1/5] piglit: silence piglit_report_subtest_result() format warnings

2013-09-27 Thread Brian Paul
silences a bunch of warnings such as: tests/fbo/fbo-alphatest-formats.c:184:3: warning: format not a string literal and no format arguments [-Wformat-security] --- tests/fbo/fbo-alphatest-formats.c|6 +++--- tests/fbo/fbo-blending-formats.c |

[Piglit] [PATCH 3/5] glean: silence unused var compiler warning

2013-09-27 Thread Brian Paul
--- tests/glean/tshaderapi.cpp |1 + 1 file changed, 1 insertion(+) diff --git a/tests/glean/tshaderapi.cpp b/tests/glean/tshaderapi.cpp index 5111c30..fcd6547 100644 --- a/tests/glean/tshaderapi.cpp +++ b/tests/glean/tshaderapi.cpp @@ -440,6 +440,7 @@

[Piglit] [PATCH 4/5] layered-2d-texture-render: add const qualifiers to silence warnings

2013-09-27 Thread Brian Paul
--- tests/spec/amd_vertex_shader_layer/layered-2d-texture-render.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/spec/amd_vertex_shader_layer/layered-2d-texture-render.c b/tests/spec/amd_vertex_shader_layer/layered-2d-texture-render.c index 88a2bfa..71fc249