Re: [Piglit] [PATCH 1/7] cl-program-tester: Use more appropriate member names for struct test_arg

2013-10-02 Thread Tom Stellard
On Tue, Oct 01, 2013 at 05:03:16PM -0500, Aaron Watry wrote: > The main downside to this plan that I see is that combining the tests > for all data types into the same program run leads to something like > the following: > > Using the current vload-int.cl as an example: > Currently my pitcairn fai

[Piglit] [PATCH] sso: Add compile tests for the location layout qualifier

2013-10-02 Thread Ian Romanick
From: Ian Romanick NVIDIA (304.64 on GTX 260) fails all of the 1.10, 1.20, and 1.30 tests because they fail to recognize the layout keyword at all. Paul has suggested that adding #extension GL_ARB_fragment_coord_conventions: require may work around this issue in some cases. Signed-off-by:

Re: [Piglit] [PATCH 5/8] cmake: Increase minimum version from 2.6 to 2.8.

2013-10-02 Thread Dylan Baker
On Tuesday, October 01, 2013 10:42:39 PM Ken Phillis Jr wrote: > Since i got a few emails over this particular change... I will go ahead and > explain the primary reason for this change. It's a minor change when you > consider that most current linux distributions have included some version > of cm

[Piglit] usage of C++11 STL features in a Piglit test

2013-10-02 Thread Jon Ashburn
I am working on Piglit tests for arb_texture_view. I was considering using C++11 features in STL (e.g. unordered_set). Any reason not to use these newer STL features if they are supported in the newer versions of g++ as found on recent Ubuntu distributions? In particular, wondering if com

Re: [Piglit] [PATCH 5/8] cmake: Increase minimum version from 2.6 to 2.8.

2013-10-02 Thread Matt Turner
On Tue, Oct 1, 2013 at 6:42 PM, Dylan Baker wrote: > On Tuesday, October 01, 2013 05:13:52 PM Ken Phillis Jr wrote: >> The use of cmake 2.8 just happens to coincide with requiring slightly newer >> tools... see these release announcements... >> kitware - news: cmake 2.8.11 released ( May 22, 2013

[Piglit] [PATCH 01/14] Test that struct names may not begin with "gl_" prefix.

2013-10-02 Thread Paul Berry
--- .../struct/struct-name-uses-gl-prefix.vert | 22 ++ 1 file changed, 22 insertions(+) create mode 100644 tests/spec/glsl-1.10/compiler/struct/struct-name-uses-gl-prefix.vert diff --git a/tests/spec/glsl-1.10/compiler/struct/struct-name-uses-gl-prefix.vert b/test

[Piglit] [PATCH 00/14] Tests related to interface block redeclaration.

2013-10-02 Thread Paul Berry
I'm putting the finishing touches on a patch series for Mesa that allows for redeclaration of the gl_PerVertex interface block. This series contains the tests I used to validate my Mesa work. The GLSL 1.50 spec doesn't directly address how to redeclare elements of the gl_PerVertex interface block

[Piglit] [PATCH 06/14] Test that the built-in gl_PerVertex interface block can be redeclared.

2013-10-02 Thread Paul Berry
--- .../redeclare-pervertex-out-subset-gs.shader_test | 77 ++ ...redeclare-pervertex-subset-vs-to-gs.shader_test | 113 + .../redeclare-pervertex-subset-vs.shader_test | 73 + 3 files changed, 263 insertions(+) create mode 100644 tests/spec/gl

[Piglit] [PATCH 05/14] Test that in general, interface blocks cannot be redeclared.

2013-10-02 Thread Paul Berry
--- ...face-block-redeclared-different-block-name.vert | 36 ++ ...interface-block-redeclared-same-block-name.vert | 36 ++ 2 files changed, 72 insertions(+) create mode 100644 tests/spec/glsl-1.50/compiler/named-interface-block-redeclared-different-block-

[Piglit] [PATCH 04/14] Test that interface blocks cannot declare conflicting names.

2013-10-02 Thread Paul Berry
--- ...nterface-block-conflicts-with-ordinary-var.vert | 21 +++ ...-block-elem-conflicts-with-prev-block-elem.vert | 30 ++ ...face-block-elem-conflicts-with-prev-global.vert | 28 3 files changed, 79 insertions(+) create mode 100644 tests/sp

[Piglit] [PATCH 02/14] Test illegal usages of "gl_" prefix in interface blocks.

2013-10-02 Thread Paul Berry
--- .../interface-block-array-elem-uses-gl-prefix.vert | 24 ++ ...terface-block-instance-name-uses-gl-prefix.vert | 23 + .../interface-block-name-uses-gl-prefix.vert | 23 + .../named-interface-block-elem-uses-gl-prefix.vert | 24

[Piglit] [PATCH 03/14] Test that redeclaration of gl_PerVertex must be for a subset.

2013-10-02 Thread Paul Berry
--- ...edeclares-pervertex-in-with-illegal-member.geom | 41 ++ ...declares-pervertex-out-with-illegal-member.geom | 41 ++ ...s-redeclares-pervertex-with-illegal-member.vert | 38 3 files changed, 120 insertions(+) create mode 100644

[Piglit] [PATCH 07/14] Test that gl_PerVertex can't be redeclared after it's been used.

2013-10-02 Thread Paul Berry
--- ...-redeclares-pervertex-in-after-other-usage.geom | 37 + .../gs-redeclares-pervertex-in-after-usage.geom| 38 ++ ...redeclares-pervertex-out-after-other-usage.geom | 37 + .../gs-redeclares-pervertex-out-after-usage.geom | 38

[Piglit] [PATCH 09/14] Test that after redeclaration, absent members of gl_PerVertex can't be used.

2013-10-02 Thread Paul Berry
--- ...redeclares-pervertex-in-before-other-usage.geom | 34 ...edeclares-pervertex-out-before-other-usage.geom | 37 ++ ...edeclares-pervertex-out-before-other-usage.vert | 34 3 files changed, 105 insertions(+) create mode 100644 te

[Piglit] [PATCH 10/14] Test that builtins can't be redeclared both inside and outside gl_PerVertex.

2013-10-02 Thread Paul Berry
--- ...s-pervertex-out-after-global-redeclaration.geom | 36 ++ ...ertex-out-after-other-global-redeclaration.geom | 35 + ...-pervertex-out-before-global-redeclaration.geom | 36 ++ ...rtex-out-before-other-global-redeclaration.geom | 35

[Piglit] [PATCH 08/14] Test that gl_PerVertex can't be redeclared multiple times in one shader.

2013-10-02 Thread Paul Berry
--- .../gs-redeclares-pervertex-in-multiple-times.geom | 32 ++ ...gs-redeclares-pervertex-out-multiple-times.geom | 32 ++ ...vs-redeclares-pervertex-out-multiple-times.vert | 32 ++ 3 files changed, 96 insertions(+) create mode 100644

Re: [Piglit] [PATCH 00/14] Tests related to interface block redeclaration.

2013-10-02 Thread Paul Berry
On 2 October 2013 16:45, Paul Berry wrote: > I'm putting the finishing touches on a patch series for Mesa that > allows for redeclaration of the gl_PerVertex interface block. This > series contains the tests I used to validate my Mesa work. > > The GLSL 1.50 spec doesn't directly address how to

[Piglit] [PATCH 11/14] Test inter- and intra-stage gl_PerVertex matching rules.

2013-10-02 Thread Paul Berry
These tests verify the following linkage rules, from GLSL 4.10: 1. If multiple shaders using members of a built-in block belonging to the same interface are linked together in the same program, they must all redeclare the built-in block in the same way, as described in section 4.3.7 "Interface Blo

[Piglit] [PATCH 12/14] Verify array-ness and instance name of gl_PerVertex redeclarations.

2013-10-02 Thread Paul Berry
--- .../gs-redeclares-pervertex-in-as-nonarray.geom| 43 ++ ...edeclares-pervertex-in-with-incorrect-name.geom | 38 +++ ...eclares-pervertex-in-without-instance-name.geom | 38 +++ .../gs-redeclares-pervertex-out-as-array.geom | 42

[Piglit] [PATCH 14/14] Test that gl_in may be redeclared with an array size.

2013-10-02 Thread Paul Berry
--- ...gs-redeclares-pervertex-in-with-array-size.geom | 45 ++ 1 file changed, 45 insertions(+) create mode 100644 tests/spec/glsl-1.50/compiler/gs-redeclares-pervertex-in-with-array-size.geom diff --git a/tests/spec/glsl-1.50/compiler/gs-redeclares-pervertex-in-with-array

[Piglit] [PATCH 13/14] Verify that gl_PerVertex can't be redeclared in certain shader types.

2013-10-02 Thread Paul Berry
--- .../fs-disallows-redeclaration-of-pervertex-in.frag | 18 ++ .../fs-disallows-redeclaration-of-pervertex-out.frag | 19 +++ .../vs-disallows-redeclaration-of-pervertex-in.vert | 18 ++ 3 files changed, 55 insertions(+) create mode 100644 t

Re: [Piglit] [PATCH 5/8] cmake: Increase minimum version from 2.6 to 2.8.

2013-10-02 Thread Ken Phillis Jr
On Wed, Oct 2, 2013 at 4:44 PM, Matt Turner wrote: > On Tue, Oct 1, 2013 at 6:42 PM, Dylan Baker > wrote: > > On Tuesday, October 01, 2013 05:13:52 PM Ken Phillis Jr wrote: > >> The use of cmake 2.8 just happens to coincide with requiring slightly > newer > >> tools... see these release announce

Re: [Piglit] usage of C++11 STL features in a Piglit test

2013-10-02 Thread Ken Phillis Jr
On Wed, Oct 2, 2013 at 4:32 PM, Jon Ashburn wrote: > I am working on Piglit tests for arb_texture_view. I was considering > using C++11 features in STL (e.g. unordered_set). Any reason not to use > these newer STL features if they are supported in the newer versions of > g++ as found on rec

[Piglit] [PATCH] arb_shader_bit_encoding: Generate tests for 3.30, not 4.00.

2013-10-02 Thread Matt Turner
I was generating GLSL 4.00 tests because that's when ARB_gpu_shader5 functionality was folded in, but 3.30 is actually the first version with the bit encoding functions. --- generated_tests/gen_shader_bit_encoding_tests.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gen