Re: [Piglit] [PATCH 3/4] util: Add a -list-subtests option that will list all the subtests

2013-10-08 Thread Daniel Vetter
On Fri, Oct 04, 2013 at 06:11:00PM -0700, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com This required some ugly hacking about to get the list of subtests to process_args. Suggestions? The utility is that all.tests can do 'sometest -list-subtests' to automatically get

Re: [Piglit] [PATCH 2/4] util: Add common framework for command-line invoked subtests

2013-10-08 Thread Ian Romanick
On 10/07/2013 10:39 AM, Chad Versace wrote: On 10/04/2013 06:10 PM, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com There are two parts to this. First, command line options of the form -subtest foo have their argument (the foo part) stored in a list in the

Re: [Piglit] [PATCH 1/4] util: Add utility function to accumulate results of subtests

2013-10-08 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/07/2013 09:02 AM, Eric Anholt wrote: Ian Romanick i...@freedesktop.org writes: From: Ian Romanick ian.d.roman...@intel.com This looks a lot like piglit_merge_result. It sure does. I didn't know that function existed. Oof. -BEGIN

Re: [Piglit] [PATCH] shaders: add test for bool casting of large integers.

2013-10-08 Thread Ian Romanick
On 10/07/2013 04:22 PM, Dave Airlie wrote: From: Dave Airlie airl...@redhat.com I noticed the TGSI convertor just does INEG then AND 0x3f80, which works for small values, but fails for larger ints. This seems to fail on nvidia (4.3.0 NVIDIA 325.15) and on ironlake with mesa 9.2. If

[Piglit] [RFC PATCH] Test that in/out qualifiers are required when redeclaring gl_ClipDistance.

2013-10-08 Thread Paul Berry
Although it is not explicitly stated in the GLSL spec, all examples of redeclaring built-in in/out variables (such as gl_ClipDistance) include the in or out qualifier, so it seems like failure to do so should cause a compile error. At present: - Mesa (as of commit a50c5f8) does not generate an

Re: [Piglit] [PATCH 06/14] Test that the built-in gl_PerVertex interface block can be redeclared.

2013-10-08 Thread Jordan Justen
On Wed, Oct 2, 2013 at 4:45 PM, Paul Berry stereotype...@gmail.com wrote: --- .../redeclare-pervertex-out-subset-gs.shader_test | 77 ++ ...redeclare-pervertex-subset-vs-to-gs.shader_test | 113 + .../redeclare-pervertex-subset-vs.shader_test | 73

[Piglit] [PATCH] geometry-end-primitive-optional-with-points-out: Require GLSL 1.50.

2013-10-08 Thread Vinson Lee
Signed-off-by: Vinson Lee v...@freedesktop.org --- .../geometry/geometry-end-primitive-optional-with-points-out.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/spec/glsl-1.50/execution/geometry/geometry-end-primitive-optional-with-points-out.c

[Piglit] [PATCH v2] gs: Don't try to use gl_PerVertex when redeclaring fragment shader inputs.

2013-10-08 Thread Paul Berry
In commit 5b1dff3 (Geometry shaders: Test gl_ClipDistance input (GLSL 1.50)) I accidentally used this syntax to redeclare the gl_ClipDistance fragment shader input: in gl_PerVertex { float gl_ClipDistance[8]; }; This is incorrect--gl_PerVertex is only meaningful in vertex and

Re: [Piglit] [PATCH 06/14] Test that the built-in gl_PerVertex interface block can be redeclared.

2013-10-08 Thread Paul Berry
On 8 October 2013 11:40, Jordan Justen jljus...@gmail.com wrote: On Wed, Oct 2, 2013 at 4:45 PM, Paul Berry stereotype...@gmail.com wrote: --- .../redeclare-pervertex-out-subset-gs.shader_test | 77 ++ ...redeclare-pervertex-subset-vs-to-gs.shader_test | 113

Re: [Piglit] [PATCH 14/14] Test that gl_in may be redeclared with an array size.

2013-10-08 Thread Jordan Justen
Series Reviewed-by: Jordan Justen jordan.l.jus...@intel.com I thought I might see a positive .geom with *both* per-vertex in out. Too trivial? On Wed, Oct 2, 2013 at 4:45 PM, Paul Berry stereotype...@gmail.com wrote: --- ...gs-redeclares-pervertex-in-with-array-size.geom | 45

Re: [Piglit] [PATCH] geometry-end-primitive-optional-with-points-out: Require GLSL 1.50.

2013-10-08 Thread Paul Berry
On 8 October 2013 11:56, Vinson Lee v...@freedesktop.org wrote: Signed-off-by: Vinson Lee v...@freedesktop.org --- .../geometry/geometry-end-primitive-optional-with-points-out.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [Piglit] [PATCH] geometry-end-primitive-optional-with-points-out: Require GLSL 1.50.

2013-10-08 Thread Vinson Lee
On Tue, Oct 8, 2013 at 12:47 PM, Paul Berry stereotype...@gmail.com wrote: On 8 October 2013 11:56, Vinson Lee v...@freedesktop.org wrote: Signed-off-by: Vinson Lee v...@freedesktop.org --- .../geometry/geometry-end-primitive-optional-with-points-out.c | 2 ++ 1 file changed, 2

Re: [Piglit] [PATCH 14/14] Test that gl_in may be redeclared with an array size.

2013-10-08 Thread Paul Berry
On 8 October 2013 12:17, Jordan Justen jljus...@gmail.com wrote: Series Reviewed-by: Jordan Justen jordan.l.jus...@intel.com I thought I might see a positive .geom with *both* per-vertex in out. Too trivial? That's a good idea. I'll do that as a follow-up. On Wed, Oct 2, 2013 at 4:45

[Piglit] [PATCH] gs: Test that a single shader can redeclare both gl_PerVertex input and output.

2013-10-08 Thread Paul Berry
--- ...gs-redeclares-both-pervertex-blocks.shader_test | 67 ++ 1 file changed, 67 insertions(+) create mode 100644 tests/spec/glsl-1.50/execution/gs-redeclares-both-pervertex-blocks.shader_test diff --git

Re: [Piglit] [PATCH] geometry-end-primitive-optional-with-points-out: Require GLSL 1.50.

2013-10-08 Thread Paul Berry
On 8 October 2013 13:55, Vinson Lee v...@freedesktop.org wrote: On Tue, Oct 8, 2013 at 12:47 PM, Paul Berry stereotype...@gmail.com wrote: On 8 October 2013 11:56, Vinson Lee v...@freedesktop.org wrote: Signed-off-by: Vinson Lee v...@freedesktop.org ---

[Piglit] [PATCH 1/8] GL_ARB_UBO/referenced-by-shader: Drop unused uniform.

2013-10-08 Thread Eric Anholt
I think this was a copy-and-paste leftover from the getactiveuniformname test. --- tests/spec/arb_uniform_buffer_object/referenced-by-shader.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/spec/arb_uniform_buffer_object/referenced-by-shader.c

[Piglit] [PATCH 4/8] GL_ARB_vertex_buffer_object: Test for glBufferSubData() on index buffers.

2013-10-08 Thread Eric Anholt
We already have one for VBOs under general/ --- tests/all.tests| 1 + .../arb_vertex_buffer_object/CMakeLists.gl.txt | 1 + .../arb_vertex_buffer_object/ib-subdata-sync.c | 84 ++ 3 files changed, 86 insertions(+) create mode

[Piglit] [PATCH 3/8] GL_ARB_copy_buffer: Add a test for syncing with glBufferData();

2013-10-08 Thread Eric Anholt
Like the subdata test, make sure that we get back the right results when putting new data in our source or dest after a copy. --- tests/all.tests | 1 + tests/spec/arb_copy_buffer/CMakeLists.gl.txt | 1 + tests/spec/arb_copy_buffer/data-sync.c | 109

[Piglit] [PATCH 5/8] GL_ARB_vertex_buffer_object: Add test for glBufferData() on the index buffer.

2013-10-08 Thread Eric Anholt
--- tests/all.tests| 1 + .../arb_vertex_buffer_object/CMakeLists.gl.txt | 1 + tests/spec/arb_vertex_buffer_object/ib-data-sync.c | 83 ++ 3 files changed, 85 insertions(+) create mode 100644

[Piglit] [PATCH 6/8] GL_ARB_texture_buffer_object: Add a test for syncing with glBufferSubData().

2013-10-08 Thread Eric Anholt
--- tests/all.tests| 1 + .../arb_texture_buffer_object/CMakeLists.gl.txt| 1 + .../spec/arb_texture_buffer_object/subdata-sync.c | 102 + 3 files changed, 104 insertions(+) create mode 100644

[Piglit] [PATCH 8/8] GL_ARB_vertex_buffer_object: Test many draws using glBufferSubData().

2013-10-08 Thread Eric Anholt
The previous tests tried to get at bad synchronization for unexpected rendering behaviors (repeatedly glBufferSubData()ing over the same state), while this tries to get at a more expected rendering behavior (incrementally glBufferSubData()ing into subsequent areas in a VBO). It also caught a ton

[Piglit] [PATCH 7/8] GL_ARB_texture_buffer_object: Test for a bug in i965 with glBufferData().

2013-10-08 Thread Eric Anholt
--- tests/all.tests| 1 + .../arb_texture_buffer_object/CMakeLists.gl.txt| 1 + tests/spec/arb_texture_buffer_object/data-sync.c | 102 + 3 files changed, 104 insertions(+) create mode 100644

Re: [Piglit] [PATCH] gs: Test that a single shader can redeclare both gl_PerVertex input and output.

2013-10-08 Thread Jordan Justen
Reviewed-by: Jordan Justen jordan.l.jus...@intel.com On Tue, Oct 8, 2013 at 1:59 PM, Paul Berry stereotype...@gmail.com wrote: --- ...gs-redeclares-both-pervertex-blocks.shader_test | 67 ++ 1 file changed, 67 insertions(+) create mode 100644

Re: [Piglit] [PATCH] geometry-end-primitive-optional-with-points-out: Require GLSL 1.50.

2013-10-08 Thread Vinson Lee
On Tue, Oct 8, 2013 at 2:05 PM, Paul Berry stereotype...@gmail.com wrote: On 8 October 2013 13:55, Vinson Lee v...@freedesktop.org wrote: On Tue, Oct 8, 2013 at 12:47 PM, Paul Berry stereotype...@gmail.com wrote: On 8 October 2013 11:56, Vinson Lee v...@freedesktop.org wrote:

Re: [Piglit] [PATCH] geometry-end-primitive-optional-with-points-out: Require GLSL 1.50.

2013-10-08 Thread Paul Berry
On 8 October 2013 15:22, Vinson Lee v...@freedesktop.org wrote: On Tue, Oct 8, 2013 at 2:05 PM, Paul Berry stereotype...@gmail.com wrote: On 8 October 2013 13:55, Vinson Lee v...@freedesktop.org wrote: On Tue, Oct 8, 2013 at 12:47 PM, Paul Berry stereotype...@gmail.com wrote: On 8

[Piglit] [PATCH] glut framework: skip if implementation doesn't support required GL version.

2013-10-08 Thread Paul Berry
In effect, we are already doing this when Waffle is in use, since Waffle uses a context creation mechanism that ensures that the context won't be created if the implementation doesn't support the GL version needed by the test. But for GLUT we need to do the check manually, since GLUT always just