Re: [Piglit] [PATCH] util/x11: Propagate window resize events to piglit_width/height

2013-10-18 Thread Chad Versace
On 10/18/2013 05:19 PM, Eric Anholt wrote: Chad Versace writes: When I switched Piglit from GLUT to Waffle, I broke detection of X11 window resizes. When the user resized the window, Piglit called piglit_display() but neglected to update piglit_width/height. This patch ensures that Piglit upd

Re: [Piglit] [PATCH 00/10] shader_runner support for micro benchmarks

2013-10-18 Thread Eric Anholt
Paul Berry writes: > On 16 October 2013 13:33, Jordan Justen wrote: > >> On Wed, Oct 16, 2013 at 10:58 AM, Eric Anholt wrote: >> > Jordan Justen writes: >> > >> >> git://people.freedesktop.org/~jljusten/piglit shader_runner-time-v1 >> >> >> >> I think shader_runner could be an easy way to deve

Re: [Piglit] [PATCH] util/x11: Propagate window resize events to piglit_width/height

2013-10-18 Thread Eric Anholt
Chad Versace writes: > When I switched Piglit from GLUT to Waffle, I broke detection of X11 > window resizes. When the user resized the window, Piglit called > piglit_display() but neglected to update piglit_width/height. > > This patch ensures that Piglit updates piglit_width/height correctly. >

Re: [Piglit] [PATCH] Test that all desktop GLSL versions can be cross-linked.

2013-10-18 Thread Eric Anholt
Paul Berry writes: > Verified using the NVIDIA proprietary driver for Linux (version > 313.18). Reviewed-by: Eric Anholt pgpp0KT1pe0lv.pgp Description: PGP signature ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/m

Re: [Piglit] [PATCH 2/4] arb_texture_view: Test valid and invalid formats

2013-10-18 Thread Brian Paul
The same formatting nitpicks from patch 1 apply to this patch and #3. More below. On 10/18/2013 05:06 PM, Jon Ashburn wrote: When calling glTextureView() only certain formats are valid based on the format of the original texture. This tests valid/invalid combinations. Tested on Nvidia Quadro 6

Re: [Piglit] [PATCH 1/4] ARB_texture_view: Test for API coverage of subset of input params

2013-10-18 Thread Brian Paul
On 10/18/2013 05:06 PM, Jon Ashburn wrote: Tests GL_ARB_texture_view and validity of input parameters. Use both valid and invalid parameters, although mostly invalid parameters are tested since other tests will use valid parameters. Only the parameters "texture", "origtexture", "minlevel", "nu

[Piglit] [PATCH 3/4] ARB_texture_view:Test valid and invalid targets for TextureView

2013-10-18 Thread Jon Ashburn
The new target supplied with textureView must be compatible with the original textures target. This tests valid and invalid combinations. Tested on Nvidia Quadro 600, all tests pass. --- tests/all.tests | 1 + tests/spec/arb_texture_view/CMakeLists.gl.txt | 1 +

[Piglit] [PATCH 4/4] ARB_texture_view: Add query tests for gl state effected by this extension

2013-10-18 Thread Jon Ashburn
Tests the queryable state from ARB_texture_view extension is correct. Includes GL_TEXTURE_IMMUTABLE_LEVELS,GL_TEXTURE_VIEW_MIN_LEVEL, GL_TEXTURE_VIEW_NUM_LEVELS, GL_TEXTURE_IMMUTABLE_FORMAT. Tested on Nvidia Quadro 600, all subtests pass. --- tests/all.tests | 1 +

[Piglit] [PATCH 1/4] ARB_texture_view: Test for API coverage of subset of input params

2013-10-18 Thread Jon Ashburn
Tests GL_ARB_texture_view and validity of input parameters. Use both valid and invalid parameters, although mostly invalid parameters are tested since other tests will use valid parameters. Only the parameters "texture", "origtexture", "minlevel", "numlevels", "minlayer", "numlayers" are tested

[Piglit] [PATCH 2/4] arb_texture_view: Test valid and invalid formats

2013-10-18 Thread Jon Ashburn
When calling glTextureView() only certain formats are valid based on the format of the original texture. This tests valid/invalid combinations. Tested on Nvidia Quadro 600, all tests pass. --- tests/all.tests | 1 + tests/spec/arb_texture_view/CMakeLists.gl.txt |

[Piglit] (no subject)

2013-10-18 Thread Jon Ashburn
If these look okay can someone push them to fd.o public repo for me? ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH 3/3] ARB_texture_view:Test valid and invalid targets for TextureView

2013-10-18 Thread Jon Ashburn
On 10/18/2013 12:43 PM, Ian Romanick wrote: On 10/16/2013 04:37 PM, Jon Ashburn wrote: The new target supplied with textureView must be compatible with the original textures target. This tests valid and invalid combinations. Tested on Nvidia Quadro 600, all tests pass. --- tests/all.tests

Re: [Piglit] [PATCH 00/10] shader_runner support for micro benchmarks

2013-10-18 Thread Paul Berry
On 16 October 2013 13:33, Jordan Justen wrote: > On Wed, Oct 16, 2013 at 10:58 AM, Eric Anholt wrote: > > Jordan Justen writes: > > > >> git://people.freedesktop.org/~jljusten/piglit shader_runner-time-v1 > >> > >> I think shader_runner could be an easy way to develop > >> quick micro-benchmark

Re: [Piglit] [PATCH 2/2] glsl-1.50: add size requirements to 3 shader_test tests

2013-10-18 Thread Paul Berry
On 11 October 2013 10:38, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > .../spec/glsl-1.50/execution/geometry/point-size-out.shader_test |5 > +++-- > .../execution/redeclare-pervertex-out-subset-gs.shader_test |5 > +++-- > .../glsl-1.50/execution/redeclare-pervert

Re: [Piglit] [PATCH 1/2] shader_runner: support SIZE in requirement section of a shader_test

2013-10-18 Thread Paul Berry
On 11 October 2013 10:38, Jordan Justen wrote: > If a test requires a certain size, it adds 'SIZE Width Height' to > the requirements section. Width and Height must be unsigned > integers. > > Signed-off-by: Jordan Justen > --- > tests/shaders/shader_runner.c | 40 > ++

Re: [Piglit] [PATCH 3/3] ARB_texture_view:Test valid and invalid targets for TextureView

2013-10-18 Thread Ian Romanick
On 10/16/2013 04:37 PM, Jon Ashburn wrote: > The new target supplied with textureView must be compatible with the > original textures target. This tests valid and invalid combinations. > > Tested on Nvidia Quadro 600, all tests pass. > --- > tests/all.tests | 1 +

Re: [Piglit] [PATCH 2/3] arb_texture_view: Test valid and invalid formats

2013-10-18 Thread Ian Romanick
On 10/16/2013 04:37 PM, Jon Ashburn wrote: > When calling glTextureView() only certain formats are valid based on the > format > of the original texture. This tests valid/invalid combinations. > > Tested on Nvidia Quadro 600, all tests pass. > --- > tests/all.tests

Re: [Piglit] [PATCH 2/3] arb_texture_view: Test valid and invalid formats

2013-10-18 Thread Ian Romanick
On 10/17/2013 01:39 PM, Jon Ashburn wrote: > > On 10/17/2013 12:46 PM, Ian Romanick wrote: >> On 10/16/2013 04:37 PM, Jon Ashburn wrote: >>> diff --git a/tests/spec/arb_texture_view/common.c >>> b/tests/spec/arb_texture_view/common.c >>> new file mode 100644 >>> index 000..c5f5a23 >>> --- /dev

Re: [Piglit] [PATCH 2/2] depthstencil-render-miplevels: Fix stencil drawing for width %4 != 0.

2013-10-18 Thread Paul Berry
On 9 October 2013 13:33, Eric Anholt wrote: > It didn't affect test results, since we don't probe this data and it's > only in manual mode, but it did cause buffer overflow. > --- > tests/texturing/depthstencil-render-miplevels.cpp | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/test

Re: [Piglit] [PATCH 1/3] ARB_texture_view: Test for API coverage of subset of input params

2013-10-18 Thread Ian Romanick
On 10/17/2013 01:29 PM, Jon Ashburn wrote: > RE: > "This test doesn't appear to use integer textures or floating-point > textures." > +piglit_require_extension("GL_EXT_texture_integer"); > +piglit_require_extension("GL_ARB_texture_float"); > > > I think it does but maybe wrong in my under

Re: [Piglit] [PATCH] util/x11: Propagate window resize events to piglit_width/height

2013-10-18 Thread Chad Versace
On 10/18/2013 11:21 AM, Jordan Justen wrote: Reviewed-by: Jordan Justen On Fri, 2013-10-18 at 11:12 -0700, Chad Versace wrote: When I switched Piglit from GLUT to Waffle, I broke detection of X11 window resizes. When the user resized the window, Piglit called piglit_display() but neglected to

Re: [Piglit] [PATCH] util/x11: Propagate window resize events to piglit_width/height

2013-10-18 Thread Jordan Justen
Reviewed-by: Jordan Justen On Fri, 2013-10-18 at 11:12 -0700, Chad Versace wrote: > When I switched Piglit from GLUT to Waffle, I broke detection of X11 > window resizes. When the user resized the window, Piglit called > piglit_display() but neglected to update piglit_width/height. > > This patc

[Piglit] [PATCH] util/x11: Propagate window resize events to piglit_width/height

2013-10-18 Thread Chad Versace
When I switched Piglit from GLUT to Waffle, I broke detection of X11 window resizes. When the user resized the window, Piglit called piglit_display() but neglected to update piglit_width/height. This patch ensures that Piglit updates piglit_width/height correctly. (It's amazing that it took this

Re: [Piglit] [PATCH 4/4] arb_transform_feedback2: Misc. API error checks

2013-10-18 Thread Dylan Baker
On Friday, October 04, 2013 06:11:01 PM Ian Romanick wrote: > From: Ian Romanick > > This covers most of the errors mentioned in the spec that aren't > already covered in cannot-bind-when-active.c and gen-names-only.c. > Most of the other errors should be covered by existing > EXT_transform_feedb

[Piglit] [PATCH] ARB_viewport_array: Add test for API coverage of index/first/count params

2013-10-18 Thread Jon Ashburn
Tests valid and invalid "index", "first", "count" parameters for the following: glViewportArrayv, glViewportIndexedf, glViewportIndexedfv glScissorArrayv, glScissorIndexed, glScissorIndexedv glDepthRangeArrayv, glDepthRangeIndexed glGetFloati_v, glGetDoublei_v Tested on Nvidia Quadro 600 all t

Re: [Piglit] [PATCH] tests/spec: ARB_arrays_of_arrays compiler tests

2013-10-18 Thread Paul Berry
On 5 October 2013 04:21, Timothy Arceri wrote: > > Signed-off-by: Timothy Arceri > --- > tests/all.tests|7 +++ > ...-function-parameter-declaration-new-syntax.vert | 17 > ...ay-of-array-function-parameter-declaration.vert | 17 +