Re: [Piglit] [PATCH] triangle-rasterization: increase the precision of the test

2013-10-29 Thread Brian Paul
On 10/28/2013 05:53 PM, Zack Rusin wrote: Increase the subpixel precision to 8 bits. This requires changing some of the code to 64 bits to avoid overflows. Signed-off-by: Zack Rusin za...@vmware.com --- Reviewed-by: Brian Paul bri...@vmware.com

Re: [Piglit] [PATCH V2 1/6] ARB_sample_shading: Add test to verify new functions and enums

2013-10-29 Thread Paul Berry
On 25 October 2013 16:49, Anuj Phogat anuj.pho...@gmail.com wrote: Tests basic functionality of function: MinSampleShadingARB() and enums: SAMPLE_SHADING_ARB MIN_SAMPLE_SHADING_VALUE_ARB Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- tests/all.tests

Re: [Piglit] [PATCH] triangle-rasterization: increase the precision of the test

2013-10-29 Thread Jose Fonseca
Looks good to me. Thanks All D3D10 capable hardware is guaranteed to pass. I'm not sure about D3D9 hardware though. If this becomes an issue for older hardware, we could improve test to pick FIXED_SHIFT based on the OpenGL version, or the availability of gemeotry shaders, or something like

Re: [Piglit] [PATCH V2 2/6] ARB_sample_shading: Add test to verify the functionality of gl_NumSamples

2013-10-29 Thread Paul Berry
On 25 October 2013 16:49, Anuj Phogat anuj.pho...@gmail.com wrote: V2: Get rid of redundant projection matrix. Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- tests/all.tests| 6 + .../arb_sample_shading/execution/CMakeLists.gl.txt | 1 +

Re: [Piglit] Patches needing to be integrated

2013-10-29 Thread Jose Fonseca
cmake patches look good AFAICT. Reviewed-by: Jose Fonseca jfons...@vmware.com Jose - Original Message - I submitted a couple of patches that still have not been applied to the piglit git repository so I figure It would be a good idea to bring up the fixes now...

Re: [Piglit] [PATCH V2 3/6] ARB_sample_shading: Add test to verify the functionality of gl_SampleID

2013-10-29 Thread Paul Berry
On 25 October 2013 16:49, Anuj Phogat anuj.pho...@gmail.com wrote: V2: Get rid of redundant projection matrix. Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- tests/all.tests| 5 + .../arb_sample_shading/execution/CMakeLists.gl.txt | 1 +

Re: [Piglit] [Patch RFC] Piglit Segmentation Handler

2013-10-29 Thread Ken Phillis Jr
I just retested this on windows and this patch set should be considered critical, because on any recent release of windows ( For example, Windows Vista and Windows 7) have piglit grind to a halt when running tests because when a program crashes, windows will always bring up a dialog stating...

Re: [Piglit] [PATCH V2 4/6] ARB_sample_shading: Add test to verify the functionality of gl_SampleMask[]

2013-10-29 Thread Paul Berry
On 25 October 2013 16:49, Anuj Phogat anuj.pho...@gmail.com wrote: V2: Get rid of redundant projection matrix. Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- tests/all.tests| 5 + .../arb_sample_shading/execution/CMakeLists.gl.txt | 1 +

Re: [Piglit] [PATCH V2 5/6] ARB_sample_shading: Add test to verify the functionality of gl_SamplePosition

2013-10-29 Thread Paul Berry
On 25 October 2013 16:49, Anuj Phogat anuj.pho...@gmail.com wrote: V2: Use better technique to verify sample positions in fragment shader. Get rid of redundant projection matrix. Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- tests/all.tests|

Re: [Piglit] [PATCH V2 6/6] ARB_sample_shading: Add compiler tests for new builtins

2013-10-29 Thread Paul Berry
On 25 October 2013 16:49, Anuj Phogat anuj.pho...@gmail.com wrote: Tests gl_SamplePosition, gl_SampleID, gl_NumSamples, gl_SampleMask[] Signed-off-by: Anuj Phogat anuj.pho...@gmail.com Personally, I don't think these tests are necessary. The previous patches adequately

Re: [Piglit] [PATCH 5/7] ARB_texture_view: Test for rendering various targets in texture view

2013-10-29 Thread Jordan Justen
On Fri, Oct 25, 2013 at 9:41 AM, Jon Ashburn j...@lunarg.com wrote: RE your comment: +config.window_width = 128; +config.window_height = 128; Is 128 special? Can you just go with the defaults? In the past we've had trouble on Windows when the width is 130 or so pixels. Long

Re: [Piglit] [PATCH] cl: Add complex real world test: Pyrit

2013-10-29 Thread Tom Stellard
On Fri, Oct 18, 2013 at 12:48:16AM +0200, Peter Wu wrote: Pyrit computes pairwise master keys (PMKs) to attack WPA/WPA2-PSK. This test verifies two aspects: - Computation of the second round of a HMAC (using SHA-1). - A calculation of the PMK key. Both tests use test vectors from IEEE

Re: [Piglit] [PATCH] cl: Add complex real world test: Pyrit

2013-10-29 Thread Peter Wu
On Tuesday 29 October 2013 11:08:58 Tom Stellard wrote: On Fri, Oct 18, 2013 at 12:48:16AM +0200, Peter Wu wrote: Pyrit computes pairwise master keys (PMKs) to attack WPA/WPA2-PSK. This test verifies two aspects: - Computation of the second round of a HMAC (using SHA-1). - A

Re: [Piglit] [PATCH 5/7] ARB_texture_view: Test for rendering various targets in texture view

2013-10-29 Thread Jon Ashburn
I choose a line primitve since using a 1D texture, but certainly could use a 1D texture on a rectangle. If using a rectangle then the test becomes basically window size independent (except likely really tiny windows). I think if the line were drawn aligned to the viewport axis then it would

Re: [Piglit] [PATCH] cl: Add complex real world test: Pyrit

2013-10-29 Thread Tom Stellard
On Tue, Oct 29, 2013 at 08:02:51PM +0100, Peter Wu wrote: On Tuesday 29 October 2013 11:08:58 Tom Stellard wrote: On Fri, Oct 18, 2013 at 12:48:16AM +0200, Peter Wu wrote: Pyrit computes pairwise master keys (PMKs) to attack WPA/WPA2-PSK. This test verifies two aspects: -

[Piglit] New test for partial blits after a buffer swap

2013-10-29 Thread Federico Mena Quintero
Hello, everyone, Attached is a new test for piglit which exposes a bug in Mesa's software rendering (and another bug in hardware rendering, but that's not its main purpose). The bug is as follows. With software rendering, after doing a buffer swap, glBlitFrameBufferEXT() appears to to copy the

[Piglit] [PATCH] fbo-blit-after-swap: New test for partial blits after a buffer swap

2013-10-29 Thread Federico Mena Quintero
From: Federico Mena Quintero feder...@suse.com The clutter/cogl libraries try to minimize the area that gets updated on every frame. They do this by doing glBlitFramebufferEXT() from the back buffer to the front buffer. However, this is buggy with software rendering if there has been a buffer

Re: [Piglit] New test for partial blits after a buffer swap

2013-10-29 Thread Eric Anholt
Federico Mena Quintero federico.mena.li...@gmail.com writes: Hello, everyone, Attached is a new test for piglit which exposes a bug in Mesa's software rendering (and another bug in hardware rendering, but that's not its main purpose). The bug is as follows. With software rendering, after

[Piglit] [PATCH 2/9] ARB_viewport_array: Validity test for depth range index/first/count params

2013-10-29 Thread Jon Ashburn
Tests GL_ARB_viewport_array validity for indices. Use both valid and invalid parameters (index, first, count) for all these new API entry points: glDepthRangeArrayv, glDepthRangeIndexed, glGetDoublei_v. Tested on Nvidia Quadro 600 all tests pass. --- tests/all.tests

[Piglit] [PATCH 4/9] ARB_viewport_array: Test validity of bounds for viewport, depthRange, scissor

2013-10-29 Thread Jon Ashburn
Tests for the validity of Viewport bounds, Depth Range bounds and Scissor Box bounds with viewport arrays (0 to GL_MAX_VIEWPORTS-1). Viewport bounds are x, y, width, height. Depth Range bounds are near, far. Scissor Box bounds are left, bottom, width, height. Tested with Nvidia Quadro 600.

[Piglit] [PATCH 3/9] ARB_viewport_array: Validity test for scissor index related params

2013-10-29 Thread Jon Ashburn
Tests GL_ARB_viewport_array validity for indices. Use both valid and invalid parameters (index, first, count) for these new API entry points: glScissorArrayv, glScissorIndexed, glScissorIndexedv. Also test SCISSOR_TEST indices with glEnablei and others. Tested on Nvidia Quadro 600 all test

[Piglit] [PATCH 5/9] ARB_viewport_array: Test validity for glGetFloati_v and glGetDoublei_v

2013-10-29 Thread Jon Ashburn
Test valid and invalid queries using glGetFLoati_v and glGetDoublei_v. Also test correct queries of GL_SCISSOR_TEST default value and settable values. Tested on Nvidia Quadro 600 and all tests pass. --- tests/all.tests | 1 +

[Piglit] [PATCH 6/9] ARB_viewport_array: Test min/max values for new implementation constants

2013-10-29 Thread Jon Ashburn
Tested GLenums are GL_MAX_VIEWPORT_DIMS, GL_MAX_VIEWPORTS, GL_VIEWPORT_SUBPIXEL_BITS, GL_VIEWPORT_BOUNDS_RANGE, GL_LAYER_PROVOKING_VERTEX, GL_VIEWPORT_INDEX_PROVOKING_VERTEX. Tested on Nvidia Quadro 600, test passes. --- tests/all.tests | 1 +

[Piglit] [PATCH 9/9] ARB_viewport_array: Rendering test with multiple scissor rectangles/enables

2013-10-29 Thread Jon Ashburn
Tests rendering into a single framebuffer surface with multiple viewports via a geometry shader. Scissoring is used to restrict quads to a smaller area on the surface. Confirm that each area of the surface delineated by a scissor rectangle for viewport index renders the correct color. Both

[Piglit] [PATCH 1/9] ARB_viewport_array: Validity test for viewport index/first/count params

2013-10-29 Thread Jon Ashburn
Tests GL_ARB_viewport_array regarding the validity for the indices. Use both valid and invalid parameters (index, first, count) for these new API entry points: glViewportArrayv, glViewportIndexedf, glViewportIndexedfv, glGetFloati_v. Also test that writing to an invalid viewport index for

[Piglit] [PATCH 8/9] ARB_viewport_array: Rendering test with multiple depthranges

2013-10-29 Thread Jon Ashburn
Draws quads into a single framebuffer surface with multiple viewports via a geometry shader. Each different viewport has a different DepthRange. The fragment shader outputs a color based on the depthRange, z, and viewport index. Confirm that each quad has the correct color and therefore has the

[Piglit] [PATCH 7/9] ARB_viewport_array: Rendering test with multiple viewports

2013-10-29 Thread Jon Ashburn
Tests rendering into a single framebuffer surface with multiple viewports via a geometry shader. Confirm that each area of the surface delineated by a viewport renders the correct color. Use multiple draw calls to replicate geometry rather than the geometry shader. Tested on Nvidia Quadro 600,

Re: [Piglit] [PATCH 1/7] arb_vertex_attrib_binding: Test error conditions

2013-10-29 Thread Eric Anholt
Sorry we all dropped this on the floor. I'm taking a look at your series now. Fredrik Höglund fred...@kde.org writes: diff --git a/tests/spec/arb_vertex_attrib_binding/errors.c b/tests/spec/arb_vertex_attrib_binding/errors.c new file mode 100644 index 000..adac098 --- /dev/null +++

Re: [Piglit] [PATCH 5/7] ARB_texture_view: Test for rendering various targets in texture view

2013-10-29 Thread Brian Paul
On 10/28/2013 12:16 PM, Jon Ashburn wrote: Tests GL_ARB_texture_view rendering with various texture targets. Creates texture maps with different solid colors for each level or layer reads the framebuffer to ensure the rendered color is correct. Tested on Nvidia Quadro 600, all subtests pass.

Re: [Piglit] New test for partial blits after a buffer swap

2013-10-29 Thread Federico Mena Quintero
On Tue, 2013-10-29 at 13:52 -0700, Eric Anholt wrote: Awesome, thanks for the quick reply :) Ouch. Doing anything to GL_FRONT is really punitive to performance in DRI2. Any chance we could convince clutter to use GLX_MESA_copy_sub_buffer/EGL_NV_post_sub_buffer instead? Then you wouldn't

Re: [Piglit] [PATCHv2] cl: Add complex real world test: Pyrit

2013-10-29 Thread Dylan Baker
On Tuesday, October 29, 2013 10:35:42 PM Peter Wu wrote: Pyrit computes pairwise master keys (PMKs) to attack WPA/WPA2-PSK. This test verifies two aspects: - Computation of the second round of a HMAC (using SHA-1). - A calculation of the PMK key. Both tests use test vectors from IEEE

Re: [Piglit] [PATCH 1/9] ARB_viewport_array: Validity test for viewport index/first/count params

2013-10-29 Thread Brian Paul
On 10/29/2013 03:55 PM, Jon Ashburn wrote: Tests GL_ARB_viewport_array regarding the validity for the indices. Use both valid and invalid parameters (index, first, count) for these new API entry points: glViewportArrayv, glViewportIndexedf, glViewportIndexedfv, glGetFloati_v. Also test that

Re: [Piglit] [PATCH 9/9] ARB_viewport_array: Rendering test with multiple scissor rectangles/enables

2013-10-29 Thread Brian Paul
On 10/29/2013 03:55 PM, Jon Ashburn wrote: Tests rendering into a single framebuffer surface with multiple viewports via a geometry shader. Scissoring is used to restrict quads to a smaller area on the surface. Confirm that each area of the surface delineated by a scissor rectangle for

Re: [Piglit] [PATCH 6/9] ARB_viewport_array: Test min/max values for new implementation constants

2013-10-29 Thread Brian Paul
On 10/29/2013 03:55 PM, Jon Ashburn wrote: Tested GLenums are GL_MAX_VIEWPORT_DIMS, GL_MAX_VIEWPORTS, GL_VIEWPORT_SUBPIXEL_BITS, GL_VIEWPORT_BOUNDS_RANGE, GL_LAYER_PROVOKING_VERTEX, GL_VIEWPORT_INDEX_PROVOKING_VERTEX. Tested on Nvidia Quadro 600, test passes. --- tests/all.tests

Re: [Piglit] [PATCH 8/9] ARB_viewport_array: Rendering test with multiple depthranges

2013-10-29 Thread Brian Paul
On 10/29/2013 03:55 PM, Jon Ashburn wrote: Draws quads into a single framebuffer surface with multiple viewports via a geometry shader. Each different viewport has a different DepthRange. The fragment shader outputs a color based on the depthRange, z, and viewport index. Confirm that each quad

Re: [Piglit] [PATCH 5/9] ARB_viewport_array: Test validity for glGetFloati_v and glGetDoublei_v

2013-10-29 Thread Brian Paul
On 10/29/2013 03:55 PM, Jon Ashburn wrote: Test valid and invalid queries using glGetFLoati_v and glGetDoublei_v. Also test correct queries of GL_SCISSOR_TEST default value and settable values. Tested on Nvidia Quadro 600 and all tests pass. --- tests/all.tests

Re: [Piglit] [PATCH 2/7] arb_vertex_attrib_binding: Test new states

2013-10-29 Thread Eric Anholt
Fredrik Höglund fred...@kde.org writes: Test setting and quering all new states. This also tests interactions with glVertexAttribPointer(). Same MIN2 and uncreached comments as the previous test. +#include piglit-util-gl-common.h + +#define MIN(a, b) (a b ? a : b) +

Re: [Piglit] [PATCHv2] cl: Add complex real world test: Pyrit

2013-10-29 Thread Tom Stellard
On Tue, Oct 29, 2013 at 04:42:19PM -0700, Dylan Baker wrote: On Tuesday, October 29, 2013 10:35:42 PM Peter Wu wrote: Pyrit computes pairwise master keys (PMKs) to attack WPA/WPA2-PSK. This test verifies two aspects: - Computation of the second round of a HMAC (using SHA-1). - A

Re: [Piglit] [PATCHv2] cl: Add complex real world test: Pyrit

2013-10-29 Thread Dylan Baker
On Tuesday, October 29, 2013 07:58:11 PM Tom Stellard wrote: On Tue, Oct 29, 2013 at 04:42:19PM -0700, Dylan Baker wrote: On Tuesday, October 29, 2013 10:35:42 PM Peter Wu wrote: Pyrit computes pairwise master keys (PMKs) to attack WPA/WPA2-PSK. This test verifies two aspects: -