Re: [Piglit] GL_ARB_explicit_attrib_location requirements

2014-07-08 Thread Ian Romanick
On 07/08/2014 08:54 AM, Brian Paul wrote: > The spec for GL_ARB_explicit_attrib_location says it requires OpenGL 2.0 > or GL_ARB_vertex_shader and it's written against the OpenGL 3.2 core > spec / GLSL 1.50. The extension spec says nothing about how the > extension would work in GLSL before 1.50.

Re: [Piglit] [PATCH] arb_texture_multisample: add new fetch-texel test

2014-07-08 Thread Ilia Mirkin
On Tue, Jul 8, 2014 at 6:46 PM, Brian Paul wrote: > On 07/08/2014 04:36 PM, Ilia Mirkin wrote: >> >> On Tue, Jul 8, 2014 at 6:32 PM, Brian Paul wrote: >>> >>> A simple test to check that using fetchTexel() to get individual >>> samples from a MSAA texture really works. >> >> >> How is this differ

[Piglit] [PATCH] arb_texture_multisample: add new texelFetch() test

2014-07-08 Thread Brian Paul
A simple test to check that using texelFetch() to get individual samples from a MSAA texture really works. v2: rename "fetch texel" -> "texel fetch". --- tests/all.py |3 + .../spec/arb_texture_multisample/CMakeLists.gl.txt |1 + tests/spec/arb_textur

Re: [Piglit] [PATCH] gl-3.0: add a test to stress the bound resource limits

2014-07-08 Thread Matthew McClure
I will try to reproduce locally with a later build of their drivers. However, I believe this is NVIDIA's bug. If they report that they can support 124 varying floats (the Variable array), they should not have this issue. The 304.116 drivers did not show this issue on a GeForce GTX 650. Would it

Re: [Piglit] [PATCH] gl-3.0: add a test to stress the bound resource limits

2014-07-08 Thread Brian Paul
On 07/08/2014 04:49 PM, Matthew McClure wrote: Update to reflect feedback from Brian Paul. The update includes documentation for each function and removal of the "flat" qualifier, since this version of the test is using GLSL 1.30. Verified on: Ubuntu 12.04.3 OpenGL vendor string: NVIDIA Corpo

Re: [Piglit] [PATCH] clipflat: fix 0/2 index typo

2014-07-08 Thread Matthew McClure
Reviewed-by: Matthew McClure - Original Message - From: "Brian Paul" To: piglit@lists.freedesktop.org Sent: Tuesday, July 8, 2014 3:32:19 PM Subject: [Piglit] [PATCH] clipflat: fix 0/2 index typo Spotted by Meng-Lin Wu. --- tests/general/clipflat.c |2 +- 1 file changed, 1 insertio

Re: [Piglit] [PATCH] gl-3.0: add a test to stress the bound resource limits

2014-07-08 Thread Matthew McClure
Update to reflect feedback from Brian Paul. The update includes documentation for each function and removal of the "flat" qualifier, since this version of the test is using GLSL 1.30. Verified on: Ubuntu 12.04.3 OpenGL vendor string: NVIDIA Corporation OpenGL renderer string: GeForce GTX 650/PC

Re: [Piglit] [PATCH] arb_texture_multisample: add new fetch-texel test

2014-07-08 Thread Brian Paul
On 07/08/2014 04:36 PM, Ilia Mirkin wrote: On Tue, Jul 8, 2014 at 6:32 PM, Brian Paul wrote: A simple test to check that using fetchTexel() to get individual samples from a MSAA texture really works. How is this different than texelFetch (in tests/texturing/shaders/texelFetch.c) with sampler2

Re: [Piglit] [PATCH] arb_texture_multisample: add new fetch-texel test

2014-07-08 Thread Ilia Mirkin
On Tue, Jul 8, 2014 at 6:32 PM, Brian Paul wrote: > A simple test to check that using fetchTexel() to get individual > samples from a MSAA texture really works. How is this different than texelFetch (in tests/texturing/shaders/texelFetch.c) with sampler2DMS? Also, assuming it is different, proba

[Piglit] [PATCH] clipflat: fix 0/2 index typo

2014-07-08 Thread Brian Paul
Spotted by Meng-Lin Wu. --- tests/general/clipflat.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/general/clipflat.c b/tests/general/clipflat.c index 37a40af..03a069c 100644 --- a/tests/general/clipflat.c +++ b/tests/general/clipflat.c @@ -295,7 +295,7 @@ checkResul

[Piglit] [PATCH] arb_texture_multisample: add new fetch-texel test

2014-07-08 Thread Brian Paul
A simple test to check that using fetchTexel() to get individual samples from a MSAA texture really works. --- tests/all.py |3 + .../spec/arb_texture_multisample/CMakeLists.gl.txt |1 + tests/spec/arb_texture_multisample/fetch-texel.c | 315 +++

Re: [Piglit] GL_ARB_explicit_attrib_location requirements

2014-07-08 Thread Chris Forbes
Brian, I think the real answer here is "all of the above". It seems reasonable that any of these extensions which introduce specific layout qualifiers also cause layout() itself to exist. It doesn't seem quite as reasonable for this to cause `out` to exist. -- Chris On Wed, Jul 9, 2014 at 3:54

Re: [Piglit] [PATCH] gl-3.0: add a test to stress the bound resource limits

2014-07-08 Thread Brian Paul
On 07/08/2014 11:01 AM, Matthew McClure wrote: I ran this on Ubuntu 12.04.3 with: OpenGL vendor string: NVIDIA Corporation OpenGL renderer string: GeForce GTX 650/PCIe/SSE2 OpenGL version string: 4.2.0 NVIDIA 304.116 OpenGL shading language version string: 4.20 NVIDIA via Cg compiler OpenGL exte

[Piglit] GL_ARB_explicit_attrib_location requirements

2014-07-08 Thread Brian Paul
The spec for GL_ARB_explicit_attrib_location says it requires OpenGL 2.0 or GL_ARB_vertex_shader and it's written against the OpenGL 3.2 core spec / GLSL 1.50. The extension spec says nothing about how the extension would work in GLSL before 1.50. Note that this extension adds a new layout qu

Re: [Piglit] [PATCH] gl-3.0: add a test to stress the bound resource limits

2014-07-08 Thread Brian Paul
On 07/07/2014 07:51 AM, Matthew McClure wrote: With this patch, we add a test that will stress the bound resource limits as determined by the GL API getInteger values. The bound resources are populated with floats given a table of primes. Each contribution is multiplied into the final expression,