[Piglit] [PATCH 16/23] arb_shader_image_load_store: Import test for the maximum texture size.

2015-01-31 Thread Francisco Jerez
Test that images work as expected up to the maximum texture dimensions reported by the implementation for each target. The test is carried out one dimension at a time to avoid creating huge textures (a 16Kx16K RGBA32F texture is already 4GB), but this is not always possible because e.g. both

[Piglit] [PATCH 19/23] arb_shader_image_load_store: Import image aliasing test.

2015-01-31 Thread Francisco Jerez
Test if the implementation is incorrectly assuming that different image uniforms point to disjoint locations in memory, which could lead to incorrect code transformations and break valid GLSL programs. --- tests/all.py | 1 +

[Piglit] [PATCH 01/23] util/shader: Define nothrow variant of piglit_compile_shader_text().

2015-01-31 Thread Francisco Jerez
Define a variant of piglit_compile_shader_text() that doesn't call piglit_report_result() on failure killing the program, which is quite annoying for tests that expect a compilation to fail and for tests that are structured in a number of subtests, because a single sub-test failing to compile a

[Piglit] [PATCH 18/23] arb_shader_image_load_store: Import memory access qualifier test.

2015-01-31 Thread Francisco Jerez
Test that no changes are observed when an optional image qualifier is omitted (e.g. access qualifiers may be omitted, format qualifiers may be omitted when the writeonly qualifier is present), and test several combinations of binding access modes and access qualifiers. --- tests/all.py

[Piglit] [PATCH 04/23] arb_shader_image_load_store: Add misc. image manipulation code and hook up to the build system.

2015-01-31 Thread Francisco Jerez
--- tests/all.py | 6 + tests/spec/CMakeLists.txt | 1 + .../arb_shader_image_load_store/CMakeLists.gl.txt | 15 + .../arb_shader_image_load_store/CMakeLists.txt | 1 + tests/spec/arb_shader_image_load_store/common.c|

[Piglit] [PATCH 22/23] arb_shader_image_load_store: Import image unit and uniform state tracking tests.

2015-01-31 Thread Francisco Jerez
Test the image unit and image uniform binding commands and then check that the state query APIs return the expected values for all bound image units. --- tests/all.py | 1 + .../arb_shader_image_load_store/CMakeLists.gl.txt | 1 +

[Piglit] [PATCH 23/23] arb_shader_image_load_store: Import test for atomics with unused result.

2015-01-31 Thread Francisco Jerez
Test all image atomic built-in functions without using their return value to make sure that they aren't optimized out by the compiler accidentally and because some implementations may use different hardware instructions for the same atomic operation depending on whether the return value of the

[Piglit] [PATCH 21/23] arb_shader_image_load_store: Import shader memory barrier tests.

2015-01-31 Thread Francisco Jerez
Test the relative ordering of memory transactions before and after a call to the memoryBarrier() GLSL built-in. --- tests/all.py | 1 + tests/quick.py | 1 + .../arb_shader_image_load_store/CMakeLists.gl.txt | 1 +

[Piglit] [PATCHv2 05/23] arb_shader_image_load_store: Import atomicity image built-in tests.

2015-01-31 Thread Francisco Jerez
Import a number of tests intended to check if the read-modify-write built-in functions defined by the spec are carried out atomically. v2: Disable the locking imageAtomicExchange test and use a lockless algorithm instead to test the built-in. Avoids GPU hang on Intel hardware. ---

[Piglit] [PATCHv2 15/23] arb_shader_image_load_store: Import tests for the maximum of supported images.

2015-01-31 Thread Francisco Jerez
Test that the limits of supported image units (GL_MAX_IMAGE_UNITS), per-shader image uniforms (GL_MAX_*_IMAGE_UNIFORMS), and combined image uniforms (GL_MAX_COMBINED_IMAGE_UNIFORMS) are true by setting up a GL pipeline that reaches some of the limits and checking that it renders as expected. v2:

[Piglit] [PATCH 17/23] arb_shader_image_load_store: Import minimum maximum test.

2015-01-31 Thread Francisco Jerez
--- tests/all.py | 1 + .../arb_shader_image_load_store/CMakeLists.gl.txt | 1 + tests/spec/arb_shader_image_load_store/minmax.c| 76 ++ 3 files changed, 78 insertions(+) create mode 100644

[Piglit] [PATCH 20/23] arb_shader_image_load_store: Import built-in semantics tests.

2015-01-31 Thread Francisco Jerez
Test that image built-in functions do what they are supposed to do by comparing their results with a simulation run on the CPU with similar inputs. The test is repeated for all built-ins, shader stages, formats and texture targets either sequentially or combinatorially depending on the --quick

[Piglit] [PATCHv2 03/23] arb_shader_image_load_store: Import grid execution helpers.

2015-01-31 Thread Francisco Jerez
Define helper functions that are able to run a piece of GLSL code on an arbitrary shader stage (as of now VS, TCS, TES, GS, FS and CS are supported) for a given execution size. This makes every shader stage expose a consistent interface that looks like a sort of primitive two-dimensional compute

[Piglit] [PATCHv2 11/23] arb_shader_image_load_store: Import image array indexing test.

2015-01-31 Thread Francisco Jerez
Test that indexing of image arrays using dynamically uniform expressions works as expected. v2: Add support for shader stages other than fragment. --- tests/all.py | 1 + .../arb_shader_image_load_store/CMakeLists.gl.txt | 1 +

[Piglit] [PATCH 08/23] arb_shader_image_load_store: Import dead fragments test.

2015-01-31 Thread Francisco Jerez
Test that image stores and atomics have no effect when called from fragment shader invocations that aren't covered by a primitive or have been discarded. --- tests/all.py | 1 + .../arb_shader_image_load_store/CMakeLists.gl.txt | 1 +

[Piglit] [PATCH 12/23] arb_shader_image_load_store: Import invalid and undefined image access tests.

2015-01-31 Thread Francisco Jerez
Test a number of cases like reading or writing outside the limits of the image that the spec defines as being invalid either return zero or have no effect depending on the specific built-in. In addition test that other cases that according to the spec cause undefined results don't lead to program

[Piglit] [PATCH 09/23] arb_shader_image_load_store: Import early_fragment_tests test.

2015-01-31 Thread Francisco Jerez
The extension defines an input layout qualifier that allows the application to force early fragment tests for a specified shader program. This has several consequences that are verified by this test, including that the fragment shader is guaranteed not to be executed if the depth test fails, that

[Piglit] [PATCHv2 10/23] arb_shader_image_load_store: Import host memory barrier tests.

2015-01-31 Thread Francisco Jerez
Add tests for the glMemoryBarrier() API which provides a way to serialize shader memory transactions issued by previous drawing commands with respect to subsequent GL commands. v2: Skip indirect draw and transform feedback tests when the extensions they rely on are not supported. ---

[Piglit] Tests for ARB_shader_image_load_store (resend).

2015-01-31 Thread Francisco Jerez
This is my third and last rebase and resend of the ARB_shader_image_load_store tests I sent to this mailing list last October. If there have been no objections by the 3rd February at noon (UTC) I will push the rest of the series without review. [PATCH 01/23] util/shader: Define nothrow variant

[Piglit] [PATCHv2 06/23] arb_shader_image_load_store: Import image format bitcasting test.

2015-01-31 Thread Francisco Jerez
The ARB_shader_image_load_store extension allows the reinterpretation of the binary contents of an existing image as an image of a different compatible format. The resulting values should be predictable and are defined in terms of the usual GL pixel transfer operations. v2: Actually bind the

Re: [Piglit] Tests for ARB_shader_image_load_store (resend).

2015-01-31 Thread Francisco Jerez
Francisco Jerez curroje...@riseup.net writes: This is my third and last rebase and resend of the ARB_shader_image_load_store tests I sent to this mailing list last October. If there have been no objections by the 3rd February at noon (UTC) I will push the rest of the series without review.

Re: [Piglit] [PATCHv2 02/23] arb_shader_image_load_store: Add common image metadata.

2015-01-31 Thread Jordan Justen
Reviewed-by: Jordan Justen jordan.l.jus...@intel.com On 2015-01-31 07:41:24, Francisco Jerez wrote: Define helper data structures and functions to query several kinds of information for any supported image format, target or shader stage, like the matching pixel transfer type and format for a

Re: [Piglit] [PATCH 01/23] util/shader: Define nothrow variant of piglit_compile_shader_text().

2015-01-31 Thread Francisco Jerez
Jordan Justen jordan.l.jus...@intel.com writes: On 2015-01-31 07:41:23, Francisco Jerez wrote: Define a variant of piglit_compile_shader_text() that doesn't call piglit_report_result() on failure killing the program, which is quite annoying for tests that expect a compilation to fail and for

Re: [Piglit] [PATCH 01/23] util/shader: Define nothrow variant of piglit_compile_shader_text().

2015-01-31 Thread Matt Turner
On Sat, Jan 31, 2015 at 7:41 AM, Francisco Jerez curroje...@riseup.net wrote: Define a variant of piglit_compile_shader_text() that doesn't call piglit_report_result() on failure killing the program, which is quite annoying for tests that expect a compilation to fail and for tests that are

Re: [Piglit] [PATCH 01/23] util/shader: Define nothrow variant of piglit_compile_shader_text().

2015-01-31 Thread Jordan Justen
On 2015-01-31 07:41:23, Francisco Jerez wrote: Define a variant of piglit_compile_shader_text() that doesn't call piglit_report_result() on failure killing the program, which is quite annoying for tests that expect a compilation to fail and for tests that are structured in a number of

Re: [Piglit] [PATCH 01/23] util/shader: Define nothrow variant of piglit_compile_shader_text().

2015-01-31 Thread Francisco Jerez
Hi Matt, Matt Turner matts...@gmail.com writes: On Sat, Jan 31, 2015 at 7:41 AM, Francisco Jerez curroje...@riseup.net wrote: Define a variant of piglit_compile_shader_text() that doesn't call piglit_report_result() on failure killing the program, which is quite annoying for tests that

Re: [Piglit] [PATCH 01/23] util/shader: Define nothrow variant of piglit_compile_shader_text().

2015-01-31 Thread Jordan Justen
On 2015-01-31 11:45:59, Francisco Jerez wrote: Jordan Justen jordan.l.jus...@intel.com writes: On 2015-01-31 07:41:23, Francisco Jerez wrote: Define a variant of piglit_compile_shader_text() that doesn't call piglit_report_result() on failure killing the program, which is quite annoying