Re: [Piglit] [PATCH] framework/run.py: add option to not retry incomplete tests on resume

2015-05-20 Thread Dylan Baker
On Thu, May 21, 2015 at 12:31:40AM +, Mason, Michael W wrote: > > -Original Message- > > From: Dylan Baker [mailto:baker.dyla...@gmail.com] > > Sent: Wednesday, May 20, 2015 5:27 PM > > To: Mason, Michael W > > Cc: piglit@lists.freedesktop.org > > Subject: Re: [Piglit] [PATCH] framework

Re: [Piglit] [PATCH v2] arb_direct_state_access: Add a FramebufferTextureLayer cube-map test

2015-05-20 Thread Ian Romanick
On 04/29/2015 12:21 PM, Fredrik Höglund wrote: > This test verifies that faces of a cube-map texture can be attached > to a framebuffer object using glNamedFramebufferTextureLayer and > glFramebufferTextureLayer. > --- > > v2: - Remove the check for ARB_vertex_array_object (core in 3.0) > - Fi

Re: [Piglit] [PATCH] framework/run.py: add option to not retry incomplete tests on resume

2015-05-20 Thread Mason, Michael W
> -Original Message- > From: Dylan Baker [mailto:baker.dyla...@gmail.com] > Sent: Wednesday, May 20, 2015 5:27 PM > To: Mason, Michael W > Cc: piglit@lists.freedesktop.org > Subject: Re: [Piglit] [PATCH] framework/run.py: add option to not retry > incomplete tests on resume > > Looks good

Re: [Piglit] [PATCH] framework/run.py: add option to not retry incomplete tests on resume

2015-05-20 Thread Dylan Baker
Looks good to me. Reviewed-by: Dylan Baker btw, do you have push access? On Wed, May 20, 2015 at 02:17:04PM -0700, Mike Mason wrote: > This patch adds an option to not retry incomplete tests when resuming > a test run. This is especially useful when a failing test causes > a crash or reboot. Cu

Re: [Piglit] [PATCH] framework/run.py: allow additional excluded tests on resume

2015-05-20 Thread Mason, Michael W
OK, I'm abandoning this patch in favor of this one: [Piglit] [PATCH] framework/run.py: add option to not retry incomplete tests on resume Mike > -Original Message- > From: Dylan Baker [mailto:baker.dyla...@gmail.com] > Sent: Tuesday, May 19, 2015 3:05 PM > To: Mason, Michael W > Cc: Da

[Piglit] [PATCH] framework/run.py: add option to not retry incomplete tests on resume

2015-05-20 Thread Mike Mason
This patch adds an option to not retry incomplete tests when resuming a test run. This is especially useful when a failing test causes a crash or reboot. Currently, that same test runs again when attempting to resume the test run, resulting in the same crash or reboot. Signed-off-by: Mike Mason -

Re: [Piglit] [PATCH v2] program_interface_query: add new subtest for getprogramresourceiv

2015-05-20 Thread Martin Peres
On 20/05/15 15:10, Samuel Iglesias Gonsalvez wrote: Test that uniforms inside arrays of uniform blocks with instance name are queried properly. Tested on NVIDIA's proprietary driver version 340.65 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90397 Signed-off-by: Samuel Iglesias Gonsa

[Piglit] [PATCH v2] program_interface_query: add new subtest for getprogramresourceiv

2015-05-20 Thread Samuel Iglesias Gonsalvez
Test that uniforms inside arrays of uniform blocks with instance name are queried properly. Tested on NVIDIA's proprietary driver version 340.65 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90397 Signed-off-by: Samuel Iglesias Gonsalvez --- V2: * Change instance name for the array

Re: [Piglit] [PATCH] program_interface_query: add new subtest for getprogramresourceiv

2015-05-20 Thread Martin Peres
On 20/05/15 11:39, Samuel Iglesias Gonsálvez wrote: On 19/05/15 12:02, Martin Peres wrote: On 19/05/15 08:46, Samuel Iglesias Gonsalvez wrote: Test that uniforms inside arrays of uniform blocks with instance name are queried properly. Tested on NVIDIA's proprietary driver version 340.65 Bugzi

Re: [Piglit] [PATCH] program_interface_query: add new subtest for getprogramresourceiv

2015-05-20 Thread Samuel Iglesias Gonsálvez
On 19/05/15 12:02, Martin Peres wrote: > On 19/05/15 08:46, Samuel Iglesias Gonsalvez wrote: >> Test that uniforms inside arrays of uniform blocks with instance name are >> queried properly. >> >> Tested on NVIDIA's proprietary driver version 340.65 >> >> Bugzilla: https://bugs.freedesktop.org/show

Re: [Piglit] [PATCH 06/25] arb_direct_state_access: Use piglit_reset_gl_error in texunits

2015-05-20 Thread Pohjolainen, Topi
On Mon, May 18, 2015 at 01:49:59PM -0700, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick This is also: Reviewed-by: Topi Pohjolainen Unfortunately I don't have much input for the rest of the patches in the series. > --- > tests/spec/arb_direct_state_access/texunit

Re: [Piglit] [PATCH 05/25] arb_direct_state_access: Use piglit_draw_rect and piglit_draw_rect_tex in copy texsubimage

2015-05-20 Thread Pohjolainen, Topi
On Mon, May 18, 2015 at 01:49:58PM -0700, Ian Romanick wrote: > From: Ian Romanick > > This test is based on a very, very old piglit test. It's so old that it > predates these utility functions. > > Signed-off-by: Ian Romanick Patches 3-5 are clear improvements in my eyes: Reviewed-by: Topi