Re: [Piglit] [PATCH] glsl-1.10: test for rotating a variable components in a loop

2015-09-01 Thread Ilia Mirkin
On Tue, Sep 1, 2015 at 9:02 PM, Dave Airlie wrote: > From: Dave Airlie > > This test fails on r600 with sb enabled, it does something > similiar to what a lot of the CTS test cases do. > > Signed-off-by: Dave Airlie > --- > .../fs-while-loop-rotate-value.shader_test | 32 >

[Piglit] [PATCH] glsl-1.10: test for rotating a variable components in a loop

2015-09-01 Thread Dave Airlie
From: Dave Airlie This test fails on r600 with sb enabled, it does something similiar to what a lot of the CTS test cases do. Signed-off-by: Dave Airlie --- .../fs-while-loop-rotate-value.shader_test | 32 ++ 1 file changed, 32 insertions(+) create mode 100644 tes

Re: [Piglit] [PATCH] Porting basic GL rendering tests to piglit

2015-09-01 Thread Ilia Mirkin
On Tue, Sep 1, 2015 at 5:49 PM, Juliet Fru wrote: > --- > tests/all.py| 1 + > tests/spec/gl-1.0/CMakeLists.gl.txt | 1 + > tests/spec/gl-1.0/no-op-paths.c | 332 > > 3 files changed, 334 insertions(+) > create mode 100644 tes

[Piglit] Fwd: [PATCH] Removed Glean GL rendering paths test

2015-09-01 Thread Juliet Fru
--- tests/all.py | 1 - tests/glean/CMakeLists.gl.txt | 1 - tests/glean/tpaths.cpp| 375 -- tests/glean/tpaths.h | 79 - 4 files changed, 456 deletions(-) delete mode 100644 tests/glean/tpaths.cpp delete mode

Re: [Piglit] [PATCH v2 4/4] Add API tests for KHR_texture_compression_astc_ldr

2015-09-01 Thread Nanley Chery
On Tue, Sep 1, 2015 at 11:56 AM, Dylan Baker wrote: > I assume this should be added to all.py as well? > > Yes. I've fixed this locally. > On Fri, Aug 28, 2015 at 09:44:38AM -0700, Nanley Chery wrote: > > From: Nanley Chery > > > > These tests check that the GL error returned by valid and inva

Re: [Piglit] [PATCH] arb_copy_image: fix a few error check tests

2015-09-01 Thread Brian Paul
On 09/01/2015 02:33 PM, Ian Romanick wrote: On 08/31/2015 04:22 PM, Brian Paul wrote: Some of the error checks were incorrect before. Per the spec: 1. GL_TEXTURE_BUFFER and GL_TEXTURE_CUBE_MAP_+/-_XYZ are not legal targets and should be flagged as invalid enums. I think we should not check t

[Piglit] [PATCH] arb_copy_image: fix a few error check tests

2015-09-01 Thread Brian Paul
Some of the error checks were incorrect before. Per the spec: 1. GL_TEXTURE_BUFFER and GL_TEXTURE_CUBE_MAP_+/-_XYZ are not legal targets and should be flagged as invalid enums. 2. GL_INVALID_OPERATION should be generated when trying to copy between compressed/uncompressed formats whose block/tex

[Piglit] [PATCH] Porting basic GL rendering tests to piglit

2015-09-01 Thread Juliet Fru
--- tests/all.py| 1 + tests/spec/gl-1.0/CMakeLists.gl.txt | 1 + tests/spec/gl-1.0/no-op-paths.c | 332 3 files changed, 334 insertions(+) create mode 100644 tests/spec/gl-1.0/no-op-paths.c diff --git a/tests/all.py b/tests/al

Re: [Piglit] [PATCH] arb_copy_image: fix a few error check tests

2015-09-01 Thread Ian Romanick
On 08/31/2015 04:22 PM, Brian Paul wrote: > Some of the error checks were incorrect before. Per the spec: > > 1. GL_TEXTURE_BUFFER and GL_TEXTURE_CUBE_MAP_+/-_XYZ are not legal targets > and should be flagged as invalid enums. I think we should not check these targets. Checking for either error

Re: [Piglit] [PATCH v2 4/4] Add API tests for KHR_texture_compression_astc_ldr

2015-09-01 Thread Dylan Baker
I assume this should be added to all.py as well? On Fri, Aug 28, 2015 at 09:44:38AM -0700, Nanley Chery wrote: > From: Nanley Chery > > These tests check that the GL error returned by valid and invalid API calls > are as defined by the spec. > > Signed-off-by: Nanley Chery > --- > .../khr_tex

Re: [Piglit] [PATCH] abr_gpu_shader_fp64: Verify that setting a double with glUniform*fv is an error

2015-09-01 Thread Ilia Mirkin
On Tue, Sep 1, 2015 at 2:33 PM, Ian Romanick wrote: > On 08/31/2015 09:34 PM, Ilia Mirkin wrote: >> On Mon, Aug 31, 2015 at 11:55 PM, Ian Romanick wrote: >>> +static const char vs_source[] = >>> + "#version 330\n" >> >> The test description above only requires version 150. AFAIK there's no

Re: [Piglit] [PATCH] abr_gpu_shader_fp64: Verify that setting a double with glUniform*fv is an error

2015-09-01 Thread Ian Romanick
On 08/31/2015 11:41 PM, Matt Turner wrote: > On Mon, Aug 31, 2015 at 8:55 PM, Ian Romanick wrote: >> From: Ian Romanick >> >> Also verify that setting a float with glUniform*dv generates an error. >> >> NOTE: Mesa currently fails the matrix tests. >> >> Signed-off-by: Ian Romanick >> Cc: Dave Ai

Re: [Piglit] [PATCH] abr_gpu_shader_fp64: Verify that setting a double with glUniform*fv is an error

2015-09-01 Thread Ian Romanick
On 08/31/2015 09:34 PM, Ilia Mirkin wrote: > On Mon, Aug 31, 2015 at 11:55 PM, Ian Romanick wrote: >> +static const char vs_source[] = >> + "#version 330\n" > > The test description above only requires version 150. AFAIK there's no > need for anything higher... Yes... that was a copy-and-p

Re: [Piglit] [PATCH] arb_copy_image: add new format swizzle test

2015-09-01 Thread Ilia Mirkin
On Tue, Sep 1, 2015 at 1:14 PM, Fredrik Höglund wrote: > On Tuesday 01 September 2015, Ilia Mirkin wrote: >> On Tue, Sep 1, 2015 at 12:22 PM, Fredrik Höglund wrote: >> > On Tuesday 01 September 2015, Brian Paul wrote: >> >> On 08/31/2015 05:38 PM, Ilia Mirkin wrote: >> >> > On Mon, Aug 31, 2015 a

Re: [Piglit] [PATCH] arb_copy_image: add new format swizzle test

2015-09-01 Thread Fredrik Höglund
On Tuesday 01 September 2015, Ilia Mirkin wrote: > On Tue, Sep 1, 2015 at 12:22 PM, Fredrik Höglund wrote: > > On Tuesday 01 September 2015, Brian Paul wrote: > >> On 08/31/2015 05:38 PM, Ilia Mirkin wrote: > >> > On Mon, Aug 31, 2015 at 7:29 PM, Ilia Mirkin > >> > wrote: > >> >> Reviewed-by: Il

Re: [Piglit] [PATCH] arb_copy_image: add new format swizzle test

2015-09-01 Thread Ilia Mirkin
On Tue, Sep 1, 2015 at 12:22 PM, Fredrik Höglund wrote: > On Tuesday 01 September 2015, Brian Paul wrote: >> On 08/31/2015 05:38 PM, Ilia Mirkin wrote: >> > On Mon, Aug 31, 2015 at 7:29 PM, Ilia Mirkin wrote: >> >> Reviewed-by: Ilia Mirkin >> >> >> >> Thanks a lot for doing this! I assume that i

Re: [Piglit] [PATCH] arb_copy_image: add new format swizzle test

2015-09-01 Thread Fredrik Höglund
On Tuesday 01 September 2015, Brian Paul wrote: > On 08/31/2015 05:38 PM, Ilia Mirkin wrote: > > On Mon, Aug 31, 2015 at 7:29 PM, Ilia Mirkin wrote: > >> Reviewed-by: Ilia Mirkin > >> > >> Thanks a lot for doing this! I assume that it fails with your gallium > >> ARB_copy_image implementation as

[Piglit] [PATCH] teximage-colors: replace assertion with useful info

2015-09-01 Thread Brian Paul
Instead of asserting or crashing on a bad command line format, print list of legal values. --- tests/texturing/teximage-colors.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/tests/texturing/teximage-colors.c b/tests/texturing/teximage-colors.c index ea0c5e1..bdd261b

[Piglit] [PATCH] ext_texture_integer: add new tex formats test

2015-09-01 Thread Brian Paul
Test glTexImage2D() and glGetTexImage() with a variety of internalFormats and user formats/types. Note: currently fails with Mesa, passes with NVIDIA. v2: fix % vs. & mix-up, move test code into piglit_init(). --- tests/all.py | 1 + tests/spec/ext_texture_i

[Piglit] [PATCH] arb_copy_image: add new format swizzle test

2015-09-01 Thread Brian Paul
Check that copies between textures whose formats may only differ by swizzling works correctly. v2: move test code into piglit_init() --- tests/all.py| 1 + tests/spec/arb_copy_image/CMakeLists.gl.txt | 1 + tests/spec/arb_copy_image/format-swizzle.c | 232

Re: [Piglit] [PATCH] arb_copy_image: add new format swizzle test

2015-09-01 Thread Brian Paul
On 08/31/2015 05:38 PM, Ilia Mirkin wrote: On Mon, Aug 31, 2015 at 7:29 PM, Ilia Mirkin wrote: Reviewed-by: Ilia Mirkin Thanks a lot for doing this! I assume that it fails with your gallium ARB_copy_image implementation as I predicted? Yes. In Mesa, I added some code that checks for swizzl

Re: [Piglit] [PATCH] ext_texture_integer: add new tex formats test

2015-09-01 Thread Brian Paul
On 08/31/2015 05:38 PM, Ilia Mirkin wrote: On Mon, Aug 31, 2015 at 7:21 PM, Brian Paul wrote: Test glTexImage2D() and glGetTexImage() with a variety of internalFormats and user formats/types. Note: currently fails with Mesa, passes with NVIDIA. --- tests/all.py