Re: [Piglit] [PATCH 2/8] Add texturing/texsubimage-unpack

2016-01-20 Thread Nicolai Hähnle
On 20.01.2016 20:43, Ian Romanick wrote: On 01/18/2016 01:40 PM, Nicolai Hähnle wrote: From: Nicolai Hähnle This is similar to the texsubimage test, but checks various type and format conversions as well as a different set of pixel unpack settings. I haven't looked

Re: [Piglit] [PATCH 1/2] shader_runner: add basic depthbuffer testing support

2016-01-20 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick On 01/19/2016 12:20 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > This commit adds an optional 'depthbuffer' line to the [require] > section as well as the possibility of enabling/disabling

Re: [Piglit] [PATCH 2/8] Add texturing/texsubimage-unpack

2016-01-20 Thread Ian Romanick
On 01/18/2016 01:40 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > This is similar to the texsubimage test, but checks various type and format > conversions as well as a different set of pixel unpack settings. I haven't looked at the texsubimage test, so some of

Re: [Piglit] [PATCH 1/8] fbo-formats: include information about number of bits in sized formats

2016-01-20 Thread Ian Romanick
On 01/18/2016 01:40 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > The idea is that tests can get an idea of how much precision to expect when > using these formats. > --- > tests/fbo/fbo-formats.h | 392 > > 1

[Piglit] [Bug 93783] [regression, bisected] arb_shader_image_load_store.compiler.declaration-format-qualifier-duplicate

2016-01-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93783 Mark Janes changed: What|Removed |Added Resolution|FIXED |---

Re: [Piglit] [PATCH] arb_shader_image_load_store: fix location of storage qualifier

2016-01-20 Thread Francisco Jerez
Timothy Arceri writes: > In GLSL 1.50 layout qualifiers must come before the storage > qualifier. A recent fix in Mesa exposed this issue. > > Cc: Ilia Mirkin Reviewed-by: Francisco Jerez > --- >

[Piglit] [PATCH] arb_shader_image_load_store: fix location of storage qualifier

2016-01-20 Thread Timothy Arceri
In GLSL 1.50 layout qualifiers must come before the storage qualifier. A recent fix in Mesa exposed this issue. Cc: Ilia Mirkin --- tests/spec/arb_shader_image_load_store/grid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Piglit] [PATCH V2] arb_shader_image_load_store: fix syntax error in execution tests

2016-01-20 Thread Timothy Arceri
On Wed, 2016-01-20 at 03:42 -0500, Ilia Mirkin wrote: > On Tue, Jan 19, 2016 at 9:21 PM, Timothy Arceri > wrote: > > @@ -98,7 +98,7 @@ header_hunk(const struct grid_info grid) > > "#define H %d\n" > > "#define N %d\n" > >

[Piglit] [Bug 93783] [regression, bisected] arb_shader_image_load_store.compiler.declaration-format-qualifier-duplicate

2016-01-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93783 --- Comment #5 from Timothy Arceri --- I've tested on my IVB and there is indeed more issues with the tests. They seem to take different paths in the tests on different hardware, so I didn't notice these when fixing on my

[Piglit] [Bug 93783] [regression, bisected] arb_shader_image_load_store.compiler.declaration-format-qualifier-duplicate

2016-01-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93783 --- Comment #6 from Timothy Arceri --- HSW/IVB issues resolve by piglit: commit9bd8454a24304eabadcc4a5f6766158bbb8eb508 arb_shader_image_load_store: fix location of storage qualifier In GLSL 1.50 layout qualifiers

[Piglit] [PATCH] arb_direct_state_access: Also test texture parameters around glGenerateTextureMipmap

2016-01-20 Thread Ian Romanick
From: Ian Romanick NOTE: This causes the test to fail on Mesa drivers that use meta (e.g., i965). Signed-off-by: Ian Romanick Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93717 --- .../generatetexturemipmap.c

Re: [Piglit] [PATCH V2] arb_shader_image_load_store: fix syntax error in execution tests

2016-01-20 Thread Ilia Mirkin
On Tue, Jan 19, 2016 at 9:21 PM, Timothy Arceri wrote: > @@ -98,7 +98,7 @@ header_hunk(const struct grid_info grid) > "#define H %d\n" > "#define N %d\n" > "#define GRID_T %s\n" > - "#define