Re: [Piglit] [PATCH] arb_enhanced_layouts: test packing of floats in the same slots as an array

It's traditional for green to mean good, red to mean bad. You have those flipped here. On Oct 10, 2017 2:58 AM, "Timothy Arceri" wrote: > This test causes an assert to be thrown on i965 currently. > --- > ...fs-array-interleave-single-location.shader_test | 93 > ++ > 1 file

Re: [Piglit] [PATCH] arb_enhanced_layouts: test packing of floats in the same slots as an array

On 10/10/17 23:39, Ilia Mirkin wrote: It's traditional for green to mean good, red to mean bad. You have those flipped here. Right. I'd fixed this locally but forgot to commit before sending. On Oct 10, 2017 2:58 AM, "Timothy Arceri" > wrote: This test cau

[Piglit] [PATCH v2] arb_enhanced_layouts: test packing of floats in the same slots as an array

This test causes an assert to be thrown on i965 currently. --- ...fs-array-interleave-single-location.shader_test | 93 ++ 1 file changed, 93 insertions(+) create mode 100644 tests/spec/arb_enhanced_layouts/execution/component-layout/vs-to-fs-array-interleave-single-location.

[Piglit] [PATCH] arb_shader_atomic_counter_ops: declare counters to fix undefined behaviour.

From: Dave Airlie It's undefined (including crashing) behaviour to use atomic counters without having bound enough storage for them. This fixes this test to bind the storage for the counters it uses. Signed-off-by: Dave Airlie --- .../arb_shader_atomic_counter_ops/execution/all_touch_test.shad

[Piglit] [PATCH] arrays_of_arrays/atomic_counters: set requirements on atomic counter numbers.

From: Dave Airlie These both use 20 counters so check against the limits before running. Signed-off-by: Dave Airlie --- .../execution/atomic_counters/fs-simple-inc-dec-read.shader_test | 1 + .../execution/atomic_counters/vs-simple-inc-dec-read.shader_test | 1 + 2 files change

[Piglit] [PATCH] arrays_of_arrays/atomic_counter: check counters limit on linker test.

From: Dave Airlie Signed-off-by: Dave Airlie --- .../arb_arrays_of_arrays/linker/vs-to-fs-atomic-counter.shader_test | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/spec/arb_arrays_of_arrays/linker/vs-to-fs-atomic-counter.shader_test b/tests/spec/arb_arrays_of_arrays/linker/vs

Re: [Piglit] [PATCH] arrays_of_arrays/atomic_counters: set requirements on atomic counter numbers.

Reviewed-by: Timothy Arceri On 11/10/17 11:24, Dave Airlie wrote: From: Dave Airlie These both use 20 counters so check against the limits before running. Signed-off-by: Dave Airlie --- .../execution/atomic_counters/fs-simple-inc-dec-read.shader_test | 1 + .../execution/atomic_c

Re: [Piglit] [PATCH] arrays_of_arrays/atomic_counter: check counters limit on linker test.

Reviewed-by: Timothy Arceri On 11/10/17 11:28, Dave Airlie wrote: From: Dave Airlie Signed-off-by: Dave Airlie --- .../arb_arrays_of_arrays/linker/vs-to-fs-atomic-counter.shader_test | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/spec/arb_arrays_of_arrays/linker/vs-to-fs

Re: [Piglit] [PATCH] arb_shader_atomic_counter_ops: declare counters to fix undefined behaviour.

Reviewed-by: Timothy Arceri On 11/10/17 11:18, Dave Airlie wrote: From: Dave Airlie It's undefined (including crashing) behaviour to use atomic counters without having bound enough storage for them. This fixes this test to bind the storage for the counters it uses. Signed-off-by: Dave Airlie

Re: [Piglit] [PATCH] arb_shader_atomic_counter_ops: declare counters to fix undefined behaviour.

Oops. Reviewed-by: Ian Romanick On 10/10/2017 05:18 PM, Dave Airlie wrote: > From: Dave Airlie > > It's undefined (including crashing) behaviour to use atomic counters > without having bound enough storage for them. This fixes this test > to bind the storage for the counters it uses. > > Sign