Re: [Piglit] [PATCH 2/2] all.py: filter directories traversed to find shader tests

2017-11-09 Thread Brian Paul
On 11/09/2017 05:29 PM, Dylan Baker wrote: Quoting Brian Paul (2017-11-09 15:16:33) The script searches all files under tests/ and generated_tests/ for files ending in ".shader_test". For each match, a ShaderTest() object is created and added to the test list. For GL extensions or versions not

[Piglit] [PATCH] framework: decrement argc in delete_arg()

2017-11-09 Thread Brian Paul
So it doesn't have to be done after every call to delete_arg(). --- tests/util/piglit-framework-gl.c | 23 +-- 1 file changed, 9 insertions(+), 14 deletions(-) diff --git a/tests/util/piglit-framework-gl.c b/tests/util/piglit-framework-gl.c index 22aadc5..1b2078d 100644 --- a/

[Piglit] [PATCH] all.py: filter directories traversed to find shader tests

2017-11-09 Thread Brian Paul
The script searches all files under tests/ and generated_tests/ for files ending in ".shader_test". For each match, a ShaderTest() object is created and added to the test list. For GL extensions or versions not supported by the driver, this is wasted effort. This patch looks for directories unde

Re: [Piglit] [PATCH 2/2] all.py: filter directories traversed to find shader tests

2017-11-09 Thread Dylan Baker
Quoting Brian Paul (2017-11-09 15:16:33) > The script searches all files under tests/ and generated_tests/ for > files ending in ".shader_test". For each match, a ShaderTest() object > is created and added to the test list. > > For GL extensions or versions not supported by the driver, this is >

Re: [Piglit] [PATCH 1/2] framework: fix wflinfo issues in opengl module

2017-11-09 Thread Dylan Baker
Quoting Brian Paul (2017-11-09 15:16:32) > 1. If the PIGLIT_PLATFORM string is 'mixed_glx_egl' we need to convert > it to 'glx' so that wflinfo understands it. > > 2. Look in the piglit bin/ directory for the wflinfo.exe program. > When we build piglit, we copy wflinfo.exe into the bin/ directory

[Piglit] [PATCH 1/2] framework: fix wflinfo issues in opengl module

2017-11-09 Thread Brian Paul
1. If the PIGLIT_PLATFORM string is 'mixed_glx_egl' we need to convert it to 'glx' so that wflinfo understands it. 2. Look in the piglit bin/ directory for the wflinfo.exe program. When we build piglit, we copy wflinfo.exe into the bin/ directory for packaging to avoid having to install waffle on

[Piglit] [PATCH 2/2] all.py: filter directories traversed to find shader tests

2017-11-09 Thread Brian Paul
The script searches all files under tests/ and generated_tests/ for files ending in ".shader_test". For each match, a ShaderTest() object is created and added to the test list. For GL extensions or versions not supported by the driver, this is wasted effort. This patch looks for directories unde

Re: [Piglit] [PATCH] util: remove -compat from arguments so as not to confuse tests

2017-11-09 Thread Brian Paul
On 11/09/2017 03:49 PM, Marek Olšák wrote: From: Marek Olšák --- tests/util/piglit-framework-gl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/util/piglit-framework-gl.c b/tests/util/piglit-framework-gl.c index 29e0e3a..22aadc5 100644 --- a/tests/util/piglit-framework-gl.c +++

Re: [Piglit] [PATCH 10/12] Remove text coord generation Glean test

2017-11-09 Thread Brian Paul
In subject line: s/text/texture/ -Brian On 11/09/2017 02:27 PM, Fabian Bieler wrote: --- tests/all.py | 1 - tests/glean/CMakeLists.gl.txt | 1 - tests/glean/ttexgen.cpp | 376 -- tests/glean/ttexgen.h | 67 ---

Re: [Piglit] [PATCH 01/12] Port point sprite test from Glean to Piglit

2017-11-09 Thread Brian Paul
On 11/09/2017 02:27 PM, Fabian Bieler wrote: The new test is also a bit stricter on rasterization then the old one. It shouldn't be stricter than the spec, however. --- tests/all.py | 1 + tests/spec/CMakeLists.txt | 1 + tests/spec/arb

Re: [Piglit] [PATCH] util: remove -compat from arguments so as not to confuse tests

2017-11-09 Thread Marek Olšák
On Thu, Nov 9, 2017 at 11:55 PM, Brian Paul wrote: > On 11/09/2017 03:49 PM, Marek Olšák wrote: >> >> From: Marek Olšák >> >> --- >> tests/util/piglit-framework-gl.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/tests/util/piglit-framework-gl.c >> b/tests/util/piglit-framework-

Re: [Piglit] [PATCH] arb_enhanced_layouts: add test for location aliasing with non-numerical type

2017-11-09 Thread Timothy Arceri
On 09/11/17 18:52, Iago Toral wrote: This is not so much based on the spec but based on the original code we had in the linker (which we still have) which assumes that all locations consumed by a struct variable use up all 4 components (thus preventing any kind of aliasing to be successful) based

[Piglit] [PATCH] util: remove -compat from arguments so as not to confuse tests

2017-11-09 Thread Marek Olšák
From: Marek Olšák --- tests/util/piglit-framework-gl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/util/piglit-framework-gl.c b/tests/util/piglit-framework-gl.c index 29e0e3a..22aadc5 100644 --- a/tests/util/piglit-framework-gl.c +++ b/tests/util/piglit-framework-gl.c @@ -179,20

Re: [Piglit] [PATCH] cmake: also install Windows manifest files

2017-11-09 Thread Jose Fonseca
On 09/11/17 20:51, Brian Paul wrote: The previous patch (5087aa3f1020d0 "cmake: create Win10 manifest files for particular executables") didn't copy the manifest files when doing 'make install'. This fixes that. It requires CMake 3.0 or later. Thanks to Brad King for helping out! --- cmake/p

[Piglit] [PATCH 06/12] Remove texture environment Glean test

2017-11-09 Thread Fabian Bieler
--- tests/all.py | 1 - tests/glean/CMakeLists.gl.txt | 1 - tests/glean/ttexenv.cpp | 674 -- tests/glean/ttexenv.h | 69 - 4 files changed, 745 deletions(-) delete mode 100644 tests/glean/ttexenv.cpp delete mode 10

[Piglit] [PATCH 10/12] Remove text coord generation Glean test

2017-11-09 Thread Fabian Bieler
--- tests/all.py | 1 - tests/glean/CMakeLists.gl.txt | 1 - tests/glean/ttexgen.cpp | 376 -- tests/glean/ttexgen.h | 67 4 files changed, 445 deletions(-) delete mode 100644 tests/glean/ttexgen.cpp delete mode

[Piglit] [PATCH 11/12] Port texture unit test from Glean to Piglit

2017-11-09 Thread Fabian Bieler
--- tests/all.py| 1 + tests/spec/gl-2.0/api/CMakeLists.gl.txt | 1 + tests/spec/gl-2.0/api/texture-units.c | 260 3 files changed, 262 insertions(+) create mode 100644 tests/spec/gl-2.0/api/texture-units.c diff --git a/tests/all

[Piglit] [PATCH 07/12] Port texture env combine4 test from Glean to Piglit

2017-11-09 Thread Fabian Bieler
The custom rolled random number generation was replaced by one from stdlib. --- tests/all.py | 5 + tests/spec/CMakeLists.txt | 1 + .../spec/nv_texture_env_combine4/CMakeLists.gl.txt | 13 ++ tests/spec/nv_texture_env_combine4/CM

[Piglit] [PATCH 03/12] Port texture env combine test from Glean to Piglit

2017-11-09 Thread Fabian Bieler
--- tests/all.py |5 + tests/llvmpipe.py |1 + tests/quick.py |7 + tests/spec/CMakeLists.txt |1 + .../spec/ext_texture_env_combine/CMakeLists.gl.txt

[Piglit] [PATCH 05/12] Port texture env test from Glean to Piglit

2017-11-09 Thread Fabian Bieler
Note: 3 texture environment functions (modulate, decal and blend) were introduces with OpenGL 1.0. GL 1.1 and 1.3 added the replace and add functions, respectively. As this test tests all 5 functions it is classified as OpenGL 1.3. --- tests/all.py| 1 + tests/spec/gl-1

[Piglit] [PATCH 02/12] Remove point sprite Glean test

2017-11-09 Thread Fabian Bieler
Replaced by new piglit arb_point_sprite-mipmap test. --- tests/all.py | 1 - tests/glean/CMakeLists.gl.txt | 1 - tests/glean/tpointsprite.cpp | 454 -- tests/glean/tpointsprite.h| 74 --- 4 files changed, 530 deletions(-) del

[Piglit] [PATCH 04/12] Remove texture env combine Glean test

2017-11-09 Thread Fabian Bieler
Replaced by new piglit ext_texture_env_combine-combine test. --- tests/all.py |1 - tests/glean/CMakeLists.gl.txt |1 - tests/glean/ttexcombine.cpp | 1715 - tests/glean/ttexcombine.h | 137 tests/llvmpipe.py

[Piglit] [PATCH 08/12] Remove texture env combine4 Glean test

2017-11-09 Thread Fabian Bieler
--- tests/all.py | 1 - tests/glean/CMakeLists.gl.txt | 1 - tests/glean/ttexcombine4.cpp | 415 -- tests/glean/ttexcombine4.h| 88 - 4 files changed, 505 deletions(-) delete mode 100644 tests/glean/ttexcombine4.cpp delet

[Piglit] [PATCH 09/12] Port tex coord generation test from Glean to Piglit

2017-11-09 Thread Fabian Bieler
Note that the Glean test used multiple vertex specification modes (immediate, vertex arrays, display lists, ...). This new test only uses one since the manner of vertex specification has no impact on the code path wrt texture coordinate generation in modern OpenGL implementations. Also this test d

[Piglit] [PATCH 12/12] Remove texture unit Glean test

2017-11-09 Thread Fabian Bieler
--- tests/all.py | 1 - tests/glean/CMakeLists.gl.txt | 1 - tests/glean/ttexunits.cpp | 319 -- tests/glean/ttexunits.h | 75 -- 4 files changed, 396 deletions(-) delete mode 100644 tests/glean/ttexunits.cpp delete

[Piglit] [PATCH 01/12] Port point sprite test from Glean to Piglit

2017-11-09 Thread Fabian Bieler
The new test is also a bit stricter on rasterization then the old one. It shouldn't be stricter than the spec, however. --- tests/all.py | 1 + tests/spec/CMakeLists.txt | 1 + tests/spec/arb_point_sprite/CMakeLists.gl.txt | 14 ++ tests/sp

[Piglit] [PATCH] gl-1.0-logicop: allow testing single mode on the command line

2017-11-09 Thread Brian Paul
And require GL 1.1 since that's when color logicops were introduced. Technically, we should move/rename the test, but it's hardly worth it. --- tests/spec/gl-1.0/logicop.c | 90 + 1 file changed, 58 insertions(+), 32 deletions(-) diff --git a/tests/spec

[Piglit] [PATCH] framework: specify GL_NEAREST filter for FBO textures

2017-11-09 Thread Brian Paul
By setting the min/mag filters, we give a hint to the OpenGL driver that we probaby don't want mipmapped textures. This results in the Mesa state tracker allocating single-level textures here instead of full mipmaps. --- tests/util/piglit-framework-gl/piglit_fbo_framework.c | 4 1 file chang

[Piglit] [PATCH] cmake: also install Windows manifest files

2017-11-09 Thread Brian Paul
The previous patch (5087aa3f1020d0 "cmake: create Win10 manifest files for particular executables") didn't copy the manifest files when doing 'make install'. This fixes that. It requires CMake 3.0 or later. Thanks to Brad King for helping out! --- cmake/piglit_util.cmake | 5 - 1 file chang

[Piglit] [PATCH] isinf-and-isnan: add clamp / min / max tests

2017-11-09 Thread sroland
From: Roland Scheidegger We expect non-nan results for these (according to d3d10 rules, and at least for min/max, also according to ieee rules). The tests will not actually fail with other results (since GL's NaN behavior is all undefined), albeit some apps may rely on this. (We'll use clamp to 0