Re: [Piglit] [PATCH] gl-1.0-blend-func: skip some blend tests when using LLVM 3.8

Brian Paul writes: > On 01/18/2018 01:27 PM, Eric Anholt wrote: >> Brian Paul writes: >> >>> To avoid an infinite loop. See code comments for details. >> >> Skipping a failing test and returning pass is wrong to me. > > It's not ideal. But the bug is in

Re: [Piglit] [PATCH] gl-1.0-blend-func: skip some blend tests when using LLVM 3.8

On 01/18/2018 01:27 PM, Eric Anholt wrote: Brian Paul writes: To avoid an infinite loop. See code comments for details. Skipping a failing test and returning pass is wrong to me. It's not ideal. But the bug is in LLVM and cannot readily be fixed in llvmpipe. I

Re: [Piglit] [PATCH] gl-1.0-blend-func: skip some blend tests when using LLVM 3.8

Am 18.01.2018 um 21:04 schrieb Brian Paul: > On 01/18/2018 12:38 PM, Roland Scheidegger wrote: >> Am 18.01.2018 um 20:07 schrieb Brian Paul: >>> To avoid an infinite loop.  See code comments for details. >>> --- >>>   tests/spec/gl-1.0/blend.c | 39 +++ >>>   1

Re: [Piglit] [PATCH] gl-1.0-blend-func: skip some blend tests when using LLVM 3.8

Brian Paul writes: > To avoid an infinite loop. See code comments for details. Skipping a failing test and returning pass is wrong to me. signature.asc Description: PGP signature ___ Piglit mailing list

Re: [Piglit] [PATCH] gl-1.0-blend-func: skip some blend tests when using LLVM 3.8

On 01/18/2018 12:38 PM, Roland Scheidegger wrote: Am 18.01.2018 um 20:07 schrieb Brian Paul: To avoid an infinite loop. See code comments for details. --- tests/spec/gl-1.0/blend.c | 39 +++ 1 file changed, 39 insertions(+) diff --git

Re: [Piglit] [PATCH] cl: Add test for MUBUF access with a negative vaddr

On Tue, 2017-11-28 at 14:20 -0800, Matt Arsenault wrote: > Explanation in test comment. > --- > .../program/execute/amdgcn-mubuf-negative-vaddr.cl | 62 > ++ > 1 file changed, 62 insertions(+) > create mode 100644 tests/cl/program/execute/amdgcn-mubuf-negative-vaddr.cl > >

[Piglit] Question regarding Crucible TODO item

Hello! The Crucible TODO.txt file contains: - Add a --diff option to crucible-run that dumps image diffs for failed tests. (Requires multiple command buffers). I do not understand how an optional image diff dump would require multiple command buffers. Couldn't the diff be generated on the CPU?

Re: [Piglit] [PATCH] gl-1.0-blend-func: skip some blend tests when using LLVM 3.8

Am 18.01.2018 um 20:07 schrieb Brian Paul: > To avoid an infinite loop. See code comments for details. > --- > tests/spec/gl-1.0/blend.c | 39 +++ > 1 file changed, 39 insertions(+) > > diff --git a/tests/spec/gl-1.0/blend.c b/tests/spec/gl-1.0/blend.c >

[Piglit] [PATCH] gl-1.0-blend-func: skip some blend tests when using LLVM 3.8

To avoid an infinite loop. See code comments for details. --- tests/spec/gl-1.0/blend.c | 39 +++ 1 file changed, 39 insertions(+) diff --git a/tests/spec/gl-1.0/blend.c b/tests/spec/gl-1.0/blend.c index 35e940f..e69ed31 100644 --- a/tests/spec/gl-1.0/blend.c

Re: [Piglit] [PATCH 2/3] gl-1.0-blend-func: add --quick option

On 01/17/2018 04:55 PM, Roland Scheidegger wrote: That should help llvmpipe quite a bit... Albeit 1% doesn't sound like it would give a lot of coverage, maybe a bit more (5% or so) would still cut down the time significantly while having less risk of missing failures? Hmm, it looks like

Re: [Piglit] [PATCH 2/3] gl-1.0-blend-func: add --quick option

That should help llvmpipe quite a bit... Albeit 1% doesn't sound like it would give a lot of coverage, maybe a bit more (5% or so) would still cut down the time significantly while having less risk of missing failures? Either way, for 1-2/3 Reviewed-by: Roland Scheidegger Am

[Piglit] [PATCH 2/3] gl-1.0-blend-func: add --quick option

The test normally runs about 27,000 tests and takes quite a long time with some drivers. With the --quick option, only 1% of the tests are run. And update tests/quick.py to run the test with --quick. --- tests/quick.py| 7 +++ tests/spec/gl-1.0/blend.c | 23

[Piglit] [PATCH 3/3] gl-1.0-dlist-materials: new test of materials in display lists

This exercises two code paths in Mesa's display list VBO code. --- tests/all.py| 1 + tests/spec/gl-1.0/CMakeLists.gl.txt | 1 + tests/spec/gl-1.0/dlist-materials.c | 164 3 files changed, 166 insertions(+) create mode 100644

Re: [Piglit] [PATCH 3/3] gl-1.0-dlist-materials: new test of materials in display lists

Am 17.01.2018 um 23:54 schrieb Brian Paul: > This exercises two code paths in Mesa's display list VBO code. > --- > tests/all.py| 1 + > tests/spec/gl-1.0/CMakeLists.gl.txt | 1 + > tests/spec/gl-1.0/dlist-materials.c | 164 > > 3

Re: [Piglit] [PATCH] cl: Add test for MUBUF access with a negative vaddr

ping > On Dec 15, 2017, at 14:01, Matt Arsenault wrote: > > ping > >> On Nov 28, 2017, at 17:20, Matt Arsenault wrote: >> >> Explanation in test comment. >> --- >> .../program/execute/amdgcn-mubuf-negative-vaddr.cl | 62 >> ++ >> 1