Re: [Piglit] [PATCH] Add a test for instanced GS inputs.

2018-06-22 Thread andrii.simiklit
Hello, It would be great If somebody could take a look this test) This test against following bug: https://bugs.freedesktop.org/show_bug.cgi?id=96354 Regards, Andrii. On 05.06.18 16:33, Andrii Simiklit wrote: All of our other tests for instanced geometry shaders don't actually transfe

[Piglit] [PATCH] compatibility: test vertex color clamping in geom and tess shaders

2018-06-22 Thread Timothy Arceri
--- .../tes-clamp-vertex-color.shader_test| 76 +++ .../gs-clamp-vertex-color.shader_test | 47 2 files changed, 123 insertions(+) create mode 100644 tests/spec/arb_tessellation_shader/execution/compatibility/tes-clamp-vertex-color.shader_test create

Re: [Piglit] [PATCH v3] unsized_array_member: It should expect link success instead of link error

2018-06-22 Thread Dylan Baker
Quoting Eleni Maria Stea (2018-06-18 00:13:50) > Modified the unsized_array_member.shader_test to expect successful > linking instead of linker error. > > According to the GLSLang Specification (version 4.60 Section 4.2 Scoping): Please update the comment in the commit message to match the one in

Re: [Piglit] [PATCH 03/24] framework: add --glsl option

2018-06-22 Thread Dylan Baker
Quoting Alejandro PiƱeiro (2018-06-20 05:40:38) > So when executing shader tests, they will be executed with -glsl. This > is the force GLSL mode, that is only relevant if the shader test > includes SPIR-V shaders. I'm not sure I understand what you're doing. It looks like you're planning to build

Re: [Piglit] [PATCH] deqp: Add Mesa version overrides for khr_gl* testlist generation.

2018-06-22 Thread Dylan Baker
Quoting Eric Anholt (2018-06-20 17:52:34) > The runner will assertion fail if it can't create an appropriate > context, so just force the version so that we can get our testlists > generated. > --- > framework/test/deqp.py | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --gi

[Piglit] [PATCH 4/7] intel_shader_atomic_float_minmax: Add tests for atomicCompSwap(float, float, float)

2018-06-22 Thread Ian Romanick
From: Ian Romanick This test is similar to the NV_shader_atomic_float test for atomicAdd. Instead of using atomicAdd, it uses a loop with atomicCompSwap to open-code it. Signed-off-by: Ian Romanick --- .../shared-atomicCompSwap-float.shader_test| 66 + .../ssbo-atomicCo

[Piglit] [PATCH 2/7] intel_shader_atomic_float_minmax: Add tests for atomicExchange(float, float)

2018-06-22 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- .../shared-atomicExchange-float.shader_test| 77 + .../ssbo-atomicExchange-float.shader_test | 78 ++ 2 files changed, 155 insertions(+) create mode 100644 tests/spec/intel_shader_atomi

[Piglit] [PATCH 7/7] intel_shader_atomic_float_minmax: Validate NaN behavior of atomicMin and atomicMax

2018-06-22 Thread Ian Romanick
From: Ian Romanick The behavior of NaN with atomicMin and atomicMax is nontrivial. This test should hit all the possible combinations of non-NaN, signaling NaN, and quite NaN. The the tests or the extension spec for more details. The data for these tests was generated using Python code that is

[Piglit] [PATCH 6/7] intel_shader_atomic_float_minmax: Add test for atomicCompSwap involving NaN

2018-06-22 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- .../ssbo-atomicCompSwap-float-NaN.shader_test | 64 ++ 1 file changed, 64 insertions(+) create mode 100644 tests/spec/intel_shader_atomic_float_minmax/execution/ssbo-atomicCompSwap-float-NaN.shader_test diff --git a

[Piglit] [PATCH 3/7] intel_shader_atomic_float_minmax: Add tests for atomic{Min, Max}(float, float)

2018-06-22 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- .../execution/shared-atomicMax-float.shader_test | 139 .../execution/shared-atomicMin-float.shader_test | 143 + .../execution/ssbo-atomicMax-float.shader_test | 141 .../ex

[Piglit] [PATCH 5/7] intel_shader_atomic_float_minmax: Add tests for atomicCompSwap with -0

2018-06-22 Thread Ian Romanick
From: Ian Romanick The idea is that implementations that use the integer compare-and-swap hardware will not see that 0.0 == -0.0. Signed-off-by: Ian Romanick --- ...-atomicCompSwap-float-negative-zero.shader_test | 63 ++ 1 file changed, 63 insertions(+) create mode 100644

[Piglit] [PATCH 1/7] intel_shader_atomic_float_minmax: Simple negative compile tests

2018-06-22 Thread Ian Romanick
From: Ian Romanick If the extension isn't enabled in the shader, the functions should not be availale. Yes, I botched this in the initial implementation. Signed-off-by: Ian Romanick --- .../compiler/shared-atomicExchange-float-fail.comp | 20 .../compiler/shared-atomicMax