>
> I think if we actually want to fix this properly then we could do it by
> making a NIR linker for GLSL.
>
> [1] https://bugs.freedesktop.org/show_bug.cgi?id=92822
OK. Thanks for the thorough explanation! I'll drop this patch.
>
> On 9/2/19 3:59 am, Andres
This is:
Reviewed-by: Andres Gomez
On Tue, 2019-03-19 at 14:29 +1100, Timothy Arceri wrote:
> This test for a crash in Mesa seen in an Assasins Creed Odyssey shader.
> ---
> ...riable-iteration-limit-unroll4.shader_test | 88 +++
> 1 file changed, 88 insertions(
On Wed, 2019-03-20 at 20:56 +1100, Timothy Arceri wrote:
>
> On 20/3/19 7:58 pm, Juan A. Suarez Romero wrote:
> > For the 4 first patches in the series:
> >
> > Reviewed-by: Juan A. Suarez
> >
> >
> > On Fri, 2019-02-01 at 19:55 +0200, Andres
On Tue, 2019-03-19 at 16:14 +0200, Andres Gomez wrote:
> On Sat, 2019-02-16 at 10:22 +1100, Timothy Arceri wrote:
> > It would be great if you could run this test on the Nvidia binary blob
> > to confirm the results. If everything works as expected the series is:
>
> The p
er.
Hence, I'll understand I can land this series with your Rb.
> Reviewed-by: Timothy Arceri
>
> Thanks for fixing all this!
>
> On 9/2/19 3:57 am, Andres Gomez wrote:
> > Previuosly, this was overlooked asuming that, since they were SSOs, no
> > inner interfa
On Fri, 2019-02-22 at 18:15 +, Eric Engestrom wrote:
>
> On February 22, 2019 2:51:28 PM UTC, Andres Gomez wrote:
> > The property is supported by most of the editors, but not all:
> > https://github.com/editorconfig/editorconfig/wiki/EditorConfig-Properties#max_line_length
The property is supported by most of the editors, but not all:
https://github.com/editorconfig/editorconfig/wiki/EditorConfig-Properties#max_line_length
Cc: Eric Engestrom
Cc: Eric Anholt
Signed-off-by: Andres Gomez
---
.editorconfig | 4
1 file changed, 4 insertions(+)
diff --git a
separate active variable."
Cc: Timothy Arceri
Cc: Martin Peres
Signed-off-by: Andres Gomez
---
.../spec/arb_program_interface_query/getprogramresourceindex.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/spec/arb_program_interface_query/getprogra
Arceri
Cc: Tapani Pälli
Cc: Ilia Mirkin
Cc: Martin Peres
Signed-off-by: Andres Gomez
---
.../spec/arb_program_interface_query/common.h | 61 ---
.../getprogramresourceiv.c| 8 +--
.../resource-query.c | 48 +++
3 files c
Cc: Timothy Arceri
Cc: Martin Peres
Signed-off-by: Andres Gomez
---
tests/spec/arb_program_interface_query/resource-query.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/spec/arb_program_interface_query/resource-query.c
b/tests/spec/arb_program_interface_query
This addresses, basically, problems due to interface mismatching with
separable program objects.
Andres Gomez (2):
arb_program_interface_query: correct tests table indentation
arb_program_interface_query: correct rendez-vous by name matching
.../spec/arb_program_interface_query/common.h
nputs on the interface
will be undefined."
Cc: Timothy Arceri
Cc: Iago Toral Quiroga
Cc: Samuel Iglesias Gonsálvez
Cc: Tapani Pälli
Cc: Ian Romanick
Cc: Ilia Mirkin
Signed-off-by: Andres Gomez
---
.../CMakeLists.gl.txt | 2 +
.../rendezvous_by_location
From the GL_ARB_enhanced_layouts spec:
" No aliasing in output buffers is allowed: It is a compile-time or
link-time error to specify variables with overlapping transform
feedback offsets."
v2: added forgotten check_link.
Cc: Timothy Arceri
Signed-off-by: An
On Sat, 2019-02-02 at 10:15 +1100, Timothy Arceri wrote:
> On 2/2/19 4:55 am, Andres Gomez wrote:
> > Additional check to address a bug in mesa in which a stride which
> > is a divisor of the declared offset for an overflowing varying
> > won't fail.
> >
> >
From the GL_ARB_enhanced_layouts spec:
" No aliasing in output buffers is allowed: It is a compile-time or
link-time error to specify variables with overlapping transform
feedback offsets."
Cc: Timothy Arceri
Signed-off-by: Andres Gomez
---
.../xfb_offset/invalid-ov
her stated on declarations before
or after the *xfb_stride*, or in different compilation units."
Cc: Timothy Arceri
Signed-off-by: Andres Gomez
---
.../xfb_stride/variable-stride-overflow2.vert | 28 +++
1 file changed, 28 insertions(+)
create mode 100
that every path through the vertex shader executable accesses
multiple inputs aliased to any single component."
Cc: Timothy Arceri
Cc: Iago Toral Quiroga
Cc: Ilia Mirkin
Signed-off-by: Andres Gomez
---
.../type-mismatch-signed-double.vert | 59 +++
.../widt
d qualification,
and neither has a location qualifier, or
– the two variables are declared with the same location and
component layout qualifiers and match in type and
qualification."
Cc: Timothy Arceri
Cc: Iago Toral Quiroga
Cc: Ilia Mirkin
Signed-
utput."
Cc: Timothy Arceri
Cc: Iago Toral Quiroga
Cc: Samuel Iglesias Gonsálvez
Cc: Tapani Pälli
Cc: Ian Romanick
Signed-off-by: Andres Gomez
---
...explicit-location-unused-input.shader_test | 38 +++
1 file changed, 38 insertions(+)
create mode 100644
tests/spec/ar
are assigned to the same location."
Cc: Timothy Arceri
Cc: Iago Toral Quiroga
Cc: Ilia Mirkin
Signed-off-by: Andres Gomez
---
...uplicated-input-overlap-double.shader_test | 58 +++
...ation-duplicated-input-overlap.shader_test | 55 ++
...pli
Cc: Timothy Arceri
Signed-off-by: Andres Gomez
---
.../compiler/component-layout/double-component-1.vert | 4 ++--
.../compiler/component-layout/double-component-3.vert | 4 ++--
.../compiler/component-layout/dvec2.vert | 4 ++--
.../compiler/component-layout/dvec3.vert
mponent 1 or 3 as the
beginning of a double or dvec2."
Cc: Timothy Arceri
Cc: Kenneth Graunke
Signed-off-by: Andres Gomez
---
.../arb_enhanced_layouts/compiler/component-layout/dvec3.vert | 2 +-
.../arb_enhanced_layouts/compiler/component-layout/dvec4.vert | 2 +-
.../execution/compon
Cc: Timothy Arceri
Signed-off-by: Andres Gomez
---
.../vs-gs-fs-double.shader_test | 16 +++
.../vs-tcs-tes-fs-double.shader_test | 42 +--
...-fs-type-mismatch-double-float.shader_test | 4 +-
...-fs-type-mismatch-signed-float.shader_test | 4
haring the location
must have the same underlying numerical type (floating-point or
integer) and the same auxiliary storage and interpolation
qualification."
Cc: Timothy Arceri
Signed-off-by: Andres Gomez
---
...ned.shader_test => vs-to-fs-signed-unsigned.shader_test} | 6 ++
This series adds several arb_enhanced_layouts tests and some
arb_separate_shader_objects more addressing problems found in mesa and
not checked in piglit.
They are mostly related to the use of the location, component,
xfb_offset and xfb_stride layout qualifiers.
Andres Gomez (10
This is:
Reviewed-by: Andres Gomez
On Sun, 2018-12-02 at 11:28 -0500, Rhys Kidd wrote:
> Travis-CI has or will shortly make in early December 2018 a number of
> beneficial
> changes to their Linux continuous integration testing infrastructure [0][1].
> An accompanying benefit of th
Cc: Mark Janes
Cc: Dylan Baker
Cc: Juan A. Suarez Romero
Signed-off-by: Andres Gomez
---
tests/gtf_gl.py | 95 +
1 file changed, 95 insertions(+)
create mode 100644 tests/gtf_gl.py
diff --git a/tests/gtf_gl.py b/tests/gtf_gl.py
new file mode
Cc: Mark Janes
Cc: Dylan Baker
Cc: Juan A. Suarez Romero
Signed-off-by: Andres Gomez
---
tests/gtf_gles.py | 82 +++
1 file changed, 82 insertions(+)
create mode 100644 tests/gtf_gles.py
diff --git a/tests/gtf_gles.py b/tests/gtf_gles.py
new file
On Sun, 2018-07-29 at 13:10 +0100, Daniel Stone wrote:
> Hi,
>
> On Mon, 23 Jul 2018 at 18:20, Eric Engestrom wrote:
> > On Friday, 2018-07-20 09:41:12 +0300, Andres Gomez wrote:
> > > On Mon, 2018-06-11 at 12:15 +0100, Eric Engestrom wrote:
> > > > On Mon
On Thu, 2018-07-19 at 22:16 -0400, Rhys Kidd wrote:
> On Thu, 19 Jul 2018 at 18:59, Andres Gomez wrote:
> > It's quite old and not even supported by wheel any more.
> >
> > Cc: Juan A. Suarez Romero
> > Cc: Dylan Baker
> > Signed-off-by: Andres Gomez
&g
It's quite old and not even supported by wheel any more.
Cc: Juan A. Suarez Romero
Cc: Dylan Baker
Signed-off-by: Andres Gomez
---
.travis.yml | 2 --
1 file changed, 2 deletions(-)
diff --git a/.travis.yml b/.travis.yml
index b4cbcca49..b6e8136e8 100644
--- a/.travis.yml
+++ b/.travi
This avoids modifications in the original filters object.
Detected through Travis CI.
Fixed also a couple of typos.
Fixes: 1f0f2ad25 ("framework: Add filters class")
Cc: Dylan Baker
Cc: Michel Dänzer
Signed-off-by: Andres Gomez
---
framework/profile.py
pytest-warnings is not needed since it was integrated into pytest's
core since 3.1
pytest-timeout >= 1.3.0 requires pytest >= 3.6.0 and we want to keep
using 3.2.5
Cc: Juan A. Suarez Romero
Cc: Dylan Baker
Signed-off-by: Andres Gomez
---
tox.ini | 3 +--
1 file changed, 1 inse
This is:
Reviewed-by: Andres Gomez
On Thu, 2018-04-19 at 09:44 +0200, Juan A. Suarez Romero wrote:
> Commit 7cf9e743a updated deqp mustpass lists to use text based mustpass.
>
> Hence unit tests should use text based mustpass too.
>
> Fixes: 7cf9e743a ("framework: updat
After:
https://github.com/KhronosGroup/VK-GL-CTS/commit/f06134c65f55a009bbe284d2b7c0e56dee0f70cd
The Khronos CTS runner added a new KHR-NoContext case list.
This new test profile will run this new subset.
Cc: Mark Janes
Cc: Dylan Baker
Cc: Juan A. Suarez Romero
Signed-off-by: Andres Gomez
. Suarez Romero
Signed-off-by: Andres Gomez
---
tests/khr_gles.py | 88 +++
1 file changed, 88 insertions(+)
create mode 100644 tests/khr_gles.py
diff --git a/tests/khr_gles.py b/tests/khr_gles.py
new file mode 100644
index 0..59a0fe089
cmake based job.
>
> Acked-by: Dylan Baker
>
> Quoting Andres Gomez (2018-01-31 13:11:52)
> > Until now we were only running the python unit tests.
> >
> > It seems desirable to also check that the CMake based build compiles
> > successfully. We do that now us
On Mon, 2018-01-29 at 14:06 -0800, Eric Anholt wrote:
> Andres Gomez writes:
>
> > Until now we were only running the python unit tests.
> >
> > It seems desirable to also check that the CMake based build compiles
> > successfully. We do that now using docker.
&g
Cc: Juan A. Suarez
Signed-off-by: Andres Gomez
Reviewed-by: Juan A. Suarez
---
.travis.yml | 47 --
docker/Rockerfile.piglit | 74
2 files changed, 118 insertions(+), 3 deletions(-)
create mode 100644 dock
v2, as
suggested by Juan.
Cc: Dylan Baker
Cc: Juan A. Suarez
Signed-off-by: Andres Gomez
Reviewed-by: Juan A. Suarez
---
.travis.yml | 47 --
docker/Rockerfile.piglit | 74
2 files changed, 118 insert
Cc: Kenneth Graunke
Cc: Dylan Baker
Signed-off-by: Andres Gomez
---
tests/khr_gl.py | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/tests/khr_gl.py b/tests/khr_gl.py
index 6a4e845c4..30e28b045 100644
--- a/tests/khr_gl.py
+++ b/tests/khr_gl.py
@@ -21,9 +21,10
changes for
extra details regarding these variables.
v2: Removed other build possibilities other than just from inside
Travis-CI, as suggested by Juan.
Cc: Dylan Baker
Cc: Juan A. Suarez
Signed-off-by: Andres Gomez
Reviewed-by: Juan A. Suarez
---
.travis.yml | 47
changes for
extra details regarding these variables.
Cc: Dylan Baker
Cc: Juan A. Suarez Romero
Signed-off-by: Andres Gomez
---
We choose to do this task using docker instead of directly in the
Travis CI VM because of various reasons.
First, the Travis env is configured for a python execution. Adding
On Tue, 2017-12-19 at 08:52 +0100, Alejandro Piñeiro wrote:
> Reviewed-by: Alejandro Piñeiro
>
> PS: in fact I have that fix as part of one of my patches, but I have
> pending to answer one Ilia question (need some investigation). In any
> case, I think that we can fix the typo now. Thanks!
OK.
On Mon, 2017-12-18 at 09:47 -0800, Francisco Jerez wrote:
> Andres Gomez writes:
>
> > Cc: Francisco Jerez
> > Signed-off-by: Andres Gomez
> > ---
> > tests/spec/arb_shader_image_load_store/grid.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion
Cc: Alejandro Piñeiro
Signed-off-by: Andres Gomez
---
tests/spec/arb_internalformat_query2/common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/spec/arb_internalformat_query2/common.c
b/tests/spec/arb_internalformat_query2/common.c
index a5686c0a5..9fa5fa9d1
Cc: Francisco Jerez
Signed-off-by: Andres Gomez
---
tests/spec/arb_shader_image_load_store/grid.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/spec/arb_shader_image_load_store/grid.c
b/tests/spec/arb_shader_image_load_store/grid.c
index 68d80b102..261dbfd13 100644
Cc: Dylan Baker
Cc: Juan A. Suarez Romero
Signed-off-by: Andres Gomez
---
.travis.yml | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/.travis.yml b/.travis.yml
index 1d6c954f5..b47829ff9 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -3,15 +3,15 @@ cache: pip
Cc: Dylan Baker
Signed-off-by: Andres Gomez
---
unittests/generators/test_generators.py | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/unittests/generators/test_generators.py
b/unittests/generators/test_generators.py
index a3ea3e29e..ccb57e725 100644
--- a/unittests
Cc: Dylan Baker
Signed-off-by: Andres Gomez
---
unittests/generators/test_glsl.py | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/unittests/generators/test_glsl.py
b/unittests/generators/test_glsl.py
index 66e3f66e1..5eec79484 100644
--- a/unittests
This is a small series which correct some small mistakes, update the
unit test for the generator and enables it in Travis CI.
Andres Gomez (3):
unittests: correct tessellation typo
unittests: update python generator
travis: add generator unittests
.travis.yml
This is:
Reviewed-by: Andres Gomez
On Mon, 2017-12-18 at 13:45 +0100, Juan A. Suarez Romero wrote:
> Newer pytest versions (>=3.3.) require new versions of PythonSix
> (>=1.10.0).
>
> We want to keep the current PythonSix version required by piglit.
>
> So le't
The message should state why we do this.
The reason is that python3.3 is not supported any more by the installed
3.3.1 version of pytest, since we don't force a maximum version any
more after 2b0a9cc7a.
On Fri, 2017-12-15 at 11:57 +0100, Juan A. Suarez Romero wrote:
> Let's remove python3.3 supp
On Fri, 2017-12-15 at 11:57 +0100, Juan A. Suarez Romero wrote:
> ---
> tox.ini | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tox.ini b/tox.ini
> index c1b7a0104..2bd99f544 100644
> --- a/tox.ini
> +++ b/tox.ini
> @@ -27,7 +27,7 @@ deps =
> pytest-warnings
> p
Fixes: edc41a1db ("framework: move WflInfo class into new wflinfo.py module")
Cc: Brian Paul
Cc: Dylan Baker
Signed-off-by: Andres Gomez
---
unittests/framework/test/test_glsl_parser_test.py | 2 +-
unittests/framework/test/test_opengl.py | 363 +---
Fixes: e76ecd048 ("framework: also print elapsed time with piglit-summary.py")
Cc: Brian Paul
Cc: Dylan Baker
Signed-off-by: Andres Gomez
---
unittests/framework/summary/test_console.py | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/unittests
://github.com/KhronosGroup/VK-GL-CTS
Signed-off-by: Andres Gomez
Cc: Mark Janes
Cc: Dylan Baker
Cc: Marek Olšák
Acked-by: Marek Olšák
Acked-by: Dylan Baker
---
piglit.conf.example | 10 ++
tests/khr_gl.py | 93 +
tests/khr_gl45.py | 69
This reverts commit 1f93e29d853c0dc9ee1a22bb7e6366b6eb8d5ac7.
This broke backwards compatibility with already released API-specific
test sets.
Signed-off-by: Andres Gomez
---
tests/cts_gl.py | 20 ++--
tests/cts_gl45.py | 2 +-
2 files changed, 11 insertions(+), 11 deletions
://github.com/KhronosGroup/VK-GL-CTS
Signed-off-by: Andres Gomez
Cc: Mark Janes
Cc: Dylan Baker
Cc: Marek Olšák
---
tests/khr_gl.py | 93 +++
tests/khr_gl45.py | 69 +
2 files changed, 162 insertions
r
API-specific release, as explained at:
https://github.com/KhronosGroup/VK-GL-CTS/wiki/Contributing#branches
Now, we revert the changes and provide 2 new profiles to use with the
renamed tests.
Andres Gomez (2):
Revert "tests: Update integration for khronos CTS runner."
tests: Added
After:
https://github.com/KhronosGroup/VK-GL-CTS/commit/af8c22a343ee2c230488f6de71b36dc3070b2024
OpenGL GL*-CTS case lists have been renamed to KHR-GL*.
Signed-off-by: Andres Gomez
---
tests/cts_gl.py | 20 ++--
tests/cts_gl45.py | 2 +-
2 files changed, 11 insertions(+), 11
On Tue, 2017-03-28 at 08:57 +1100, Timothy Arceri wrote:
...
> With the remaining tests reworded in a similar way this patch is:
>
> Acked-by: Timothy Arceri
>
Thanks a lot for checking this.
I've reworded the comments and this patch has already landed.
--
Br,
Andres
___
On Tue, 2017-03-07 at 13:20 -0800, Francisco Jerez wrote:
> Andres Gomez writes:
>
> > This adds a test to check that a link error is expected when
> > specifying different binding points among compilation units for atomic
> > counters with the same
xcept the block name is always used in
place of the instance name (API accesses are to interfaces, not
to shaders)."
Signed-off-by: Andres Gomez
Cc: Timothy Arceri
---
...age-blocks-align-qualifier-mismatch.shader_test | 54 +
...cks-member-align
eries adds tests to check that a link error is expected
when specifying different binding points for matching Uniform Blocks,
Shader Storage Blocks or Opaque-Uniforms across multiple compilation
units.
Andres Gomez (2):
arb_shading_language_420pack: check different binding points
arb_shader_at
must be equal
for a uniform variable of the same name."
v2: Added GL minimum version restriction.
Signed-off-by: Andres Gomez
Cc: Francisco Jerez
Cc: Ian Romanick
---
.../different-bindings-atomic-counter.shader_test | 51 ++
1 file changed, 51 insertions(+)
c
ieve that it
applies to it too.
v2:
- Added GL minimum version restrictions.
- Corrected GLSL minimum version restrictions.
- Corrected the outcome and documentation for the linking failures
on UBOs and SSBOs.
- Added tests for UBOs and SSBOs without instance names.
Signed-
Reviewed-by: Andres Gomez
On Fri, 2017-02-10 at 14:15 +0100, Jose Maria Casanova Crespo wrote:
> From GLSL ES 3.10 spec, section 4.1.9 "Arrays":
>
> "If an array is declared as the last member of a shader storage block
> and the size is not specified at compile-ti
must be equal
for a uniform variable of the same name."
Signed-off-by: Andres Gomez
Cc: Francisco Jerez
Cc: Kenneth Graunke
---
.../different-bindings-atomic-counter.shader_test | 50 ++
1 file changed, 50 insertions(+)
create mode 100644
of Opaque-Uniforms, a link error is expected.
Andres Gomez (2):
arb_shading_language_420pack: check different binding points
arb_shader_atomic_counters: check different binding points
.../different-bindings-atomic-counter.shader_test | 50 ++
.../linker/differen
wn in the examples below."
Although this restriction is not included in the
ARB_shading_language_420pack spec, it is reasonable to believe that it
applies to it too.
Signed-off-by: Andres Gomez
Cc: Matt Turner
Cc: Kenneth Graunke
---
.../linker/different-bindings-image2D.shader_
C test could be a better idea, dunno.
From my side, this is:
Reviewed-by: Andres Gomez
>
> Dylan
>
> Quoting Dylan Baker (2016-10-31 14:40:35)
> > There are 18000 of these tests, quick.py has 53000 tests, which is 34%
> > of the total tests. That's just too many for
gain for review.
I hope the changelog is explanatory enough ☺
>
> -ilia
>
> On Sat, Oct 22, 2016 at 5:19 PM, Andres Gomez wrote:
> > Provides support for highlighting incorrect indentation.
> >
> > v2: python-mode inherits from prog-mode
> > v3: Removed
effect.
v2: python-mode inherits from prog-mode
v3: Removed too long lines trail highlighting, as suggested by Ilia
Mirkin.
Signed-off-by: Andres Gomez
---
.dir-locals.el | 17 +
1 file changed, 13 insertions(+), 4 deletions(-)
diff --git a/.dir-locals.el b/.dir-locals.el
index
If nobody says otherwise, I will land this by the beginning of next
week.
On Sun, 2016-10-23 at 00:19 +0300, Andres Gomez wrote:
> Provides support for highlighting incorrect indentation.
>
> v2: python-mode inherits from prog-mode
> v3: Removed too long lines trail highlighting, as
ult
input/output layout declarations.
Reviewed-by: Timothy Arceri
Signed-off-by: Andres Gomez
---
...tion-identifiers-in-single-layout-mismatch.geom | 38 +++
...le-invocation-identifiers-in-single-layout.geom | 38 +++
...size-identifiers-in-single-layout-mi
. If
the same layout-qualifier-name occurs in multiple layout qualifiers for
the same declaration, the last one overrides the former ones."
V2: Removed link check, as suggested by Timothy.
Reviewed-by: Timothy Arceri
Signed-off-by: Andres Gomez
---
than one layout qualifier may appear in a single declaration."
Signed-off-by: Andres Gomez
---
...e-layout-qualifier-in-single-declaration-1.geom | 25 ++
...e-layout-qualifier-in-single-declaration-2.geom | 25 ++
...e-layout-qualifier-in-single-dec
than one layout qualifier may appear in a single declaration."
Signed-off-by: Andres Gomez
---
...e-layout-qualifier-in-single-declaration-1.geom | 31 ++
...e-layout-qualifier-in-single-declaration-2.geom | 31 ++
...e-layout-qualifier-in-single-dec
.
From the ARB_shading_language_420pack spec:
"More than one layout qualifier may appear in a single declaration."
Signed-off-by: Andres Gomez
---
...e-layout-qualifier-in-single-declaration-1.vert | 31 ++
...e-layout-qualifier-in-single-declaration-2
From the GL_ARB_enhanced_layouts spec:
"While *xfb_stride* can be declared multiple times for the same buffer,
it is a compile-time or link-time error to have different values
specified for the stride for the same buffer."
Reviewed-by: Timothy Arceri
Signed-off-by: An
.
From the ARB_shading_language_420pack spec:
"More than one layout qualifier may appear in a single declaration."
Signed-off-by: Andres Gomez
---
...e-layout-qualifier-in-single-declaration-1.vert | 30 ++
...e-layout-qualifier-in-single-declaration-2
ned-off-by: Andres Gomez
---
...declaration-per-program-max-verts-mismatch.geom | 22 +++
...-one-out-declaration-per-program-max-verts.geom | 25 +-
2 files changed, 42 insertions(+), 5 deletions(-)
create mode 100644
tests/spec/glsl-1.50/compiler/layout-on
instead of just
1.40.
Old patches 5/7 and 7/7 have been removed, which was testing
multiple layout-qualifiers in the same declaration with
ARB_enhanced_layouts in addition to ARB_shading_language_420pack.
Patches 6/9, 7/9, 8/9 and 9/9 have been added with extra tests.
Andres Gomez (9
From the ARB_tessellation_shader spec:
"All tessellation control shader layout declarations in a program must
specify the same output patch vertex count."
Reviewed-by: Timothy Arceri
Signed-off-by: Andres Gomez
---
...e-qualifier-declarations-vertices-mismatch
On Mon, 2016-10-24 at 11:05 +1100, Timothy Arceri wrote:
> On Sat, 2016-10-22 at 23:42 +0300, Andres Gomez wrote:
> > We already had tests for a repeated layout-qualifier-name in a single
> > layout-qualifier. Now, we also add similar tests to check across
> > multiple lay
On Mon, 2016-10-24 at 11:44 +1100, Timothy Arceri wrote:
> Reviewed-by: Timothy Arceri
>
> On Sat, 2016-10-22 at 23:42 +0300, Andres Gomez wrote:
[snip]
> > diff --git a/tests/spec/arb_shading_language_420pack/compiler/layout-
> > qualifiers/multiple-local_size-
On Mon, 2016-10-24 at 11:15 +1100, Timothy Arceri wrote:
> On Sat, 2016-10-22 at 23:42 +0300, Andres Gomez wrote:
> > Section 4.3.8.2 (Output Layout Qualifiers) of the GLSL 1.50 spec
> > says:
> >
> > "All geometry shader output layout declarations i
On Mon, 2016-10-24 at 11:58 +1100, Timothy Arceri wrote:
> On Sat, 2016-10-22 at 23:42 +0300, Andres Gomez wrote:
> > ARB_shading_language_420pack
>
>
> You may be interested in finishing off this patch:
>
> https://patchwork.freedesktop.org/patch/71093/
>
> I ne
Provides support for highlighting incorrect indentation.
v2: python-mode inherits from prog-mode
v3: Removed too long lines trail highlighting, as suggested by Ilia
Mirkin.
Signed-off-by: Andres Gomez
---
.dir-locals.el | 17 +
1 file changed, 13 insertions(+), 4 deletions
can be dropped straight away if I
didn't make a proper interpretation.
Andres Gomez (7):
glsl-1.50: Add GS output layout qualifier redeclaration test
arb_tessellation_shader: Add tests for TCS output size redeclaration
arb_enhanced_layouts: Add more xfb_stride redeclaration
Section 4.3.8.2 (Output Layout Qualifiers) of the GLSL 1.50 spec says:
"All geometry shader output layout declarations in a program must declare
the
same layout and same value for max_vertices."
Signed-off-by: Andres Gomez
---
...ut-declaration-consistent-with-prev-layout
From the ARB_tessellation_shader spec:
"All tessellation control shader layout declarations in a program must
specify the same output patch vertex count."
Signed-off-by: Andres Gomez
---
...e-qualifier-declarations-vertices-mismatch.tesc | 23 ++
...
. If
the same layout-qualifier-name occurs in multiple layout qualifiers for
the same declaration, the last one overrides the former ones."
Signed-off-by: Andres Gomez
---
...-invocation-in-single-declaration-mismatch.geom | 31 ++
lifier may appear in a single declaration.
Additionally, the same layout-qualifier-name can occur multiple times
within a layout qualifier or across multiple layout qualifiers in the
same declaration"
Signed-off-by: Andres Gomez
---
...identifiers-in-single-declaration-m
This is also true for overriding layout-qualifier-names, where one
overrides the other (e.g., row_major vs. column_major); only the last
occurrence has any effect."
Signed-off-by: Andres Gomez
---
...tion-identifiers-in-single-layout-mismatch.geom | 38 +++
ation.
Additionally, the same layout-qualifier-name can occur multiple times
within a layout qualifier or across multiple layout qualifiers in the
same declaration"
Signed-off-by: Andres Gomez
---
...-in-single-declaration-no-enhanced-layouts.vert | 22 +
.
From the GL_ARB_enhanced_layouts spec:
"While *xfb_stride* can be declared multiple times for the same buffer,
it is a compile-time or link-time error to have different values
specified for the stride for the same buffer."
Signed-off-by: Andres Gomez
---
.../xfb_st
If nobody says otherwise, I will land this by the beginning of next
week.
On Tue, 2016-08-02 at 19:53 +0300, Andres Gomez wrote:
> Highlight bogus indentation and long lines.
>
> v2: python-mode inherits from prog-mode
>
> Signed-off-by: Andres Gomez
> ---
>
On Tue, 2016-08-09 at 13:14 +1000, Timothy Arceri wrote:
> On Fri, 2016-08-05 at 17:43 +0300, Andres Gomez wrote:
> > This set focus on checking invalid structs construction.
> > Specifically,
> > adds a test to check that only implicit conversions are perform and
> >
1 - 100 of 213 matches
Mail list logo