Re: [Piglit] [PATCH] gl-3.0: add a test to stress the bound resource limits

2014-07-08 Thread Brian Paul
On 07/07/2014 07:51 AM, Matthew McClure wrote: With this patch, we add a test that will stress the bound resource limits as determined by the GL API getInteger values. The bound resources are populated with floats given a table of primes. Each contribution is multiplied into the final expression,

Re: [Piglit] [PATCH] cmake: Require Mako >= 0.7

2014-07-07 Thread Brian Paul
On 07/07/2014 09:26 AM, Brian Paul wrote: I'm having trouble with Mako since the requirement bump. I had an older version of Mako installed. I tried upgrading with "sudo pip install --user --upgrade Mako" but that didn't seem to work. Then I uninstalled Mako and tried in

Re: [Piglit] [PATCH] cmake: Require Mako >= 0.7

2014-07-07 Thread Brian Paul
I'm having trouble with Mako since the requirement bump. I had an older version of Mako installed. I tried upgrading with "sudo pip install --user --upgrade Mako" but that didn't seem to work. Then I uninstalled Mako and tried installing again. The installation had some warnings but seems

Re: [Piglit] [PATCH] ext_framebuffer_multisample: Add NORETURN attribute to print_usage_and_exit.

2014-07-07 Thread Brian Paul
ec/ext_framebuffer_multisample/accuracy.cpp +++ b/tests/spec/ext_framebuffer_multisample/accuracy.cpp @@ -58,7 +58,7 @@ const int pattern_width = 256; const int pattern_height = 256; const int supersample_factor = 16; Test *test = NULL; -void +NORETURN void print_usage_and_exit(char *prog_name) {

[Piglit] [PATCH 2/2] arb_provoking_vertex/xfb-before-flatshading: use default window size

2014-07-03 Thread Brian Paul
--- tests/spec/arb_provoking_vertex/xfb-before-flatshading.c |2 -- 1 file changed, 2 deletions(-) diff --git a/tests/spec/arb_provoking_vertex/xfb-before-flatshading.c b/tests/spec/arb_provoking_vertex/xfb-before-flatshading.c index 67cc581..6d168ea 100644 --- a/tests/spec/arb_provoking_ver

[Piglit] [PATCH 1/2] arb_blend_func_extended: require GL 3.0

2014-07-03 Thread Brian Paul
Since the test shaders require GLSL 1.30 --- .../arb_blend_func_extended/execution/fbo-extended-blend-explicit.c |2 +- tests/spec/arb_blend_func_extended/execution/fbo-extended-blend.c|2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/spec/arb_blend_func_ext

Re: [Piglit] [PATCH 1/3] spec/ARB_copy_image: Add a simple ARB_copy_image test

2014-06-30 Thread Brian Paul
On 06/30/2014 10:49 AM, Jason Ekstrand wrote: On Sat, Jun 28, 2014 at 6:28 AM, Brian Paul mailto:bri...@vmware.com>> wrote: On 06/27/2014 05:31 PM, Jason Ekstrand wrote: This is a simple sanity test for the ARB_copy_image extension. This tests tes

Re: [Piglit] [PATCH 3/3] ARB_copy_image: Test different combinations of texture formats

2014-06-28 Thread Brian Paul
On 06/27/2014 05:31 PM, Jason Ekstrand wrote: This tests glCopyTexSubImage on all of the allowed combinations of internal texture formats. Signed-off-by: Jason Ekstrand --- tests/all.py| 77 +++ tests/spec/arb_copy_image/CMakeLists.gl.txt | 1 + tests/

Re: [Piglit] [PATCH 2/3] ARB_copy_image: Add a test for testing different texture target combinations

2014-06-28 Thread Brian Paul
On 06/27/2014 05:31 PM, Jason Ekstrand wrote: This tests all of the possible different combinations of texture targets such as GL_TEXTURE_2D, GL_TEXTURE_CUBE_MAP, GL_TEXTURE_1D_ARRAY, etc. The only targets not tested are GL_TEXTURE_2D_MULTISAMPLE and GL_TEXTURE_2D_MULTISAMPLE_ARRAY but those are

Re: [Piglit] [PATCH 1/3] spec/ARB_copy_image: Add a simple ARB_copy_image test

2014-06-28 Thread Brian Paul
not sure if you want to do that here though. + + if (!piglit_automatic) { + glBindFramebufferEXT(GL_DRAW_FRAMEBUFFER_EXT, +piglit_winsys_fbo); + + image_draw(&images[1], 0, 0); + image_draw(&images[0], 64, 0); + + piglit_present_results(); + } + + image_destroy(&images[0]); + image_destroy(&images[1]); + + return pass ? PIGLIT_PASS : PIGLIT_FAIL; +} Looks good otherwise. Reviewed-by: Brian Paul ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] [PATCH 1/2] ext_texture_integer: add error-checking test

2014-06-27 Thread Brian Paul
This is based on the previous integer-errors test, but tests many more glTexImage internalFormat / format / type combinations. --- tests/all.py |1 + tests/spec/ext_texture_integer/CMakeLists.gl.txt |1 + tests/spec/ext_texture_integer/errors.c

[Piglit] [PATCH 2/2] gl-3.0/integer-errors: do more glTexImage parameter error checking

2014-06-27 Thread Brian Paul
Instead of spot checking a few internalFormat/format/type combinations test all of them. And only test the core profile formats. The ext_texture_integer-errors test hits the other legacy/compat formats. Remove the tests for glDrawPixels, glReadPixels, etc. since that's covered in the new ext_tex

Re: [Piglit] [PATCH] glsl-fs-color-matrix: Remove unused variable.

2014-06-26 Thread Brian Paul
For all 6 unused-var-removal patches: Reviewed-by: Brian Paul ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] Time to switch to Python 3 already?

2014-06-25 Thread Brian Paul
Correct. -Brian On 06/25/2014 04:53 PM, Dylan Baker wrote: Wait, you guys don't have a 2.6 requirement anymore? On Wednesday, June 25, 2014 04:48:11 PM Brian Paul wrote: On 06/24/2014 07:24 PM, Kenneth Graunke wrote: On Tuesday, June 24, 2014 10:30:56 AM Matt Turner wrote: It was more

Re: [Piglit] [PATCH] triangle-rasterization: increase the precision of the test

2014-06-25 Thread Brian Paul
n.cpp | 96 ++-- 1 file changed, 53 insertions(+), 43 deletions(-) Reviewed-by: Brian Paul ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] Time to switch to Python 3 already?

2014-06-25 Thread Brian Paul
On 06/24/2014 07:24 PM, Kenneth Graunke wrote: On Tuesday, June 24, 2014 10:30:56 AM Matt Turner wrote: It was more than a year ago now [1] that we agreed to "hold these patches back for a short time (maybe a month) to give people time to get ready for the transition" In the mean time, we've st

[Piglit] [PATCH] arb_uniform_buffer_object-minmax: divide block size by 4 to get components

2014-06-25 Thread Brian Paul
GL_MAX_UNIFORM_BLOCK_SIZE is in bytes. A "component" is regarded as being four bytes in size. So to compute the number of components, divide the block size by 4. With this change, nvidia's driver passes the test. Found by Kai Ninomiya of VMware. --- tests/spec/arb_uniform_buffer_object/minmax.

[Piglit] [PATCH 1/2] piglit-dispatch: fix get_core_proc_address() for Windows

2014-06-25 Thread Brian Paul
Even for functions such as glGetStringi() which are in OpenGL 3.0, we call get_core_proc_address() with gl_10x_version = 10 (seems to be a larger problem in the dispatch code generation). That means we try GetProcAddress("OPENGL32.DLL") and fail. Now, if GetProcAddress() fails, try get_ext_proc_a

[Piglit] [PATCH 2/2] util/framework/glut: do more core/compat profile checking

2014-06-25 Thread Brian Paul
Check if actually got a core profile. Then, if the tests requires a compat profile, skip the test. --- .../piglit-framework-gl/piglit_glut_framework.c| 22 1 file changed, 22 insertions(+) diff --git a/tests/util/piglit-framework-gl/piglit_glut_framework.c b/tests/uti

Re: [Piglit] [PATCH] util/framework/glut: check if we have a core profile

2014-06-25 Thread Brian Paul
Thanks, but I think I'm going to do a bit more in this area. New patch(es) to come, after more testing... -Brian On 06/25/2014 10:28 AM, Charmaine Lee wrote: Reviewed-by: Charmaine Lee From: Piglit on behalf of Brian Paul Sent: Wednesday,

[Piglit] [PATCH] util/framework/glut: check if we have a core profile

2014-06-25 Thread Brian Paul
For the GLUT framework, check the context version and whether GL_ARB_compatibility is supported to determine if we should set piglit_is_core_profile. Fixes some issues when running GL 3.1 and later on Windows. --- tests/util/piglit-framework-gl/piglit_glut_framework.c |8 1 file chan

[Piglit] [PATCH] arb_texture_buffer_object-get: use piglit_get_gl_enum_name() in error msg

2014-06-25 Thread Brian Paul
--- tests/spec/arb_texture_buffer_object/get.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/spec/arb_texture_buffer_object/get.c b/tests/spec/arb_texture_buffer_object/get.c index 202a909..d96a3c1 100644 --- a/tests/spec/arb_texture_buffer_object/get.c +++ b/

[Piglit] [PATCH] gl-3.0-render-integer: add a new test for rendering to integer textures

2014-06-19 Thread Brian Paul
ES OR OTHER + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER + * DEALINGS IN THE SOFTWARE. + */ + +/** + * Test OpenGL 3.0 rendering to integer texture formats. + * Brian Paul + * 19 June 2014

[Piglit] [PATCH] pbo-readpixels-small: restore 2x2 window size, report SKIP for other sizes

2014-06-18 Thread Brian Paul
This test requires a 2x2 window size- it's not just the glReadPixels(2x2) that matters. --- tests/general/pbo-readpixels-small.c |9 + 1 file changed, 9 insertions(+) diff --git a/tests/general/pbo-readpixels-small.c b/tests/general/pbo-readpixels-small.c index 900a929..9f2f338 10064

Re: [Piglit] [PATCH 3/4] pbo-readpixels-small: use default window size

2014-06-18 Thread Brian Paul
en I (quickly) looked at this I assumed it was the glReadPixels(w=2,h=2) that was significant. I'll post a fix-up patch... -Brian On 06/08/2014 03:16 PM, Brian Paul wrote: --- tests/general/pbo-readpixels-small.c |3 --- 1 file changed, 3 deletions(-) diff --git a/tests/general

Re: [Piglit] [PATCH] gl-3.0: Don't query GL_TEXTURE_{LUMINANCE, INTENSITY}_* outside compat profile

2014-06-17 Thread Brian Paul
stuff into the function too, but no big deal. Reviewed-by: Brian Paul ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH] gl-3.0: Don't query GL_TEXTURE_{LUMINANCE, INTENSITY}_* outside compat profile

2014-06-17 Thread Brian Paul
} } else { /* For stencil, there's no query for * the type, so our table above It might be nice to put the glGetTexLevelParameteriv() call and surrounding checks into a separate fun

Re: [Piglit] [PATCH v3] fbo: test that swizzle doesn't affect mipmap generation

2014-06-17 Thread Brian Paul
swizzles from red to green instead of to alpha. Reviewed-by: Brian Paul --- tests/all.py | 1 + tests/fbo/CMakeLists.gl.txt| 1 + tests/fbo/fbo-generatemipmap-swizzle.c | 165 + 3 files changed, 167 insertions

[Piglit] [PATCH] gl-3.0-vertexattribipointer: add argv support for running single tests

2014-06-16 Thread Brian Paul
--- tests/spec/gl-3.0/vertexattribipointer.c | 43 +++--- 1 file changed, 34 insertions(+), 9 deletions(-) diff --git a/tests/spec/gl-3.0/vertexattribipointer.c b/tests/spec/gl-3.0/vertexattribipointer.c index b69e731..633b881 100644 --- a/tests/spec/gl-3.0/vertexattrib

Re: [Piglit] [PATCH v2] fbo: test that swizzle doesn't affect mipmap generation

2014-06-16 Thread Brian Paul
piglit_require_extension("GL_ARB_texture_swizzle"); If you decide to keep the GL_RED texture, require GL_ARB_texture_rg. +} Looks good otherwise. Reviewed-by: Brian Paul ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH] fbo-generatemipmap-1d: Remove unused variables.

2014-06-16 Thread Brian Paul
Reviewed-by: Brian Paul On Fri, Jun 13, 2014 at 11:03 PM, Vinson Lee wrote: > Fix clang unused-const-variable warnings. > > tests/fbo/fbo-generatemipmap-1d.c:44:20: warning: unused variable 'red' > [-Wunused-const-variable] > static const fl

Re: [Piglit] [PATCH] arb_uniform_buffer_object: add new rendering test

2014-06-13 Thread Brian Paul
Ping. On 06/11/2014 10:48 AM, Brian Paul wrote: Add a test that actually draws something with uniform buffer objects along the lines of what an application might do. --- tests/all.py |1 + .../arb_uniform_buffer_object/CMakeLists.gl.txt|1

Re: [Piglit] [PATCH] framework/summary/html: Prevent forward slashes in URLs.

2014-06-12 Thread Brian Paul
Just to be clear, I think forward slash is / while backward slash is \. -Brian On 06/12/2014 06:22 AM, jfons...@vmware.com wrote: From: José Fonseca It's fine for URLs to have forward slash directory separators when viewing the HTML on Windows. But if one moves the HTML report to a Linux mac

[Piglit] [PATCH] arb_uniform_buffer_object: add new rendering test

2014-06-11 Thread Brian Paul
Add a test that actually draws something with uniform buffer objects along the lines of what an application might do. --- tests/all.py |1 + .../arb_uniform_buffer_object/CMakeLists.gl.txt|1 + tests/spec/arb_uniform_buffer_object/rendering.c |

Re: [Piglit] [PATCH] Hook up two new EXT_packed_depth_stencil tests added recently

2014-06-11 Thread Brian Paul
) +ext_packed_depth_stencil['readdrawpixels'] = concurrent_test('ext_packed_depth_stencil-readdrawpixels') oes_packed_depth_stencil = {} spec['OES_packed_depth_stencil'] = oes_packed_depth_stencil Reviewed-by: Brian Paul Hmm, I did that but somehow it di

Re: [Piglit] [PATCH] framework/exectest.py: Set returncode to 0 when executable is missing.

2014-06-10 Thread Brian Paul
x27;: 'skip'}\n" "Test executable not found.\n") err = "" -returncode = None +returncode = 0 else: raise e Reviewed-by: Brian Paul ___ Pig

[Piglit] [PATCH] ARB_shader_bit_encoding: add a test which exercises an nvidia bug

2014-06-10 Thread Brian Paul
With nvidia's 325.15 driver (at least) the GLSL compiler generates invalid code. --- tests/all.py |8 .../execution/and-clamp.shader_test| 43 2 files changed, 51 insertions(+) create mode 100644 tests/spec/arb

Re: [Piglit] [PATCH 1/4] util: Ensure that stdout and stderr are flushed on exceptions.

2014-06-09 Thread Brian Paul
ceptionCode); return EXCEPTION_CONTINUE_SEARCH; } The series looks OK to me, AFAICT. Reviewed-by: Brian Paul ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] [PATCH 3/4] ext_packed_depth_stencil: new glRead/DrawPixels test

2014-06-09 Thread Brian Paul
FTWARE OR THE USE OR OTHER DEALINGS + * IN THE SOFTWARE. + */ + +/** + * Test GL_EXT_packed_depth_stencil with glRead/DrawPixels + * Based on an original Glean test written by Brian Paul. + */ + +#include "piglit-util-gl-common.h" + +PIGLIT_GL_TEST_CONFIG_BEGIN + config.s

[Piglit] [PATCH 2/4] ext_packed_depth_stencil: new errors test

2014-06-09 Thread Brian Paul
r API error handling. + * Based on an original Glean test written by Brian Paul. + */ + +#include "piglit-util-gl-common.h" + +PIGLIT_GL_TEST_CONFIG_BEGIN + config.supports_gl_compat_version = 12; + config.window_visual = (PIGLIT_GL_VISUAL_RGBA | +

[Piglit] [PATCH 1/4] remove glean/tbufferobject test

2014-06-09 Thread Brian Paul
R OTHER -// DEALINGS IN THE SOFTWARE. -// -// END_COPYRIGHT - -// tbufferobject.c - test various buffer object features/extensions -// Author: Brian Paul - - -#define GL_GLEXT_PROTOTYPES -#include -#include -#include -#include -#include "tbufferobject.h" - - -namespace

[Piglit] [PATCH 4/4] remove glean depthstencil test

2014-06-09 Thread Brian Paul
-// DEALINGS IN THE SOFTWARE. -// -// END_COPYRIGHT - -// tdepthstencil.h: Test GL_EXT_packed_depth_stencil extension. -// Brian Paul 1 October 2005 - - -#include -#include -#include -#include "tdepthstencil.h" -#include "rand.h" -#include "image.h" -#in

[Piglit] [PATCH 4/4] depth-tex-modes-rg: fix initial window size

2014-06-08 Thread Brian Paul
Use the larger of the default window size and the size required by the test parameters. --- tests/texturing/depth-tex-modes-rg.c |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tests/texturing/depth-tex-modes-rg.c b/tests/texturing/depth-tex-modes-rg.c index 4cf8aec

[Piglit] [PATCH 1/4] fp-abs-01: use default window size

2014-06-08 Thread Brian Paul
--- tests/shaders/fp-abs-01.c |3 --- 1 file changed, 3 deletions(-) diff --git a/tests/shaders/fp-abs-01.c b/tests/shaders/fp-abs-01.c index 0b59829..411c29b 100644 --- a/tests/shaders/fp-abs-01.c +++ b/tests/shaders/fp-abs-01.c @@ -37,9 +37,6 @@ PIGLIT_GL_TEST_CONFIG_BEGIN config

[Piglit] [PATCH 3/4] pbo-readpixels-small: use default window size

2014-06-08 Thread Brian Paul
--- tests/general/pbo-readpixels-small.c |3 --- 1 file changed, 3 deletions(-) diff --git a/tests/general/pbo-readpixels-small.c b/tests/general/pbo-readpixels-small.c index 026531b..900a929 100644 --- a/tests/general/pbo-readpixels-small.c +++ b/tests/general/pbo-readpixels-small.c @@ -41,

[Piglit] [PATCH 2/4] tex-skipped-unit: use default window size

2014-06-08 Thread Brian Paul
--- tests/texturing/tex-skipped-unit.c |3 --- 1 file changed, 3 deletions(-) diff --git a/tests/texturing/tex-skipped-unit.c b/tests/texturing/tex-skipped-unit.c index 53477d1..8355f41 100644 --- a/tests/texturing/tex-skipped-unit.c +++ b/tests/texturing/tex-skipped-unit.c @@ -33,9 +33,6 @@

Re: [Piglit] [PATCH v2 1/7] Test GL_ARB_clear_texture using 3D textures

2014-06-06 Thread Brian Paul
then rendered to the window and probed for the correct results. --- Overall, the series looks good to me. Just a few nits that I posted. Reviewed-by: Brian Paul ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org

Re: [Piglit] [PATCH 7/7] Test GL_ARB_clear_texture using 1- and 2- component textures

2014-06-06 Thread Brian Paul
On 06/05/2014 09:38 AM, Neil Roberts wrote: This adds a test for glClearTexSubImage when clearing a sub-region of textures using an internal format of GL_RED and GL_RG. --- tests/all.py | 1 + tests/spec/arb_clear_texture/CMakeLists.gl.txt | 1 + tests/spec

Re: [Piglit] [PATCH 5/7] Test GL_ARB_clear_texture using a range of sized formats

2014-06-06 Thread Brian Paul
On 06/05/2014 09:38 AM, Neil Roberts wrote: This adds a test for glClearTexSubImage when clearing a sub-region of a texture using a range of sized internal formats. --- tests/all.py | 1 + tests/spec/arb_clear_texture/CMakeLists.gl.txt | 1 + tests/spec/arb

Re: [Piglit] [PATCH 3/7] Test GL_ARB_clear_texture using a range of base formats

2014-06-06 Thread Brian Paul
On 06/05/2014 09:38 AM, Neil Roberts wrote: This adds a test for glClearTexSubImage when clearing a sub-region of a 2D texture using a range of formats that are supported in basic GL. A utility function is added to test a format combination so that further tests can be added with other formats th

Re: [Piglit] [PATCH piglit] Test using glTexSubImage2D with packed depth-stencil textures

2014-06-05 Thread Brian Paul
LGTM. Reviewed-by: Brian Paul On 06/05/2014 05:57 AM, Neil Roberts wrote: This adds a test for updating a sub-region of a texture created with the GL_EXT_packed_depth_stencil extension. Currently this seems to trigger a bug on the i965 driver. --- tests/all.py

Re: [Piglit] [PATCH] util: Prevent uncaught exceptions from being silently ignored on Windows.

2014-06-05 Thread Brian Paul
n_handler); #endif /* _WIN32 */ } Looks good AFAICT. Reviewed-by: Brian Paul ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH 3/3] ext_transform_feedback: use default window size

2014-06-05 Thread Brian Paul
On 06/05/2014 05:51 AM, Jose Fonseca wrote: Looks ok. Though I still wonder if it wouldn't be to do as I suggested in another similar review request -- to treat config.window_width/height as "minimum" values, as opposed to maximum values. That is, something along the lines of diff --git a/te

Re: [Piglit] [PATCH piglit 1/3] Test GL_ARB_clear_texture using 3D textures

2014-06-04 Thread Brian Paul
I just did a quick review (you might wait to see if there's other comments) but these tests look OK to me. Just a few minor things below. Reviewed-by: Brian Paul On 06/04/2014 11:13 AM, Neil Roberts wrote: This adds a test for glClearTexSubImage when clearing a sub-region of a 3D te

[Piglit] [PATCH] gl-3.0: add new test for glVertexAttribIPointer()

2014-06-04 Thread Brian Paul
--- tests/all.py |1 + tests/spec/gl-3.0/CMakeLists.gl.txt |1 + tests/spec/gl-3.0/vertexattribipointer.c | 239 ++ 3 files changed, 241 insertions(+) create mode 100644 tests/spec/gl-3.0/vertexattribipointer.c diff --git a/te

[Piglit] [PATCH 3/3] ext_transform_feedback: use default window size

2014-06-04 Thread Brian Paul
These tests need no other changes. Again, this is to avoid the "spurious window resize" issue on Windows when the initial window size is too small. --- tests/spec/ext_transform_feedback/alignment.c |3 --- tests/spec/ext_transform_feedback/api-errors.c |3 --- tests/spe

[Piglit] [PATCH 1/3] ext_transform_feedback: use default window size for interleaved test

2014-06-04 Thread Brian Paul
This test has a hard-coded array of expected results which assume a 64 x 32 window. Now the window size can be anything but we explicitly set up the projection matrix for a 64 x 32 region. --- tests/spec/ext_transform_feedback/interleaved.c | 15 +++ 1 file changed, 11 insertions(+)

[Piglit] [PATCH 2/3] ext_transform_feeback: use default window size for position test

2014-06-04 Thread Brian Paul
This test also has hard-coded expected[] coords which assume a 64 x 32 window size. New use the default window size but setup the projection matrix and viewport as if the window was only 64 x 32. --- tests/spec/ext_transform_feedback/position.c | 16 1 file changed, 12 insertio

Re: [Piglit] [PATCH 1/2] cmake: Install piglit as piglit.py on Windows.

2014-06-03 Thread Brian Paul
# Drop .py extension (used on Windows) +_bin = _binname _libdir = path.abspath(path.join(_binpath, '..', 'lib', _bin)) sys.path.append(_libdir) if 'PIGLIT_SOURCE_DIR' not in os.environ: For both: Reviewed-by: Brian Paul

[Piglit] [PATCH] all.py: use os.path everywhere for consistency

2014-06-03 Thread Brian Paul
--- tests/all.py | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/tests/all.py b/tests/all.py index e2d1c77..b8a246b 100644 --- a/tests/all.py +++ b/tests/all.py @@ -5,7 +5,6 @@ __all__ = ['profile'] import itertools import os -import os.path as path import pl

[Piglit] [PATCH 3/3] all.py: minor formatting/indentation change to improve readability

2014-06-03 Thread Brian Paul
--- tests/all.py |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tests/all.py b/tests/all.py index 5802227..e2d1c77 100644 --- a/tests/all.py +++ b/tests/all.py @@ -27,9 +27,8 @@ if sys.platform == "cygwin": # $PIGLIT_BUILD_DIR (if that environment variable exists) or

[Piglit] [PATCH 2/3] all.py: use os.path.join() and string.split() to fix things for cygwin

2014-06-03 Thread Brian Paul
Use os.path.join() to build up file paths instead of using string concatenation. In plain_test(), split up the arguments string using string.split() instead of shlex.split() because the later removes the '\' characters in Windows paths, which causes things to blow up. I can't find any particular

[Piglit] [PATCH 1/3] all.py: check if running in cygwin, use Windows-style path for testsDir

2014-06-03 Thread Brian Paul
Otherwise, the file path we're passing to programs such as shader_runner is in Unix style, which Windows programs don't understand. v2: use subprocess module instead of commands module, per Dylan --- tests/all.py |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tests/a

Re: [Piglit] [PATCH 3/3] all.py: use os.path.join() and string.split() to fix things for cygwin

2014-06-03 Thread Brian Paul
On 06/02/2014 11:14 AM, Jose Fonseca wrote: - Original Message - On Sunday, June 01, 2014 03:03:22 PM Brian Paul wrote: Use os.path.join() to build up file paths instead of using string concatenation. In plain_test(), split up the arguments string using string.split() instead of

[Piglit] [PATCH] gl-2.0/vertexattribpointer: new test for glVertexAttribPointer

2014-06-03 Thread Brian Paul
Tests all the type/size/normalize combinations for glVertexAttribPointer. Note- a similar test should be written for GL 3.0's glVertexAttribIPointer. v2: pass the expected value and atolerance to the shader and compute pass/fail there, per Jose's idea. And test GL_DOUBLE type. --- tests/all.py

Re: [Piglit] [PATCH] gl-2.0/vertexattribpointer: new test for glVertexAttribPointer

2014-06-03 Thread Brian Paul
On 06/02/2014 11:26 AM, Jose Fonseca wrote: - Original Message - Tests all the type/size/normalize combinations for glVertexAttribPointer. Note- a similar test should be written for GL 3.0's glVertexAttribIPointer. --- tests/all.py|1 + tests/spec/gl-

Re: [Piglit] [PATCH 1/3] asmparsertest: print error if unable to open file

2014-06-01 Thread Brian Paul
On 06/01/2014 03:08 PM, Ilia Mirkin wrote: On Sun, Jun 1, 2014 at 5:03 PM, Brian Paul wrote: --- tests/asmparsertest/asmparsertest.c |1 + 1 file changed, 1 insertion(+) diff --git a/tests/asmparsertest/asmparsertest.c b/tests/asmparsertest/asmparsertest.c index 16ed0df..c250270

[Piglit] [PATCH 1/3] asmparsertest: print error if unable to open file

2014-06-01 Thread Brian Paul
--- tests/asmparsertest/asmparsertest.c |1 + 1 file changed, 1 insertion(+) diff --git a/tests/asmparsertest/asmparsertest.c b/tests/asmparsertest/asmparsertest.c index 16ed0df..c250270 100644 --- a/tests/asmparsertest/asmparsertest.c +++ b/tests/asmparsertest/asmparsertest.c @@ -120,6 +120

[Piglit] [PATCH 2/3] all.py: check if running in cygwin, use Windows-style path for testsDir

2014-06-01 Thread Brian Paul
Otherwise, the file path we're passing to programs such as shader_runner is in Unix style, which Windows programs don't understand. --- tests/all.py |5 + 1 file changed, 5 insertions(+) diff --git a/tests/all.py b/tests/all.py index a42e79e..bf174b7 100644 --- a/tests/all.py +++ b/tests/

[Piglit] [PATCH 3/3] all.py: use os.path.join() and string.split() to fix things for cygwin

2014-06-01 Thread Brian Paul
Use os.path.join() to build up file paths instead of using string concatenation. In plain_test(), split up the arguments string using string.split() instead of shlex.split() because the later removes the '\' characters in Windows paths, which causes things to blow up. I can't find any particular

Re: [Piglit] [PATCH] arb_vertex_array_bgra: Add tests for glGet*(GL_*_ARRAY_SIZE) == GL_BGRA.

2014-06-01 Thread Brian Paul
Reviewed-by: Brian Paul On Sun, Jun 1, 2014 at 1:54 PM, wrote: > From: José Fonseca > > Mesa didn't get this quite right, causing problems to ApiTrace -- > https://github.com/apitrace/apitrace/issues/261 . > --- > tests/all.py

[Piglit] [PATCH] gl-2.0/vertexattribpointer: new test for glVertexAttribPointer

2014-06-01 Thread Brian Paul
Tests all the type/size/normalize combinations for glVertexAttribPointer. Note- a similar test should be written for GL 3.0's glVertexAttribIPointer. --- tests/all.py|1 + tests/spec/gl-2.0/CMakeLists.gl.txt |1 + tests/spec/gl-2.0/vertexattribpointer.c | 2

Re: [Piglit] [PATCH 1/2] util: add a simple set of matrix functions

2014-05-30 Thread Brian Paul
On Fri, May 30, 2014 at 10:48 AM, Jose Fonseca wrote: > > Series looks good at a glance. Just one minor remark inline. > > > > + */ > > + > > + > > +#ifndef PIGLIT_MATRIX_H > > +#define PIGLIT_MATRIX_H > > + > > + > > +#ifdef __cplusplus > > +extern "C" { > > +#endif > > + > > + > > +#include >

[Piglit] [PATCH] vertexid: use default window size for gl_VertexID tests

2014-05-27 Thread Brian Paul
--- tests/spec/glsl-1.30/execution/vertexid-beginend.c |3 --- tests/spec/glsl-1.30/execution/vertexid-drawarrays.c |3 --- tests/spec/glsl-1.30/execution/vertexid-drawelements.c |3 --- 3 files changed, 9 deletions(-) diff --git a/tests/spec/glsl-1.30/execution/vertexid-beginen

Re: [Piglit] [PATCH] Fix require extension usage -- prepend GL_ and GLX_ in missing places

2014-05-27 Thread Brian Paul
On 05/24/2014 05:31 PM, Emil Velikov wrote: On 24/05/14 22:10, Ilia Mirkin wrote: Signed-off-by: Ilia Mirkin --- This doesn't actually end up mattering for the GLX tests because they do a substr-based search in the overall extension string. But for the GL tests it matters because it looks for

Re: [Piglit] [PATCH] tests/spec/glsl-1.30: add tests for integer sign() function

2014-05-23 Thread Brian Paul
(arg0); gl_FragColor = result == expected ? vec4(0.0, 1.0, 0.0, 1.0) : vec4(1.0, 0.0, 0.0, 1.0); } On Fri, May 23, 2014 at 1:18 PM, Brian Paul wrote: --- .../glsl-1.30/execution/fs-sign-int4.shader_test | 24 + .../glsl-1.30/execution/vs-sign-int4.shader_test |

[Piglit] [PATCH] tests/spec/glsl-1.30: add tests for integer sign() function

2014-05-23 Thread Brian Paul
--- .../glsl-1.30/execution/fs-sign-int4.shader_test | 24 + .../glsl-1.30/execution/vs-sign-int4.shader_test | 27 2 files changed, 51 insertions(+) create mode 100644 tests/spec/glsl-1.30/execution/fs-sign-int4.shader_test create mode 100644 tests/s

[Piglit] [PATCH 2/2] arb_base_instance: add glDrawArrays test for this extension

2014-05-22 Thread Brian Paul
This test uses the new piglit matrix functions to setup transformations. --- tests/all.py |1 + tests/spec/arb_base_instance/CMakeLists.gl.txt |1 + tests/spec/arb_base_instance/drawarrays.c | 226 3 files changed, 228 insert

[Piglit] [PATCH 1/2] util: add a simple set of matrix functions

2014-05-22 Thread Brian Paul
For tests using the core profile we no longer have the legacy GL matrix functions to set up transformations. These functions let us easily setup transformations in such test programs. --- tests/util/CMakeLists.gl.txt |1 + tests/util/piglit-matrix.c | 458 ++

Re: [Piglit] [PATCH] svga: enable instanced arrays for VGPU10

2014-05-21 Thread Brian Paul
On 05/21/2014 04:08 PM, Brian Paul wrote: Please disregard. -Brian ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] [PATCH] svga: enable instanced arrays for VGPU10

2014-05-21 Thread Brian Paul
This enables the GL_ARB_instanced_arrays extension (vertex attribute divisors). Piglit tests pass. --- src/gallium/drivers/svga/svga_pipe_vertex.c | 10 -- src/gallium/drivers/svga/svga_screen.c |2 +- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/gallium/d

Re: [Piglit] [PATCH 02/11] glean/glsl1: Port illegal shader tests to piglit.

2014-05-21 Thread Brian Paul
On 05/20/2014 04:31 PM, Matt Turner wrote: From: Kenneth Graunke --- tests/glean/tglsl1.cpp | 152 + tests/shaders/glsl1/COPYRIGHT | 31 + tests/shaders/glsl1/break-with-no-loop.frag| 9 ++ tests/shaders/gl

[Piglit] [PATCH 03/10] arb_instanced_arrays: put extension prefix on executables

2014-05-20 Thread Brian Paul
Prefix the executables with "arb_instanced_arrays" to be more consistent. --- tests/all.py |6 +++--- tests/spec/arb_instanced_arrays/CMakeLists.gl.txt |4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/all.py b/tests/all.py i

[Piglit] [PATCH 04/10] arb_draw_elements_base_vertex: rename dlist test

2014-05-20 Thread Brian Paul
--- tests/all.py |2 +- .../CMakeLists.gl.txt |2 +- .../dlist-arb_draw_instanced.c | 96 tests/spec/arb_draw_elements_base_vertex/dlist.c | 96 4 files ch

[Piglit] [PATCH 10/10] arb_draw_elements_base_vertex: rename/move negative index test

2014-05-20 Thread Brian Paul
--- tests/all.py |4 +- tests/general/CMakeLists.gl.txt|4 - tests/general/draw-elements-base-vertex-neg.c | 141 .../CMakeLists.gl.txt |1 + .../arb_draw_elements_base_ver

[Piglit] [PATCH 07/10] arb_draw_elements_base_vertex: rename multidrawelements test

2014-05-20 Thread Brian Paul
--- tests/all.py |2 +- .../CMakeLists.gl.txt |2 +- .../multi-draw-elements-base-vertex.c | 190 .../multidrawelements.c| 190 4 files ch

[Piglit] [PATCH 08/10] arb_draw_elements_base_vertex: move bounds checking test

2014-05-20 Thread Brian Paul
--- tests/all.py |2 +- tests/general/CMakeLists.gl.txt|1 - tests/general/draw-elements-base-vertex-bounds.c | 127 .../CMakeLists.gl.txt |1 + tests/spec/arb_draw_elements_b

[Piglit] [PATCH 05/10] arb_draw_elements_base_vertex: rename instanced drawelements test

2014-05-20 Thread Brian Paul
--- tests/all.py |2 +- .../CMakeLists.gl.txt |2 +- .../draw-elements-instanced-base-vertex.c | 191 .../drawelements-instanced.c | 191 4 files ch

[Piglit] [PATCH 0/10] rename some tests

2014-05-20 Thread Brian Paul
The names of many piglit tests are pretty inconsistent. Nowadays, most tests get put in a tests/spec/arb_foo_bar/ directory and the executables are prefixed with "arb_foo_bar-*". But older tests don't really follow any pattern. Many were just dumped in tests/general/ I'd like to clean up s

[Piglit] [PATCH 06/10] arb_draw_elements_base_vertex: rename drawrangeelements test

2014-05-20 Thread Brian Paul
--- tests/all.py |2 +- .../CMakeLists.gl.txt |2 +- .../draw-range-elements-base-vertex.c | 173 .../drawrangeelements.c| 173 4 files ch

[Piglit] [PATCH 09/10] arb_draw_elements_base_vertex: move the drawelements test

2014-05-20 Thread Brian Paul
--- tests/all.py |5 +- tests/general/CMakeLists.gl.txt|1 - tests/general/draw-elements-base-vertex.c | 156 .../CMakeLists.gl.txt |1 + .../arb_draw_elements_base_ver

[Piglit] [PATCH 01/10] arb_draw_instanced: move and rename drawarrays test

2014-05-20 Thread Brian Paul
Move tests/general/draw-instanced.c to tests/spec/arb_draw_instanced/drawarrays.c --- tests/all.py |2 +- tests/general/CMakeLists.gl.txt|1 - tests/general/draw-instanced.c | 183 .../arb_d

[Piglit] [PATCH 02/10] arb_instanced_arrays: move and rename test

2014-05-20 Thread Brian Paul
Move tests/general/draw-instanced-divisor.c to tests/spec/arb_instanced_arrays/drawarrays.c --- tests/all.py |2 +- tests/general/CMakeLists.gl.txt |1 - tests/general/draw-instanced-divisor.c| 191 - t

[Piglit] [PATCH] arb_draw_instanced: use default window size, set viewport

2014-05-20 Thread Brian Paul
--- tests/spec/arb_draw_instanced/execution/elements.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tests/spec/arb_draw_instanced/execution/elements.c b/tests/spec/arb_draw_instanced/execution/elements.c index 7cb418b..84eed79 100644 --- a/tests/spec/arb_draw_instan

[Piglit] [PATCH] arb_texture_compression/internal-format-query: use piglit_get_gl_enum_name()

2014-05-16 Thread Brian Paul
--- .../arb_texture_compression/internal-format-query.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/tests/spec/arb_texture_compression/internal-format-query.c b/tests/spec/arb_texture_compression/internal-format-query.c index 7a7b6d4..f6b2af2 100644 -

[Piglit] [PATCH] arb_occlusion_query: restore window size specification

2014-05-15 Thread Brian Paul
Commit ef4f461346d01a66 mistakenly removed the window size from this test, causing it to fail. --- tests/spec/arb_occlusion_query/occlusion_query.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/spec/arb_occlusion_query/occlusion_query.c b/tests/spec/arb_occlusion_query/occlusion

Re: [Piglit] [PATCH 03/15] arb_occlusion_query: use default window size

2014-05-15 Thread Brian Paul
On 05/14/2014 09:53 PM, Michel Dänzer wrote: On 14.05.2014 10:06, Brian Paul wrote: diff --git a/tests/spec/arb_occlusion_query/occlusion_query.c b/tests/spec/arb_occlusion_query/occlusion_query.c index e099f06..b8ea664 100644 --- a/tests/spec/arb_occlusion_query/occlusion_query.c +++ b/tests

Re: [Piglit] Piglit build broken

2014-05-14 Thread Brian Paul
On 05/14/2014 12:31 PM, Dylan Baker wrote: On Wednesday, May 14, 2014 12:23:04 Brian Paul wrote: > Dylan, I think you may have forgot to commit a new file or something: > > Traceback (most recent call last): > File "/home/brianp/pig/generated_tests/gen_texture_lod_tests.

[Piglit] Piglit build broken

2014-05-14 Thread Brian Paul
Dylan, I think you may have forgot to commit a new file or something: Traceback (most recent call last): File "/home/brianp/pig/generated_tests/gen_texture_lod_tests.py", line 178, in main() File "/home/brianp/pig/generated_tests/gen_texture_lod_tests.py", line 160, in main gen_f

Re: [Piglit] [PATCH 15/15] arb_texture_buffer_object: use default window size

2014-05-14 Thread Brian Paul
Yup, that'd be easier for me too. I've got more of these changes coming, but now I'm down to the ones which require fixing the test because they relied on particular window dimensions. -Brian On 05/14/2014 08:46 AM, Jose Fonseca wrote: LGTM AFAICT. BTW, personally, I'd prefer reviewing this

<    3   4   5   6   7   8   9   10   11   12   >