Re: [Piglit] [v3 10/11] ext_memory_object: Add helper for image type support

On Thursday 21 December 2017, Topi Pohjolainen wrote: > CC: Fredrik Hoeglund > > Signed-off-by: Topi Pohjolainen > --- > tests/spec/ext_memory_object/common.c| 24 > tests/spec/ext_memory_object/common.h| 4 >

Re: [Piglit] [v2 4/7] ext_memory_object: Support for setting up vulkan framebuffer

On Monday 18 December 2017, Topi Pohjolainen wrote: > v2: Store image size in order to know how much memory to import, > see glImportMemoryFdEXT(). > > Signed-off-by: Topi Pohjolainen > --- > tests/spec/ext_memory_object/vk_common.h | 34 >

Re: [Piglit] [PATCH 0/7] Add tests for ARB_vertex_attrib_binding

On Friday 16 October 2015, Dave Airlie wrote: > Hey Fredrik, > > were you going to finish these with Eric's comments? I thought those patches had landed. The commit messages in my branch suggest that I have updated them based on Eric's comments, but I'll double check and resend them. Thanks

Re: [Piglit] [PATCH] arb_copy_image: add new format swizzle test

On Tuesday 01 September 2015, Ilia Mirkin wrote: > On Tue, Sep 1, 2015 at 12:22 PM, Fredrik Höglund <fred...@kde.org> wrote: > > On Tuesday 01 September 2015, Brian Paul wrote: > >> On 08/31/2015 05:38 PM, Ilia Mirkin wrote: > >> > On Mon, Aug 31, 2015 at 7:29 P

Re: [Piglit] [PATCH] arb_copy_image: add new format swizzle test

On Tuesday 01 September 2015, Brian Paul wrote: > On 08/31/2015 05:38 PM, Ilia Mirkin wrote: > > On Mon, Aug 31, 2015 at 7:29 PM, Ilia Mirkin wrote: > >> Reviewed-by: Ilia Mirkin > >> > >> Thanks a lot for doing this! I assume that it fails with your

Re: [Piglit] [PATCH v2] arb_direct_state_access: Add a FramebufferTextureLayer cube-map test

On Thursday 21 May 2015, Ian Romanick wrote: On 04/29/2015 12:21 PM, Fredrik Höglund wrote: This test verifies that faces of a cube-map texture can be attached to a framebuffer object using glNamedFramebufferTextureLayer and glFramebufferTextureLayer. --- v2: - Remove the check

Re: [Piglit] [PATCH] DSA: fix incorrect errors expected for BindTextureUnit()

, name); /* Too High */ - pass = piglit_check_gl_error(GL_INVALID_OPERATION); + pass = piglit_check_gl_error(GL_INVALID_VALUE); /* Trivial, but should work. */ glBindTextureUnit(1, name); Reviewed-by: Fredrik Höglund fred...@kde.org

Re: [Piglit] [PATCH v2] arb_framebuffer_no_attachments: add params setget test

On Wednesday 22 April 2015, Tapani Pälli wrote: All other tests except invalid_enum_check pass on Nvidia binary driver (version 346.35), tests also pass currently on upcoming Mesa implementation. v2: - make test use Core context (for DSA), change test concurrent (Ilia Mirkin) -

Re: [Piglit] [PATCH 2/2] DSA: CreateTextures() with a NULL argument is allowed to crash

, name); pass = piglit_check_gl_error(GL_NO_ERROR); This patch is: Reviewed-by: Fredrik Höglund fred...@kde.org ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH 1/2] DSA: fix incorrect errors expected for BindTextureUnit()

also uses 8-column tabs for indentation. With those nitpicks fixed: Reviewed-by: Fredrik Höglund fred...@kde.org + +/* Texture name doesn't exist */ glBindTextureUnit(0, name); pass = piglit_check_gl_error(GL_INVALID_OPERATION); - /* No target */ +/* Texture name

Re: [Piglit] [PATCH] DSA: fix error value for *TextureSubImage* when target doesn't match

On Thursday 23 April 2015, Arthur Huillet wrote: Hi, On Thu, 23 Apr 2015 14:26:32 +0300 Martin Peres martin.pe...@linux.intel.com wrote: Does the patch look OK to you? Yeah, patch looks perfectly fine. But I'd like to hear from Laura (or Martin perhaps, who reviewed a lot of these)

Re: [Piglit] [PATCH 00/14] Add DSA tests for vertex array objects

On Wednesday 01 April 2015, Martin Peres wrote: Here is the result of the run on nvidia 346.35: http://pastebin.com/TGPzKpPG I've also looked at the non-vao failures, and found some cases where the NVIDIA driver is right and the test is wrong. bind-texture-unit.c: /* No target */

Re: [Piglit] [PATCH 11/14] arb_direct_state_access: Add a test for glGetVertexArray*iv

On Thursday 02 April 2015, Ilia Mirkin wrote: On Thu, Apr 2, 2015 at 1:53 PM, Laura Ekstrand la...@jlekstrand.net wrote: On Tue, Mar 31, 2015 at 10:26 AM, Fredrik Höglund fred...@kde.org wrote: + { + GL_VERTEX_ATTRIB_ARRAY_LONG

Re: [Piglit] [PATCH 11/14] arb_direct_state_access: Add a test for glGetVertexArray*iv

On Thursday 02 April 2015, Laura Ekstrand wrote: On Tue, Mar 31, 2015 at 10:26 AM, Fredrik Höglund fred...@kde.org wrote: This test verifies that glGetVertexArrayiv, glGetVertexArrayIndexediv, and glGetVertexArrayIndexed64iv work as expected. --- tests/all.py

Re: [Piglit] [PATCH 05/14] arb_direct_state_access: Add a test for glVertexArrayAttrib[I|L]Format

On Thursday 02 April 2015, Laura Ekstrand wrote: On Tue, Mar 31, 2015 at 10:26 AM, Fredrik Höglund fred...@kde.org wrote: This test verifies that glVertexArrayAttribFormat, glVertexArrayAttribIFormat and glVertexArrayAttribLFormat work as expected. --- tests/all.py

Re: [Piglit] [PATCH 09/14] arb_direct_state_access: Add a test for glVertexArrayVertexBuffer

On Thursday 02 April 2015, Laura Ekstrand wrote: On Tue, Mar 31, 2015 at 10:26 AM, Fredrik Höglund fred...@kde.org wrote: This test verifies that glVertexArrayVertexBuffer works as expected. --- tests/all.py | 1 + .../spec

Re: [Piglit] [PATCH 00/14] Add DSA tests for vertex array objects

On Wednesday 01 April 2015, Martin Peres wrote: On 31/03/15 20:26, Fredrik Höglund wrote: This series adds piglit tests for the VAO portion of GL_ARB_direct_state_access. The tests are written so that they can be run against either the core or compatibility profiles. The exception

[Piglit] [PATCH 00/14] Add DSA tests for vertex array objects

-format fails without this patch: http://patchwork.freedesktop.org/patch/44068 It would be interesting to know if the tests pass with NVIDIA's implementation, but I haven't been able to test that. Fredrik Höglund (14): dsa/utils: Add check_indexed_vao_param() dsa/utils: Add

[Piglit] [PATCH 08/14] arb_direct_state_access: Add a test for glVertexArrayElementBuffer

b/tests/spec/arb_direct_state_access/vao-element-array-buffer.c new file mode 100644 index 000..8e0a9e1 --- /dev/null +++ b/tests/spec/arb_direct_state_access/vao-element-array-buffer.c @@ -0,0 +1,123 @@ +/* + * Copyright (C) 2015 Fredrik Höglund + * + * Permission is hereby granted, free

[Piglit] [PATCH 06/14] arb_direct_state_access: Add a test for glVertexArrayAttribBinding

-binding.c new file mode 100644 index 000..f498790 --- /dev/null +++ b/tests/spec/arb_direct_state_access/vao-attrib-binding.c @@ -0,0 +1,132 @@ +/* + * Copyright (C) 2015 Fredrik Höglund + * + * Permission is hereby granted, free of charge, to any person obtaining a + * copy of this software

[Piglit] [PATCH 13/14] arb_direct_state_access: Add a compatibility-profile test

@@ +/* + * Copyright (C) 2015 Fredrik Höglund + * + * Permission is hereby granted, free of charge, to any person obtaining a + * copy of this software and associated documentation files (the Software), + * to deal in the Software without restriction, including without limitation + * on the rights

[Piglit] [PATCH 04/14] arb_direct_state_access: Add a test for glEnable/DisableVertexArrayAttrib

mode 100644 index 000..98db400 --- /dev/null +++ b/tests/spec/arb_direct_state_access/vao-attrib-enabledisable.c @@ -0,0 +1,127 @@ +/* + * Copyright (C) 2015 Fredrik Höglund + * + * Permission is hereby granted, free of charge, to any person obtaining a + * copy of this software and associated

[Piglit] [PATCH 14/14] arb_direct_state_access: Add a compatibility-profile draw test

/null +++ b/tests/spec/arb_direct_state_access/vao-compat-draw.c @@ -0,0 +1,171 @@ +/* + * Copyright (C) 2015 Fredrik Höglund + * + * Permission is hereby granted, free of charge, to any person obtaining a + * copy of this software and associated documentation files (the Software), + * to deal

[Piglit] [PATCH 03/14] arb_direct_state_access: Add a test for glCreateVertexArrays

) 2015 Fredrik Höglund + * + * Permission is hereby granted, free of charge, to any person obtaining a + * copy of this software and associated documentation files (the Software), + * to deal in the Software without restriction, including without limitation + * on the rights to use, copy, modify

[Piglit] [PATCH 10/14] arb_direct_state_access: Add a test for glVertexArrayVertexBuffers

/spec/arb_direct_state_access/vao-vertex-buffers.c new file mode 100644 index 000..6c47376 --- /dev/null +++ b/tests/spec/arb_direct_state_access/vao-vertex-buffers.c @@ -0,0 +1,351 @@ +/* + * Copyright (C) 2015 Fredrik Höglund + * + * Permission is hereby granted, free of charge, to any person

[Piglit] [PATCH 12/14] arb_direct_state_access: Add a core-profile test

+1,186 @@ +/* + * Copyright (C) 2015 Fredrik Höglund + * + * Permission is hereby granted, free of charge, to any person obtaining a + * copy of this software and associated documentation files (the Software), + * to deal in the Software without restriction, including without limitation

[Piglit] [PATCH 07/14] arb_direct_state_access: Add a test for glVertexArrayBindingDivisor

/tests/spec/arb_direct_state_access/vao-binding-divisor.c new file mode 100644 index 000..0f1be2d --- /dev/null +++ b/tests/spec/arb_direct_state_access/vao-binding-divisor.c @@ -0,0 +1,119 @@ +/* + * Copyright (C) 2015 Fredrik Höglund + * + * Permission is hereby granted, free of charge, to any

[Piglit] [PATCH 11/14] arb_direct_state_access: Add a test for glGetVertexArray*iv

-get.c new file mode 100644 index 000..db4a89c --- /dev/null +++ b/tests/spec/arb_direct_state_access/vao-get.c @@ -0,0 +1,285 @@ +/* + * Copyright (C) 2015 Fredrik Höglund + * + * Permission is hereby granted, free of charge, to any person obtaining a + * copy of this software and associated

[Piglit] [PATCH 02/14] dsa/utils: Add check_vbo_binding()

This function returns true if the VBO binding of the given index matches the expected values, and false otherwise. An error message is printed if the actual parameter values don't match the expected values. --- tests/spec/arb_direct_state_access/dsa-utils.c | 19 +++

[Piglit] [PATCH 01/14] dsa/utils: Add check_indexed_vao_param()

This function returns true if the given parameter matches the expected value, and false otherwise. An error message is printed if the parameter value doesn't match the expected value. --- tests/spec/arb_direct_state_access/dsa-utils.c | 17 +

[Piglit] [PATCH 05/14] arb_direct_state_access: Add a test for glVertexArrayAttrib[I|L]Format

/arb_direct_state_access/vao-attrib-format.c new file mode 100644 index 000..807176f --- /dev/null +++ b/tests/spec/arb_direct_state_access/vao-attrib-format.c @@ -0,0 +1,791 @@ +/* + * Copyright (C) 2015 Fredrik Höglund + * + * Permission is hereby granted, free of charge, to any person obtaining

[Piglit] [PATCH 09/14] arb_direct_state_access: Add a test for glVertexArrayVertexBuffer

/arb_direct_state_access/vao-vertex-buffer.c new file mode 100644 index 000..dde03fb --- /dev/null +++ b/tests/spec/arb_direct_state_access/vao-vertex-buffer.c @@ -0,0 +1,140 @@ +/* + * Copyright (C) 2015 Fredrik Höglund + * + * Permission is hereby granted, free of charge, to any person obtaining

[Piglit] [PATCH] glx: Add a test for GLX_ARB_context_flush_control

Verify that glXCreateContextAttribsARB accepts the GLX_CONTEXT_RELEASE_BEHAVIOR_ARB attribute, that the value of GL_CONTEXT_RELEASE_BEHAVIOR in the created context reflects the value of the attribute, and that queued rendering commands are not lost when switching contexts. --- The test doesn't

Re: [Piglit] [PATCH] glx-choosefbconfig-defaults: New glXChooseFBConfig test

On Tuesday 11 February 2014, Ian Romanick wrote: On 02/02/2014 07:42 AM, Fredrik Höglund wrote: Verify that glXChooseFBConfig uses the default values in table 3.4 in the GLX 1.4 specification for attributes not specified in attribList. This test currently fails on Mesa. Which cases

[Piglit] [PATCH] glx-choosefbconfig-defaults: New glXChooseFBConfig test

/tests/glx/glx-choosefbconfig-defaults.c @@ -0,0 +1,130 @@ +/* + * Copyright © 2014 Fredrik Höglund + * + * Permission is hereby granted, free of charge, to any person obtaining a + * copy of this software and associated documentation files (the Software), + * to deal in the Software without restriction

Re: [Piglit] [PATCH 1/7] arb_vertex_attrib_binding: Test error conditions

On Tuesday 29 October 2013, Eric Anholt wrote: Sorry we all dropped this on the floor. I'm taking a look at your series now. Fredrik Höglund fred...@kde.org writes: diff --git a/tests/spec/arb_vertex_attrib_binding/errors.c b/tests/spec/arb_vertex_attrib_binding/errors.c new file mode

Re: [Piglit] [PATCH 2/7] arb_vertex_attrib_binding: Test new states

On Wednesday 30 October 2013, Eric Anholt wrote: Fredrik Höglund fred...@kde.org writes: Test setting and quering all new states. This also tests interactions with glVertexAttribPointer(). Same MIN2 and uncreached comments as the previous test. +#include piglit-util-gl-common.h

Re: [Piglit] [PATCH 6/7] arb_vertex_attrib_binding: Test instance-divisor

On Wednesday 30 October 2013, Eric Anholt wrote: Fredrik Höglund fred...@kde.org writes: diff --git a/tests/spec/arb_vertex_attrib_binding/instance-divisor.c b/tests/spec/arb_vertex_attrib_binding/instance-divisor.c new file mode 100644 index 000..88ae454 --- /dev/null +++ b

Re: [Piglit] [PATCH 1/7] arb_vertex_attrib_binding: Test error conditions

On Friday 01 November 2013, Eric Anholt wrote: Fredrik Höglund fred...@kde.org writes: On Tuesday 29 October 2013, Eric Anholt wrote: Sorry we all dropped this on the floor. I'm taking a look at your series now. Fredrik Höglund fred...@kde.org writes: diff --git a/tests/spec

Re: [Piglit] [PATCH 7/7] arb_vertex_attrib_binding: Test zero-stride bindings

On Wednesday 30 October 2013, Eric Anholt wrote: Fredrik Höglund fred...@kde.org writes: diff --git a/tests/spec/arb_vertex_attrib_binding/zero-stride.c b/tests/spec/arb_vertex_attrib_binding/zero-stride.c new file mode 100644 index 000..83b56e4 --- /dev/null +++ b/tests/spec

[Piglit] [PATCH] GL_ARB_ubo/getintegeri_v: Fix assumptions about offset alignment

Don't assume that GL_UNIFORM_BUFFER_OFFSET_ALIGNMENT is 1. This makes the test pass with gallium drivers. --- tests/spec/arb_uniform_buffer_object/getintegeri_v.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git